--- Day changed Sat Feb 11 2017 02:51 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has joined #joinmarket 03:28 -!- q-biq [q-biq@153.92.126.244] has joined #joinmarket 03:28 -!- q-biq [q-biq@153.92.126.244] has quit [Changing host] 03:28 -!- q-biq [q-biq@unaffiiliated/q-biq] has joined #joinmarket 03:37 -!- stachrom [d4338865@gateway/web/freenode/ip.212.51.136.101] has joined #joinmarket 03:51 -!- cannon-c [ccc23f04@gateway/web/freenode/ip.204.194.63.4] has quit [Quit: Page closed] 03:53 -!- MaxSan [~one@91.214.169.69] has joined #joinmarket 04:21 -!- MaxSan [~one@91.214.169.69] has quit [Quit: Leaving.] 04:58 -!- MaxSan [~one@91.214.169.69] has joined #joinmarket 05:56 < fluffypony> waxwing: that DGC article made me violently angry 05:56 < fluffypony> I ranted on Twitter, then saw your comment on Reddit 05:56 < waxwing> fluffypony: heh i guess i needn't say i agree then :) 05:57 < waxwing> grumpy early morning reddit rant :) 05:57 < fluffypony> I swear I've developed an eye twitch from reading stuff like that 06:03 -!- Tergi [4a4aed8d@gateway/web/freenode/ip.74.74.237.141] has joined #joinmarket 06:06 < Tergi> Looking on the wiki to see if i can find a way to import a private key into wallet tool for running a yield gen. i have one key that has a tiny amount on it figured it might get swept into a larger transaction? 06:06 < Tergi> Anyway i am not finding it 06:10 < Tergi> i tihnk i see it in the code 06:19 < MaxSan> waxwing: what did you read? 06:19 < MaxSan> im curious lol 06:20 < waxwing> Tergi: do python wallet-tool.py --help (if you haven't already) 06:21 < Tergi> ahh the simple things haha 06:21 < Tergi> i did import it 06:22 < Tergi> says it worked but doesnt show in the list when you just check the wallet balance that i could see, so ill just see what it does after it runs a while 06:23 < waxwing> i would never recommend messing around with privkeys, but i guess if it's low value 06:24 < waxwing> Tergi: if you open the json file i think you'll see an encrypted privkey entry there. but as for display, i'm not sure. i'd have to check. 06:24 < MaxSan> what was this DGC article? 06:24 < Tergi> ok, Well the private key is to a wallet that is getting dumped so its not important to keep anything super secure 06:35 < fluffypony> MaxSan: https://medium.com/@DCGco/scaling-bitcoin-reflections-from-the-dcg-portfolio-35b9a065b2a4 07:08 < MaxSan> well thanks for that 07:08 < MaxSan> I just got cancer 07:32 -!- Giszmo [~leo@pc-165-227-45-190.cm.vtr.net] has joined #joinmarket 07:51 < JM-IRCRelay> [AlexCato] thoughts about easily identifying overlapping orders in the taker scripts 07:51 < JM-IRCRelay> [AlexCato] for each maker with more than 1 offer: 07:52 < JM-IRCRelay> [AlexCato] loop and add up the single offer ids' ranges. If the individual ranges are higher than the samlest minimum and the highest maximum, there must be overlap --> add to ignore 07:52 < JM-IRCRelay> [AlexCato] that way it should be solvable in O(n) 07:53 < JM-IRCRelay> [AlexCato] thats how i'd solve this now, unless i'm thinking too complicated and you guys have better, faster, easier ideas ( ping waxwing, belcher, adlai ) 08:36 < fluffypony> MaxSan: don't blame me, you asked :-P 08:42 < waxwing> what do you expect from the hashfast scammer 08:50 < gmaxwell> fluffypony: it's ultra demoralizing that because Bitcoin Core is a big open collaboration that any time anyone technically sensible does anything it's described as "bitcoin core".. so you get "no one but bitcoin core tested segwit" when meanwhile loads of people who have virtually never worked on core not just tested to it but contributed to the design. 08:50 < gmaxwell> But then somehow even thoug the bitcoin project is collaborative enough that every clueful act can be described as being part of it... memes that its not open continue being repeated without substantiaion. :-/ 08:50 < kanzure> the article was copy+paste from a jgarzik rant 08:51 < kanzure> without attribution because ??? 08:51 < waxwing> i always thought the rebrand to "Bitcon Core" wasn't very smart from a non-technical perspective 08:51 < waxwing> although it's certainly easy to see its reason from a tech perspective 08:51 < fluffypony> gmaxwell: that was one of the points in my Twitter rant: https://twitter.com/fluffyponyza/status/830401678788665344 08:51 < gmaxwell> waxwing: I hated it, personally... many people working on it didn't like it. 08:51 < waxwing> right 08:51 < waxwing> fluffypony: imma let you finish, but i have the best rant of all time 08:52 < gmaxwell> kanzure: :( gift that keeps on giving. :( 08:52 < waxwing> actually i did the text equivalent of flipping the table over at the end :) 08:52 < gmaxwell> I should have known his recent show up out of nowhere on github meant nothing good even though for once he didn't shit on things. :( 08:53 < kanzure> and the negotiation text is copy-paste zooko 08:53 < gmaxwell> ... 08:53 < fluffypony> that's ok, Zooko doesn't even understand how zk-SNARKs work, much less how cryptocurrency works 08:53 < waxwing> i hear he's good at geometry 08:54 < fluffypony> every time he says something that annoys me I open this Github issue and laugh: https://github.com/zcash/zcash/issues/713 08:54 < gmaxwell> Great so an attack on the primary bitcoin core project written by someone who is a disgruntled ex contributor seperated by years and an altcoin competator. :( 08:54 < gmaxwell> Zooko is an earnestly nice guy, but I think he's been corrupted by the darkside of the altcoin force. :( 08:55 < fluffypony> gmaxwell: that's my take as well 08:55 < fluffypony> someone described it to me as "some investors wanted their own personal Bitcoin core dev, and the best they could do was Zooko" 08:55 < waxwing> talking of triangles, like this one: https://twitter.com/el33th4xor/status/829059709168521216 08:55 < kanzure> so when is joinmarket getting merged into core 08:56 < waxwing> when it's not broken. maybe :) 08:56 < kanzure> fascinating 08:56 < gmaxwell> fluffypony: there are a bunch of zcash issues that are horrifying. With ebfull and daria expressing caution and zooko randomizing. some things in zcash are really screwed up due to this. (e.g. their difficulty management algorithim is extremely ... horrifying; and just slammed in without testing and characterization) 08:56 < fluffypony> kanzure: it needs a BIP first :-P 08:56 < fluffypony> gmaxwell: their diff retarget algo is from DigiByte...I mean, come on! 08:57 < fluffypony> that's like the blind leading the blind 08:57 < kanzure> why are we stinking up #joinmarket today? 08:57 < fluffypony> yes 08:57 < gmaxwell> because joinmarket is awesome. 08:57 < fluffypony> because JoinMarket uses encryption, which is the cancer of cryptocurrency 08:57 < fluffypony> source: https://bitcointalk.org/index.php?topic=421615.msg17809753#msg17809753 08:57 < waxwing> lol 08:57 < waxwing> that was absolutely magnificent; where did it come from? 08:58 < waxwing> oh source, thanks 08:58 < fluffypony> waxwing: could only be from a Dash-er :-P 08:59 < waxwing> the cancer looks like a brain. guess they don't like those there :) 08:59 < fluffypony> hah hah 09:03 < waxwing> alexcato having a think. tbh it never occurred to me that it'd need any thinking, but i guess it does. 09:08 < waxwing> kanzure: a less glib version: 'broken' refers to it's too easy to sybil, economically, and adversarially (i think the latter, less so). i don't mean 'broken' in a more fundamental sense. 09:14 < waxwing> alexcato why can't you just take each min, and test if it's in the range (min, max) for each other order? you're concerned about O(n^2) right. hmm, technically that is an issue, yeah. 09:45 -!- coins123 [~coins123@unaffiliated/coins123] has quit [] 09:47 < waxwing> does this make sense, list all mins and maxes in order: a_min a_max b_min b_max .... z_min z_max, tag each item as min/max and then scan through and reject on the first repetition of type (i.e. min, min or max, max) 09:47 < waxwing> but that requires sort 09:56 < JM-IRCRelay> [AlexCato] yeah, i prefer my method. That also has the advantage that it can ideally stop right when the individual combined ranges exceed the theoretically allowed maximum range 09:56 < JM-IRCRelay> [AlexCato] couldnt come up with a more efficient method 09:57 < waxwing> i didn't fully understand what you meant, let me read it again 09:57 < JM-IRCRelay> [AlexCato] example will make it easier: 09:57 < JM-IRCRelay> [AlexCato] maker has 3 offers, a_min=1, a_max=5, b_min=2, b_max=5, c_min=3, c_max=5 09:58 < JM-IRCRelay> [AlexCato] i'll start with the range of a = 5-1 = 4 09:58 < JM-IRCRelay> [AlexCato] 4 is smaller or equal than the min of all minimum_offers (5-1=4) 09:58 < JM-IRCRelay> [AlexCato] next step: offer b 09:59 < JM-IRCRelay> [AlexCato] range of b = 5-2 = 3. Add that to a's range, which would be 4+3 09:59 < JM-IRCRelay> [AlexCato] 7 is >= the maximum theoretically allowed of 5 09:59 < JM-IRCRelay> [AlexCato] so stops right here and adds the maker to the ignore list 09:59 < JM-IRCRelay> [AlexCato] before even having to check all offers 10:00 < JM-IRCRelay> [AlexCato] (error by me here: max allowed was 4, not 5) 10:00 < waxwing> this -> [AlexCato] 4 is smaller or equal than the min of all minimum_offers (5-1=4) 10:00 < waxwing> don't get 10:00 < JM-IRCRelay> [AlexCato] yeah, let me try again. Half a sentence missing 10:02 < JM-IRCRelay> [AlexCato] of this specific maker, the minimum of *all* his offers is 1. The maximum of all his offers is 5. Therefor, the maximum range all his individual offers are allowed to have combined is his max-min = 4 10:02 < JM-IRCRelay> [AlexCato] now i just add the individual offer ranges up, one at a time. If at some point the combined individual offers ranges exceed the total maximum, there has to be an overlap 10:03 < waxwing> ah, i get it now. yes. 10:03 < JM-IRCRelay> [AlexCato] so worst case this algorithm does is O(n), in most overlapping cases it will be a lot more efficient, given the current makers who do that 10:04 < waxwing> yeah i can imagine a lot of methods would benefit from truncation, but this one seems good to me 10:04 < JM-IRCRelay> [AlexCato] great, then i'll work on a PR for that 10:05 < JM-IRCRelay> [AlexCato] first i need a sqlite3 tutorial :) . I know sql, so that shouldnt take too long 10:09 < waxwing> alexcato don't think you need to? just start from the orders list? not that it matters much. 10:11 < waxwing> oh you mean don't enter it first. yeah. 10:45 -!- nightcity [5999b126@gateway/web/freenode/ip.89.153.177.38] has joined #joinmarket 11:13 < JM-IRCRelay> [AlexCato] https://github.com/JoinMarket-Org/joinmarket/blob/master/joinmarket/taker.py#L611 <-- is that (nick,) an error or some kind of syntax i dont get? 11:17 < waxwing> alexcato : my memory tells me you have to do that with a tuple of length only 1 11:18 < waxwing> otherwise it's not recognized as a tuple 11:29 < JM-IRCRelay> [AlexCato] thanks, though I fail to see why there must be a tuple at all here 11:30 < waxwing> you'd have to check the sqlite docs i guess; seems pretty clear that those vars are for the placeholders marked by '?' in the SQL 11:31 < JM-IRCRelay> [AlexCato] yeah, but in that line there's only one placeholder 11:31 < JM-IRCRelay> [AlexCato] line 604 is totally clear to me, in contrast 11:31 < waxwing> right but presumably the function takes a tuple as argument to do that job in the general case 11:31 < waxwing> the function execute() i mean 11:32 < JM-IRCRelay> [AlexCato] ah, that might be it 12:24 < JM-IRCRelay> [AlexCato] hm, currently there are 35 makers with overlapping offers (out of 84 makers total) 13:09 -!- himmelhund [d5f05661@gateway/web/freenode/ip.213.240.86.97] has joined #joinmarket 13:11 < JM-IRCRelay> [AlexCato] I can identify the malformed orders quite nicely, reading from the sqlite-DB also works as expected. Since I just want to check the orderbook's makers when absolutely necessary, i planned to remove invalid makers it right before that line (ping waxwing): https://github.com/JoinMarket-Org/joinmarket/blob/master/sendpayment.py#L104 13:12 < JM-IRCRelay> [AlexCato] my lines for db-deletions seem to be completely ignored though. Runs without a problem, but when i check the orderbook after my deletions, the orders are still in there. Deletion-line: self.taker.db.execute('DELETE FROM orderbook WHERE counterparty=?;', (nick,)) 13:13 < himmelhund> register password 13:13 < himmelhund> register password 13:14 < JM-IRCRelay> [AlexCato] i wonder if maybe a db-commit is missing, but then again, there isnt one here either: https://github.com/JoinMarket-Org/joinmarket/blob/master/joinmarket/taker.py#L555 13:26 < JM-IRCRelay> [AlexCato] nvm. It does work. The numbers of the web-orderbook and my tests were just completely different 13:36 < JM-IRCRelay> [AlexCato] btw, I just notice that JM's default TX fee check should be triggered sometimes, lately: absurd_fee_per_kb = 100000 13:36 < JM-IRCRelay> [AlexCato] definition of 'absurd' changed somewhat quickly... 13:50 -!- himmelhund [d5f05661@gateway/web/freenode/ip.213.240.86.97] has left #joinmarket [] 13:59 -!- himmelhund_ [d5f05661@gateway/web/freenode/ip.213.240.86.97] has joined #joinmarket 14:00 -!- himmelhund_ [d5f05661@gateway/web/freenode/ip.213.240.86.97] has left #joinmarket [] 14:01 -!- himmelhund_ [d5f05661@gateway/web/freenode/ip.213.240.86.97] has joined #joinmarket 14:01 -!- himmelhund_ [d5f05661@gateway/web/freenode/ip.213.240.86.97] has quit [Client Quit] 14:01 -!- himmelhund_ [d5f05661@gateway/web/freenode/ip.213.240.86.97] has joined #joinmarket 14:13 -!- himmelhund [d5f05661@gateway/web/freenode/ip.213.240.86.97] has joined #joinmarket 14:14 -!- himmelhund_ [d5f05661@gateway/web/freenode/ip.213.240.86.97] has quit [Quit: Page closed] 14:16 < GithubBot5678> [joinmarket] AlexCato opened pull request #710: For CJs: ignore makers with overlapping offer ranges (develop...ignore_overlapping) https://git.io/vDwls 14:17 -!- coins123 [~coins123@unaffiliated/coins123] has joined #joinmarket 14:30 -!- himmelhund [d5f05661@gateway/web/freenode/ip.213.240.86.97] has quit [Quit: Page closed] 15:46 -!- stachrom [d4338865@gateway/web/freenode/ip.212.51.136.101] has quit [Ping timeout: 260 seconds] 16:03 -!- Giszmo [~leo@pc-165-227-45-190.cm.vtr.net] has quit [Ping timeout: 256 seconds] 16:51 -!- Giszmo [~leo@pc-165-227-45-190.cm.vtr.net] has joined #joinmarket 17:36 -!- FiveBroDeepBook [~gk.1wm.su@2606:f180:1:2ea:2ea:af60:f0b8:8f26] has joined #joinmarket 17:36 -!- FiveBroDeepBook [~gk.1wm.su@2606:f180:1:2ea:2ea:af60:f0b8:8f26] has left #joinmarket [] 17:44 -!- Cory [~Cory@unaffiliated/cory] has quit [Read error: No route to host] 17:48 -!- Cory [~Cory@unaffiliated/cory] has joined #joinmarket 22:29 -!- FiveBroDeepBook [~gk.1wm.su@2606:f180:2:2f4:2f4:830f:72a5:8cb7] has joined #joinmarket 22:29 -!- FiveBroDeepBook [~gk.1wm.su@2606:f180:2:2f4:2f4:830f:72a5:8cb7] has left #joinmarket [] 23:06 -!- Guest56637 [~john@46.101.18.195] has joined #joinmarket 23:19 -!- Guest56637 [~john@46.101.18.195] has quit [Remote host closed the connection]