--- Day changed Thu Nov 02 2017
00:10 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has joined #joinmarket     
00:55 -!- xcvvcx [53e42f33@gateway/web/freenode/ip.83.228.47.51] has joined #joinmarket     
01:18 -!- coins123 [~coins123@unaffiliated/coins123] has joined #joinmarket     
02:19 -!- viasil [~viasil@198.12.75.25] has quit [Ping timeout: 240 seconds]     
02:25 -!- viasil [~viasil@198.12.75.25] has joined #joinmarket     
04:07 -!- coins123 [~coins123@unaffiliated/coins123] has quit [Remote host closed the connection]     
05:54 -!- coins123 [~coins123@c-208-25.net-185.wadsl.it] has joined #joinmarket     
05:54 -!- coins123 [~coins123@c-208-25.net-185.wadsl.it] has quit [Changing host]     
05:54 -!- coins123 [~coins123@unaffiliated/coins123] has joined #joinmarket     
06:22 -!- quitobro [~quitobro@pool-108-41-0-186.nycmny.fios.verizon.net] has joined #joinmarket     
06:23 -!- MaxSan [~user@213.152.162.84] has quit [Ping timeout: 240 seconds]     
07:14 -!- quitobro [~quitobro@pool-108-41-0-186.nycmny.fios.verizon.net] has quit [Quit: quitobro]     
07:33 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #joinmarket     
07:40 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket     
09:27 -!- quitobro_ [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #joinmarket     
09:28 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Ping timeout: 260 seconds]     
09:28 -!- quitobro_ is now known as quitobro     
09:48 -!- liead is now known as adlai     
10:33 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Quit: quitobro]     
10:45 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
10:59 < GitHub16> [joinmarket-clientserver] AdamISZ pushed 1 new commit to master: https://git.io/vFGNe
10:59 < GitHub16> joinmarket-clientserver/master 288f74b AdamISZ: Add full BIP143 semantics for custom sighash flags
11:07 < waxwing> it's annoying that build fails can fail with stuff that's not relevant to the code, like this: https://travis-ci.org/JoinMarket-Org/joinmarket-clientserver/builds/296398249#L1072
11:10 < arubi> is this just random failure?
11:11 < waxwing> haven't tried to repeat it yet, but seems like it's happened a fair few times before.
11:11 < waxwing> off for a cycle in palo alto :)
11:12 < arubi> looks like it either didn't get the key or sigs
11:21 -!- quitobro [~quitobro@static-108-29-95-16.nycmny.fios.verizon.net] has joined #joinmarket     
11:24 -!- quitobro [~quitobro@static-108-29-95-16.nycmny.fios.verizon.net] has quit [Client Quit]     
11:29 -!- quitobro [~quitobro@static-108-29-95-16.nycmny.fios.verizon.net] has joined #joinmarket     
11:34 -!- quitobro [~quitobro@static-108-29-95-16.nycmny.fios.verizon.net] has quit [Quit: quitobro]     
11:35 -!- quitobro [~quitobro@static-108-29-95-16.nycmny.fios.verizon.net] has joined #joinmarket     
11:39 -!- quitobro_ [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #joinmarket     
11:40 -!- quitobro [~quitobro@static-108-29-95-16.nycmny.fios.verizon.net] has quit [Ping timeout: 248 seconds]     
11:40 -!- quitobro_ is now known as quitobro     
12:14 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Quit: quitobro]     
12:57 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #joinmarket     
14:23 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Quit: quitobro]     
15:00 -!- undeath [~undeath@unaffiliated/undeath] has joined #joinmarket     
15:01 < undeath> has anyone ever looked into why coverall is broken in jm-cs?
15:23 < waxwing> just clicked restart build and it passed arubi (i saw this behaviour a bit before, but haven't made any commits for a while)
15:23 < waxwing> undeath, i did try to look into it at first, but i found it hard to figure out. some weirdness with pytest and coverage modules no doubt.
15:24 < undeath> yeah, the only hint I found so far is "Coverage.py warning: No data was collected." at the end of the tests in travis
15:24 < waxwing> early on (like, a year ago) it had very good coverage but now it'll be back to the default of "pretty damn low" i'm afraid.
15:25 < waxwing> i made some notes on the issue of testing in the TODO.md in docs. i'm not really sure the best way to proceed, but there are a lot of tests, and they can be run locally.
15:25 < waxwing> well the weirdness presumably includes travis considering i don't get that error locally.
15:25 < undeath> yes, same for me
15:27 < arubi> waxwing, yea I guess sometimes curl just fails to download one of the files.  I did see it locally but thought it was just my connection.  maybe it's the other end
15:30 < waxwing> yeah something like that i guess
15:30 -!- delinquentme [~delinquen@c-73-71-127-234.hsd1.ca.comcast.net] has joined #joinmarket     
15:31 < delinquentme> adlai, PMd
15:53 < undeath> waxwing: found the problem with coveralls :)
15:53 < undeath> is there a reason to use fixed versions for the python modules in requirements-dev?
16:02 < waxwing> undeath, that came from an earlier version issue with the same modules/packages
16:02 < waxwing> which i'd struggle to remember. if you can make it work with different versions, i'd be more than fine with that..
16:03 < undeath> it's not related to coveralls but I just tried a build with the latest versions and it succeeded
16:03 < waxwing> one thing is whether/how you can specify which modules are not included in test coverage.
16:04 < waxwing> but if you can get it to work at all it's already a step up.
16:04 < waxwing> (i mean, on travis; iirc coverage works fine locally)
16:05 < undeath> excludes work just as configured
16:05 < undeath> https://coveralls.io/builds/14016961
16:05 < undeath> eg jsonrpc.py is not included
16:05 < undeath> I'll make a PR so you can have a look whenever you have time
16:08 < waxwing> great
16:08 < waxwing> one thing that makes me remember, bci.py should be removed, we don't use that any more ... :)
16:09 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Read error: Connection reset by peer]     
16:12 < GitHub124> [joinmarket-clientserver] undeath opened pull request #102: fix coveralls (master...coveralls-fix) https://git.io/vFZVV
16:15 < waxwing> undeath, yeah i'll merge that straight away, thanks.
16:15 < undeath> great :)
16:18 < undeath> the travis build in the PR failed for some weird reason but succeeded on my repo just minutes ago
16:18 -!- MaxSan [~user@213.152.162.84] has joined #joinmarket     
16:19 < GitHub52> [joinmarket-clientserver] AdamISZ force-pushed master from 288f74b to 6679f92: https://git.io/v5bgz
16:19 < GitHub52> joinmarket-clientserver/master 6679f92 AdamISZ: Add full BIP143 semantics for custom sighash flags
16:20 < waxwing> undeath, same issue as i had earlier today
16:20 < waxwing> some download of a key seems to fail intermittently; something like that
16:21 < undeath> I see
16:34 < arubi> I could add an override for that thing for travis (or in general if better)
16:35 < arubi> pretty weird, it does seem to download something, but fails on validating it specifically
16:35 < arubi> at least locally it were just curl not starting the download at all
16:44 < GitHub94> [joinmarket-clientserver] AdamISZ pushed 1 new commit to master: https://git.io/vFZiJ
16:44 < GitHub94> joinmarket-clientserver/master 8c24701 AdamISZ: Add utxo tainting tool for Joinmarket wallets...
16:44 < waxwing> re this ^ , it would be great if someone could help me by testing this on testnet (i've tested on regtest, you can do too if you know how of course)
16:44 < waxwing> start with jmtainter.py --help and go from there.
16:45 < waxwing> you can either make a single|acp input output pair yourself, start with `wallet-tool.py showutxos` and pick one, then do `jmtainter.py walletfile make utxo`, then pass across txhex
16:46 < waxwing> or i can do that and you can do taker side, where you do `jmtainter.py -m mixdepth walletfile take amount-in-satoshis destinationaddr txhex`
16:46 < waxwing> note that there is a --bump option; defaults to 10000 satoshis, the maker gets that bump to his output, and the taker checks that that bump is less than or equal to his value (same default).
16:47 < waxwing> whether this ends up being useful is .. a valid point to debate :)
16:55 < waxwing> damn apparently US border took nopara in for questioning after he said he was coming to a Bitcoin conference:(
16:57 < arubi> :(     
16:57 < arubi> I'll run that tomorrow ^
16:58 -!- delinquentme [~delinquen@c-73-71-127-234.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]     
16:58 < GitHub157> [joinmarket-clientserver] AdamISZ pushed 3 new commits to master: https://git.io/vFZPT
16:58 < GitHub157> joinmarket-clientserver/master fc3904e undeath: remove fixed package versions for dev requirements
16:58 < GitHub157> joinmarket-clientserver/master bac5390 undeath: travis: install in dev mode
16:58 < GitHub157> joinmarket-clientserver/master 52264a7 AdamISZ: Merge #102: fix coveralls...
16:58 < GitHub74> [joinmarket-clientserver] AdamISZ closed pull request #102: fix coveralls (master...coveralls-fix) https://git.io/vFZVV
17:01 < arubi> I always foget how to add a branch to travis
17:04 < waxwing> as for me i can't even remember how to add a trigger for coveralls to the repo
17:06 < arubi> oh right you have to commit stuff first right
17:06 < arubi> clever how this git stuff works
17:10 < waxwing> hmm i'm not sure now. we've still got "after_success: coveralls" in the .travis.yml
17:11 < arubi> I'm guessing you're supposed to include some token somewhere?  maybe your github account settings?
17:11 < waxwing> hmm don't think the account, since other repo on same account does it
17:11 < waxwing> maybe in the coveralls account
17:12 < arubi> ah kinda makes sense, like you activate repos on travis
17:12 < waxwing> yeah but i don't know how, oh well, hardly urgent.
17:14 < arubi> I'm rebasing on top of that, re-running on my repo and will PR the gpg skip thing if I don't fall asleep before it's done :)
17:14 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #joinmarket     
17:22 < undeath> you only need to activate coveralls on their website
17:23 < undeath> for public github repos you don't need any api keys or similar
17:37 < waxwing> cool, we now have BIP49 support in trezor, ledger, samourai and electrum - so (segwit)JM is compatible with all those (for recovery, modulo the privacy concern)
17:37 < waxwing> well i have only tested trezor so far, still waiting for any reports on others (and electrum 3 only just released)
17:38 < waxwing> i guess the reverse is another use case, *perhaps* more interesting, i.e. you have funds on one of those wallets and want to move them into JM; but, afaik that is mostly not going to work, since i think a lot/most of them don't use 12(+1) word seeds, and especially not by default.
17:41 < undeath> electrum 3 doesn't use legacy segwit addresses though
17:46 < waxwing> "Segwit scripts embedded in p2sh are supported with hardware
17:46 < waxwing>       wallets or bip39 seeds. To create a segwit-in-p2sh wallet,
17:46 < waxwing>       trezor/ledger users will need to enter a BIP49 derivation path."
17:46 < waxwing> according to thomasv ^ ; it'll be supported. but now i read it, i see; probably not supported outside HW
17:47 < undeath> yes, that's how I understood the comments on reddit
17:48 < waxwing> yeah, i was being too optimistic there, i'm still a bit disappointed he went that route, since bech32 is not backwards compatible, you can't receive from a lot of services with that.
17:48 < waxwing> i mean yeah there is a reason of course, it's smaller, but still, it's how i thought most wallets were going to look at it.
17:49 < undeath> yes, me too
17:49 < undeath> I guess he just wanted to provide some incentive for service providers to update their stacks
17:51 < GitHub124> [joinmarket-clientserver] fivepiece opened pull request #103: add --no-gg-validation flag, default it in travis (master...installsh_travis_nogpg) https://git.io/vFZDP
17:52 < arubi> why did it say --no-gg.. instead of no-gpg.., oh well
17:54 < waxwing> heh     
17:56 < waxwing> i'll probably create a --electrum and --core options for that jmtainter tool, but it'll involve sourcing some information from those external wallets.
17:56 < waxwing> afk     
17:56 < arubi> zzz     
17:57 -!- undeath [~undeath@unaffiliated/undeath] has quit [Quit: WeeChat 1.9.1]     
18:07 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #joinmarket     
19:48 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Quit: quitobro]     
23:36 -!- Guest96010 [~rix@bnc.vps.bg] has quit [Quit: no one lives forever]     
23:37 -!- Rix [~rix@unaffiliated/rix] has joined #joinmarket     
23:38 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.]