--- Day changed Mon Mar 19 2018 00:00 < arubi> so really only when it's a brand new wallet. I don't think importaddress touches the keypool so no reason for it to do a refill at any point 00:02 < waxwing> thx 00:02 < arubi> /goes to work 00:24 < AgoraRelay_> [agora-irc/AlexCato] > AlexCato is using an already set up wallet 00:24 < AgoraRelay_> [agora-irc/AlexCato] that is correct 00:24 < AgoraRelay_> [agora-irc/AlexCato] i'll try to reproduce the error on a new installation this week and create an issue, if I'm successful at that 01:38 -!- wump is now known as wumpus 01:54 -!- Shana80Cummings [~Shana80Cu@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection] 02:05 -!- Princess80Stiede [~Princess8@ns334669.ip-5-196-64.eu] has joined #joinmarket 04:17 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket 05:30 -!- dcousens [~dcousens@110.140.197.162] has quit [Ping timeout: 256 seconds] 05:33 -!- dcousens [~dcousens@110.140.62.103] has joined #joinmarket 06:18 -!- quitobro [~quitobro@pool-108-41-0-186.nycmny.fios.verizon.net] has joined #joinmarket 06:21 -!- quitobro_ [quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #joinmarket 06:22 -!- quitobro [~quitobro@pool-108-41-0-186.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds] 06:22 -!- quitobro_ is now known as quitobro 06:31 -!- Guest52395 is now known as starsoccer 06:53 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #joinmarket 07:08 < quitobro> hey guys, running the install.sh script on mac os and hitting an issue w/ libsodium 07:09 < quitobro> ~/Sites/crypto/joinmarket-clientserver/deps/libffi ~/Sites/crypto/joinmarket-clientserver/deps ~/Sites/crypto/joinmarket-clientserver 07:09 < quitobro> ~/Sites/crypto/joinmarket-clientserver/deps ~/Sites/crypto/joinmarket-clientserver 07:09 < quitobro> ~/Sites/crypto/joinmarket-clientserver/deps/libsodium ~/Sites/crypto/joinmarket-clientserver/deps ~/Sites/crypto/joinmarket-clientserver 07:09 < quitobro> % Total % Received % Xferd Average Speed Time Time Time Current 07:09 < quitobro> Dload Upload Total Spent Left Speed 07:09 < quitobro> 100 323 100 323 0 0 5 0 0:01:04 0:01:03 0:00:01 67 07:09 < quitobro> % Total % Received % Xferd Average Speed Time Time Time Current 07:09 < quitobro> Dload Upload Total Spent Left Speed 07:09 < quitobro> 100 1850k 100 1850k 0 0 255k 0 0:00:07 0:00:07 --:--:-- 253k 07:09 < quitobro> % Total % Received % Xferd Average Speed Time Time Time Current 07:09 < quitobro> Dload Upload Total Spent Left Speed 07:09 < quitobro> 100 543 100 543 0 0 1219 0 --:--:-- --:--:-- --:--:-- 1220 07:09 < quitobro> gpg: WARNING: no command supplied. Trying to guess what you mean ... 07:09 < quitobro> gpg: no valid OpenPGP data found. 07:09 < quitobro> gpg: processing message failed: Unknown system error 07:09 < quitobro> Libsodium was not built. Exiting. 07:15 < quitobro> SOLVED, i’d missed this step: `brew install cartr/qt4/pyqt@4 libsodium` 08:23 < quitobro> waxwing: where does the json rpc authentication logic take place for all the scripts? 08:24 < quitobro> i want to open a PR taht makes JM able to read the `~/.bitcoin/cookie.auth` file for rpc credentials 08:24 < quitobro> similar to how LND does it 08:24 < belcher> quitobro that logic is in blockchaininterface.py 08:24 < quitobro> belcher: thanks 08:25 < belcher> in LND, do you have to configure the location of the ~/.bitcoin/cookie.auth file ? 08:25 < belcher> i looked at that idea a while ago but i dont think it completely removes the requirement for the user to configure something 08:26 < belcher> sipa's comment here summarises the three ways to do this https://github.com/bitcoin/bitcoin/issues/10218#issuecomment-294344400 08:26 < quitobro> belcher: na, LND checks the ‘default’ location i believe, ~/.bitcoin/cookie.auth 08:27 < belcher> ok i see, and then if it doesnt exist it exits with an error and the user has to configure something 08:27 < belcher> that could work well actually 08:27 < quitobro> belcher: you mean from the perspective of querying bitcoind json-rpc? when you start bitcoind w/o any RPC config options it writes cookie.auth for you 08:27 < belcher> maybe like, check in the config file if the location of the data directory exists, if so then go there, if not then go to the default ~/.bitcoin/ 08:28 < quitobro> as long as the user executing bitcoind has permissions to read that file 08:28 < quitobro> belcher: when u say ‘check’ you mean check the config - is that jm config or bitcoin config? 08:29 < belcher> jm config 08:29 < belcher> since jm needs to know where to find cookie.auth (but can try in the default location if it doesnt know) 08:29 < quitobro> is there an existing config for jm to set ‘bitcoin data dir’? i don’t recall such a config, tho we could certainly add one 08:30 < belcher> the idea is one would be added, and the "rpcuser/rpcpassword" would be removed 08:30 < belcher> although actually.. its bad to break things when people update.. so it would be good to have to backward compatible 08:30 < quitobro> yep, agreed 08:31 < belcher> ideally when people update to the new version of joinmarket, using rpcuser/rpcpassword would still work, but new users could not configure at all and joinmarket would look for cookie.auth 08:31 < belcher> fun fact: back in 2015 you could connect joinmarket to bitcoin core by having it run ./bitcoin-cli.. that still works too 08:31 < belcher> if stuff gets broken when people update, then eventually people stop updating at all :P 08:32 < quitobro> very true 08:40 < belcher> quitobro you probably already know about this, but this page documents where the data directory is on different OSes https://en.bitcoin.it/wiki/Data_directory 11:13 -!- GitHub115 [GitHub115@gateway/service/github.com/x-muuwhmknsemtpwoj] has joined #joinmarket 11:13 < GitHub115> [joinmarket-clientserver] mecampbellsoup opened pull request #128: Enable data dir configuration to obtain RPC credentials from cookie auth file (master...auto-discover-json-rpc-credentials) https://git.io/vxGIU 11:13 -!- GitHub115 [GitHub115@gateway/service/github.com/x-muuwhmknsemtpwoj] has left #joinmarket [] 11:17 < belcher> quitobro == mecampbellsoup ooooohh :) 11:18 < quitobro> nooooooooooooooooooooooooooo 11:18 < quitobro> nooooooooooooooooooo!!!!!!!!!!!!!!!! 11:18 < quitobro> i’m doxed!! 11:18 < belcher> looks like you accidently edited yield-generator-basic.py too 11:18 < quitobro> oh oops 11:18 < quitobro> now everyone knows which maker i am too :( 11:19 < belcher> if only their nicknames were randomly generated every time.. 11:19 < belcher> :P 11:25 < belcher> multiwallet is a good idea yes 11:25 < belcher> i havent yet looked at how multiwallet actually works 11:25 < belcher> since the calls importaddress didnt seem to have an option to choose which wallet file to put them in 11:26 < belcher> but it would be great if people could use their own wallet, joinmarket, lnd, etc etc with one node without the wallet files stepping over each other 11:28 < arubi> belcher, there's a flag, -rpcwallet= for bitcoin-cli 11:28 < belcher> and then when you call `importaddress`, how do you choose which wallet that address gets imported to 11:28 < belcher> oh i see 11:29 < belcher> ./bitcoin-cli -rpcwallet=wallet importaddress 11:29 < arubi> mhm 11:29 < belcher> so there must be some way over json-rpc 11:30 < arubi> yea, with knots' setup it's implied. an rpc gets their own wallet per their credentials 11:32 < belcher> ill try it with core, since i was thinking of using something like that for electrum personal server 11:33 < arubi> oh sweet 11:39 < arubi> quitobro, just wondering, why is it not possible to use this on regtest too? 11:43 < arubi> (actually I'll add this Q to the PR so it's documented) 11:49 < waxwing> quitobro, thanks for the suggestion 11:50 < quitobro> arubi: that comment was old i just moved it in the PR if you notice in the diff 11:50 < quitobro> i think it’s referring to rpc credentials in general for unlocking the wallet 11:51 < arubi> ohh I see, right 13:14 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 13:57 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket 15:26 < AgoraRelay_> [agora-irc/AlexCato] could reproduce the wallet-tool error on a brand new JM-client installation. Generating a new wallet and importing addresses on the new one works just fine; my old existing segwit-wallet still fails with exactly the same error 15:26 < AgoraRelay_> [agora-irc/AlexCato] i'll open an issue 15:30 < AgoraRelay_> [agora-irc/AlexCato] deleting the index_cache from the wallet-file fixed it, after it re-imported addresses 15:32 -!- MaxSan [~user@86.105.9.67] has joined #joinmarket 15:41 < AgoraRelay_> [agora-irc/AlexCato] https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/129 15:43 < AgoraRelay_> [agora-irc/belcher] i wonder if the error is something like "address has already been imported" ? 15:43 < AgoraRelay_> [agora-irc/belcher] but im pretty sure in that part of the code, already-imported addresses are obtained from core so as not to import them again 15:44 < AgoraRelay_> [agora-irc/AlexCato] then it should fail even harder after deleting the index_cache, right? 15:45 < AgoraRelay_> [agora-irc/AlexCato] might have to step through this with a debugger, but sadly lack the time for that at this moment. And you probably cant reproduce it... so it'll have to wait a bit :/ 15:46 < AgoraRelay_> [agora-irc/belcher] deleting the index cache makes it fall back to importing from the beginning, theres another if-statement branch iirc 15:46 < AgoraRelay_> [agora-irc/belcher] at least the workaround is simple 17:41 -!- KDD2UAgamambel [~esmyjgt@190.7.148.228] has joined #joinmarket 17:41 -!- KDD2UAgamambel [~esmyjgt@190.7.148.228] has quit [Client Quit] 18:39 -!- MaxSan [~user@86.105.9.67] has quit [Remote host closed the connection] 19:23 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 21:29 -!- AgoraRelay [~jmrelayfn@p5DE4A55A.dip0.t-ipconnect.de] has joined #joinmarket 21:30 -!- AgoraRelay_ [~jmrelayfn@p5DE4AAFE.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 22:50 -!- dcousens [~dcousens@110.140.62.103] has quit [Quit: The Lounge - https://thelounge.github.io] 23:07 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 255 seconds] 23:18 < waxwing> wrt belcher's point, i remember once about a year ago, dealing with a very strange case of failure/crash that did indeed turn out to be a function of JM trying to import an address that Core already thought "belonged" to itself. or something like that. i'll try to find the github issue. 23:18 < waxwing> but yes ofc delete index cache as a solution points away from that, but still. 23:23 -!- quitobro [quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Quit: quitobro] 23:39 -!- Cory [~Cory@unaffiliated/cory] has joined #joinmarket