--- Day changed Thu Apr 12 2018
00:05 < waxwing> that's joinmarket-clientserver 0.3.3 btw, not 0.2.3 but never mind :) Interesting, wonder if this is the same issue as https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/129
00:05 < waxwing> certainly looks like it.
01:06 -!- Lairem1 [~User@185.189.113.2] has joined #joinmarket     
01:08 -!- Lairem [~User@unaffiliated/lairem] has quit [Ping timeout: 265 seconds]     
04:02 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #joinmarket     
04:02 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Client Quit]     
04:12 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #joinmarket     
04:12 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Client Quit]     
04:14 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #joinmarket     
06:24 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection]     
06:31 < waxwing> so the above is a bit of a mystery to me. to summarize: two people independently reported that, specifically when upgrading from 0.15.x to 0.16.0 Bitcoin Core, when loading the wallet, with wallet-tool.py, in joinmarket-cs, they found that they got the above error. which is an RPC error calling importaddress at this line: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/blockchaininterface.py#L353
06:32 < waxwing> AlexCato reported that the error was fixed when he removed the index_cache ; although i think one can't jump to an exact conclusion from that in itself.
06:34 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
06:43 < waxwing> the first thing i'm struggling with is that i can't figure out what actual rpc error is coming out of the importaddress call. it should be printed out but it isn't for some reason.
07:45 < waxwing> Lairem1, if you get a chance, could you let me know if the error is reproducible? If so, could you hold off from fixing/changing anything, and ping me here (I'll be around most of the rest of the day GMT  until midnight I guess). I'd like to try adding a line or two of code to find the issue.
08:04 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has quit [Ping timeout: 276 seconds]     
08:17 -!- belcher [~user@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]     
08:17 -!- belcher [~user@unaffiliated/belcher] has joined #joinmarket     
08:23 -!- GitHub42 [GitHub42@gateway/service/github.com/x-shnsjbryzpzrnpjv] has joined #joinmarket     
08:23 < GitHub42> [joinmarket-clientserver] AdamISZ pushed 1 new commit to master: https://git.io/vxxbK
08:23 < GitHub42> joinmarket-clientserver/master 1f8e004 AdamISZ: Include error reporting on failures of importaddress
08:23 -!- GitHub42 [GitHub42@gateway/service/github.com/x-shnsjbryzpzrnpjv] has left #joinmarket []     
08:24 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has joined #joinmarket     
08:30 < arubi> waxwing, I was just looking through the diff between importaddress in 0.15.1 and 0.16.0, seems like there's a new possible "throw JSONRPCError" that was added:
08:30 < arubi> +    WalletRescanReserver reserver(pwallet);
08:30 < arubi> +    if (fRescan && !reserver.reserve()) {
08:30 < arubi> +        throw JSONRPCError(RPC_WALLET_ERROR, "Wallet is currently rescanning. Abort existing rescan or wait.");
08:30 < arubi> +    }
08:31 < arubi> might be related..
08:32 < waxwing> arubi, Thanks. I don't think these guys were rescanning, but good to know that case exists.
08:33 < arubi> yea, maybe not a rescan, maybe the node was just started and was catching up?  we'll see with the more verbose output you added
08:36 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 265 seconds]     
08:37 < arubi> oh actually, you're passing rescan=false right, so 'fRescan' should be false too and this check bypassed
09:02 < waxwing> right; if fRescan is referring to the rpc parameter, then yeah it's always false there arubi 
09:14 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
09:14 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket     
09:42 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
09:58 -!- instagibbs [~instagibb@pool-100-15-128-78.washdc.fios.verizon.net] has quit [Ping timeout: 260 seconds]     
10:00 -!- so [~so@unaffiliated/so] has quit [Read error: Connection reset by peer]     
10:05 -!- akrmn [~akrmn@79.red-83-54-170.dynamicip.rima-tde.net] has joined #joinmarket     
10:10 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #joinmarket     
10:39 < arubi> I'm going over the error trace in #129, at one point it's at 'blockchaininterface.py", line 538, in sync_addresses' (no longer the same line no. after today's push) , this is a loop that takes privkeys from the jm wallet and imports the addresses for them. I'm looking at the loop which is now at line 538, seems that it does "magicbyte=get_p2pk_vbyte()" and it turn that fetches a p2pkh version byte?  AlexCato's says "A long-working JM wallet 
10:39 < arubi> (segwit)..." so I'm wondering what's going on there
10:39 < arubi> waxwing, ^   sorry if it's irrelevant
10:46 < arubi> the loop fills up imported_addr_list with these addresses which in turn is passed to self.add_watchonly_addresses (now at :545).  basically I'm lost as to why this happens
10:47 < arubi> sorry it fills wallet_addr_list
11:12 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 276 seconds]     
11:37 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #joinmarket     
11:37 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host]     
11:37 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #joinmarket     
11:57 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 265 seconds]     
12:28 < AgoraRelay> [agora-irc/AlexCato] [Freenode/arubi] yea, maybe not a rescan, maybe the node was just started and was catching up?  we'll see with the more verbose output you added <-- About that: my node never stops
12:29 < AgoraRelay> [agora-irc/AlexCato]  and I always have a debug.log constantly open on my log monitor. 100% sure that bitcoin core was working just fine. Also using a different wallet file just worked fine
12:29 < AgoraRelay> [agora-irc/AlexCato] it was only reproducible with the very old wallet file
12:29 < arubi> right, thanks for confirming
12:34 < AgoraRelay> [agora-irc/AlexCato] and i might still have it. With the new commit by waxwing, we might get useful additional info. Let me check.
12:39 < AgoraRelay> [agora-irc/AlexCato] interesting: the broken wallet file works now as well. It did not try to import new addresses this time: using the wallet-file with the removed index_cache (which fixed the issue before) now makes this error un-reproducible on my machine
12:42 < waxwing> alexcato, so it was a very old wallet file: i guess then it was a pretty long time before the exception/crash?
12:45 < AgoraRelay> [agora-irc/AlexCato] was created when i switched to segwit, probably in september or october of 2017
12:45 < AgoraRelay> [agora-irc/AlexCato] index cache is in the low hundreds/dozens
12:46 < waxwing> hmm. i have a similar sized and aged wallet. i also updated to 0.16 about 2-3 weeks ago (a little later than you). never saw this behaviour.
12:49 < AgoraRelay> [agora-irc/AlexCato] oh, it was november. I've even put it in the issue description
12:50 < AgoraRelay> [agora-irc/AlexCato] and yeah, i dont think this is deterministic. We should have seen more error reports then, because this is not an error that can be ignored
12:51 < waxwing> right def not deterministic. also i just noticed your debug out has 760 addresses listed as to be imported, that's of interest.
12:51 < waxwing> well "not deterministic", in the sense, it's hard to know what determines it :)
12:52 < AgoraRelay> [agora-irc/AlexCato] true dat!
12:56 < waxwing> if Lairem1 sees it, i'd like to know how many addresses it said it was going to import (near the start of the console output), on the slight chance the terminal is still open
13:04 < waxwing> arubi, yeah that thing you noticed is about keys imported to the wallet (not part of the HD tree), so it's not actually compatible with p2sh iirc, only with legacy address type.
13:06 < arubi> ahh I see, well fwiw right now if you import a privkey, all relevant scripts are imported as well.  p2pkh, p2sh-p2wpkh, bare p2wpkh, p2pk..
13:06 < waxwing> ok that's cool.
13:07 < waxwing> heads up, first mini-fee spike i've seen in ages https://bitcoinfees.github.io/#3h
13:07 < arubi> aww, and I was about to migrate wallets on the weekend :\
13:07 < waxwing> btc price is also weird. total flatline then huge spike then flatline again.
13:07 < waxwing> it's like a perfect square wave or whatever that's called.
13:08 < arubi> so, business as usual? :)
13:08 < waxwing> step function is what i was thinking of.
13:08 < arubi> yea today's bull run caught me by surprise.  I had to do a double take on the price
13:10 < waxwing> the sharp move is totally normal. but completely flat before *and* after is weird. step functions like that are really uncommon patterns in markets i think.
13:11 < waxwing> funnily enough, a really perfect market should probably behave exactly like that: if actually new news arrives, it should rapidly move the price to a new level and stay there until the next bit of news.
13:11 < waxwing> but ofc it really doesn't work like that.
13:16 < arubi> were there even any good news?  iirc the last thing I read on reddit before this happened was that there were a bunch of shorts made on some exchange.  well who knows if it's even related or even true
13:16 < waxwing> yeah, no idea, there was no obvious news i think.
13:18 < wumpus> no news, just gremlins as usual
13:19 < arubi> makes sense
13:36 -!- instagibbs [~instagibb@pool-100-15-128-78.washdc.fios.verizon.net] has joined #joinmarket     
14:20 < midnightmagic> waxwing: not so uncommon. It appears to me like someone is moving money around.
15:34 < belcher_> waxwing if you look at the price on a 1m chart you can see it overshot.. so it was a step function with a high damping factor
15:34 < belcher_> and no oscillation
15:36 < waxwing> yeah i remember at one time thinking you could model price moves like that, maybe apply the idea of critical damping.
15:46 < Lairem1> will provide more information in a minute
15:49 -!- Lairem1 is now known as Lairem     
16:07 < Lairem> i ran jm 0.2.3 + core 0.15 with no major problem
16:07 < Lairem> then i swiped that wallet to a new one, then switched to 0.16
16:08 < Lairem> ygpe worked fine until i restarted the machine
16:09 < Lairem> the old wallet still shows addresses with wallet tool but not the new one
16:10 < Lairem> one sec so i post those logs
16:11 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #joinmarket     
16:13 < Lairem> https://pastebin.com/tFk87cx6 logs of new wallet on 0.2.3 and 0.16
16:14 < Lairem> simultaneously i had another machine running 0.3.3 with a new wallet and 0.16
16:14 < Lairem> same story. worked fine until i restarted
16:16 < Lairem> both wallets relatively new, the 0.3.3 one having just 2 joins and the 0.2.3 one less than 50 i would say
16:16 < Lairem> logs are the ones i posted yesterday
16:22 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer]     
16:22 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
16:23 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Max SendQ exceeded]     
16:23 < Lairem> absolutely sure i was not rescanning and core was up and running as expected
16:24 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
16:24 -!- raedah [~x@71.19.251.248] has joined #joinmarket     
16:42 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
16:44 -!- fzk-man [~mviql@177.128.213.254] has joined #joinmarket     
16:46 -!- fzk-man [~mviql@177.128.213.254] has quit [Remote host closed the connection]     
16:52 -!- ctfwmufm [~vqzahbcv@2001:19f0:5:2c27:5400:1ff:fe73:82bf] has joined #joinmarket     
16:52 -!- fenvyiek [~spmzyxjq@177-126-158-72.voatelecom.net.br] has joined #joinmarket     
16:54 -!- ctfwmufm [~vqzahbcv@2001:19f0:5:2c27:5400:1ff:fe73:82bf] has quit [Remote host closed the connection]     
16:54 -!- fenvyiek [~spmzyxjq@177-126-158-72.voatelecom.net.br] has quit [K-Lined]     
18:33 -!- raedah [~x@71.19.251.248] has quit [Ping timeout: 240 seconds]     
19:18 -!- Lairem [~User@185.189.113.2] has quit [Read error: Connection reset by peer]     
19:35 -!- Lairem [~User@185.189.113.7] has joined #joinmarket     
19:56 -!- Lairem [~User@185.189.113.7] has quit [Changing host]     
19:56 -!- Lairem [~User@unaffiliated/lairem] has joined #joinmarket     
20:12 < Lairem> fyi i tried resetting the values in wallet.json index_cache and also recovering from seed but neither worked
20:12 < Lairem> both 0.2.3 and 0.3.3
20:19 -!- AgoraRelay [~jmrelayfn@p5DE4A523.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]     
20:27 < Lairem> also wallet-tool.py succesfully generated and displayed addresses on both versions
20:31 -!- AgoraRelay [~jmrelayfn@p5DE4A4AF.dip0.t-ipconnect.de] has joined #joinmarket     
20:41 < Lairem> waxwing if this helps at all, on 0.2.3 it fails while triyng to import 1 address after clearing index_cache
20:45 -!- ariadorxs [~fbrqj@177.220.233.26] has joined #joinmarket     
20:48 -!- ariadorxs [~fbrqj@177.220.233.26] has quit [Remote host closed the connection]     
21:03 -!- jmsxYD3J6G [~dmczl@189.127.12.250.nipcable.com] has joined #joinmarket     
21:05 -!- jmsxYD3J6G [~dmczl@189.127.12.250.nipcable.com] has quit [Remote host closed the connection]     
21:40 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 276 seconds]     
22:13 -!- Lairem1 [~User@185.189.113.4] has joined #joinmarket     
22:14 -!- Lairem [~User@unaffiliated/lairem] has quit [Ping timeout: 240 seconds]     
22:55 -!- Lairem1 is now known as Lareim     
22:55 -!- Lareim is now known as Lairem     
22:55 -!- Lairem [~User@185.189.113.4] has quit [Changing host]     
22:55 -!- Lairem [~User@unaffiliated/lairem] has joined #joinmarket     
23:34 < Lairem> &join bitcoin
23:34 < Lairem> oops 
23:53 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Ping timeout: 276 seconds]     
23:59 -!- xcvvcx [53e42f33@gateway/web/freenode/ip.83.228.47.51] has quit [Quit: Page closed]