--- Day changed Sat Apr 14 2018 00:36 -!- Jeromy21Pollich [~Jeromy21P@ns334669.ip-5-196-64.eu] has joined #joinmarket 02:03 -!- shalome [7656b924@gateway/web/freenode/ip.118.86.185.36] has joined #joinmarket 02:37 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Ping timeout: 264 seconds] 02:54 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket 04:36 -!- belcher [~user@unaffiliated/belcher] has quit [Ping timeout: 268 seconds] 04:41 -!- belcher [~user@unaffiliated/belcher] has joined #joinmarket 05:10 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket 06:45 < waxwing> struggling to find any previous discussion on this. there is this but it has no content: https://github.com/JoinMarket-Org/joinmarket/issues/752 06:46 < waxwing> does anyone have any good ideas about what *should* happen when this rpc error happens? the user has imported the key (probably for spending) into his Bitcoin Core wallet, and then when he tries to sync joinmarket, he can't because the address can't be imported. 06:47 < waxwing> i'm entirely ready to take the time to make a patch, except i don't know what the patch contains :) 06:50 < arubi> waxwing, ignore that error specifically? it's not much of an error right, more like a warning 06:51 < waxwing> arubi, oh. but, then i have to think about what that means for the wallet. am i being dumb here? 06:51 < waxwing> ah, it's already been used, so ... 06:52 < arubi> hmm, is there a way to change an address's label? not sure 06:52 < waxwing> right. if that were possible that would eliminate the need to worry about edge cases. 06:53 < waxwing> but if Core wallet has an address in its 'default', i guess it's not too happy to have it be swiped out to a different label? 06:54 < arubi> well you can put a label on an address that the wallet has in "" 06:54 < waxwing> this is what i was thinking before, but i remain confused about it. thing is, i *guess* that almost in every case of a person doing this, it'd be a lower numbered index address in the JM hierarchy, one that is not going to get referred to again. but that's fiddly. 06:54 < arubi> maybe it's the same, lemme see 06:54 < waxwing> if people would stop moving keys around manually .. :( (it's dangerous too, but that's never going to stop anyone) 06:57 < arubi> yea probably not going to happen.. there's 'setlabel' that can change an address's label after the privkey was imported.. how does jm wallet know if an address has been used? 06:57 < waxwing> i think listtransactions, or listaddressgroupings using fast mode, i'll have to check again 06:58 < waxwing> yeah 06:59 < waxwing> listtransactions is called with the wallet name as the first parameter (label/account) 07:01 < arubi> ah, so it'll have to 'setlabel' for an address during import as that happens, then I guess it'll know about it next time listtransactions is called? 07:01 < waxwing> oh hang on. let me look up setlabel. 07:02 < waxwing> btw is there such a thing as de-importing arubi ? 07:03 < waxwing> i can't find setlabel. is it in the bitcoin-cli help? 07:03 < waxwing> i see a 'setaccount' (this is 0.16) 07:04 < arubi> oh then it's probably in master. I'm guessing it does the same thing. I don't think there's anything like de-importing 07:05 < waxwing> right. so what on earth is the right thing to do i wonder. pause import, ask the user if they want to move the key from the other account to this JM one? 07:05 < waxwing> that's a pain but it almost seems like the only acceptable thing to do. 07:06 < arubi> yea I guess so, they've basically overridden the jm wallet when importing a privkey 07:12 < arubi> waxwing, actually jm using multiwallet (jm uses a core wallet by itself) would probably make it so even if the user ended up importing a key, the python wallet would not even know about it 07:13 < waxwing> you mean where the JM Core wallet is different from the other Core wallet (the default one, or something like that?) 07:13 < arubi> right 07:13 < waxwing> no idea about multiwallet, is it already released? 07:13 < arubi> oh yes 07:14 < waxwing> hmm so how does one choose the wallet if using rpc? 07:15 < arubi> I think you just give the name of the wallet in the path. belcher has this set up in EPS 07:15 < waxwing> ah ok like using http 07:15 < arubi> electrumpersonalserver/jsonrpc.py: self.url = "/wallet/" + wallet_filename 07:15 < waxwing> sounds like a good PR for belcher then :) 07:16 < arubi> :) 07:28 -!- shalome [7656b924@gateway/web/freenode/ip.118.86.185.36] has quit [Quit: Page closed] 08:21 < waxwing> hmm. -4 is "unspecified wallet error"; but it'd be crappy to trigger the action of the exact error string I think? 08:23 < waxwing> otoh if the action (on user choice) is only to call setaccount, then it's probably OK. 08:33 < arubi> if '-4' repeats for other errors as well then comparing against the exact message is probably better.. 08:45 < waxwing> ping alexcato , wondering what you think should be done. i'm somewhat inclined to do no more than give a clear error message. perhaps advise user on what can be done manually to address it. 08:45 < waxwing> sounds like multiwallet is a logical long term addressing of such issues. 08:45 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #joinmarket 08:55 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 11:05 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #joinmarket 11:45 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 264 seconds] 11:51 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket 12:59 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Ping timeout: 268 seconds] 13:09 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket 13:15 -!- viasil_ [~viasil@185.212.171.206] has joined #joinmarket 13:16 -!- viasil [~viasil@185.212.171.206] has quit [Read error: Connection reset by peer] 13:35 < Lairem> waxwing, i can confirm that was the issue. switching back to bitcoin-rpc from electrum now 13:35 < Lairem> thanks for the help 16:13 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Ping timeout: 240 seconds] 16:28 -!- Lairem1 [~User@185.189.113.11] has joined #joinmarket 16:31 -!- Lairem [~User@185.189.113.12] has quit [Ping timeout: 240 seconds] 16:31 -!- Lairem [~User@185.189.113.52] has joined #joinmarket 16:34 -!- Lairem [~User@185.189.113.52] has left #joinmarket [] 16:35 -!- Lairem1 [~User@185.189.113.11] has quit [Ping timeout: 256 seconds] 17:18 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 17:54 -!- viasil_ is now known as viasil 18:20 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket 18:51 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Ping timeout: 264 seconds] 19:14 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket 19:17 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Quit: Leaving.] 19:18 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #joinmarket 20:17 -!- AgoraRelay [~jmrelayfn@p5DE4A64F.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds] 20:20 -!- Lairem [~User@185.189.113.12] has joined #joinmarket 20:20 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Ping timeout: 240 seconds] 20:21 -!- Lairem [~User@185.189.113.12] has quit [Changing host] 20:21 -!- Lairem [~User@unaffiliated/lairem] has joined #joinmarket 20:28 -!- AgoraRelay [~jmrelayfn@p5486603E.dip0.t-ipconnect.de] has joined #joinmarket 21:53 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket 22:33 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Quit: WeeChat 2.2-dev] 22:38 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket 22:58 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 245 seconds]