--- Day changed Thu May 03 2018
00:36 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket     
00:43 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket     
01:13 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket     
04:24 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 264 seconds]     
04:26 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #joinmarket     
04:52 < belcher> viasil i made another commit and squish on that PR and the same thing happened, i tried your steps again but this time theres a conflict https://pastebin.com/D3vh6L1a i dont think i should fix the conflict because it will add unrelated changes to the PR
04:58 -!- quitobro [~quitobro@pool-108-41-0-186.nycmny.fios.verizon.net] has joined #joinmarket     
05:03 -!- quitobro [~quitobro@pool-108-41-0-186.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds]     
05:03 -!- quitobro [quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #joinmarket     
05:13 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 255 seconds]     
05:14 < viasil> ok, I'll take a look
05:27 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 256 seconds]     
05:29 < belcher> ty     
05:30 < viasil> got sidetracked, looking now
05:32 < viasil> hrm, strange, I fetched origin (bitcoin repo), reset to belcher/2018-04-rpc-getaddress and then rebase origin/master (bitcoin repo master) and it worked cleanly
05:33 < viasil> from your pastebin, what is origin?
05:33 < viasil> (bitcoin repo, or belcher repo)
05:34 < belcher> bitcoin repo
05:34 < belcher> i was following these steps here exactly https://pastebin.com/a25AN7Zs
05:34 < viasil> Ok, before the rebase, did you "git fetch origin"
05:35 < viasil> Also, did you just want to cleanly rebase code, or did you also make updates locally?
05:36 < belcher> only cleanly rebase, i already made updates and squished them
05:36 < belcher> i didnt do fetch origin, i could try it now, after git rebase --abort
05:37 < belcher> nope, conflict again
05:39 < viasil> Is the code/tree anywhere online I could work with it?
05:39 < viasil> So I can see what state it's in and send commands
05:39 < belcher> https://github.com/chris-belcher/bitcoin/tree/2018-04-rpc-getaddress
05:40 < belcher> with PR open https://github.com/bitcoin/bitcoin/pull/13152
05:40 < viasil> and is the squashed/final commit you want d5b24010836e4fe8d820cb28897895ce567d1c4c?
05:41 < viasil> nevermind that
05:41 < belcher> no, its 73f046df94b4f19ebbfa7d76c1f25562f9b7d1b5
05:45 < viasil> ah, ok, i think everything is actually normal then.  Perform the rebase again and edit the rpcconsole.h file
05:45 < viasil> look for the "<<<<" section
05:46 < belcher> i see them
05:46 < viasil> edit out the unwanted version and save
05:46 < belcher> but wont it show up in my PR then
05:46 < belcher> its unrelated, i never edited rpcconsole.h at all
05:47 < viasil> no, so long as it matches what's in the original
05:47 < belcher> ah     
05:47 < viasil> Someone else did, and you're pulling in the changes
05:47 < viasil> https://github.com/chris-belcher/bitcoin/commit/b069b0f9c578c770eb6d56d5344c8fd2aaa4ec57
05:50 < viasil> after you do that, git add the rpcconsole.h file and git rebase --continue
05:50 < viasil> then do git diff origin/master to see the clean patch (to verify)
05:50 < belcher> ah     
05:50 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
05:50 < belcher> git diff origin/master is a good command lol
05:51 < belcher> yes it all worked, excellent
05:51 < viasil> yeah, just be sure you git fetch origin before (which just pulls in all remote changes to git state, but does not modify local working copy)
05:52 < belcher> before the git rebase -i ?
05:52 < belcher> btw i actually used git rebase --skip since it said "If there is nothing left to stage, chances are that something else already introduced the same changes; you might want to skip this patch."
05:52 < viasil> if you're just squashing locally, it's not necessary, but if you're cleaning up for a push, yes.  always fetch to get the latest state of the remote
05:53 < belcher> i did think it was strange that git was asking me to fix conflicts that in theory were already fixed
05:53 < belcher> ok got it
05:53 < belcher> ah, so this problem happens because i squish onto the wrong commit
05:53 < belcher> because the local repo isnt sync'd with the remote on, and git fetch sync's it, i see
05:54 < viasil> yes, exactly
05:54 < viasil> and by local repo, it's more like local git state repo, not working repo, which can be confusing
05:54 < belcher> whats the difference between those two?
05:55 < viasil> Heh, didn't mean to confuse more :-)
05:55 < viasil> Ok, so you can have 10 remotes (all setup with git remote add whatever whatever.git)
05:55 < viasil> If you edit code for some amount of time, those remotes get ahead of you
05:56 < viasil> When you're ready to see what has happened in the meantime, you git fetch remoteN
05:56 < viasil> It changes nothing in your working dir (no code changes)
05:56 < viasil> But lets git know about those changes, so now you can do git diff remoteN/master
05:56 < belcher> got it
05:57 < belcher> but whats the difference between the local git state and working repo
05:57 < viasil> and git log remoteN/master to see history
05:57 < belcher> or is working repo just another word for a remoteN
05:57 < viasil> I am using bad terms it seems.  I was only trying to make a distinction between internal git state (which git fetch updates) and your source code working dir (which git fetch does not touch)
05:58 < belcher> okay i see
05:58 < belcher> yeah gits internal state is all the commits, A -> B -> C and so on
05:58 < belcher> i read that git pull is actually git fetch; git merge;
05:58 < viasil> right, it's more or less the timeline of commit hashes per remote
05:59 < viasil> Right, I was trying to explain that yesterday
05:59 < belcher> which makes sense, it obtains the remote state and then edits your code to be in line with it
05:59 < viasil> I never use git pull
05:59 < viasil> instead use git fetch; git rebase
05:59 < viasil> Because merges cause trouble for upstream :-)
05:59 < viasil> for going upstream, rather
05:59 < belcher> alright
06:00 < belcher> ty again
06:00 < viasil> no problem
06:00 < belcher> ill def spend some time learning about git even more
06:08 -!- player1 [~player1@s91904422.blix.com] has joined #joinmarket     
06:12 < waxwing> arubi, belcher does Core support sign/verify message against p2sh-p2wpkh yet?
06:12 < belcher> i think no
06:12 < belcher> but not sure
06:13 < waxwing> yeah wrong chan really sorry
06:13 < waxwing> (but pretty sure that's right)
06:16 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #joinmarket     
06:32 -!- player1 [~player1@s91904422.blix.com] has quit [Ping timeout: 256 seconds]     
06:32 -!- player1 [~player1@185.62.204.168] has joined #joinmarket     
06:48 < quitobro> hi guys - anyone have a suggested/recommended VPS provider for hosting an always-on full node? cheap and logless preferably :)
06:50 < waxwing> not really, dunno about logless, i've been using crowncloud in the UK recently, been reliable and pretty cheap. but tbh i want to investigate this too.
06:51 < waxwing> i remember a few months ago peter todd telling me about some company .. was it "scaleway"? can't recall.
06:51 < waxwing> but there's like a million of those companies right
06:52 < quitobro> yea there are tons and tons
06:52 < belcher> if you're running joinmarket on them, dont you get worried they might steal your coins?
06:58 < quitobro> yea, i think what i’m going to do (i’m running out of disk on my laptop, basically) is: prune my BTC node, and just use neutrino/some other remote BTC node for my LND stuff
06:58 < quitobro> since JM works with a pruned node, but LND does not (yet?)
07:03 < belcher> pity that LND doesnt work on a pruned node
07:03 < belcher> people talk about how disk space is the cheapest resource but its the only resource used by core that is ever-growing
07:05 < quitobro> yea it’s cheap but it just becomes kinda annoying when you have to store 500GB (i think it’s closer to 400 but give it a year…) on SSD
07:05 < quitobro> i suppose you could do all the IO to hard disk but
07:06 -!- quitobro [quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Quit: quitobro]     
07:18 < waxwing> yeah i think a node that's only being used for watching/monitoring and your actual wallet being local makes a lot of sense.
07:19 < waxwing> e.g. run things like lnd and jm locally and node with indexing, remote. potentially non-ideal for privacy but that seems *fairly* minor (and there's tons of things you can do on that front)
07:24 < waxwing> (lnd needs txindex btw if you use bitcoind)
08:02 < belcher> thats one reason to make it possible to tunnel the rpc connection
08:02 < belcher> one bad thing the original joinmarket did was require those walletnotify=curl blahblahblah things which are hard to tunnel
08:13 < waxwing> right; an encrypted point-to-point connection is not exactly rocket science at this point :)
08:23 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Read error: Connection reset by peer]     
08:23 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket     
08:28 < belcher> ssh tunnel seems the easiest
08:29 < waxwing> yeah ssh is cool. i vaguely remember doing -L and -R stuff for tunnelling.
08:30 < waxwing> "As such, we are retiring BIP126 from Samourai Wallet and we are happy to introduce STONEWALL in replacement.. STONEWALL is a new send type available at no extra charge to all Samourai users, enabled by default - it can be disabled in the Transaction Settings. Whenever possible your wallet will create transactions that simulates a CoinJoin transaction and obtains a Boltzmann score greater than 0. Transactions will appear on the blockchain as if 
08:30 < waxwing> there are multiple unrelated counterparties involved."
08:30 < waxwing> https://blog.samouraiwallet.com/post/173544815052/full-bech32-support-introducing-boltzmann-and
08:32 < waxwing> i guess by default they'll be increasing fees though, eh.
08:32 < waxwing> but it's great news generally if wallets at least try to obfuscate like this
08:45 < arubi> waxwing, re non-p2pkh sign\verify, the current standard is pretty bad..  core doesn't support it but if you want to, you could basically just replace the recid byte (the first byte) in the sig core returns, and it would be a valid (p2sh-)p2wpkh sig
08:54 -!- bsm1175321 [~mcelrath@173-9-124-61-NewEngland.hfc.comcastbusiness.net] has quit [Remote host closed the connection]     
09:03 -!- quitobro [quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #joinmarket     
09:05 < arubi> weird, I can get electrum to verify p2pkh and p2wpkh with same message and signature, no change needed for the recid byte (seems like electrum doesn't check for it anyway), but not p2sh-p2wpkh
09:05 < arubi> I'm on 3.1.1, maybe it's fixed later on
09:17 -!- madacol [~Thunderbi@181.56.216.44] has joined #joinmarket     
09:20 < waxwing> i was mostly just interested in verify on Core, because all I've done is implement signmessage in JM so that the output is compatible with Core. Tbh, the only reason I did even *that* was because someone requested it.
09:21 < waxwing> Would be happy to implement the other direction, but it's not a priority, and re: segwit, I'll just wait and copy Core.
09:21 -!- bsm1175321 [~mcelrath@173-9-124-61-NewEngland.hfc.comcastbusiness.net] has joined #joinmarket     
09:21 < waxwing> i'd bet the only reason it was requested was so someone could claim a shitfork :)
09:22 < waxwing> back to the samourai stonewall, this gist on the algo is worth a look (if you didn't see it already): https://gist.github.com/SamouraiDev/4ced85a29996dd56781e2bf319b93aaf
09:23 -!- madacol [~Thunderbi@181.56.216.44] has quit [Read error: Connection reset by peer]     
09:25 -!- madacol [~Thunderbi@181.56.216.44] has joined #joinmarket     
09:38 < arubi> oh very cool, so that means a mixed joinmarket will look like the 3rd type stonewall send
09:56 < arubi> oh p2sh-p2wpkh with the same sig as p2pkh, and same for p2wpkh does work on electrum, I was using the wrong address :).  so basically yuck :P
09:58 < arubi> not that it /really/ matters to check against the correct recid, so maybe they got the right idea
09:59 -!- madacol [~Thunderbi@181.56.216.44] has quit [Read error: Connection reset by peer]     
10:32 -!- madacol [~Thunderbi@181.56.216.44] has joined #joinmarket     
10:44 -!- madacol [~Thunderbi@181.56.216.44] has quit [Read error: Connection reset by peer]     
11:10 < arubi> oh btw waxwing I know you said you'll consider verifymessage later on, but a while ago I wrote https://github.com/fivepiece/sign-verify-message/blob/master/signverifymessage.md which might help a bit.  extending this to other address types (considering eg trezor's standard for signing p2sh\p2wpkh stuff) is basically adding a step 8 at sign (add the constant for p2sh\bare p2wpkh) and adapting step 7 in verify against the correct address.  it 
11:10 < arubi> should be 1:1 compatible with core
11:11 < waxwing> arubi, ok thanks i'll keep it in mind
11:11 < arubi> cheers
12:25 -!- GitHub116 [GitHub116@gateway/service/github.com/x-gvynvsjxdngpoclq] has joined #joinmarket     
12:25 < GitHub116> [joinmarket-clientserver] AdamISZ pushed 1 new commit to master: https://git.io/vp2hT
12:25 < GitHub116> joinmarket-clientserver/master 816078b AdamISZ: Merge #137: Add support for taker using a non-segwit wallet...
12:25 -!- GitHub116 [GitHub116@gateway/service/github.com/x-gvynvsjxdngpoclq] has left #joinmarket []     
12:25 -!- GitHub45 [GitHub45@gateway/service/github.com/x-eedyzdqpgqcssdqy] has joined #joinmarket     
12:25 < GitHub45> [joinmarket-clientserver] AdamISZ closed pull request #137: Add support for taker using a non-segwit wallet (master...taker-non-sw) https://git.io/vpzpy
12:25 -!- GitHub45 [GitHub45@gateway/service/github.com/x-eedyzdqpgqcssdqy] has left #joinmarket []     
12:26 < waxwing> ok as of that ^ you can run maker or taker side without segwit with segwit = false in [POLICY]. Except not in Qt/gui
12:26 < waxwing> tested it quite a bit (including a few trials on mainnet for sanity check)
12:27 < belcher> very cool
12:30 < waxwing> huh, just opened that *md arubi .. that's some good info, maybe it can be added to the bitcoin wiki in some form (assuming the same information is not available elsewhere, as i suspect)
12:31 < belcher> we figured out how to create bitcoin wiki accounts fwiw
12:32 < belcher> its probably easier to only link that guide to start with
12:32 < belcher> im going to add it to the wiki now i think
12:33 < arubi> oh thanks, please do.  I don't think that info is anywhere except in libsecpk :)
12:36 < waxwing> arubi, is 'HASH256' a standard term for sha2^2 ?
12:36 < arubi> yes, correct
12:37 < arubi> well standard in bitcoin world, as HASH160 -> rmd160(sha256()), they take the name of the opcodes
12:38 < waxwing> "The signing user's public key P being used in in" <-- typo
12:38 < waxwing> arubi, yeah i knew that one, but HASH256 slipped my memory. maybe add a footnote or something, unless everyone else remembers :)
12:39 < arubi> thanks :), probably some more in there.  not a bad idea to add a note.
12:41 -!- player1 [~player1@185.62.204.168] has quit [Quit: player1]     
12:42 < waxwing> i slightly object to the first section being called "Encoding of a Bitcoin signed message", since it's really encoding of a message *to be* signed.
12:43 < waxwing> noob may be confused thinking that encoding is itself a signature. still they'd have to be pretty confused if they read the rest of the doc and still didn't get it.
12:45 < arubi> how would you phrase that?  I see your point, it should pretty much convey that the encoding itself is not even the message that's passed to the verifier.  it's all internal
12:47 < waxwing> just forget that, it's not worth the trouble to think about really.
12:48 < arubi> hopefully it's the non-noobs who'll be implementing it :)
12:52 -!- player1 [~player1@89.249.64.235] has joined #joinmarket     
12:56 -!- pipp8 [~pipp8@45.32.161.1] has joined #joinmarket     
13:16 < pipp8> is this project mantained?
13:18 < pipp8> I have downloaded joinmarket, and it use btc.blockr.io which is no more available
13:21 < AgoraRelay> [agora-irc/AlexCato] hi pipp8, yes its maintained. The version you most likely wanna use though is this one: https://github.com/JoinMarket-Org/joinmarket-clientserver Support segwit, gets a ton of use and can use other blockchain sources than blockr
13:22 < pipp8> AgoraRelay, I have downloaded this -> https://github.com/JoinMarket-Org/joinmarket  is that outdated? sure, I was able to change it to electrum, but having blockr as default was a little disappointed
13:23 < AgoraRelay> [agora-irc/AlexCato] though using your own full bitcoin node is always preferable, if you wish to mix your own coins, you can also use a lighter blockchain source like electrum in it
13:24 < AgoraRelay> [agora-irc/AlexCato] it's a little outdated, as it only supports non-segwit transactions and hasnt been changed in a while; But as you noticed, it can work still as well
13:24 < pipp8> AgoraRelay, sure, I was only taking a look in a sandbox :-P I will try your suggested version, thanks
13:25 < pipp8> **giving
13:26 < belcher> we are in the process of replacing that outdated version
13:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
13:43 -!- madacol [~Thunderbi@181.56.216.44] has joined #joinmarket     
13:48 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket     
13:51 -!- player1 [~player1@89.249.64.235] has quit [Quit: player1]     
13:55 -!- madacool [~Thunderbi@181.56.216.44] has joined #joinmarket     
13:56 -!- pipp8 [~pipp8@45.32.161.1] has left #joinmarket ["Leaving"]     
13:57 -!- madacol [~Thunderbi@181.56.216.44] has quit [Ping timeout: 240 seconds]     
13:57 -!- madacool is now known as madacol     
14:56 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Ping timeout: 276 seconds]     
15:17 -!- madacol [~Thunderbi@181.56.216.44] has quit [Ping timeout: 256 seconds]     
15:32 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 265 seconds]     
15:42 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
16:12 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 264 seconds]     
16:13 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
16:15 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket     
16:20 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 264 seconds]     
16:31 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
17:13 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection]     
17:31 -!- pipp8 [~pipp8@45.32.161.1] has joined #joinmarket     
17:35 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
17:54 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Ping timeout: 264 seconds]     
18:05 -!- quitobro [quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Quit: quitobro]     
18:05 -!- quitobro [quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #joinmarket     
18:18 -!- pipp8 [~pipp8@45.32.161.1] has quit [Quit: Leaving]     
20:02 -!- madacol [~Thunderbi@181.56.216.44] has joined #joinmarket     
20:13 -!- quitobro [quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Quit: quitobro]     
20:33 -!- rdymac [uid31665@gateway/web/irccloud.com/x-hokdzmbqkjwadwhw] has joined #joinmarket     
20:59 -!- AgoraRelay [~jmrelayfn@p5DE4A5B6.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]     
21:09 -!- AgoraRelay [~jmrelayfn@p5DE4A5CD.dip0.t-ipconnect.de] has joined #joinmarket     
21:16 < adlai> please disregard any comments containing the words "outdated", "version", and/or "any"
21:16  * adlai intends to maintain any outdated versions that he relies upon, indefinitely, for the forseeable future.
21:17 < adlai> a more interesting question for pipp8 could have been, "where on line did you get a version that uses that blockr thing?"
21:17 < adlai> aka "WHAT YEAR IS IT WHERE YOU ARE!?!?!?!?!?"
21:42 -!- raedah [~x@71.19.252.27] has quit [Ping timeout: 264 seconds]     
22:04 -!- madacol [~Thunderbi@181.56.216.44] has quit [Ping timeout: 260 seconds]     
22:15 -!- gmaxwell [gmaxwell@mf4-xiph.osuosl.org] has joined #joinmarket     
22:16 -!- gmaxwell is now known as Guest9910     
22:16 -!- Netsplit over, joins: nkuttler
22:26 -!- nsh [~lol@wikipedia/nsh] has joined #joinmarket     
23:02 -!- rdymac [uid31665@gateway/web/irccloud.com/x-hokdzmbqkjwadwhw] has quit [Quit: Connection closed for inactivity]     
23:26 -!- Guest9910 [gmaxwell@mf4-xiph.osuosl.org] has quit [Changing host]     
23:26 -!- Guest9910 [gmaxwell@wikimedia/KatWalsh/x-0001] has joined #joinmarket     
23:27 -!- Guest9910 is now known as gmaxwell