--- Day changed Tue Jun 26 2018
02:37 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket     
04:12 < waxwing> please note https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/154 and my response
04:13 < waxwing> and btw on the above macos thing, i could swear someone else had a similar issue quite recently
04:14 < waxwing> damn i thought i'd added a commit to make sure the json-rpc error is displayed, but can't see one now
04:16 < waxwing> and again, on the above, what i do remember is that failures during sync of the form "json rpc error, crash" are usually indicative of someone who is trying to import an already-imported address in Core.
04:19 < belcher> so sybil nodes that DOS everyone
04:20 < belcher> a question for "random under a maximum" is how to choose that maximum
04:21 < belcher> gmaxwell suggested quantize the prices before choosing here https://github.com/JoinMarket-Org/joinmarket/issues/14#issuecomment-143509788
04:27 < waxwing> belcher, yeah so on that 154 issue, i tbh don't remember if ignored_makers gets kept from 1 round to the next; i just know that it does in *some* circumstances, i'm gonna have to check (unless someone else wants to) whether it's working properly for an ordinary sendpayment-and-loop scenario. maybe it only works in tumbler. this is just one of those little loose ends that were so hard to all tie up when rewriting/refactoring the code for jmcs.
04:28 < waxwing> of course if you have like 30 sybil bots or whatever it doesn't really solve the issue.
04:29 < belcher> also doesnt ignored_makers only store the irc nick? so a sybil bot could generate new nicks easily
04:31 < waxwing> good point
04:32 < waxwing> yes we could ban utxos in theory, but that's part of the overall issue (693 and whatnot)
04:51 -!- MaxSan [~user@91.207.102.163] has joined #joinmarket     
04:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 245 seconds]     
04:55 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket     
06:34 -!- MaxSan [~user@91.207.102.163] has quit [Remote host closed the connection]     
06:49 < AgoraRelay> [agora-irc/AlexCato] > gonna have to check (unless someone else wants to) whether it's working properly for an ordinary sendpayment-and-loop scenario
06:49 < AgoraRelay> [agora-irc/AlexCato] tried that a few weeks ago, that works
06:50 < AgoraRelay> [agora-irc/AlexCato] there just are many non-respondants, and they're cheap --> chosen often for joins
06:50 < AgoraRelay> [agora-irc/AlexCato] oh. Didnt properly read what you wrote. It works for single sendpayments. Unsure what the "-and-loop" is referring to
06:59 < waxwing> yeah sorry for being completely unclear, just i haven't looked at the code for a while. does sendpayment give up even if it fails, or, as tumbler, wait for stall monitor, wake back up and try again. i think the latter. it wouldn't take me long to check, sorry for being lazy
06:59 < waxwing> also one thing i do kinda remember is with default settings the stall monitor wakes up after 10 minutes (so pretty slow!)
07:37 -!- viasil [~viasil@185.217.171.21] has quit [Ping timeout: 265 seconds]     
07:39 -!- viasil [~viasil@185.217.171.21] has joined #joinmarket     
07:56 < AgoraRelay> [agora-irc/AlexCato] if there is fewer than the minimum required makers (2 by default), sendpayment just stalls. But I've never waited 10 minutes so see if it recovers... i just tried again manually after 2 minutes or so. I will test that right now if it resumes after a while
08:02 < AgoraRelay> [agora-irc/AlexCato] started with 5 requested makers. 3/5 did not answer on first try (that's pretty bad...). That's the last message. Waiting 10 minutes now
08:03 < AgoraRelay> [agora-irc/AlexCato] in case it does recover, i'll prepare a CR which also informs the user what his options are at this point. Currenlty it just says that makers dont respond, but not whats gonna happen next (if anything happens at all)
08:39 < AgoraRelay> [agora-irc/AlexCato] Nope, it just seems to quit after around 20 minutes since first launch (sendpayment):
08:40 < AgoraRelay> [agora-irc/AlexCato] 2018-06-26 17:02:06,164 [MainThread  ] [INFO ]  Makers didnt respond: [u'J52yiEx8vZUbmMG2', u'J55MnqmqcqVGYqQs', u'J5BKSrM2zFwRmbLm']
08:40 < AgoraRelay> [agora-irc/AlexCato] 2018-06-26 17:19:47,592 [MainThread  ] [INFO ]  STALL MONITOR:
08:40 < AgoraRelay> [agora-irc/AlexCato] 2018-06-26 17:19:47,592 [MainThread  ] [INFO ]  Stall detected. Regenerating transactions and retrying.
08:41 < AgoraRelay> [agora-irc/AlexCato] done
08:41 < AgoraRelay> [agora-irc/AlexCato] it just dies then, it seems, without retrying
08:41 < AgoraRelay> [agora-irc/AlexCato] i'll have a look at this later
09:05 < waxwing> sendpayment's on_finished_callback just gives up on a stall. my thinking was that sendpayment is an interactive function, whereas tumbler is specifically a "set and walk away" (or at least, my focus was on making the latter robust, not the former)
09:06 < waxwing> for code references see https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/client_protocol.py#L322-L330
09:06 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/client_protocol.py#L346
09:07 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/scripts/sendpayment.py#L192
09:08 < waxwing> so i think it should only wait 10 minutes (not that's good, it's unrealistically high for this scenario to wait that long; but 10 minutes isn't *so* crazy for tumbler since it's slow anyway)
09:08 -!- viasil [~viasil@185.217.171.21] has quit [Ping timeout: 245 seconds]     
09:11 -!- viasil [~viasil@185.217.171.21] has joined #joinmarket     
11:11 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #joinmarket     
11:14 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds]     
15:36 -!- GitHub31 [GitHub31@gateway/service/github.com/x-tysdjdyyjpvviudk] has joined #joinmarket     
15:36 < GitHub31> [joinmarket-clientserver] kristapsk opened pull request #155: More clear description of sendpayment -P option (master...cli_options) https://git.io/f475j
15:36 -!- GitHub31 [GitHub31@gateway/service/github.com/x-tysdjdyyjpvviudk] has left #joinmarket []     
16:29 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
20:56 -!- AgoraRelay [~jmrelayfn@p5DE4A048.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]     
21:04 -!- AgoraRelay [~jmrelayfn@p54866E17.dip0.t-ipconnect.de] has joined #joinmarket     
21:28 -!- viasil [~viasil@185.217.171.21] has quit [Read error: Connection reset by peer]     
21:32 -!- viasil [~viasil@185.217.171.21] has joined #joinmarket     
23:51 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has quit [Quit: Leaving.]