--- Day changed Sun Jul 08 2018
00:02 < AgoraRelay> [agora-irc/CatoAlex] first feedback: renaming seems to work,at least on disconnect it did not rejoin the channel before the stale nick was disconnected by the server
00:02 < AgoraRelay> [agora-irc/CatoAlex] have not seen any joins since then, though. Believe thats just coincidence though. Will know more a few hours later
--- Log closed Sun Jul 08 00:38:26 2018
--- Log opened Sun Jul 08 02:09:16 2018
02:09 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #joinmarket     
02:09 -!- Irssi: #joinmarket: Total of 51 nicks [1 ops, 0 halfops, 0 voices, 50 normal]     
02:18 -!- Irssi: Join to #joinmarket was synced in 551 secs
--- Log closed Sun Jul 08 03:22:44 2018
--- Log opened Sun Jul 08 03:22:55 2018
03:22 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #joinmarket     
03:22 -!- Irssi: #joinmarket: Total of 51 nicks [1 ops, 0 halfops, 0 voices, 50 normal]     
03:32 -!- Irssi: Join to #joinmarket was synced in 559 secs
03:56 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket     
04:10 < waxwing> undeath, i wanted to say: appreciate the effort, i have not yet reviewed anything and will not for a while.
04:11 < waxwing> the reason is i already promised at least one user i'd put in a fix to ameliorate the blocking bots we're currently experiencing. that is top priority.
04:11 < waxwing> then this bugfix came along and that became even more urgent, hopefully that's addressed now.
04:11 < waxwing> so i'll go back to doing the above.
04:12 < waxwing> then i'll have to complete what i promised last month: to merge the repos. a bit of a pain/difficult but hopefully not a long time job.
04:12 < waxwing> still haven't had any critiques on that proposal re: how to do it in git/github.
04:12 < waxwing> and all of this is aside from all the non-joinmarket stuff i've been doing last month or two.
04:13 < waxwing> also, i want to do more non-joinmarket stuff (in particular, i'd like to implement snicker), and there's some other coinjoin stuff i'll be involved with later (a few weeks)
04:13 < waxwing> *and* some personal stuff i have to devote time to, too
04:13 < undeath> alright :) and thank you for all the time you dedicate to this project!
04:14 < undeath> maybe someone else also wants to take a look :)
04:14 < waxwing> i'll probably start burbling about this blocking amelioration shortly.
04:14 < waxwing> indeed, please others, take a look at undeath's PR
06:55 < AgoraRelay> [agora-irc/CatoAlex] > waxwing] did you see in the log how long it took to get it back? just curious
06:55 < AgoraRelay> [agora-irc/CatoAlex] yes, it took a little over 3 minutes. The first "nickname in use" message was 3 minutes and 15 seconds before the last
06:56 < AgoraRelay> [agora-irc/CatoAlex] i think the retry should be increased considerably from 5 sec, maybe 60?
06:56 < AgoraRelay> [agora-irc/CatoAlex] I also saw a coinjoin now, so the PR works
06:56 < waxwing> i set it to 10s
06:56 < waxwing> as a compromise between your 60 and my 5 or whatever :)
06:57 < AgoraRelay> [agora-irc/CatoAlex] oh, i see it every 5 sec in the log though, probably was 10s for each message channel
06:57 < waxwing> yeah must be, see code (it's only like 5 lines :))
06:57 < waxwing> anyway, great, i'll merge it later.
07:00 < AgoraRelay> [agora-irc/CatoAlex] great, thanks for implementing it
08:22 -!- grubles [~grubles@unaffiliated/grubles] has quit [Quit: Leaving]     
09:05 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds]     
09:18 -!- grubles [~grubles@unaffiliated/grubles] has joined #joinmarket     
09:38 -!- beIcher [~user@unaffiliated/belcher] has joined #joinmarket     
09:39 -!- belcher_ [~user@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]     
09:59 < waxwing> arubi, any reason to wait on the curl retry PR, or should i just merge?
10:00 < arubi> no reason to wait imo.  I tested on travis and looks like it successfully recovered from the first try downloading libsodium after it failed the first time
10:02 < arubi> after you merge, I'll rebase the docker PR and re-test.  if it passes then I believe it's also fine to merge whenever you think is right
10:02 -!- GitHub21 [GitHub21@gateway/service/github.com/x-sgefdnmwctveydve] has joined #joinmarket     
10:02 < GitHub21> [joinmarket-clientserver] AdamISZ pushed 1 new commit to master: https://git.io/fNff9
10:02 < GitHub21> joinmarket-clientserver/master bfc1045 AdamISZ: Merge #157: Fix bug in IRC nick collision handling...
10:02 -!- GitHub21 [GitHub21@gateway/service/github.com/x-sgefdnmwctveydve] has left #joinmarket []     
10:02 -!- GitHub159 [GitHub159@gateway/service/github.com/x-xufkvrhoafyllbwg] has joined #joinmarket     
10:02 < GitHub159> [joinmarket-clientserver] AdamISZ closed pull request #157: Fix bug in IRC nick collision handling (master...fix-irc-collisions) https://git.io/fbjYF
10:02 -!- GitHub159 [GitHub159@gateway/service/github.com/x-xufkvrhoafyllbwg] has left #joinmarket []     
10:03 -!- GitHub147 [GitHub147@gateway/service/github.com/x-rgvmxddzkbmweien] has joined #joinmarket     
10:03 < GitHub147> [joinmarket-clientserver] AdamISZ pushed 2 new commits to master: https://git.io/fNffQ
10:03 < GitHub147> joinmarket-clientserver/master 80de159 fivepiece: add retry to curl in install process
10:03 < GitHub147> joinmarket-clientserver/master f7d597b AdamISZ: Merge #158: add retry to curl in install process...
10:03 -!- GitHub147 [GitHub147@gateway/service/github.com/x-rgvmxddzkbmweien] has left #joinmarket []     
10:03 -!- GitHub51 [GitHub51@gateway/service/github.com/x-ktacslxotyjfuirl] has joined #joinmarket     
10:03 < GitHub51> [joinmarket-clientserver] AdamISZ closed pull request #158: add retry to curl in install process (master...installsh_curl_retry) https://git.io/fbjim
10:03 -!- GitHub51 [GitHub51@gateway/service/github.com/x-ktacslxotyjfuirl] has left #joinmarket []     
10:03 < arubi> nice
10:03 < waxwing> oh the docker one, is that the old one?
10:04 < waxwing> 71     
10:05 < arubi> yea.  gonna update it to use core 0.16.1 and test
10:07 < undeath> does travis run any integration tests that actually try to do a cj?
10:08 < arubi> it's running jm tests.  I'm assuming it's testing cjs..  waxwing would know for sure
10:08 < waxwing> i remember taking out the tumbler tests because it was too slow
10:08 < undeath> now that the new wallet code is done I'm not sure if any of my changes possibly broke the taker/maker
10:08 < waxwing> but i can't remember now if it's doing full coinjoins, kinda funny i know
10:09 < waxwing> undeath, i find the following invaluable: run test/ygrunner.py under py.test
10:09 < waxwing> then you can run your own takers against it. it includes the ability to make the makers non-deterministically malicious.
10:09 < waxwing> but, separate Q from travis tests ofc
10:09 < undeath> i think i once tried to write tests for that but it was hard to figure out what data the function calls actually expected
10:09 < undeath> ah, cool
10:09 < undeath> will have a look, thanks
10:10 < waxwing> basically you can run a full simulated pit on regtest with miniircd for the IRC and as many ygs as you like, in theory
10:10 < waxwing> if somehow that "full stack" type test dropped out of the travis suite, it should go back in, in some very simple form.
10:11 < waxwing> one quirk (amongst others): run py.test <insert options> test/ygrunner.py -s to print to console the seed which contains coins for your taker.
10:11 < waxwing> there's some info in docs/TESTING.md but it's somewhat imperfect
10:12 < arubi> we have '-k "not configure"' now.  I do remember there being two tests that were disabled a while back, but they were re-enabled since then
10:12 < waxwing> in particular it should be something like this: `py.test --btcroot=/path/to/bitcoind --btcpwd=passwordinconf --btcconf=/path/to/bitcoin.conf --nirc=2 test/ygrunner.py -s`
10:13 < waxwing>  /path/to/bitcoind should actually be /path/to/bitcoin/bin/ if you see what i mean
10:14 < waxwing> obv you need to use a regtest joinmarket.cfg and have it in your root joinmarket-clientserver directory, see the example in test/regtest_joinmarket.cfg
10:14 < undeath> alright, I'll look into that
10:15 < waxwing> anything with broad scale effects, i find i absolutely have to use that setup. feel free to ask Qs. For wallet only stuff you could in theory do without, but i realise at this point you need to start sanity testing the full stack, so to speak.
10:20 < undeath> yep. I tried to keep changes to non-wallet code as small as possible but there are some in taker/taker_utils and I think I need to review maker. not to mention a couple of (tested) changes in blockchaininterface
10:31 -!- undeath [~undeath@unaffiliated/undeath] has quit [Quit: WeeChat 2.1]     
11:38 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket     
11:45 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Ping timeout: 268 seconds]     
12:20 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket     
12:49 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds]     
12:56 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket     
13:24 < waxwing> pushed a restart-with-subset branch (no PR yet); got something working on sendpayment (not looked at tumbler yet).
13:24 < waxwing> basically, if originally N makers and M fail to respond with sig, restarts with the specific N-M makers who were honest.
13:24 < waxwing> very early try though, it'll take a lot of polishing. good side is it'll be easy to test on the real pit at least.
13:25 < waxwing> also added a DeterministicMaliciousYieldGenerator class :)
13:31 < waxwing> arubi, still got this build error (your pr was merged here): https://travis-ci.org/JoinMarket-Org/joinmarket-clientserver/jobs/401523316#L387
14:01 < arubi> waxwing, looks like a different error.  previous one was on linux, "curl: (28) Operation timed out after 0 milliseconds with 0 out of 0 bytes received" (was on linux) which --retry can handle, this one is "curl: (35) Server aborted the SSL handshake" on osx.  it might need "--retry-connrefused" but I'm not sure.  searching ddg for this error osx comes up a lot.  I'll take a look tomorrow, but in the mean time can you try restarting it?
14:02 < waxwing> will do
14:07 < arubi> arg.  passes now.  that would be a bit harder to debug :)  will see tomorrow.  gn
15:54 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
16:47 -!- MaxSan [~user@185.156.175.51] has quit [Ping timeout: 240 seconds]     
17:34 -!- MaxSan [~user@194.88.143.66] has joined #joinmarket     
17:37 -!- MaxSan [~user@194.88.143.66] has quit [K-Lined]     
17:58 -!- AgoraRelay [~jmrelayfn@p5DE4A866.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]     
18:14 -!- AgoraRelay [~jmrelayfn@p5DE4AE01.dip0.t-ipconnect.de] has joined #joinmarket