--- Day changed Tue Jul 10 2018
01:51 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket     
02:28 -!- undeath [~undeath@unaffiliated/undeath] has joined #joinmarket     
02:51 < waxwing> after many requests i feel forced to put a very big, unambiguous link to joinmarket-clientserver in the joinmarket readme. i didn't want to do this myself, so it didn't look like i was controlling everything.
02:51 < waxwing> it's really annoying/embarrassing when people ask about the code, they all see it and think it's unused/unmaintained.
03:36 -!- MaxSan [~user@185.9.19.107] has quit [Ping timeout: 256 seconds]     
03:36 -!- GithubBot5678 [GithubBot5@gateway/service/github.com/x-mbtpwssipqimrftx] has joined #joinmarket     
03:36 < GithubBot5678> [joinmarket] AdamISZ pushed 1 new commit to master: https://git.io/fNU2v
03:36 < GithubBot5678> joinmarket/master 2c374e1 AdamISZ: Temporary redirect to joinmarket-clientserver
03:36 -!- GithubBot5678 [GithubBot5@gateway/service/github.com/x-mbtpwssipqimrftx] has left #joinmarket []     
03:41 < waxwing> i pushed to master, as i don't believe we'll have more releases until the "merge" operation anyway.
03:43 < undeath> I'm not sure if there is a "best way" to merge jm and jm-cs. If you merge cs into the main jm repo the issues/prs are all going to be messed up
03:44 < undeath> a prominent notice in the readme and project description seems like a pretty clean solution to me
03:57 < waxwing> yeah. it's not simple; i think i can do it in a way that preserves the history. issues will take a while to clean up. for PRs we can just close/reopen, as will be making sure the diffs are identical. but .. yes, your POV is logical in itself. i'm leaning more towards it now.
04:02 -!- AgoraRelay [~jmrelayfn@p5DE4AEEB.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds]     
04:22 -!- AgoraRelay [~jmrelayfn@p54866923.dip0.t-ipconnect.de] has joined #joinmarket     
04:57 < waxwing> hmm trying to test the anti-blocking strategy on mainnet and none of them blocked, damn
04:57 < waxwing> is anyone else seeing blocking behaviour regularly in last, say, week or so? i see a lot of joins completing succesfully last several days. have they stopped or something?
05:50 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Remote host closed the connection]     
07:12 -!- qubenix [~qubenix@185.96.210.192] has joined #joinmarket     
07:25 < grubles> waxwing, i haven't seen any lately
07:26 < waxwing> joins? i'd advise using near-zero fees; it was actually helpful to do so recently with regular blocking/misbehaving makers. btw my second try ended up getting 2/5 makers, other three were blocking *first* round (so it used complete with subset)
07:27 < waxwing> i guess i ahve to give up trying to use mainnet, i can get the data more or less completely on regtest.
07:33 -!- qubenix_ [~qubenix@43.245.162.131] has joined #joinmarket     
07:36 -!- qubenix [~qubenix@185.96.210.192] has quit [Ping timeout: 264 seconds]     
07:36 < grubles> sorry. misread the question.
07:36  * grubles grabs coffee
07:38 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 240 seconds]     
07:44 -!- Cory [~Cory@unaffiliated/cory] has joined #joinmarket     
08:04 -!- MaxSan [~user@185.9.19.107] has joined #joinmarket     
08:26 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket     
08:28 -!- grubles [~grubles@unaffiliated/grubles] has quit [Quit: Leaving]     
09:18 < belcher_> undeath: iv read through your PR but not very closely, since its quite big, ill read thought it and review it more soon
09:37 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 250 seconds]     
09:40 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket     
10:12 < undeath> belcher_: thank you :)
10:12 < undeath> if you have any comments so far let me know
10:13 < undeath> I've not rebased or stashed to make it easier following it on a commit-by-commit basis
10:13 < undeath> if it's more useful if I did, let me know
10:42 -!- GitHub118 [GitHub118@gateway/service/github.com/x-usmhkibwbhdfcnea] has joined #joinmarket     
10:42 < GitHub118> [joinmarket-clientserver] undeath opened pull request #160: add basic test for coinjoins (master...test_coinjoin) https://git.io/fNTZl
10:42 -!- GitHub118 [GitHub118@gateway/service/github.com/x-usmhkibwbhdfcnea] has left #joinmarket []     
10:50 < waxwing> undeath, see comment, thanks. there's a weird travis error. (like that's news!)
10:51 < undeath> yeah, looking into that but it's in some part of the code I didn't touch at all >.>
10:51 < undeath> locally it passed
10:55 < waxwing> yeah that's what i was afraid of; very weird. that's never errored before.
11:00 < undeath> https://bitcoincore.org/en/doc/0.16.1/rpc/util/estimatesmartfee/
11:00 < undeath> documentation says that key is "optional"
11:00 < undeath> so maybe we just hit a case where it's not actually present
11:01 < arubi> fee estimation shows up on the log at :2686
11:01 < arubi> transaction has been relayed
11:02 < undeath> that's a different test that was failing
11:02 < undeath> or is it not?
11:03 < arubi> oh I thought it was all one test?  I see "jmclient/test/test_coinjoin.py F" for failing
11:03 < undeath> two failed
11:03 < undeath> jmbase/test/test_commands.py F
11:03  * undeath looks innocently
11:03 < arubi> yes you're right.  moment
11:04 < undeath> but that probably has nothing to do with bitcoid
11:04 < undeath> but the line in the bitcoind output might still be from a different test
11:05 < arubi> that's true
11:05 < waxwing> yeah you reminded me, there is a problem with estimatesmartfee like that. i've seen it before. no idea what's changed here though.
11:06 < arubi> it might behave weird on regtest
11:06 < arubi> if there are too few blocks maybe, and all empty, no txs in mempool..  nothing to gather fee estimation from
11:07 < arubi> (just guessing)
11:08 < undeath> that's possible. test_coinjoin ran before any other tests doing anything with bitcoind
11:08 < waxwing> wait; test_commands failed? umm .. that's just AMP, doesn't use bitcoin or anything
11:09 < undeath> test_coinjoin and test_commands failed
11:12 < undeath> btw, the osx build failed completely
11:13 < arubi> do you mean other than it didn't pass tests?
11:13 < waxwing> undeath, can i suggest this: edit the regtest_joinmarket.cfg and change tx_fees to 10000 instead of '3'
11:13 < waxwing> this way it will not source the fee estimate, but just use a fixed sats/byte
11:14 < undeath> arubi: it didn't even get so far as to run the tests
11:14 < arubi> oh osx?
11:14 < arubi> ah no, it doesn't run tests
11:14 < arubi> it only builds the software
11:14 < waxwing> of course, we should also figure out the cause but anyway.
11:14 < undeath> oh, ok. it looked like it was exiting unexpectedly /Users/travis/.travis/job_stages: line 187: shell_session_update: command not found
11:15 < arubi> that happens in travis, I think it's related to cache
11:15 < waxwing> or i guess less lazy is to fix the fee estimate key error. but maybe for that open a separate issue.
11:15 < arubi> but it does end with 0 so all good
11:15 < undeath> :)     
11:15 < undeath> waxwing: what would be the best way of handling the error?
11:15 < arubi> maybe somebody can try to run a new regtest, mine some blocks and run estimatesmartfee?  see if you get a fee at all or an error about no data?
11:16 < waxwing> fall back to a default. we had that somewhere, but it's not caught here i think. prob due to regtest startup and no estimate.
11:16 < arubi> (I could do it later)
11:18 < undeath> first thing in the lane failing is probably https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/jsonrpc.py#L146
11:18 < undeath> which should also check for the key "errors"
11:18 < arubi> there is one possible outcome for estimatesmartfee which is "errors.push_back("Insufficient data or no feerate found");"  wonder if that's it
11:20 < undeath> from a code perspective the only alternative solution to failing here is hardcoding a default fee
11:20 < undeath> in case of errors
11:21 < undeath> maybe just for the regtest blockchaininterface
11:21 < arubi> that sounds right
11:23 < waxwing> yes, but i can't remember now if we still have a hardcoded default for the failure case somewhere, already. i'll look.
11:23 < waxwing> yes we do see estimate_fee_per_kb
11:25 < undeath> ok, will do a pr
11:26 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Quit: 1 -> 0]     
11:40 -!- bitbee_ is now known as bitbee     
11:42 -!- GitHub145 [GitHub145@gateway/service/github.com/x-dqqijqtfklkqeprx] has joined #joinmarket     
11:42 < GitHub145> [joinmarket-clientserver] undeath opened pull request #161: fix estimatesmartfee failing (master...fix_estimatesmartfee_regtest) https://git.io/fNT8k
11:42 -!- GitHub145 [GitHub145@gateway/service/github.com/x-dqqijqtfklkqeprx] has left #joinmarket []     
11:43 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #joinmarket     
11:44 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Client Quit]     
11:45 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #joinmarket     
11:48 < undeath> the hardcoded default of 100k sat is a little scary though
12:06 -!- undeath [~undeath@unaffiliated/undeath] has quit [Quit: WeeChat 2.1]     
12:42 -!- qubenix_ [~qubenix@43.245.162.131] has quit [Quit: qubenix_]     
12:42 -!- qubenix [~qubenix@43.245.162.131] has joined #joinmarket     
13:38 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 250 seconds]     
13:43 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket     
15:22 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Quit: (┛◉Д◉)┛┻━┻]     
15:57 -!- grubles [~grubles@unaffiliated/grubles] has joined #joinmarket     
16:48 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
16:48 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket     
17:25 -!- qubenix [~qubenix@43.245.162.131] has quit [Remote host closed the connection]     
17:29 -!- AgoraRelay [~jmrelayfn@p54866923.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]     
17:43 -!- AgoraRelay [~jmrelayfn@p5DE4AFB1.dip0.t-ipconnect.de] has joined #joinmarket     
18:40 -!- MaxSan [~user@185.9.19.107] has quit [Ping timeout: 260 seconds]     
20:07 -!- MaxSan [~user@185.9.19.107] has joined #joinmarket     
20:16 -!- qubenix [~qubenix@185.94.192.43] has joined #joinmarket     
22:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds]     
22:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket     
23:00 -!- qubenix [~qubenix@185.94.192.43] has quit [Ping timeout: 244 seconds]     
23:20 -!- AgoraRelay [~jmrelayfn@p5DE4AFB1.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]