--- Day changed Sat Jul 21 2018 01:33 -!- ben__ [5eaf4681@gateway/web/freenode/ip.94.175.70.129] has joined #joinmarket 01:33 -!- ben__ [5eaf4681@gateway/web/freenode/ip.94.175.70.129] has quit [Client Quit] 02:10 -!- undeath [~undeath@unaffiliated/undeath] has joined #joinmarket 03:11 -!- GitHub22 [GitHub22@gateway/service/github.com/x-cqymgbugzessuamn] has joined #joinmarket 03:11 < GitHub22> [joinmarket-clientserver] fivepiece opened pull request #168: update manual joinmarket-qt install steps in readme (master...jmqt_symlink_venv) https://git.io/fNWz8 03:11 -!- GitHub22 [GitHub22@gateway/service/github.com/x-cqymgbugzessuamn] has left #joinmarket [] 03:14 < arubi> got this assert error on my repo's travis in the fedora container : https://travis-ci.org/fivepiece/joinmarket-clientserver/jobs/406554435#L2989-L2990 it's unrelated to the changes in #168, just interesting 03:26 < undeath> I think there even is a comment in the code somewhere that the random tests are a little buggy 03:28 < arubi> ah alright, also looks like it all passed on the joinmarket-org travis 03:29 < undeath> but either one should be fixed 03:30 < undeath> rand_pow_array to not return 0 values or the test to have a >= check 03:30 < undeath> both are trivial but I don't know which one is the desired behaviour 03:38 < waxwing> both are fine, as per the warning, those functions aren't intended to be anything super-accurate. 03:39 < waxwing> as for that error, don't think i ever saw it, but yeah fix, why not 03:42 < waxwing> alexcato, looking at that extra error (stallmonitor one). can you move it to a separate issue? so as not to clutter the 166 thread. thanks. 03:45 < undeath> you should always initialize all object attributes in the constructor in python, that will avoid that error and probably also some others 03:45 < undeath> most IDEs even warn you about it 03:47 < waxwing> hmm yes. i can't see any negatives to that. 03:59 < waxwing> the code is just wrong, but it flagged up a few other changes i should make (basically around tracking malicious or nonresponding counterparties in Taker). i'll try to code it today then test it, but it'll take a little while. 04:00 < waxwing> i mean wrong in as much as it crashes, as seen, in that scenario (fewer responders than minimum makers; of course, there, it has to abort and/or restart anyway. but still; wrong :) ) 04:12 -!- bsm1175321 [~mcelrath@c-24-61-245-53.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds] 06:42 -!- undeath [~undeath@unaffiliated/undeath] has quit [Quit: WeeChat 2.1] 06:46 -!- d3spwn [53a19dc8@gateway/web/freenode/ip.83.161.157.200] has joined #joinmarket 06:48 < d3spwn> question: what do you guys use for running a maker when logged out? screen, tmux, nohup, something else? 06:53 < grubles> tmux 4 lyfe 07:15 < AgoraRelay> [agora-irc/AlexCato] All of that works... waxwing uses screen, i'm using nohup. Though in my case it 07:15 < AgoraRelay> [agora-irc/AlexCato] it's just out of ignorance, havent looked at the other possible ways yet 09:00 -!- grubles [~grubles@unaffiliated/grubles] has quit [Remote host closed the connection] 09:17 -!- grubles [~grubles@unaffiliated/grubles] has joined #joinmarket 09:22 -!- grubles [~grubles@unaffiliated/grubles] has quit [Client Quit] 09:29 -!- GitHub45 [GitHub45@gateway/service/github.com/x-imwbciyogsbgtnkf] has joined #joinmarket 09:29 < GitHub45> [joinmarket-clientserver] fivepiece opened pull request #170: add the wallets directory to gitignore (master...gitignore_add_wallets) https://git.io/fNWX3 09:29 -!- GitHub45 [GitHub45@gateway/service/github.com/x-imwbciyogsbgtnkf] has left #joinmarket [] 09:55 < arubi> this python-cryptography message is new : https://travis-ci.org/JoinMarket-Org/joinmarket-clientserver/jobs/406362746#L2197-L2198 09:56 < arubi> seems like it's being triggered multiple times during install, not just for coveralls. https://api.travis-ci.org/v3/job/406362746/log.txt , ctrl+f CryptographyDeprecationWarning 09:58 < arubi> only happens in travis trusty build afaict 11:00 -!- d3spwn [53a19dc8@gateway/web/freenode/ip.83.161.157.200] has quit [Quit: Page closed] 11:08 -!- grubles [~grubles@unaffiliated/grubles] has joined #joinmarket 11:54 -!- qubenix [~qubenix@173.199.80.131] has quit [Read error: Connection reset by peer] 11:54 -!- qubenix [~qubenix@217.64.113.184] has joined #joinmarket 13:47 -!- viasil [~viasil@134.19.180.167] has quit [Ping timeout: 260 seconds] 13:50 -!- viasil [~viasil@134.19.180.167] has joined #joinmarket 14:40 -!- rdymac [uid31665@gateway/web/irccloud.com/x-sfobaprhzehbphig] has quit [Quit: Connection closed for inactivity] 14:41 -!- qubenix [~qubenix@217.64.113.184] has quit [Remote host closed the connection] 16:31 < AgoraRelay> [agora-irc/AlexCato] currently working on an issue found in #166, which concerns sweep orders in sendpayment/tumbler. Under very special circumstances, the current default might choose a very expensive offers from a maker, even if this *same* maker has a cheaper offer for the same amount available 16:33 < AgoraRelay> [agora-irc/AlexCato] preconditions for it happening: a) maker has more than 1 offer b) the maker's offers have overlappnig ranges with different fees (e.g. offer1 = 0.001btc to 1btc, offer2 = 0.002 to 1 btc) and c) the taker tries to sweep all his UTXOs from one mixdepth 16:34 < AgoraRelay> [agora-irc/AlexCato] in that special case, orders are not filtered by the taker to distinct makers before choosing, resulting in potentially choosing an expensive one 16:35 < AgoraRelay> [agora-irc/AlexCato] question: would it be acceptable to completely disregard makers which have several offers with overlapping ranges (like... fix your bot, dude)? Because then it's easy to fix. 16:38 < AgoraRelay> [agora-irc/AlexCato] nevermind. Thinking more about it: if we do the "choose randomly under max" approach, takers with more than 1 offer would be unfairly advantaged if we do not reduce it to 1 offer maximum before the choosing algorithm runs 16:38 < AgoraRelay> [agora-irc/AlexCato] there needs to be a filerting to 1 offer per maker before that 17:19 -!- AgoraRelay [~jmrelayfn@p5DE4AF85.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 17:31 -!- AgoraRelay [~jmrelayfn@p5DE4AFE6.dip0.t-ipconnect.de] has joined #joinmarket 22:03 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 264 seconds] 22:11 -!- StopAndDecrypt [~StopAndDe@c-73-215-253-208.hsd1.nj.comcast.net] has joined #joinmarket 22:11 -!- StopAndDecrypt [~StopAndDe@c-73-215-253-208.hsd1.nj.comcast.net] has quit [Changing host] 22:11 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #joinmarket