--- Day changed Mon Oct 08 2018 00:34 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 01:09 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds] 01:10 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket 01:26 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.2] 02:37 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 04:05 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #joinmarket 04:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 06:11 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.2] 06:59 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [] 07:20 -!- d3spwn [~Jimmy@a83-161-157-200.adsl.xs4all.nl] has quit [Quit: Lost terminal] 10:04 < belcher_> finally found the reason my tests failed, after like 5 days lol 10:05 < belcher_> to be fair much of those 5 days were procrastinating or otherwise not working on it.. 10:23 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 11:43 < belcher_> PR #186 is ready for review/merge 11:47 < waxwing> belcher_, thanks :) 11:49 < undeath> waxwing: you are right, #197 needs some further code changes in the wallet. I'll try to look into that soon-ish 11:51 < waxwing> undeath, ok; the test setup needn't in itself be a blocker, i was going to fiddle with it a bit on mainnet/testnet wallets but if you see more changes needed, i'll hold off. cheers. 11:52 < undeath> yes, definitely needs some changes. Some places in the wallet assume that all known utxos are usable. 11:52 < undeath> so get_balance_by_mixdepth for example will return utxos in higher mixdepths than supposed to be used 11:53 < undeath> the two assertion errors you saw during testing should be fixed though 11:55 < undeath> thank you for taking a look! 11:56 < undeath> belcher_: nice, thanks for #186! 12:01 < undeath> waxwing: btw, sorry about your review comments in #183, github didn't show them to me and I can't remember having received an email about them 12:02 < waxwing> oh, i see, fine ... it was trivial anyway. 12:07 < undeath> I answered them after you merged :) 15:11 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.2] 16:25 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #joinmarket 18:08 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds] 18:10 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket