--- Day changed Sat Oct 27 2018
01:40 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket     
05:32 < waxwing> undeath, yeah obv that's one way to fix it, the irritating thing was the absence of a tree. and i didn't want to switch to json because it's not designed to be human editable
05:33 < undeath> yeah, unfortunately python's config parser doesn't support nesting
05:33 < waxwing> right. is there a way to make it look more generic though? so people understand they can use other servers, in principle, if they're set up?
05:34 < undeath> in the documentation piece you mean?
05:34 < undeath> sure
05:35 < undeath> I could add a third server that is something generic
05:35 < waxwing> well 'MESSAGING:Cgan' seems a bit too specific
05:35 < waxwing> hmm yeah that might be a decent way to do it
05:35 < undeath> I'd like to keep the actual cgan/agora entries so people can c&p to their config
05:35 < waxwing> the entries, yeah ofc, was more worried about having it embedded as section names
05:36 < undeath> oh, well, they can be whatever
05:36 < undeath> it's just to make them unique
05:36 < waxwing> having a third, disabled, section, seems like a decent option.
05:36 < waxwing> yes i understand. hardcoding those names anywhere just feels a bit icky
05:36 < undeath> i can change that to server1 and server2
05:37 < undeath> or just add a third with a generic name?
05:37 < waxwing> yes that'd be my preference, it'll just avoid confusion. we have this kind of confusion all the time.
05:37 < waxwing> i mean this is just opinion. i'd say server1, server2, server3 in the section names.
05:37 < waxwing> ofc we should just have nesting, but we don't, so this is fine as a fix imo.
05:38 < waxwing> ofc also a related point is to fix it so that either (a) it succeeds in starting up with only one server or (b) it gives a clear error message after a timeout if one server is not responding.
05:40 < undeath> yeah, that's a whole different issue
05:41 < waxwing> undeath, oh, i see, you didn't actually hardcode the names of the servers in the code. well, that's better. but for optics i'd go with 'server1' 'server2' etc. so people know more clearly that it's swappable.
05:41 < undeath> force-pushed
05:41 < waxwing> thanks
05:45 < waxwing> undeath, btw are you set up to merge things yet?
05:45 < undeath> I should be
05:45 < undeath> my commits are already signed and with ots
05:46 < waxwing> ok and you know about github-merge.py right
05:47 < waxwing> so about #197 it has a merge conflict, i take it that's from my patch-fix of the issue?
05:47 < undeath> you mentioned it, but what does it do that I can't do manually?
05:47 < undeath> yes     
05:47 < undeath> I can rebase #197
05:47 < waxwing> undeath, it signs the merge commit automatically, i'm not sure if there's another way to do that.
05:48 < waxwing> it's also nice from the point of sanity-check/review before merge, but that was the main thing
05:48 < undeath> well, in the case of #201 you/I could simply fast-forward
05:49 < undeath> other than that, merging on the cli would work as well
05:49 < waxwing> right, i see.
05:50 < waxwing> as long as every update is signed, it's fine, so go ahead with 201 if you like
05:50 < undeath> ok     
05:50 < waxwing> also tests travis :)
05:51 < undeath> was just about to say I'll at least wait for travis
05:51 < waxwing> still not really sure what's going on, there, since our last fail was the flake thing, but i def had that flagging, they sent an email yesterday saying it was removed, shrug.
05:51 < undeath> lol, weird
05:52 < undeath> maybe PRs have additional checks because they are not directly linked with the owner's approved account
05:52 < undeath> but then something somehow can re-flag the owners account
05:53 < undeath> but as long as it's working *shrug*
05:54 -!- bsm117532 [~mcelrath@c-24-61-184-150.hsd1.ma.comcast.net] has joined #joinmarket     
06:01 < undeath> ff-merged #201 to master
06:10 < waxwing> looks good, thanks
06:11 < undeath> key imports are nice, don't bash em like that :)
06:12 < waxwing> no, it's really terrible to be using private keys manually in any way.
06:12 < waxwing> i firmly support export, that's a necessity as a disaster recovery feature.
06:14 < undeath> I mean, sure, many things can go wrong. but if you know what you're doing it's not bad.
06:14 < waxwing> although now we use bip49, one could argue that export and exposing privkeys is extremely avoidable, which is nice.
06:15 < waxwing> undeath, well i think that even experts should be avoiding exposing/handling privkeys. it also complicates wallets which are very delicate/dangerous things even without such extras.
06:33 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #joinmarket     
08:08 < waxwing> belcher, finally got around to setting up EPS locally, seems to be working fine afaict. thanks :)
08:10 < belcher_> ty     
08:19 < waxwing> btw i used the new (master branch) way of starting up, it was fine once i saw the PR, only thing is it was kind of non-obvious where and what the actual script to run, was :)
08:56 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 252 seconds]     
08:56 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
09:07 < belcher_> waxwing i imagine you were reading README.md from the github website? since thats kept on the old instructions until theres a release
09:08 < belcher_> README-pip.md says "Run electrum-personal-server -c /path/to/config.cfg to start Electrum Personal Server. The first time..."
09:08 < belcher_> thanks for the feedback
09:10 < belcher_> interestingly the github stats say it only has around 200 unique visitors, but lots of people have mentioned they use it on reddit and IRC, so seems like a high % of people end up getting in touch
09:56 -!- stoner19 [stoner19@gateway/vpn/privateinternetaccess/stoner19] has quit [Remote host closed the connection]     
09:57 -!- stoner19 [stoner19@gateway/vpn/privateinternetaccess/stoner19] has joined #joinmarket     
10:58 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 246 seconds]     
11:04 -!- Cory [~Cory@unaffiliated/cory] has joined #joinmarket     
12:15 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer]     
12:15 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #joinmarket     
13:55 -!- coral623 [~Andru@196.52.93.79] has joined #joinmarket     
14:03 -!- coral623 [~Andru@196.52.93.79] has quit [Quit: Leaving.]     
14:05 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.2]     
14:07 -!- coral623 [~coral623@196.52.93.79] has joined #joinmarket     
15:31 -!- rdymac [uid31665@gateway/web/irccloud.com/x-rfzunxvaozdhtaqe] has quit [Quit: Connection closed for inactivity]     
17:03 -!- coral623 [~coral623@196.52.93.79] has quit [Ping timeout: 272 seconds]     
21:24 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Quit: bye]     
21:24 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket     
22:47 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 252 seconds]     
23:29 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket