--- Day changed Wed Oct 31 2018 02:16 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 246 seconds] 02:24 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #joinmarket 02:25 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 03:32 < Sentineo> waxwing: btw in the topic, bitsquare is Bisq ... just if you care about changing the topic slightly :) 03:50 < undeath> the "latest release" is a bit outdated, too 03:50 < undeath> and maybe even change the github link to joinmarket-clientserver 04:27 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 04:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 04:32 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 04:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 04:46 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 04:46 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 04:48 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 04:48 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 04:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 04:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 04:52 -!- mode/#joinmarket [+o waxwing] by ChanServ 04:53 -!- waxwing changed the topic of #joinmarket to: Welcome to JoinMarket: Increase Fungibility and Subsidise Your Fees | http://github.com/Joinmarket-Org/joinmarket-clientserver | @joinmarket r/joinmarket | Live View: https://joinmarket.me/ob | Latest release 0.3.5 | Also on ssl 6dvj6v5imhny3anf.onion:6697 #joinmarket 04:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 04:53 <@waxwing> belcher, see ^ , feel free to change anything 04:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 04:53 -!- mode/#joinmarket [-o waxwing] by ChanServ 04:55 < undeath> http://github ಠ_ಠ 04:56 -!- mode/#joinmarket [+o waxwing] by ChanServ 04:56 -!- waxwing changed the topic of #joinmarket to: Welcome to JoinMarket: Increase Fungibility and Subsidise Your Fees | https://github.com/Joinmarket-Org/joinmarket-clientserver | @joinmarket r/joinmarket | Live View: https://joinmarket.me/ob | Latest release 0.3.5 | Also on ssl 6dvj6v5imhny3anf.onion:6697 #joinmarket 04:56 -!- mode/#joinmarket [-o waxwing] by ChanServ 04:56 < undeath> :) 04:56 < waxwing> thanks, good eye 04:57 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 04:58 < waxwing> undeath, wait, isn't the relative value a percentage? 04:58 < undeath> it is 04:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 04:58 < waxwing> i'm reading the comment you put in the .cfg; it doesn't specify that 04:59 < undeath> ah yes, that could be improved 05:00 < undeath> I guess most people wouldn't set those anyway without seeing the (much more helpful) guidance from the prompt text 05:02 < waxwing> oh but given there is a perfectly valid alternative interpretation (i.e. 0.01 vs 1%) it's kinda vital to specify. 05:02 < undeath> agree 05:03 < undeath> also in the --help documentation 05:04 < undeath> jm is using 0.01 notation currently, how would that be described best? 05:05 < undeath> even writing "percentage" seems ambiguous 05:05 < waxwing> yeah this is annoying isn't it :) i think (number) % is totally unambiguous, isn't it? 05:05 < waxwing> as for the name of the other, it's ratio or fraction or ... yeah you're right i don't know a simple unambiguous name for that. 05:06 < undeath> ratio sounds good 05:06 < undeath> and it indeed is a ration, not a percentage, sorry for the confusion 05:06 < undeath> *ratio 05:06 < waxwing> technically a ratio should be written X:Y but nobody ever does that. you could call it a 'decimal' but that's stupid. 05:09 < undeath> # Maximum relative coinjoin fee, in fractions relative to the coinjoin value 05:09 < undeath> would that capture the gist? 05:10 < undeath> # Maximum relative coinjoin fee, in fractions of the coinjoin value 05:12 < waxwing> undeath, best to use an example "Maximum relative coinjoin fee (e.g. 0.0001 would be 0.01% of the coinjoin value, so for a coinjoin of 1BTC size the maximum fee *per counterparty* would be 0.0001 btc or 10000 satoshis" 05:12 < undeath> ok 05:12 < waxwing> well imo :) 05:12 < undeath> regarding variables C + Z, that would only be possible to fill in with sendpayment 05:12 < undeath> in tumbler that doesn't make sense at all 05:13 < undeath> N would kind of be ok to fill in 05:13 < waxwing> ah right, see what you mean. 05:13 < waxwing> in that case i think remove 'which is Z satoshis', that's not adding anything 05:14 < undeath> ok 05:14 < undeath> yeah, those variables seemed a bit confusing to me as well, the way they are in there 05:15 < undeath> should N be filled in, and if yes with what number? 05:15 < waxwing> i was just making the mental mistake of thinking only in terms of one coinjoin 05:16 < waxwing> in the absence of that, it's difficult ... wanted to make it concrete but if it's going to apply to a whole set of different coinjoins, then .. not sure actually 05:19 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 05:19 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 05:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 252 seconds] 05:19 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 05:22 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 05:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 05:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 05:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 05:31 < undeath> I'll leave it as an unresolved variable then 05:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 05:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 05:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 05:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 05:38 < waxwing> undeath, yep OK 05:38 < waxwing> and remove the Z right 05:38 < undeath> just pushed an update 05:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 05:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 05:55 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 05:55 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 272 seconds] 05:58 < waxwing> i'll read/test a bit 05:59 < undeath> yesterday I tested the various cli/conf/prompt variants and they all seemed to work, as far as limit selection goes 06:00 -!- lukedashjr is now known as luke-jr 06:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 06:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 06:06 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 06:07 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 06:13 -!- qubenix [~qubenix@gateway/tor-sasl/qubenix] has quit [Ping timeout: 256 seconds] 06:30 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 06:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 06:34 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 06:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 06:52 < waxwing> undeath, getting an exception running tumbler 06:52 < waxwing> hang on will *bin 06:53 < waxwing> https://0bin.net/paste/B9ogINW+bagZsEmE#YHH3mlG5zqcGVY61ppIBqr9JwZsAc+lAC5R43anMD4S 06:55 < waxwing> makes sense 'cos you took maxcjfee out of the options set 06:58 < waxwing> ah i see it's in Taker, we can just port that over, no biggie 07:01 < waxwing> yeah that fixed it, adding a note to PR 07:02 < undeath> oh, wasn't aware taker-utils also was using that parser 07:04 < undeath> jmclient/test/test_schedule.py and scripts/qtsupport.py need a fix, too 07:04 < waxwing> yep 07:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 07:10 < undeath> I think we can just delete it from test_schedule.py 07:10 < undeath> the test seems to work anyway 07:12 < undeath> not sure about qtsupport, I don't see where that option is used 07:13 < waxwing> undeath, ok: re: test schedule 07:13 < waxwing> re: qtsupport, i'd say leave that for now. i'll address it once we have the CLI right. 07:13 < undeath> ok, thanks 07:13 < waxwing> still testing 07:19 < waxwing> heh ... "Success! Using relative fee limit of -20.000000%" 07:19 < waxwing> it's not actually wrong, but still :) 07:19 < waxwing> (in the sense that negative fees are actually allowed here) 07:20 < undeath> yes, I was about to add a check there but then thought to myself "meh, it's actually ok" 07:21 < waxwing> yep, imo better to leave it 07:27 < waxwing> done a couple of tumbler runs and tons of sendpayments, testing (like you mentioned) the various combinations of cli/conf/prompt. i'm happy to merge after the remaining couple of points i commented in the PR are addressed. 07:27 -!- qubenix [~qubenix@66.172.11.228] has joined #joinmarket 07:27 < waxwing> will obv do a few mainnet tests from taker side once it's merged too. 07:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 07:39 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 07:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 245 seconds] 07:40 < undeath> I think the lines in qtsupport can simply be removed as well 07:40 < undeath> it was probably needed for the callback in taker_utils 07:43 -!- lukedashjr is now known as luke-jr 07:45 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3] 09:56 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 10:49 -!- rdymac [uid31665@gateway/web/irccloud.com/x-ogihfwekorsveqjk] has joined #joinmarket 11:10 -!- bitbee [~cryptocat@unaffiliated/cryptocat] has quit [Ping timeout: 252 seconds] 11:12 -!- bitbee [~bitbee@unaffiliated/cryptocat] has joined #joinmarket 12:00 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 13:26 -!- stoner19 [stoner19@gateway/vpn/privateinternetaccess/stoner19] has quit [Remote host closed the connection] 13:27 -!- stoner19 [stoner19@gateway/vpn/privateinternetaccess/stoner19] has joined #joinmarket 15:08 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 246 seconds] 15:13 -!- Pasha [~Cory@unaffiliated/cory] has joined #joinmarket 15:16 -!- Pasha is now known as Cory 15:20 -!- stoner19 [stoner19@gateway/vpn/privateinternetaccess/stoner19] has quit [Quit: Keep on keepin' on...] 15:23 -!- stoner19 [stoner19@gateway/vpn/privateinternetaccess/stoner19] has joined #joinmarket 17:08 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3] 18:32 -!- AgoraRelay [~jmrelayfn@p5DE4AC6E.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds] 18:42 -!- AgoraRelay [~jmrelayfn@p5DE4ADCE.dip0.t-ipconnect.de] has joined #joinmarket 19:06 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 19:07 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 19:11 -!- lukedashjr is now known as luke-jr 21:31 -!- rdymac [uid31665@gateway/web/irccloud.com/x-ogihfwekorsveqjk] has quit [Quit: Connection closed for inactivity] 23:11 -!- belcher [~user@unaffiliated/belcher] has quit [Ping timeout: 252 seconds] 23:25 -!- belcher [~user@unaffiliated/belcher] has joined #joinmarket