--- Day changed Fri Nov 02 2018
01:52 < Sentineo> with the new irc server format, which one is used? First one to be defined, the othersa are fallback?
02:09 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: https://www.Quanto.ga/]     
02:11 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
02:22 < waxwing> Sentineo, no both are used, or rather all that are listed
02:22 < waxwing> it's always been like that since multiple were supported; public messages are passed over all active message channels, and private messages can be passed over any of the set
02:23 < waxwing> the intention is to provide redundancy. there's a bit more to it than that, but you get the idea
02:29 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket     
03:56 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3]     
06:09 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket     
07:49 < Sentineo> ok, I get it now. Whenever tor was conifugred it failed, but after a time. I mean the server being a hidden address, not socks5. I guess it was when a priv message came on that "path" and it errored out.
07:54 < waxwing> yeah you have to use socks5 with an onion address. or did i forget something?
07:57 < Sentineo> waxwing: https://pastebin.com/0yLCuMnG
07:59 < waxwing> yeah that looks right. are you saying it doesn't work?
07:59 < Sentineo> when i leave it uncomented I get an uknown error: https://pastebin.com/7mGDS44B
08:00 < waxwing> can you pastebin the full config sections? all the messaging ones?
08:00 < waxwing> i can test it then
08:00 < Sentineo> sure
08:03 < Sentineo> https://pastebin.com/YsZArEE7 ... left with comments and everything, just in case :) so it is a 1:1 copy. if you uncomment the whole tor part you will get the exact way i had it
08:05 < waxwing> Sentineo, your messaging:server2 is wrong; it has the wrong host
08:05 < waxwing> should be onion
08:05 < waxwing> also has the wrong port, should be 6667
08:06 < waxwing> well actually pretty much everything is wrong :) but .. depends what you want
08:06 < waxwing> do you want two servers both over onion?
08:07 < Sentineo> preferably yes :) 
08:08 < waxwing> ok; so shall i write out a config for that and pastebin it?
08:08 < waxwing> it should be *kinda* clear from the base/default config, but there's soem details you can get wrong i guess
08:11 < waxwing> https://pastebin.com/CuLxHTQs
08:12 < Sentineo> ah no need, so I can grap the example, right? I just looked at the example and tried to alter the existing config :) 
08:12 < waxwing> yeah it just requires paying attention to the delta really, anyway i've done it now ^
08:12 < Sentineo> ah cool, thanks
08:13 < Sentineo> is there any penalty for using tor, like higher delay? Benefits seem to be obvious :) 
08:13 < undeath> I thought pyup was useful but it turns out their bot is too stupid to parse setup.py files :(
08:14 < undeath> tor has some latency and occasional connection aborts
08:14 < undeath> but all in all your ability to make cjs will not be impacted
08:15 < waxwing> what's pyup?
08:15 < undeath> it's a service that notifies you of dependency updates
08:15 < waxwing> yeah i have seen basically no issues with tor connection re: latency (at least, i think). perhaps disconnect cycling is a bit more common.
08:15 < waxwing> ah, k, interesting.
08:15 < undeath> but all it detects is the requirements-dev.txt
08:16 < undeath> I even explicitly added the setup.py files to the config file and they are still ignored
08:16 < waxwing> actually maybe the HS irc servers have *better* uptime, now i think of it.
08:16 < waxwing> undeath, merge 166? i should be able to start building the release then. but only after some minimal mainnet testing.
08:16 < Sentineo> how do you handle the restarts? is there a nice way to restart the script when it disconnects?
08:16 < undeath> yeah, 166 should be good to merge
08:17 < waxwing> the documentation of all the changes in this release is going to be ridiculous. i'll probably have to 'precis' heavily.
08:17 < undeath> it reconnects automactially
08:17 < undeath> what version number will the new version have? I thought 0.4.0 might be appropriate
08:18 < undeath> because there are "breaking changes"
08:18 < waxwing> yes i'd already decided that, too :)
08:18 -!- GitHub176 [GitHub176@gateway/service/github.com/x-modzmzluxmomzksz] has joined #joinmarket     
08:18 < GitHub176> [joinmarket-clientserver] AdamISZ pushed 2 new commits to master: https://git.io/fxpfb
08:18 < GitHub176> joinmarket-clientserver/master a2c74ee undeath: add random-under-max order chooser
08:18 < GitHub176> joinmarket-clientserver/master 2d434ee AdamISZ: Merge #166: add random-under-max order chooser...
08:18 -!- GitHub176 [GitHub176@gateway/service/github.com/x-modzmzluxmomzksz] has left #joinmarket []     
08:18 -!- GitHub44 [GitHub44@gateway/service/github.com/x-pafazipolqefltjz] has joined #joinmarket     
08:18 < GitHub44> [joinmarket-clientserver] AdamISZ closed pull request #166: add random-under-max order chooser (master...rand-under-max-order-choose) https://git.io/fNsCn
08:18 -!- GitHub44 [GitHub44@gateway/service/github.com/x-pafazipolqefltjz] has left #joinmarket []     
08:19 < Sentineo> btw is there a good way of verifying the commits, like bitcoin-core's verify-commits script for jmcs?
08:19 < waxwing> that reminds me, i need to sign undeath's gpg key (and make a new one for mine which is expiring)
08:19 < waxwing> i guess a starting point though undeath : you can add your key to the pubkeys/ directory
08:20 < undeath> Sentineo: that's a built-in git command
08:21 < waxwing> git log --show-signature is the only one i know or use, in terms of verifying .. it seems to hook in somehow and verify whether the signature is from a trusted source.
08:21 < undeath> git verify-tag v0.3.5
08:21 < waxwing> ah right, cool
08:21 < undeath> or git verify-commit HEAD
08:22 < waxwing> i'm putting 174 off, in case it wasn't obvious. after more testing (and please others, do test the current master, from taker side if you can!), will make release without any further changes.
08:22 < undeath> ok     
08:23 < waxwing> undeath, apart from adding instructions to release notes; do you think any other documentation may be in order for the changes? i know we already have some for the wallet changes.
08:23 < undeath> yeah, sure, we're not even sure if #174 should be merged at all
08:23 < waxwing> that'd be the exception to this being a freeze as of now (doc)
08:23 < undeath> wallet upgrade + irc config update
08:24 < undeath> anything else should not be needed
08:24 < waxwing> yes. there are three changes the user notices i guess: wallet upgrade, irc/messaging config change and max cj fee settings.
08:25 < undeath> oh, right, the max_cj_fee settings
08:25 < waxwing> the second needn't really bother them; they can ignore it safely.
08:25 < waxwing> yeah.
08:26 < undeath> btw, how about bumping the twisted version?
08:26 < undeath> we're still on some 16.x while the most recent one is 18.x
08:27 -!- GitHub188 [GitHub188@gateway/service/github.com/x-sjflxumnxtbjnwgj] has joined #joinmarket     
08:27 < GitHub188> [joinmarket-clientserver] AdamISZ closed pull request #174: Switch default merge_algorithm in joinmarket.cfg to 'greedy' (master...switch_mergealgo_default) https://git.io/fNlEk
08:27 -!- GitHub188 [GitHub188@gateway/service/github.com/x-sjflxumnxtbjnwgj] has left #joinmarket []     
08:27 < undeath> i've been running the test suite and my makers with the latest twisted version without problems
08:29 < waxwing> undeath, yeah me too. i'll do some taker-side testing though, that's important for the latest change with fees.
08:29 < waxwing> undeath, re: twisted, at one point there was actually a problem (i believe i was trying 17 and having a failure that i *think* was ssl related, it was like 2 years ago though)
08:29 < undeath> i know, #24
08:30 < waxwing> but a bit later someone (probably you) said there was no problem with latest. and that's the last time i even thought about it :)
08:31 < waxwing> so yeah bump it if you like, thanks for working on the versioning
08:31 < Sentineo> is there a way to test it in regtest, I am thinking of showing it on workshop with other stuff I have prepared for regtest - e.g. forks, etc. Bisq can be nicely shown on regtest, would be nice if jmcs could be as well.
08:31 < undeath> it's a bit of a mess to keep things updated but pinned without a bot or similar :/
08:32 < undeath> jm works fine on regtest
08:32 < undeath> the whole test suite on travis is run on regtest
08:33 < waxwing> Sentineo, here's what i do: use the regtest config in test/regtest_joinmarket.cfg
08:33 < waxwing> clean out the .bitcoin/regtest directory
08:34 < waxwing> then run this: py.test --btcconf=/path/to/bitcoin.conf --btcroot=/path/to/bin/ --btcpwd=123456abcdef --nirc=2 test/ygrunner.py -s
08:34 < waxwing> with bitcoin.conf having the user and password for the rpc in it, doesn't need anything else
08:34 < Sentineo> so how does the actual maker/taker communication happen in this case?
08:34 < waxwing> at that point it'll run two local irc servers and start three yg bots runnign, and provide you a seed to use to start a tamer bot
08:34 < waxwing> taker
08:35 < undeath> maker/taker always communicate through irc
08:35 < waxwing> but i'm expanding here on what's in docs/TESTING.md
08:35 < undeath> for demo/testing purposes you can use miniircd
08:35 < waxwing> that tells you the basic setup, including miniircd (don't worry it's no trouble)
08:36 < Sentineo> ok great
08:36 < waxwing> i'm just expanding to tell you how you can actually run sendpayment and tumbler on regtest from a "standing start" with maker bots ready to talk to you
08:36 < Sentineo> kind of the whole point is showing it to the users, the underlying stuff, so they do not treat it as magic. 
08:36 < waxwing> the most useful thing about it is that i can run a full tumbler in like a few minutes, although it takes a bit of fiddling to get the tumbler options right, ymmv
08:36 < waxwing> yeah well i mean you can open the miniircd servers in your irc client
08:37 < waxwing> i often do that, especially if i need to debug something
08:37 < waxwing> miniircd is a bit weird though (ultra basic/stripped down)
08:37 < undeath> bump twisted for release or pr?
08:37 < waxwing> i'd rather do whatever's most conservative, so i guess pr?
08:38 < undeath> ok     
08:38 < waxwing> there's always a huge amount to do, but we have to stop from time to time and actually release :)
08:38 < undeath> aboslutely :)
08:38 < Sentineo> there is not blockchain consistency check,right? Cause I have an altered regtest, with 10s blocks, and mining it with a miner, so peaople have a feeling of a real blockchain. Just want to make sure jmcs does not consensus check of its own :) 
08:38 < waxwing> no there's no check
08:39 < undeath> it just asks bitcoind if everything is alright
08:39 < waxwing> nothing in joinmarket, it's just running bitcoind and rpc-ing to it
08:39 < Sentineo> ok cool
08:40 < Sentineo> making a note for my future self, as this is going to happen realistically in a few weeks or months :) 
08:40 < Sentineo> but when people see the "playground' they get super excited, so I really want to show jm, too
08:41 < undeath> should belcher's pubkey be added as well?
08:47 -!- GitHub195 [GitHub195@gateway/service/github.com/x-bpyclvnarzranvxy] has joined #joinmarket     
08:47 < GitHub195> [joinmarket-clientserver] undeath opened pull request #206: bump twisted version to latest (master...bump-twisted) https://git.io/fxpku
08:47 -!- GitHub195 [GitHub195@gateway/service/github.com/x-bpyclvnarzranvxy] has left #joinmarket []     
08:48 < Sentineo> btw waxwing wondering if the "insight" you shared about coinjoins a few days ago has to do anything with the mempool being a bit flooded now :) 
09:11 < undeath> waxwing: have you tried reproducing #195?
09:15 < undeath> at least master seems to work for me
09:22 < waxwing> i have experienced the failure to build libsodium in the past, and having it fixed with --no-gpg-validation. however the last time i installed from scratch i *think* it worked first time. 18.04 ubuntu. may have been ~ 4 weeks ago. not 100% sure.
09:22 < undeath> ok, then it was probably some temporary network problem the user was experiencing
09:23 < waxwing> yes unfortunately that seems to happen.
09:24 < undeath> ideally the install script were only installing libsodium from source if it's not available in the system's repositories, checking that for all the linux distributions out there is not feasible
10:18 < Sentineo> the really creepy stuff is that the signing keys for repos are 6 years old for ubuntu or debian :)
10:19 < Sentineo> at lesat that was the claim of a talk, did not bother looking at it though
10:25 -!- dx25 [~dx25@67-3-130-246.omah.qwest.net] has quit [Ping timeout: 245 seconds]     
11:10 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket     
11:15 -!- davex__ [~dx25@ip-174-154-25-165.kscymo.spcsdns.net] has joined #joinmarket     
11:34 -!- davex__ [~dx25@ip-174-154-25-165.kscymo.spcsdns.net] has quit [Ping timeout: 240 seconds]     
11:40 -!- davex__ [~dx25@ip-174-154-25-165.kscymo.spcsdns.net] has joined #joinmarket     
12:00 -!- davex__ [~dx25@ip-174-154-25-165.kscymo.spcsdns.net] has quit [Ping timeout: 240 seconds]     
12:00 -!- davex__ [~dx25@ip-174-154-25-165.kscymo.spcsdns.net] has joined #joinmarket     
12:08 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3]     
12:26 -!- dx25_ [~dx25@ip-174-154-25-165.kscymo.spcsdns.net] has joined #joinmarket     
12:27 -!- davex__ [~dx25@ip-174-154-25-165.kscymo.spcsdns.net] has quit [Ping timeout: 240 seconds]     
12:49 -!- dx25_ [~dx25@ip-174-154-25-165.kscymo.spcsdns.net] has quit [Ping timeout: 240 seconds]     
12:55 -!- davex__ [~dx25@ip-107-34-136-12.kscymo.spcsdns.net] has joined #joinmarket     
13:02 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket     
13:03 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 244 seconds]     
13:06 -!- lukedashjr is now known as luke-jr     
14:03 -!- davex__ [~dx25@ip-107-34-136-12.kscymo.spcsdns.net] has quit [Ping timeout: 252 seconds]     
14:03 -!- stoner19 [stoner19@gateway/vpn/privateinternetaccess/stoner19] has quit [Excess Flood]     
14:10 -!- davex__ [~dx25@ip-174-154-2-173.kscymo.spcsdns.net] has joined #joinmarket     
15:10 -!- bsm117532 [~mcelrath@c-24-61-184-150.hsd1.ma.comcast.net] has joined #joinmarket     
15:53 -!- davex__ [~dx25@ip-174-154-2-173.kscymo.spcsdns.net] has quit [Ping timeout: 268 seconds]     
16:06 -!- bsm117532 [~mcelrath@c-24-61-184-150.hsd1.ma.comcast.net] has quit [Remote host closed the connection]     
16:08 -!- bsm117532 [~mcelrath@c-24-61-184-150.hsd1.ma.comcast.net] has joined #joinmarket     
16:45 -!- davex__ [~dx25@ip-174-154-218-231.kscymo.spcsdns.net] has joined #joinmarket     
16:58 -!- bsm117532 [~mcelrath@c-24-61-184-150.hsd1.ma.comcast.net] has quit [Ping timeout: 244 seconds]     
17:26 -!- davex__ [~dx25@ip-174-154-218-231.kscymo.spcsdns.net] has quit [Remote host closed the connection]     
18:30 -!- AgoraRelay [~jmrelayfn@p5DE4AC37.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]     
18:46 -!- AgoraRelay [~jmrelayfn@p54866A4B.dip0.t-ipconnect.de] has joined #joinmarket     
20:16 -!- stoner19 [stoner19@gateway/vpn/privateinternetaccess/stoner19] has joined #joinmarket     
22:30 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
22:31 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket