--- Day changed Sun Nov 11 2018
02:05 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket     
03:51 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3]     
05:27 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket     
05:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 264 seconds]     
05:31 -!- lukedashjr is now known as luke-jr     
05:44 < waxwing> just in case there's anyone here who has a thought, this issue has me totally stumped: https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/210
06:21 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket     
06:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds]     
06:26 -!- lukedashjr is now known as luke-jr     
06:31 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket     
06:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 246 seconds]     
06:35 -!- lukedashjr is now known as luke-jr     
07:43 -!- Giszmo [~leo@190.162.241.129] has joined #joinmarket     
07:59 < qubenix> waxwing: https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/210#issuecomment-437681969
07:59 < waxwing> Doh!
08:00 < waxwing> I had that thought in the back of my mind but dismissed it as too bizarre of an outcome :)
08:00 < qubenix> me too, but process of elimination brought me back to it in the end.
08:00 < waxwing> probably because when reviewing that PR I *thought* I saw that it allowed any name. obv some bug. thanks qubenix !
08:07 < waxwing> huh, quite mysterious at first site. it really looked like the code was very specifically designed to allow anything after 'MESSAGING:' , see https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/201/files#diff-4f3c2beacd536175f30616463ddaeb33R259
08:08 < waxwing> sight even
08:17 < qubenix> i dont know python well enough to help with the code, but in my tests nothing worked besides server{1,2}.
08:19 < waxwing> qubenix, thanks. i'll just have to figure it out w/ test, shouldn't take long. it's weird but it's also a very small kind of bug. irritating for users though, shame.
08:51 < waxwing> qubenix, it was as you'd expect, rather dumb :) https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/210#issuecomment-437685661
09:04 < qubenix> lol     
09:12 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket     
09:42 < waxwing> undeath, oh, you're here now. we can continue here if needed :)
09:42 < undeath> waxwing: how is it counter-intuitive that jm uses whatever servers are specified in the config are used?
09:43 < waxwing> that's not what's counterintuitive; what's counterintuitive is that it *also* uses the ones in the default config, which the user thought they deleted.
09:43 < undeath> maybe I'm missing something but to me this just seems what would be expected
09:43 < undeath> err, how so?
09:44 < undeath> does it merge the default config and the actual config?
09:44 < waxwing> because the way that config load works is: (a) load default (b) load from joinmarket.cfg and apply it as a delta
09:44 < waxwing> yes.
09:44 < undeath> oh     
09:44 < undeath> I didn't know about that
09:44 < waxwing> told you it was counterintuitive :)
09:44 < undeath> yes, that seems like a weird idea actually
09:44 < waxwing> well it's not really; it means that default values get loaded if you don't bother to add them, which is quite useful.
09:45 < undeath> so that nothing breaks if they upgrade and a config change would be needed?
09:46 < waxwing> i can't remember the specific thing that motivated it, but there's probably a class of cases where that's useful; of course, you don't have to do it for *all* config variables, some can be left out of the default.
09:47 < undeath> so we could simply kick out all MESSAGING sections from the default config after it has been loaded?
09:47 < qubenix> so does that mean that my bot is connecting using the default settings and my settings, connecting to the clearnet and hidden service?
09:47 < undeath> unless you use :server1 and :server2, apparently yes
09:48 < qubenix> but server{1,2} will overwrite?
09:48 < waxwing> yes that's right
09:48 < waxwing> hence 'just use server1 and server2 for now'
09:48 < waxwing> this was just a workaround for the fact that the config package we use doesn't allow nesting
09:49 < waxwing> so we can't do [section: servers] (subsection: serverA, subsection: serverB)
09:50 < waxwing> undeath, tbh i think i'd rather just stick with 'serverN' being hardcoded .. that is to say, required (not really code)
09:50 < waxwing> although prob there's a cleverer way
09:50 < undeath> I'd prefer to simply kick out the default values for irc altogether
09:51 < waxwing> oh but ... then we always get server2 even if you remove it .. nope, that's no good
09:51 < undeath> yeah
09:51 < waxwing> yes remove it from default
09:51 < waxwing> and leave it commented in default?
09:51 < waxwing> otherwise they'd have to go look up the values
09:51 < undeath> I'd simply have the code kick it out before merging the configs
09:52 < waxwing> oh i see. yes that does actually work, doesn't it.
09:52 < undeath> I'd hope so :)
09:54 < qubenix> this is what my connection looks like, to me seems like clearnet: http://termbin.com/38el
09:55 < waxwing> no the fact that it says agora.anarplex.net doesn't mean clearnet
09:55 < waxwing> if your config is for tor it'll be HS
09:56 < qubenix> but for cgan should be cgan.onion.garlic
09:57 < qubenix> it sporadically switches when i reconnect
09:57 < qubenix> seems like a race condition
09:58 < qubenix> might be their load balancing i guess??
09:58 < undeath> well, netstat is probably more reliable
10:05 -!- GitHub159 [GitHub159@gateway/service/github.com/x-rbemdwrawmvbphee] has joined #joinmarket     
10:05 < GitHub159> [joinmarket-clientserver] undeath opened pull request #212: fix loading of irc configuration (master...fix-irc-config) https://git.io/fpqeu
10:05 -!- GitHub159 [GitHub159@gateway/service/github.com/x-rbemdwrawmvbphee] has left #joinmarket []     
10:05 < waxwing> qubenix, unless you did the thing described in that issue (changed the config section name), then, you will actually get additional servers which will be clearnet, although you'll then also get 'nick in use'
10:06 < waxwing> re: cgan.onion.garlic, yes. you sure your config is right?
10:10 < qubenix> positive, i found cgan.onion.garlic earlier in the logs and irc.antirep.ninja. so it must be load balancing on their end.
10:16 < qubenix> joinmarketd doesn't use the config, right? doesn't it get fed the config settings by the other tools?
10:26 < waxwing> qubenix, correct
10:26 < waxwing> the config is passed in setup from 'client' to 'server'
10:39 < waxwing> undeath, gonna set up to test this right now, but: if you delete them at that point, does a default joinmarket.cfg file that's created from fresh still have them?
10:41 < undeath> yes     
10:41 < undeath> it just writes the string saved in the variable defaultconfig
10:41 < undeath> we only alter the parsed instance of the config
10:49 < waxwing> hmm, loading without a config file in regtest, getting: Exception: Config file does not contain the required section: MESSAGING
10:49 < undeath> oh, entirely without config
10:49 < undeath> that's even possible?
10:50 < waxwing> yes that's actually the idea :)
10:50 < waxwing> this error does make sense, it's just very obscure
10:50 < waxwing> we've always advised people to run wallet-tool and get the blockchain error, and then edit the config before running again
10:50 < waxwing> here it gets that error, i think, because it defaults to old-style messaging section, and then doesn't find it, and so that error pops up first
10:52 < undeath> what solution would you propose then?
10:53 < waxwing> undeath, heh, well when you hack around a hack of a hack, i'm not really sure where i am any more :)
10:53 < qubenix> maybe default config should be in the repo
10:53 < waxwing> iirc bitcoin also used to work like this, but for different reasons, to do with credentials.
10:53 < waxwing> run, error, edit config, run
10:53 < undeath> yes, I always found it confusing that the default config is a string variable inside a python file
10:54 < waxwing> i'm honestly not sure what the thinking was. it was maybe adlai or ghtdak or someone, can't remember. maybe someone else has a thought about it?
10:54 < waxwing> belcher_, ?
10:54 < qubenix> could be added to install/setup
10:55 < waxwing> yes it could just be a file in the repo tho' as undeath says. right now, i can't see a good reason why not.
10:55 < waxwing> i mean, not the hugest of big deals tho'.
10:55 < undeath> yeah, and only remotely relevant for our actual problem at hand
10:59 < waxwing> i think perhaps we leave it like this.
10:59 < waxwing> the question is, does this need a new release. i tend to think it does.
10:59 < undeath> maybe jm should just quit if it had to create a new config file?
10:59 < undeath> yes, it can lead to unintended ip leaks
10:59 < waxwing> exactly
11:00 < waxwing> yeah there are other very bad annoyances, but they're only annoyances; that's the biggest one, the privacy leak potential
11:01 < waxwing> undeath, re: quit, well it quits anyway, with a strange error. the thing is, it already behaved like that; it was just a different strange error.
11:01 < undeath>         print("Created a new `joinmarket.cfg`. Please review and adpot the "
11:01 < undeath>               "settings and restart joinmarket.")
11:01 < undeath>         exit(1)
11:01 < undeath> i'd add that
11:02 < undeath> without typo obv
11:02 < waxwing> right we just need to line to check if joinmarket.cfg exists. yeah you're right, that's simple enough that it should be fine.
11:02 < waxwing> oh we have it, if len(loadedFiles) etc
11:03 < waxwing> oh yeah that's dead simple. add it there. not sure why we didn't already do that.
11:03 < undeath> pused
11:03 < undeath> pushed
11:04 < waxwing> k i'll just quickly test the behaviour on my mainnet setup (incl. without config)
11:08 < undeath> I'd love to also add a fix for the problem with the install.sh some people experience but I'm not yet sure why it even happens
11:11 < undeath> although I don't understand why install.sh does things the way it does things, especially regarding gpg
11:13 < waxwing> undeath, right, good point. i think on balance we have to release this now and address that as it gets fixed.
11:13 < waxwing> checked with tests, it seems all correct to me.
11:13 < undeath> yes     
11:13 < undeath> nice
11:15 < waxwing> going to leave the IRC config doc wording as is, as it's now correct as 'servername' (i.e. whatever you like). i checked the function.
11:15 < qubenix> undeath: it has to be the html stuff above and below the gpg data. should be resolved by just using --recv-key instead of curl.
11:15 < undeath> that's exactly my thought, regarding recv-key
11:15 < undeath> although I'm not sure about the html stuff
11:16 < undeath> because that does not seem to be a problem for gpg
11:16 -!- GitHub30 [GitHub30@gateway/service/github.com/x-qlkxmukpkhspxima] has joined #joinmarket     
11:16 < GitHub30> [joinmarket-clientserver] AdamISZ pushed 3 new commits to master: https://git.io/fpqUY
11:16 < GitHub30> joinmarket-clientserver/master 426cb87 undeath: fix loading of irc configuration
11:16 < GitHub30> joinmarket-clientserver/master 0d7a91f undeath: quit after creating a new config file
11:16 < GitHub30> joinmarket-clientserver/master 833cdff AdamISZ: Merge #212: fix loading of irc configuration...
11:16 -!- GitHub30 [GitHub30@gateway/service/github.com/x-qlkxmukpkhspxima] has left #joinmarket []     
11:16 -!- GitHub63 [GitHub63@gateway/service/github.com/x-yflflknenzludnxt] has joined #joinmarket     
11:16 < GitHub63> [joinmarket-clientserver] AdamISZ closed pull request #212: fix loading of irc configuration (master...fix-irc-config) https://git.io/fpqeu
11:16 -!- GitHub63 [GitHub63@gateway/service/github.com/x-yflflknenzludnxt] has left #joinmarket []     
11:18 < qubenix> yeah my gpg (v2.1.18) takes it, maybe a version thing.
11:19 < undeath> well, I tried it on debian oldstable and it still worked :D
11:19 < undeath> if that's not old enough I don't know what
11:19 < qubenix> really need a trace from that guy and cat of the gpg files
11:19 < undeath> the person on reddit seems to use ubuntu bionic or even cosmic
11:20 < undeath> so they should have an even newer version
11:22 < qubenix> their second comment seems like the sig file was off
11:24 < qubenix> after they answer your latest questions (if no solution), should have them list-packets on the sig
11:31 < undeath> good point, thanks
11:45 -!- GitHub139 [GitHub139@gateway/service/github.com/x-ckgtwxuwbqlebfvk] has joined #joinmarket     
11:45 < GitHub139> [joinmarket-clientserver] AdamISZ pushed 1 new commit to master: https://git.io/fpqUj
11:45 < GitHub139> joinmarket-clientserver/master 3a37ce5 AdamISZ: release notes for 0.4.1
11:45 -!- GitHub139 [GitHub139@gateway/service/github.com/x-ckgtwxuwbqlebfvk] has left #joinmarket []     
11:46 < waxwing> undeath, cast your eyes over that if you have a chance, cheers
11:47 < waxwing> oh duh i forgot the commit reference. i'll add that
11:47 < waxwing> but still read it, i won't change the text
11:51 < waxwing> actually i should edit that bold text to mention that it was actually fixed, heh
11:57 -!- GitHub26 [GitHub26@gateway/service/github.com/x-rezcorbxusrpwsil] has joined #joinmarket     
11:57 < GitHub26> [joinmarket-clientserver] AdamISZ force-pushed master from 3a37ce5 to 382ba1e: https://git.io/v5bgz
11:57 < GitHub26> joinmarket-clientserver/master 382ba1e AdamISZ: release notes for 0.4.1
11:57 -!- GitHub26 [GitHub26@gateway/service/github.com/x-rezcorbxusrpwsil] has left #joinmarket []     
12:03 < undeath> waxwing: lgtm
12:05 < waxwing> thx     
12:10 < waxwing> ok published. i will post on mastodon and reddit. anyone else wants to post other places ( belcher_ ) pls do
13:36 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3]     
13:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 244 seconds]     
15:39 < technonerd> i am running into bug #195
15:39 < technonerd> libsodium_signer_key is just a 503 page
15:48 < technonerd> prob helps when pgp.mit.edu works and isnt down
17:22 -!- AgoraRelay [~jmrelayfn@p54866146.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]     
17:36 -!- AgoraRelay [~jmrelayfn@p5DE4AB46.dip0.t-ipconnect.de] has joined #joinmarket     
18:17 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket     
19:53 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 244 seconds]     
20:29 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #joinmarket     
20:34 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 244 seconds]     
20:39 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Remote host closed the connection]     
20:58 -!- Giszmo [~leo@190.162.241.129] has quit [Ping timeout: 246 seconds]     
21:24 -!- Giszmo [~leo@ip-213-236-219-201.nextelmovil.cl] has joined #joinmarket     
21:29 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #joinmarket     
21:49 -!- Giszmo [~leo@ip-213-236-219-201.nextelmovil.cl] has quit [Ping timeout: 240 seconds]     
22:08 -!- Giszmo [~leo@190.162.241.129] has joined #joinmarket