--- Day changed Sat Nov 24 2018 02:49 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 04:46 -!- belcher_ [~user@unaffiliated/belcher] has quit [Ping timeout: 268 seconds] 04:47 -!- belcher_ [~user@unaffiliated/belcher] has joined #joinmarket 04:48 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds] 06:03 < waxwing> well, it's passing jmbitcoin/test now so that's a start :) 06:53 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket 07:29 -!- GitHub181 [GitHub181@gateway/service/github.com/x-qoxidbgnhenrzwie] has joined #joinmarket 07:29 < GitHub181> [joinmarket-clientserver] AdamISZ pushed 2 new commits to master: https://git.io/fp02P 07:29 < GitHub181> joinmarket-clientserver/master 647335e undeath: add undeath's pgp key 07:29 < GitHub181> joinmarket-clientserver/master 7b201b6 AdamISZ: Merge #230: add undeath's pgp key... 07:29 -!- GitHub181 [GitHub181@gateway/service/github.com/x-qoxidbgnhenrzwie] has left #joinmarket [] 07:29 -!- GitHub137 [GitHub137@gateway/service/github.com/x-dvyaqsxohjsinohb] has joined #joinmarket 07:29 < GitHub137> [joinmarket-clientserver] AdamISZ closed pull request #230: add undeath's pgp key (master...gpg-key) https://git.io/fp0OQ 07:29 -!- GitHub137 [GitHub137@gateway/service/github.com/x-dvyaqsxohjsinohb] has left #joinmarket [] 07:34 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket 07:47 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 07:49 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3] 07:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 245 seconds] 07:51 -!- lukedashjr is now known as luke-jr 08:18 < waxwing> Lightsword, so re this: https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/229/files#diff-14344ea98bee8b31eb425ab3ecdccc1aR55 08:19 < waxwing> is there a scenario where the magicbyte is more than one byte? i guess there must be otherwise you wouldn't write it like that :) 08:22 < waxwing> basically, you're saying it's allowed to have more than one version / magic byte 08:26 < waxwing> it's weird though, because if I read it correctly, you would only allow such a > 256 version value if it was passed as an integer in the function call; if it was passed as bytes, only the first byte is read in the struct.unpack call on line 52. 08:29 < waxwing> lol we might have to give petertodd a credit if we copy over his typos :) https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/229/files#diff-14344ea98bee8b31eb425ab3ecdccc1aR119 08:29 < waxwing> and nobody wants that 08:44 -!- rdymac [uid31665@gateway/web/irccloud.com/x-skqpegrbhmbvrwsu] has joined #joinmarket 12:24 < waxwing> Was there any discussion about this one? https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/229/files#diff-14344ea98bee8b31eb425ab3ecdccc1aR203 12:25 < waxwing> i get that if the argument 'string' is in binary it'll usually be type 'bytes' so that's fine, but having it interpret as hex otherwise might conceivably create an issue. 12:25 < waxwing> atm i'm seeing it used in podle, where the inputs should be binary and are probably bytes in the new version, but anyway, atm just an observation, still going through it. 12:26 < Lightsword> waxwing, I usually use struct.unpack since it enforces a size limit 12:27 < waxwing> Lightsword, is that in relation to my first comment above? but, i'm asking .. well, see the next three lines. 12:27 < waxwing> previously the magic/version byte was assumed to be 1 byte. 12:29 < Lightsword> well I assume the behavior in that base58 decoder function is correct since it’s pretty much a direct copy 12:30 < waxwing> ok. not seeing any probs with it right now. just wondering. 13:57 < raedah> has there been any work done in relation to diffie hellman group keys ala dining cryptographers problem for not disclosing the owner of the output address? 13:59 < waxwing> raedah, i think coinshuffle++ fits the bill, maybe? i can't remember if it's a dc-net exactly, but it's a flavour of that to achieve the goal 14:00 < waxwing> iirc coinshuffle++ was quite different from coinshuffle in that regard 14:06 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 14:08 < raedah> doesnt seem so needed with joinmarkets model because a participant is being randomly selected to construct the transaction which keeps the information decentralized. coinshuffle++ is more so where there is a central server capturing the info transaction info and able to connect the inputs to the outputs. 14:32 < Lightsword> undeath, that bad byte order issue, how would I fix that? 14:34 < undeath> I guess like it was done previously, reversing the bytes obj using [::-1] 14:45 < waxwing> raedah, yes it's not as needed here, but it would be possible to do it, i guess 15:09 < Lightsword> ok, I’m down to a single test failure, https://0bin.net/paste/NJBIUM8IQoxC7vu6#iOVeIM9g1UgtCnFDOQBMQBFlkgoahuO2IISGmrYiqdv any idea what’s going on here? 15:11 < undeath> I guess it triggers some corner case in the deserializer that is handled incorrectly, but I haven't looked too close at it 15:47 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3] 16:00 < waxwing> heh, that's the only error i got around to even seeing before you fixed all the other ones :) 16:00 < waxwing> i'll take a look tomorrow but i'll probably be too late :) 16:35 < Lightsword> waxwing, I see "#TODO this will probably crap out on null for segwit" 16:35 < Lightsword> what should happen if it sees a null exactly? 17:08 -!- AgoraRelay [~jmrelayfn@p548667C2.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds] 17:19 -!- AgoraRelay [~jmrelayfn@p54866A35.dip0.t-ipconnect.de] has joined #joinmarket 18:10 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 18:10 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #joinmarket 19:28 < Lightsword> think I finally got tests passing