--- Day changed Mon Nov 26 2018
01:18 -!- takinbo_ [sid19838@gateway/web/irccloud.com/x-vyuvelisdlbcrdve] has joined #joinmarket     
01:25 -!- Netsplit *.net <-> *.split quits: takinbo
01:25 -!- takinbo_ is now known as takinbo     
01:43 -!- beIcher [~user@unaffiliated/belcher] has joined #joinmarket     
01:46 -!- belcher_ [~user@unaffiliated/belcher] has quit [Ping timeout: 250 seconds]     
01:57 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket     
03:41 -!- beIcher [~user@unaffiliated/belcher] has quit [Ping timeout: 250 seconds]     
03:43 -!- beIcher [~user@unaffiliated/belcher] has joined #joinmarket     
05:04 < waxwing> undeath, so at this point i'm happy to merge both 235 and 237 (see comments), can i get a sanity check from you on 235 first.
05:50 < undeath> waxwing: #235 looks good
05:52 < waxwing> undeath, utACK is OK :)
05:59 -!- GitHub64 [GitHub64@gateway/service/github.com/x-udrxilzfpvwhymhg] has joined #joinmarket     
05:59 < GitHub64> [joinmarket-clientserver] AdamISZ closed pull request #235: Validate maker destination addresses (master...validate-maker-address) https://git.io/fpEsr
05:59 -!- GitHub64 [GitHub64@gateway/service/github.com/x-udrxilzfpvwhymhg] has left #joinmarket []     
05:59 -!- GitHub77 [GitHub77@gateway/service/github.com/x-qkfluoskhtuctjtp] has joined #joinmarket     
05:59 < GitHub77> [joinmarket-clientserver] AdamISZ pushed 1 new commit to master: https://git.io/fpuJV
05:59 < GitHub77> joinmarket-clientserver/master c43d1f1 AdamISZ: Merge #235: Validate maker destination addresses...
05:59 -!- GitHub77 [GitHub77@gateway/service/github.com/x-qkfluoskhtuctjtp] has left #joinmarket []     
05:59 -!- GitHub173 [GitHub173@gateway/service/github.com/x-vfgckwefftvaatdw] has joined #joinmarket     
05:59 < GitHub173> [joinmarket-clientserver] AdamISZ closed pull request #237: fix possible crash on tx with odd scripts (master...fix-odd-script-crash) https://git.io/fpEBs
05:59 -!- GitHub173 [GitHub173@gateway/service/github.com/x-vfgckwefftvaatdw] has left #joinmarket []     
05:59 -!- GitHub195 [GitHub195@gateway/service/github.com/x-dgwnfcukvqlylowy] has joined #joinmarket     
05:59 < GitHub195> [joinmarket-clientserver] AdamISZ pushed 2 new commits to master: https://git.io/fpuJw
05:59 < GitHub195> joinmarket-clientserver/master 979480e undeath: fix possible crash on tx with odd scripts
05:59 < GitHub195> joinmarket-clientserver/master d278e85 AdamISZ: Merge #237: fix possible crash on tx with odd scripts...
05:59 -!- GitHub195 [GitHub195@gateway/service/github.com/x-dgwnfcukvqlylowy] has left #joinmarket []     
06:03 < waxwing> what's that? https://travis-ci.org/JoinMarket-Org/joinmarket-clientserver/jobs/459498851#L539
06:03 < undeath> some odd problem that pops up since yesterday every now and then
06:04 < undeath> something wrong with travis
06:10 < arubi> huh, almost as if ubuntu took down the xenial docker
06:10 < undeath> it works sometimes, maybe a network problem
06:11 < arubi> yea maybe.  I see it's still available
06:12 < arubi> testing a fix for the coincurve+system libsecp thing
06:32 -!- GitHub119 [GitHub119@gateway/service/github.com/x-yscxqkyrhipfadnp] has joined #joinmarket     
06:32 < GitHub119> [joinmarket-clientserver] fivepiece opened pull request #238: [DO NOT MERGE] Override system libsecp256k1 for coincurve (master...installsh_libsecp_install) https://git.io/fpuk5
06:32 -!- GitHub119 [GitHub119@gateway/service/github.com/x-yscxqkyrhipfadnp] has left #joinmarket []     
06:34 < arubi> see my comment in #234 for anybody that can test this
06:44 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket     
07:47 -!- felix34 [~muh@5.2.76.19] has joined #joinmarket     
07:48 < felix34> 2 hours ago the tumbler script logged, "No stall detected, continuing" and has done nothing since. what are the odds it has in fact stalled?
07:55 < felix34> nvm, it was waiting for confirmation of tx
08:29 -!- rdymac [uid31665@gateway/web/irccloud.com/x-wmbzcneknidhqkms] has joined #joinmarket     
08:31 -!- felix34 [~muh@5.2.76.19] has left #joinmarket []     
12:36 < Lightsword> waxwing were there any blockers left on merging #229?
12:43 < waxwing> Lightsword, i think i'm the main blocker :) i haven't quite finished reviewing it. i guess a day or two. someone could save me time by testing 234 for arubi :)
12:43 < waxwing> also it's the last game of the world chess championship today. kinda important :)
12:43 < undeath> i haven't reviewed it either
12:45 < arubi> hopefully alexcato eventually tests my patch and it fixes his issue.  fwiw my PR to coincurve for adding the env. var. override got merged in the mean time
12:46 < arubi> so whenever's a new release, we can stop monkey patching setup_support.py 
12:49 -!- rdymac [uid31665@gateway/web/irccloud.com/x-wmbzcneknidhqkms] has quit [Quit: Connection closed for inactivity]     
13:03 < waxwing> arubi, it prob won't take a moment, should i just wipe the current jmvenv/ , deps/ and just try it?
13:03 < waxwing> i have my custom location venv anyway so it's not really disturbing me
13:04 < arubi> yea that should work
13:04 < arubi> no rush though, chess and all :)
13:05 < waxwing> it was a draw :)
13:08 < waxwing> seems to have worked, just runnign the test suite
13:10 < arubi> nice
13:27 < arubi> alright, undeath I'll set up the docker again and see if I can reproduce (waxwing are you able to 'import coincurve'? ).  I didn't actually try importing coincurve interactively like that.  will look into that
13:28 < waxwing> i didn't try; i'd have to install again. are you saying it doesn't import? but i think it must otherwise the test wouldn't succeed.
13:28 < arubi> yea that's what I was thinking too
13:29 < waxwing> doesn't seem like there can be any doubt about it.
13:31 < arubi> I'll test here to make sure (will take a while to install everything, nbd)
13:31 < arubi> I mean anyway still need to figure out why undeath is getting the error, even if I don't here
13:33 < waxwing> i don't understand, i didn't see a message that undeath had tested #234?
13:34 < arubi> it's the comment right above yours in the #238 PR itself (now I figure you were looking at the irc backlog)
13:35 < waxwing> sorry 238, not 234. right, i see.
13:36 < waxwing> i just checked, yes i did test the right PR ... so yeah there's still something here.
13:37 -!- GitHub74 [GitHub74@gateway/service/github.com/x-gtrdjnfuisdlyucz] has joined #joinmarket     
13:37 < GitHub74> [joinmarket-clientserver] AdamISZ pushed 1 new commit to master: https://git.io/fpu5c
13:37 < GitHub74> joinmarket-clientserver/master 99ac1ca AdamISZ: update TESTING.md with latest test syntax
13:37 -!- GitHub74 [GitHub74@gateway/service/github.com/x-gtrdjnfuisdlyucz] has left #joinmarket []     
13:41 < waxwing> arubi, `import coincurve` does work here. guessing it's presence/absence of system libsecp right
13:42 < undeath> do you have the system lib?
13:42 < arubi> waxwing, I basically expect it to work regardless while in virtualenv
13:43 < waxwing> undeath, i actually don't know on this machine, where should i look for it?
13:43 < arubi> `apt-cache policy libsecp256k1-dev libsecp256k1-0`
13:44 < waxwing> two "Unable to locate" lines, so i guess no
13:44 < undeath> ls {,/usr}/lib64/libsecp*
13:44 < arubi> ah, so that time you got the error was on a different host?
13:44 < waxwing> no such file
13:44 < waxwing> arubi, hmm, well that's weird perhaps, but no. that was the same machine.
13:45 < arubi> yea that is weird then
13:45 < waxwing> maybe i screwed something up with virtualenvs. but as i remember it, i got the same error as alexcato did.
13:45 < arubi> and I got the same one after installing libsecp in the docker
13:45 < undeath> the error?
13:45 < arubi> the very first one from issue #234
13:46 < waxwing> yeah i got that one, the _ecdh compilation error
13:46 < arubi> I'm surprised it says "unable to locate"
13:46 < arubi> it should still find info on the packages even if not installed.  almost like I made a typo
13:47 < arubi> which OS are you on waxwing?  I think I know it says "unable to locate" on xenial at least
13:47 < waxwing> adam@adam-UX430UQ:~/code/Joinmarket/joinmarket-clientserver$ apt-cache policy libsecp256k1-dev libsecp256k1-0
13:47 < waxwing> N: Unable to locate package libsecp256k1-dev
13:47 < waxwing> N: Unable to locate package libsecp256k1-0
13:47 < waxwing> this machine is 1604
13:48 < arubi> yea then it shouldn't be available on 1604
13:48 < arubi> hmm     
13:48 < waxwing> on 1804 i get Installed: (none) for both, different output
13:50 < arubi> hmm..  does `find -name 'libsecp*' /usr` return anything at all?  (on 1604
13:50 < arubi> errr
13:50 < arubi> find /usr -name 'libsecp*'
13:51 < waxwing> yes, in /usr/local/lib
13:51 < arubi> ah then maybe you installed it from source
13:51 < waxwing> .so, .so.0 and others
13:51 < waxwing> yeah it seems highly likely i did at some point, a long time ago (only confusion is i changed my main dev laptop in 2017 so not exactly sure what happened where)
13:56 < arubi> I can also interactively import jmbitcoin \ coincurve on ubuntu 1804 with the system lib installed
13:56 < undeath> the venv doesn't seem to set LD_LIBRARY_PATH or anything related
13:57 < arubi> right, it didn't seem necessary
13:58 < undeath> I'm not sure how my system determines where to find its libraries
14:00 < arubi> hmm.  undeath did you try this installation after nuking jmvenv and dep directories?  maybe something got left behind if not
14:00 < undeath> everything was new
14:00 < arubi> I see
14:02 < arubi> we've seen this undefined symbol thing before.  I think last time it was ecdsa_recovery that was missing.  not sure what became of that
14:04 < arubi> alright.  will try grepping the channel logs tomorrow.  night for now
14:17 < AgoraRelay> [agora-irc/scriptthekidddd] Hey whisky
14:56 -!- v_unimportant_pe [~user@46.243.206.135] has joined #joinmarket     
15:40 -!- technonerd [~techno@unaffiliated/technonerd] has joined #joinmarket     
15:44 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3]     
16:53 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection]     
16:58 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
17:05 -!- AgoraRelay [~jmrelayfn@p5DE4AC1B.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]     
17:20 -!- AgoraRelay [~jmrelayfn@p5DE4A872.dip0.t-ipconnect.de] has joined #joinmarket     
21:03 -!- rdymac [uid31665@gateway/web/irccloud.com/x-xzuihnvuxaesxfpl] has joined #joinmarket