--- Day changed Fri Nov 30 2018
01:41 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Ping timeout: 250 seconds]     
05:13 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket     
05:43 < waxwing> arubi, is 238 ready?
05:53 < waxwing> undeath, yes that one, and one more on line 221, seem to be needed. currently running tumbler, seems like it's working with those two fixups
05:53 < waxwing> i guess the sum thing is fine, that was just a byproduct
05:55 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket     
05:58 < undeath> the sum thing was just where the problem surfaced, not where it was introduced
05:58 < waxwing> ah i see a ton of changes has been pushed
05:58 < waxwing> undeath, yeah that's what i meant by 'byproduct'
05:59 < waxwing> including those changes :)
06:15 < waxwing> error in new secp changes: https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/241#issuecomment-443215649
06:48 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Read error: Connection reset by peer]     
07:29 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket     
07:53 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Read error: Connection reset by peer]     
07:55 < arubi> waxwing, just need to squash it.  will do that later on today and ping.
07:55 < waxwing> k, no rush, thx
07:55 < arubi> npnp
08:45 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3]     
09:01 < arubi> waxwing, done
09:14 -!- mr_paz [~mr_paz@31.7.57.246] has joined #joinmarket     
09:42 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds]     
09:44 < Lightsword> waxwing, where’s the deserialize call that fails for https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/6ebabd46229fe586be361b07031be560c5c68dce/jmbitcoin/jmbitcoin/secp256k1_transaction.py#L17 coming from exactly?
09:47 < waxwing> Lightsword, i put the stack trace in the 0bin on the PR comment
09:47 < waxwing> just taking a dinner break now but i've been looking into it a bit. it's tricky to unpack how that particular scenario is different to other ones.
09:48 < waxwing> i think in other places the hex string comes in as unicode, or something.
09:49 < Lightsword> yeah, I’ve been trying to fix that bug at the call sites
09:49 < Lightsword> that bytes check is added because the regex in python3 is type sensitive
09:52 < waxwing> yeah i realised after i made the comment that you can remove that check, that it was a bit stupid, obv you only did it because it was needed for py3 :)
09:57 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket     
10:17 < Lightsword> waxwing, I pushed up some more fixes if you want to retest
10:49 < waxwing> Lightsword, thx
10:52 < waxwing> undeath (not here but can always send again), i don't understand the logic of having this in taker_utils: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/taker_utils.py#L103-L115
10:53 < waxwing> isn't that code all something the wallet can take care of? and moreover, the maker also needs to do the same stuff, right.
10:53 < waxwing> Lightsword, yeah that seems to fix all the errors I've seen so far. will keep looking at stuff.
10:54 < waxwing> (but i'm only testing on py2)
10:57 < Lightsword> yeah, I’m finishing up the last few py3 issues
11:03 < waxwing> Lightsword, what's the rationale for the new code in bigstring?
11:04 < Lightsword> waxwing, mostly that I couldn’t get the old code working in py3
11:04 < Lightsword> also this new way is easier to work with I think
11:08 < Lightsword> it avoids any direct use of stringio
12:01 < Lightsword> waxwing, got most py3 tests passing now, just one jmdaemon one still left with a bug
12:15 -!- mr_paz [~mr_paz@31.7.57.246] has quit [Ping timeout: 240 seconds]     
12:33 -!- mr_paz [~mr_paz@84.39.112.85] has joined #joinmarket     
12:36 < waxwing> Lightsword, great
12:53 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket     
13:24 -!- mr_paz [~mr_paz@84.39.112.85] has quit [Ping timeout: 250 seconds]     
13:43 -!- mr_paz [~mr_paz@84.39.112.86] has joined #joinmarket     
13:58 -!- GitHub122 [GitHub122@gateway/service/github.com/x-yiimryrkejnsnkro] has joined #joinmarket     
13:58 < GitHub122> [joinmarket-clientserver] AdamISZ opened pull request #244: Fix test of daemon protocol (master...fix-daemon-test) https://git.io/fpoTv
13:58 -!- GitHub122 [GitHub122@gateway/service/github.com/x-yiimryrkejnsnkro] has left #joinmarket []     
14:02 -!- GitHub164 [GitHub164@gateway/service/github.com/x-jrttnsdrnlucsdfv] has joined #joinmarket     
14:02 < GitHub164> [joinmarket-clientserver] AdamISZ pushed 2 new commits to master: https://git.io/fpoT8
14:02 < GitHub164> joinmarket-clientserver/master 214dbf3 fivepiece: override system libsecp256k1 for coincurve
14:02 < GitHub164> joinmarket-clientserver/master 3d0c2be AdamISZ: Merge #238: Override system libsecp256k1 for coincurve...
14:02 -!- GitHub164 [GitHub164@gateway/service/github.com/x-jrttnsdrnlucsdfv] has left #joinmarket []     
14:02 -!- GitHub10 [GitHub10@gateway/service/github.com/x-hqviwshnhsibbxrk] has joined #joinmarket     
14:02 < GitHub10> [joinmarket-clientserver] AdamISZ closed pull request #238: Override system libsecp256k1 for coincurve (master...installsh_libsecp_install) https://git.io/fpuk5
14:02 -!- GitHub10 [GitHub10@gateway/service/github.com/x-hqviwshnhsibbxrk] has left #joinmarket []     
14:32 -!- mr_paz [~mr_paz@84.39.112.86] has quit [Read error: Connection reset by peer]     
17:54 < Lightsword> waxwing, https://github.com/JoinMarket-Org/miniircd is broken on py3, you should rebase it off of the upstream which seems to work
17:59 -!- AgoraRelay [~jmrelayfn@p5DE4A82F.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]     
18:07 -!- AgoraRelay [~jmrelayfn@p5DE4A28F.dip0.t-ipconnect.de] has joined #joinmarket     
23:02 < Lightsword> tests passing on py3 and py2 https://travis-ci.org/JoinMarket-Org/joinmarket-clientserver/builds/462095376