--- Day changed Sat Dec 15 2018
02:24 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket     
04:01 < arubi> so waxwing, just making sure, when adding the new Qt stuff to install.sh (pyside2, qt5reactor), should I also remove the python2 stuff?  asking because the readme now says that jm-qt is unsupported on python2
04:05 < arubi> hm, are the python-qt4 and python-sip stuff even needed anymore?  doesn't seem like it
04:17 < waxwing> arubi, correct, as of now can't support Qt with Py2, so python-qt4 and python-sip can be removed from the installation script
04:18 < waxwing> people who want to use it should run the two pip install lines added to the readme, although you could automate taht later
04:19 < arubi> there was also python3-pyqt4 and python3-sip for when python3 is used, that can also be removed right?
04:24 < waxwing> arubi, yes
04:25 < arubi> cool
04:25 < waxwing> i don't speak from a position of perfect information, but we don't need that
04:35 < arubi> hm, running jm-qt on regtest, trying to generate a wallet, every seed I'm entering results in an error window that says "'NoneType' object has no attribute 'encode'", and a button for "OK".  clicking OK makes the generate window disappear and I'm returned to the empty wallet
04:35 < arubi> same when I try to enter a seed through Wallet -> Load
04:37 < arubi> (no error trace appears on the shell where I ran `python joimarket-qt.py` from)
04:45 < arubi> I think the issue is here : https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/scripts/joinmarket-qt.py#L1385
04:45 < arubi> password=pwd.encode('utf-8') , but on line 1376 'pwd' is None
04:52 < arubi> yea seems like it, but even if I work around it, seems that the seed being entered is thought of as a wallet name.  "Failed to open wallet at 'wallets/myseed': not a file"
05:02 < waxwing> arubi, apologies, the regtest setup doesn't work as the mainnet, this is kind of a historical artifact
05:03 < waxwing> regtest only allows you to use hex seeds. re: generate though, it'd certainly be nice if that worked on regtest.
05:03 < waxwing> for generate, recover etc. i've been testing only on mainnet, that stuff was never even properly implemented on regtest.
05:04 < waxwing> if you actually wanted to test it on regtest, i'd recommend using `pytest <options> test/ygrunner.py -s and use the provided seed for the Taker wallet. that way you can test coinjoins also.
05:05 < waxwing> the options should be in docs/TESTING.md (i updated it recently)
05:07 < arubi> yea waxwing I'm trying to enter a seed
05:08 < arubi> what I'm really trying to do is 1. connect jm-qt to my regtest daemon (done) , 2. create a new wallet using a seed.   I'll read the TESTING doc now
05:08 < waxwing> arubi, oh. i just tried it, yes, there's an error there.
05:08 < arubi> ah phew
05:09 < waxwing> huh that must have just crept in at the end or something, i was running it a lot before.
05:09 < waxwing> ah yeah come to think of it, it makes sense. there were several edits at the end like that, i didn't then go back and re-try on regtest.
05:11 < arubi> what I did as a "workaround" was change the pwd.encode to 'password=pwd.encode('utf-8') if pwd is not None else None' , then the next error about the wallet filename appeared (in case it helps)
05:12 < waxwing> right, working on it
05:12 < arubi> cheers
05:15 < waxwing> arubi, i just made the same edit and it worked after that
05:16 < arubi> hmm     
05:16 < waxwing> i don't get that 'wallets/myseed' thing?
05:16 < waxwing> oh by myseed you mean an actual hex seed right?
05:16 < waxwing> hmm that'd be what'd happen if it thought it wasn't testnet i guess
05:16 < arubi> well I did enter the string "myseed" for that error, but also truied just "0"
05:18 < arubi> the Qt window says "Joinmarket-Qt - Testnet"
05:19 < waxwing> oh, just '0' fails? hmm that's interesting
05:19 < waxwing> i can't recall (can check ofc) but i believe any nonhex will fail because it will think it's a file
05:19 < waxwing> arubi, 
05:20 < arubi> trying 32 byte hex
05:20 < waxwing> oh     
05:20 < waxwing> istr it actually has to be 16 bytes
05:20 < waxwing> ie 32 hex chars
05:21 < waxwing> yeah line 887 jmclient/jmclient/wallet_utils.py
05:21 < arubi> yep.  32 bytes failed with same error and 16 bytes seems to work.
05:22 < waxwing> sorry that changed at some point but didn't doc it in TESTING.md, will do
05:22 < arubi> should also change the enter seed window text, currently says "can be anything"
05:22 < waxwing> gotcha, thanks
05:22 < arubi> thanks for fixing!
05:30 -!- GitHub90 [GitHub90@gateway/service/github.com/x-uuxpbamlqmrqqvua] has joined #joinmarket     
05:30 < GitHub90> [joinmarket-clientserver] AdamISZ pushed 1 new commit to master: https://git.io/fpbjQ
05:30 < GitHub90> joinmarket-clientserver/master d7a2b6b AdamISZ: regtest: fix wallet load in Qt
05:30 -!- GitHub90 [GitHub90@gateway/service/github.com/x-uuxpbamlqmrqqvua] has left #joinmarket []     
05:36 < arubi> works for me ^
06:10 < waxwing> arubi, well one would hope so, it was your fix :)
06:11 < arubi> hehe almost, I keep forgetting that in python, None is also a False value so yours uses just a few words :)
06:12 < waxwing> well; i wouldn't be surprised if your syntax isn't considered more correct. but in practice, in this case, i don't think it makes a difference.
06:31 -!- GitHub165 [GitHub165@gateway/service/github.com/x-krpzqfkbxkrcgstr] has joined #joinmarket     
06:31 < GitHub165> [joinmarket-clientserver] fivepiece opened pull request #252: adapt install.sh for Qt with python3 (master...installsh_py3_qt_deps) https://git.io/fpNfe
06:31 -!- GitHub165 [GitHub165@gateway/service/github.com/x-krpzqfkbxkrcgstr] has left #joinmarket []     
07:17 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Remote host closed the connection]     
08:29 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket     
12:27 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket     
12:38 -!- GitHub91 [GitHub91@gateway/service/github.com/x-oavkoqgfqsiyizmf] has joined #joinmarket     
12:38 < GitHub91> [joinmarket-clientserver] AdamISZ closed pull request #250: fix crash on IRC notice with non-ascii characters (master...fix-irc-control-chars) https://git.io/fpQ3R
12:38 -!- GitHub91 [GitHub91@gateway/service/github.com/x-oavkoqgfqsiyizmf] has left #joinmarket []     
12:38 -!- GitHub30 [GitHub30@gateway/service/github.com/x-twsqoihphxkbcewq] has joined #joinmarket     
12:38 < GitHub30> [joinmarket-clientserver] AdamISZ pushed 2 new commits to master: https://git.io/fpN3Q
12:38 < GitHub30> joinmarket-clientserver/master 9ce9ee5 undeath: fix encode crash on irc notice
12:38 < GitHub30> joinmarket-clientserver/master bcc662c AdamISZ: Merge #250: fix crash on IRC notice with non-ascii characters...
12:38 -!- GitHub30 [GitHub30@gateway/service/github.com/x-twsqoihphxkbcewq] has left #joinmarket []     
12:39 < waxwing> seems not 100% clear that that is a crash vector, but it doesn't hurt.
12:39 < waxwing> and only arose out of the Py3 compat stuff
12:39 < undeath> definitely some code that can be removed again after we stop supporting py2
12:39 < waxwing> ah, you're here :) yes. thanks for that.
12:40 < undeath> btw, #252 looks quite handy for the next release
12:41 < undeath> otherwise install.sh with qt will be broken
12:42 < undeath> only downside is, it removes the prompt during install
12:45 < waxwing> undeath, yeah i put the instructions into the README
12:45 < waxwing> it's only two pip installs.
12:46 < waxwing> discussed with arubi , i wanted to give him time to figure it out, in case there was an issue. i am still not at all sure if anyone's really using the GUI.
12:46 < undeath> heh     
12:46 < undeath> hard to evaluate
12:47 < arubi> wait, did I miss anything in my py3 + qt PR ?
12:47 < undeath> responded just now
12:48 < arubi> ah I see, I'm not sure about that prompt because let's say that you don't wanna install the qt stuff, that prompt will show up every time you run install.sh
12:49 < arubi> with the --with-qt flag, it's more of an opt-in thing and I hope folks read the readme.  but -- I don't mind adding a prompt really (will have to be during the week)
12:49 < undeath> maybe a conditional prompt if -p == python3 ?
12:49 < undeath> and possibly log an echo message otherwise that qt is not supported
12:50 < arubi> alright, I can do that
12:50 < undeath> nice, thank you :)
12:51 < arubi> :)     
12:51 < arubi> also wow that pyside2 is like 160mb
12:51 < undeath> wow :/
12:58 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: https://www.Quanto.ga/]     
13:01 -!- lnostdal [~lnostdal@77.70.119.51] has joined #joinmarket     
13:19 -!- GitHub102 [GitHub102@gateway/service/github.com/x-pihiouxkfflipgba] has joined #joinmarket     
13:19 < GitHub102> [joinmarket-clientserver] AdamISZ pushed 1 new commit to master: https://git.io/fpNsH
13:19 < GitHub102> joinmarket-clientserver/master b491282 AdamISZ: Merge #251: release notes and docs for 0.5.0...
13:19 -!- GitHub102 [GitHub102@gateway/service/github.com/x-pihiouxkfflipgba] has left #joinmarket []     
13:19 -!- GitHub87 [GitHub87@gateway/service/github.com/x-prikaylhypynigbx] has joined #joinmarket     
13:19 < GitHub87> [joinmarket-clientserver] AdamISZ closed pull request #251: release notes and docs for 0.5.0 (master...release-050) https://git.io/fpNsQ
13:19 -!- GitHub87 [GitHub87@gateway/service/github.com/x-prikaylhypynigbx] has left #joinmarket []     
13:49 < waxwing> it's up on reddit, mastodon, please share as and when, thanks
14:03 < qubenix> there could be a multisig address for donations. prevents against rouge/insane person and then ofc there's also the threat to the one person that controls this public address.
15:16 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Remote host closed the connection]     
15:37 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.3]     
17:43 -!- AgoraRelay [~jmrelayfn@p548663C2.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]     
17:57 -!- AgoraRelay [~jmrelayfn@p5DE4A8BF.dip0.t-ipconnect.de] has joined #joinmarket