--- Day changed Sun Dec 16 2018
00:45 -!- raedah [~x@192.30.89.51] has joined #joinmarket     
02:25 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket     
03:27 -!- nothingmuch [~user@62.102.148.130] has quit [Ping timeout: 250 seconds]     
07:41 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Remote host closed the connection]     
08:17 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket     
09:55 < qubenix> from the linux install (https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/docs/INSTALL.md), the first set of pkg installs include things for building (automake, build-essential, etc.). if i know for sure i dont need to build anything, is it ok to remove these: libtool libffi-dev libssl-dev libgmp-dev?
10:05 < arubi> qubenix, well libffi and libtool are probably needed
10:06 < arubi> libgmp, not sure if it's a must, libssl is probably a must for sodium
10:08 < qubenix> hmm, libssl isn't in depends for libsodium. ill try without and see what happens.
10:08 < arubi> thanks!
10:08 < arubi> actually libsodium accepts a '--enable-minimal' flag that we currently don't use but I've tested it and it works
10:08 < arubi> maybe worth your time
10:09 < arubi> so what's libssl for..  twisted?
10:09 < arubi> oh yea I think that's what it was
10:09 < waxwing> yes     
10:10  * arubi starts campaign to move all web crypto to libsecp
10:10 < arubi> the one dependency to rule them all
11:29 < arubi> coincurve has "Requires-Dist: urllib3 (<1.25,>=1.21.1)".  I'm going to add a pip install of it to install.sh because coincurve's setup.py downloader seems to sometimes fail fetching it and causes the entire install to fail for me
11:30 < arubi> pip itself seems to handle it a lot better and I don't see dns failures anymore
11:49 -!- belcher_ [~user@unaffiliated/belcher] has quit [Ping timeout: 250 seconds]     
12:27 < technonerd> the python3 upgrade didnt work for me https://pastebin.com/rb29fu0i
12:27 < technonerd> ModuleNotFoundError: No module named 'jmclient'
12:28 < arubi> technonerd, and you did install with `./install.sh -p python3` ?
12:28 < arubi> I'm asking because it looks like python3 is actually not in the venv
12:28 < technonerd> yes i did
12:28 < arubi> hm.  what does `which python3` say?
12:29 < technonerd> lrwxrwxrwx. 1 root root 13 Jul  8 19:16 /usr/bin/python3 -> python-exec2c
12:29 < arubi> also, try running with 'python' instead of python3.  it should point to the correct binary
12:29 < arubi> yea, that's outside the venv.  try `python`
12:30 < technonerd> its showing 2.7
12:30 < technonerd> and home/techno/code/joinmarket-clientserver/jmenv/bin/python
12:30 < arubi> did you choose to reinstall the venv when install.sh asked?
12:30 < technonerd> i selected y to deleting jmenv
12:31 < arubi> lemme try here
12:32 < technonerd> looks like its not deleting stuff in jmenv?
12:33 < arubi> it should definitely
12:33 < technonerd> lrwxrwxrwx. 1 techno techno    9 Mar 13  2018 python -> python2.7
12:34 < arubi> yea that's really weird.  installing with 2.7 now and will try a reinstall with python3 afterwards
12:34 < arubi> it's deleteing the venv for me here
12:35 -!- belcher_ [~user@unaffiliated/belcher] has joined #joinmarket     
12:35 < waxwing> arubi, technonerd maybe the installation simply failed?
12:35 < waxwing> i think maybe that'd explain the symptoms?
12:36 < arubi> but it should delete the venv first anyway
12:36 < waxwing> ok, right
12:36 < arubi> can you change the first line of install.sh to be '#!/bin/bash -x' and re-run the script with '-p python3'?   paste the log of the install process please
12:37 < arubi> also can you tell what `ls -ld ./jmvenv` says?
12:38 < technonerd> drwxr-xr-x. 1 techno techno 72 Mar 13  2018 ./jmenv/
12:38 < arubi> yea really weird.  the verbose logs would be helpful
12:40 < waxwing> technonerd, jmenv .. not jm*v*env?
12:40 < waxwing> doesn't the install script assume the latter?
12:40 < arubi> yes     
12:40 < arubi> good eye heh
12:41 < technonerd> ok python3 is listed there and the dates are today
12:41 < technonerd> which python is still pointing to jmenv
12:41 < arubi> the jmenv thing is really weird
12:41 < arubi> it was always 'jmvenv'
12:42 < waxwing> deactivate and `source jmvenv/bin/active`
12:42 < waxwing> deactivate and `source jmvenv/bin/activate`
12:42 < arubi> yea ^
12:44 < arubi> unrelated weird travis err : https://travis-ci.org/fivepiece/joinmarket-clientserver/jobs/468745508#L3833-L3834
12:44 < arubi> 0.0 vs 0.  thank you python for being so pedantic
12:45 < arubi> oh it's actually the >,  nm me :)
12:48 < technonerd> now im unable to convert the wallet
12:52 < waxwing> technonerd, so it does install correctly using jmvenv?
12:53 < waxwing> wallet converting: so i take it you're upgrading from pre-0.4.0? your wallet is still the json format?
12:53 < technonerd> it installs correctly and im still on json
12:55 < waxwing> right; so the convert_old_wallet script isn't working? actually i can't remember the updates on that, i think undeath did it
12:55 < arubi> (sorry afk for dinner)
12:57 < waxwing> technonerd, this was the instructions for it. i guess you already saw it, but just in case: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/docs/wallet-upgrade.md
12:59 < technonerd> heres the install.sh logs just incase https://bpaste.net/show/5eea32a77da1 
12:59 < technonerd> Enter password for old wallet file:
12:59 < technonerd> Error: 'bytes' object has no attribute 'encode'
12:59 < technonerd> Failed to open wallet. Wrong password?
13:00 < waxwing> technonerd, well yes, indeed that'll be to do with the python3 upgrade. undeath was doing that, or at least was checking it, but he's not here right now.
13:00 < waxwing> i can probably fix it (assuming it's an error; likely), i'll have to take a look.
13:14 < waxwing> technonerd, this is not going to get fixed right now, most likely; either wait a bit or, if you needed it right now, you could use 0.4.0,1,2 (doesn't matter), do the convert, and then switch back to 0.5.0 (to get a release you can `git checkout v0.4.2` e.g.)
13:15 < waxwing> huh, so unsurprisingly it's the two things i didn't test that had bugs .. wallet `history` and convert-old-wallet. was kinda assuming undeath had the latter covered.
13:16 < waxwing> i've never used the wallet history function, so always just hoped other people dealt with it, but then it doesn't really matter much.
13:18 < waxwing> if undeath comes later, please point him at this: https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/241#issuecomment-443734431 and technonerd's report above about "<technonerd> Error: 'bytes' object has no attribute 'encode'"
13:20 < waxwing> btw that code is duplicated in convert_old_wallet, it should be taken from jmbase.support
13:59 < waxwing> (no it's not, sorry)
13:59 < waxwing> technonerd, in case you installed with the --develop flag, you can just remove `.encode('utf-8')` from this line: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/a86e154b159890d9a81a7169ef0424012a4b2f0f/scripts/convert_old_wallet.py#L44
14:00 < waxwing> sorry it took so long but i got sidetracked by two completely red herrings causing erroneous errors (working with a .json which was actually not json, and then in another case, using the wrong password!). but now it's clear that that's the error, just that line. at least, it works for me after that.
14:13 -!- GitHub139 [GitHub139@gateway/service/github.com/x-jhclsuxpsvzmbxvk] has joined #joinmarket     
14:13 < GitHub139> [joinmarket-clientserver] AdamISZ opened pull request #254: Fix bug in convert_old_wallet after Py3 upgrade (master...fix-convert-old) https://git.io/fpNxg
14:13 -!- GitHub139 [GitHub139@gateway/service/github.com/x-jhclsuxpsvzmbxvk] has left #joinmarket []     
14:21 < arubi> I just realized that installing qt deps using `pip install git+...` makes git itself a dependency for the gui (git wasn't a dep until now, say if you use the tar.gz).  will replace with 'pip install https://github.com/sunu/qt5reactor/archive/58410aaead2185e9917ae9cac9c50fe7b70e4a60.zip' tomorrow
14:22 < arubi> actually I'll do it now :)
14:22 < arubi> check results tomorrow, night
14:23 < waxwing> arubi, oh! thanks; i could also change that on the readme
14:23 < arubi> ah yea worth to do that
14:51 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Remote host closed the connection]     
17:22 -!- arubi [~ese168@unaffiliated/ese168] has quit [Ping timeout: 246 seconds]     
17:27 -!- arubi [~ese168@unaffiliated/ese168] has joined #joinmarket     
17:43 -!- AgoraRelay [~jmrelayfn@p5DE4A8BF.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]     
17:58 -!- AgoraRelay [~jmrelayfn@p5DE4ABD8.dip0.t-ipconnect.de] has joined #joinmarket     
18:34 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
21:34 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]     
21:41 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #joinmarket