--- Day changed Thu Aug 01 2019 01:31 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket 02:09 < felix34> is there a specific reason sendpayment.py doesn't support floating point bitcoin quantity values? I know float math is an issue but just rounding to 8 decimal places ought to do it, no? 02:13 < waxwing> felix34, just nobody did it since the beginning. yeah there'd be some trivial rounding issues but that's easy enough to deal with. 02:17 < kristapsk> it should be parsed to integer satoshi amount at argument parsing then, so floating point should not be issue here 02:18 < kristapsk> actually, I could look at it, it annoys me sometimes too, that I can't use BTC amount, can't just simply copy/paste 02:20 < felix34> kristapsk: yes, it is a major annoyance for me as well. here is the offending code: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/948390fb3067a32b2e76f3360553702fa08c4644/scripts/sendpayment.py#L69 02:22 < felix34> I am thinking for backwards compatibility it might make sense to support both int (sats) and float (btc) values, so maybe try/except the int conversion (as people are used to) and the in the except handling convert the argument to float and round it to 8 decimal places and multiply it by 1e8 to get a value in sats 02:23 < kristapsk> it should be done universal way, sendpayment.py isn't the only script that accepts satoshi parameters 02:24 < felix34> kristapsk: ok, then the other scripts would need to be changed as well, it looks hardcoded in this one 02:24 < felix34> but that is a good idea overall 02:28 < kristapsk> ok, i'm afk now, can look at it at weekend most likely 03:50 -!- newbie32 [715906eb@113.89.6.235] has joined #joinmarket 03:53 -!- newbie32 [715906eb@113.89.6.235] has quit [Remote host closed the connection] 07:37 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 07:57 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket 10:57 -!- MaxSan [~four@185.156.175.35] has quit [Quit: Leaving.] 11:17 -!- reallll [~belcher@unaffiliated/belcher] has joined #joinmarket 11:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 11:26 -!- reallll is now known as belcher 11:51 -!- viasil [~viasil@95.174.67.204] has quit [Ping timeout: 246 seconds] 11:56 -!- viasil [~viasil@95.174.67.204] has joined #joinmarket 11:56 -!- MaxSan [~four@185.156.175.35] has joined #joinmarket 12:36 -!- MaxSan [~four@185.156.175.35] has quit [Quit: Leaving.] 12:46 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket 13:22 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 14:56 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket 15:17 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 258 seconds] 15:29 -!- |avril [wha@cute.b.oy.hu] has joined #joinmarket 15:31 -!- emzy_ [~quassel@raspberry.emzy.de] has joined #joinmarket 15:37 -!- Netsplit *.net <-> *.split quits: emzy, avril 15:49 -!- |avril [wha@cute.b.oy.hu] has quit [Quit: later skater] 15:50 -!- avril [wha@unaffiliated/avril] has joined #joinmarket 16:59 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Remote host closed the connection] 17:39 -!- CgRelayBot [~CgRelayBo@p5DE4A81F.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds] 17:41 -!- AgoraRelay [~jmrelayfn@p5DE4A81F.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds] 17:55 -!- AgoraRelay [~jmrelayfn@p5DE4AAF8.dip0.t-ipconnect.de] has joined #joinmarket 17:56 -!- CgRelayBot [~CgRelayBo@p5DE4AAF8.dip0.t-ipconnect.de] has joined #joinmarket 18:14 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket