--- Day changed Sun Aug 18 2019
02:12 < waxwing> arubi, no. already done.
02:15 < CgRelayBot> [cgan/AlexCato] waxwing, found a few minutes right now to fix PR #367 to take all mixdepth into account when calculating the tumbling amount. Good catch. Locally tested, works on my end (again with the constraint: no GUI here to test, unsure if that change affects GUI versions)
02:16 < waxwing> alexcato thanks
02:18 < waxwing> oh you shouldn't really just use max mix depth, you should use starting mixdepth + num mixdepths (maybe -1?)
02:18 < waxwing> oh but yeah that could overrun
02:18 < waxwing> so the above, but not beyond max mixdepth.
02:19 < CgRelayBot> [cgan/AlexCato] yup, thats what it does. Let me get the link to the line
02:20 < CgRelayBot> [cgan/AlexCato] https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/scripts/tumbler.py#L40
02:21 < CgRelayBot> [cgan/AlexCato] or, unsure about intended behavior here. So if the tumbler is started with "-m 2". Should it tumble from mixdepth2 to mixdepth5 (so just 3 mixdepths) or should it do that from mixdepth2 to mixdepth7 (5 mixdepths) ?
02:21 < CgRelayBot> [cgan/AlexCato] reading the code, i assumed the 2nd interpretation
02:23 < waxwing> there's a -M for number of mixdepths to tumble through
02:24 < waxwing> so i could have a wallet with 5 mixdepths, start from mixdepth 0 and tumble through 3.
02:24 < waxwing> if there are funds in mixdepth 4 they should not be included in the calculation.
02:25 < CgRelayBot> [cgan/AlexCato] Alright, will update again in about 1-2 hours, busy for a bit now
02:25 < waxwing> it's ok i can do it
02:25 < waxwing> if you don't get it done during the day, when i come back to it. no worries.
03:17 < CgRelayBot> [cgan/AlexCato] alright, committed & squashed as discussed, but i believe this did not change anything. What is the intended behavior if: -M is set to 4 (this is also the default) -m is set to 2 and the wallet has 5 mixdepths? Currently the code seems to extend the wallet to 7 mixdepths, so it can fulfill the -M option.
03:18 < CgRelayBot> [cgan/AlexCato] and with "currently" i mean this is the way it works with and without my PR, so no changes are introduced from my side
03:19 < CgRelayBot> [cgan/AlexCato] the -M option was already taken into account in my previous commit before the changes, as in the linked code above (options['mixdepthcount'] is the -M option)
05:55 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket     
06:50 < waxwing> yes but what i was trying to avoid is indexing into wallet.get_balance_by_mixdepth with an index greater than 4 if the wallet doesn't have that.
06:52 < waxwing> i believe that's what's achieved by the code as-is now compared to what it was before. both (a) account for any non-empty mixdepths "ahead" of the source and (b) don't try to include balances in mixdepths that don't yet exist.
07:09 < waxwing> oh i see, it's a bit more complicated here because of how tumbler code works in that main() function.
07:10 < waxwing> the wallet is explicitly opened with the max_mix_depth = mixdepthsrc+mixdepthcount number of mixdepths.
07:11 < waxwing> so it's not possible to be querying beyond what the wallet is set to have. so in that case, yeah i think your comments above are correct. (that it doesn't make a difference).
08:07 < waxwing> as of 36e834ff3f2f99fb48c0afe338a364ddaab783b4 i don't intend to add any more code, so those who are active users here please switch to master (that commit) and report if you get any errors next couple of days, thanks.
08:07 < waxwing> i'm writing release notes now, but will hold off for any tests. i don't want to mess around making a RC branch it's too much work.
08:07 < waxwing> i could tag that commit if anyone thinks it's useful to do it.
09:47 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 244 seconds]     
09:48 < kristapsk> I agree there isn't need for RC release itself, most important is to know release is coming, so additional testing could be done
10:44 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Ping timeout: 245 seconds]     
12:20 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]     
12:20 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket     
12:20 -!- reallll [~belcher@unaffiliated/belcher] has joined #joinmarket     
12:24 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]     
13:13 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/380 as per comment. i'll leave this alone for a couple of days now, to see if anyone finds something.
13:15 < CgRelayBot> [cgan/AlexCato] running the commit you mentioned above and doing some testing (YG / sendpayments). All fine so far. One YG crashed, but this was because of a custom implementation of a YG class method, which was updated in master and needed to be manually ported to the custom YG script
13:36 < CgRelayBot> [cgan/AlexCato] A warning sometimes pops up when a YG receives a coinjoin, in jmclient/yieldgenerator.py line 116 (link will follow):
13:36 < CgRelayBot> [cgan/AlexCato] DeprecationWarning: Call to deprecated function select_utxos.
13:36 < CgRelayBot> [cgan/AlexCato]   utxos = self.wallet.select_utxos(mixdepth, total_amount)
13:36 < CgRelayBot> [cgan/AlexCato] link: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/yieldgenerator.py#L116
13:37 < CgRelayBot> [cgan/AlexCato] this is *not* new in the new master changes. I've checked my logs, it's been like that for a while, but seems non-deterministic. On some joins it's there, on others it's not
13:38 < CgRelayBot> [cgan/AlexCato] it's in 3 out of the last 35 coinjoins as yield generator
15:50 < waxwing> alexcato i don't see how it's logically possible to not reach that line in a successful coinjoin.
15:50 < waxwing> i guess i must have missed something
17:23 -!- CgRelayBot [~CgRelayBo@p5486675B.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]     
17:24 -!- AgoraRelay [~jmrelayfn@p5486675B.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]     
17:36 -!- AgoraRelay [~jmrelayfn@p5DE4AA6E.dip0.t-ipconnect.de] has joined #joinmarket     
17:38 -!- CgRelayBot [~CgRelayBo@p5DE4AA6E.dip0.t-ipconnect.de] has joined #joinmarket     
18:21 -!- eulersphi_ [~eulersphi@91.98.190.248] has joined #joinmarket     
18:22 -!- eulersphi_ is now known as Guest15237     
18:25 -!- Guest61821 [~eulersphi@91.98.183.114] has quit [Ping timeout: 245 seconds]     
21:49 -!- Guest15237 is now known as eulersphi     
22:09 -!- Kenna75Reichert [~Kenna75Re@ns334669.ip-5-196-64.eu] has joined #joinmarket     
23:02 -!- eulersphi_ [~eulersphi@91.98.190.248] has joined #joinmarket     
23:02 -!- eulersphi [~eulersphi@91.98.190.248] has quit [Read error: Connection reset by peer]     
23:02 -!- eulersphi_ is now known as Guest13107