--- Day changed Thu Sep 05 2019 00:24 -!- MaxSan [~four@185.156.175.35] has joined #joinmarket 05:39 < CgRelayBot> [cgan/AlexCato] a while ago, i said that there's a deprecation warning for select_utxos (DeprecationWarning: Call to deprecated function select_utxos) but it only occured occasionally (which made no sense). Now I know why: 05:40 < CgRelayBot> [cgan/AlexCato] this warning will be reported exactly once. So the first time this function is called, it will print the warning. It will only be seen again if e.g. the YG is restarted 05:40 < CgRelayBot> [cgan/AlexCato] so it's deterministic. 06:55 < takinbo> i've made some progress with the installation improvement; with the exception of system dependencies, all that is required now is just one `pip install` to get jmcs installed and another pip install for the gui. 06:58 < takinbo> AlexCato: this might make you happy, I get to freeze the package dependencies with their hashes so even if there's an upstream modification of the package (assuming it was malicious) after the fact, it will be rejected during the install. 06:59 < takinbo> I'm happy to update the installation instructions and submit a PR for review 07:05 -!- dopplergange [~dop@98.142.220.42] has quit [Quit: ZNC 1.7.3 - https://znc.in] 07:05 -!- dopplergange [~dop@98.142.220.42] has joined #joinmarket 08:53 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 09:17 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 11:40 < waxwing> takinbo, sounds good pls do PR 12:06 -!- viasil [~viasil@95.174.67.204] has quit [Ping timeout: 244 seconds] 12:09 -!- viasil [~viasil@95.174.67.204] has joined #joinmarket 12:22 -!- reallll [~belcher@unaffiliated/belcher] has joined #joinmarket 12:25 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 12:43 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket 12:44 -!- reallll is now known as belcher 13:54 -!- so [~so@unaffiliated/so] has joined #joinmarket 13:56 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket 13:56 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 14:17 < waxwing> kristapsk_, so pre `dcde815` it worked like this: if you reached selectWallet via generateWallet it would pass the restart_cb (restartForMsg now) and this would go into loadWalletFromBlockchain as a non-null argument for restart_cb, which would make it choose a fast sync option in syncWalletUpdate 14:17 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/dcde815bcb06de198b0826023def9b41af7cd507/scripts/joinmarket-qt.py#L1512-L1513 14:17 < waxwing> sorry i meant `22467f4` not `dcde..` (that's the 0.5.4) 14:19 < waxwing> dammit scratch all that i wrote it down all the wrong way round! trying again: 14:23 < waxwing> if you reached, pre-`22467f4`, loadWalletFromBlockchain via resyncWallet(right click) or via selectWallet from the menu action, restart_cb was None, and so it would do fast sync (see the above link for where that happens) 14:25 < waxwing> whereas if you loadWalletFromBlockchain via initWallet (creates a wallet) called by either recoverWallet or generateWallet, it would set the restart_cb to restartWithMsg (as is now) and so fast would *not* be set and it would go back to a detailed sync. 14:28 < waxwing> now further, if we call sync_wallet without the fast option (as we do in loadWalletFromBlockchain), and the wallet's imports are not all done (as they won't be if there's been a deposit, pushing the gap limit one address further), then a single sync iteration won't be enough. 14:29 < waxwing> so, notice how in the command line scripts we keep calling until the wallet flags itself as synced: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/scripts/tumbler.py#L46-L47 14:29 < waxwing> this isn't done in the Qt, which is assuming that fast will always be used unless it's a new or recovered wallet. 14:29 < waxwing> but that isn't good enough, we'll need to do the sync iterations if we do use non-fast sync. 14:30 < waxwing> the above summary ^ definitely doesn't cover everything, it's just what i concluded from a read-through earlier today while in transit. i'll do some testing tomorrow, but i'd like to know: did you get the "may need to rescan" pop up message each time when you repro-ed lopp's error? 14:39 < takinbo> waxwing: i created #391. let me know how i can improve it. 14:39 < takinbo> i'm thinking the next step will be updating the documentation. 14:40 < takinbo> but i'll like to see some testing before doing so 14:53 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 245 seconds] 15:33 < kristapsk_> waxwing, hmmm, I think I only got "need to rescan" msg only on first restart after incoming tx, not on the next one (in which I did rescan from context menu and coins appeared in wallet) 15:38 < waxwing> takinbo, yup, hopefully we'll get some eyes on it soon. thanks for doing it. 15:39 < waxwing> kristapsk_, thanks, i'll be able to test myself tomorrow. 15:40 < waxwing> but ofc your input is appreciated, if you see something different to what i do in terms of how it works, let me know. 15:42 -!- kristapsk_ is now known as kristapsk 15:43 -!- Xeha [~Xeha@unaffiliated/k1773r] has quit [Ping timeout: 248 seconds] 15:44 -!- Xeha [~Xeha@unaffiliated/k1773r] has joined #joinmarket 17:17 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.5] 17:18 -!- raedah [~x@192.30.89.51] has quit [Quit: WeeChat 2.5-rc1] 18:01 -!- CgRelayBot [~CgRelayBo@p5DE4A540.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds] 18:01 -!- AgoraRelay [~jmrelayfn@p5DE4A540.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds] 18:15 -!- AgoraRelay [~jmrelayfn@p5DE4A5AB.dip0.t-ipconnect.de] has joined #joinmarket 18:15 -!- CgRelayBot [~CgRelayBo@p5DE4A5AB.dip0.t-ipconnect.de] has joined #joinmarket 19:23 -!- MaxSan [~four@185.156.175.35] has quit [Quit: Leaving.] 19:35 -!- MaxSan [~four@185.156.175.35] has joined #joinmarket 20:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 20:50 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #joinmarket 20:59 -!- fishguts [~fishguts@121-200-12-43.79c80c.syd.nbn.aussiebb.net] has quit [Ping timeout: 264 seconds] 21:00 -!- fishguts [~fishguts@121-200-12-43.79c80c.syd.nbn.aussiebb.net] has joined #joinmarket 21:07 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 245 seconds] 21:08 -!- StopAndDecrypt [~StopAndDe@107.181.189.43] has joined #joinmarket 21:08 -!- StopAndDecrypt [~StopAndDe@107.181.189.43] has quit [Changing host] 21:08 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #joinmarket 21:46 -!- MaxSan [~four@185.156.175.35] has quit [Quit: Leaving.] 22:09 -!- StopAndDecrypt_ [~StopAndDe@107.181.189.45] has joined #joinmarket 22:09 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 245 seconds]