--- Day changed Fri Oct 25 2019 00:00 < waxwing> belcher, you mean the last sentence should be in mixdepthcount. right. thanks. 00:00 < belcher> yes, it should be in the help for --mixdepthcount aka -M 00:00 < belcher> and not in -txcountparam aka -c 00:02 < waxwing> yeah and also there is no --addrask only --addrcount, oops :) 00:04 < belcher> ah, hah 01:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 01:49 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket 02:54 < waxwing> those with nontrivial PRs - prepare to rebase ... sorry :) 05:02 < zfk> can someone show me a typical example of what their TUMBLE.schedule looks like at the beginning of a session? 06:20 -!- MaxSan [~four@195.206.105.227] has quit [Quit: Leaving.] 07:19 < waxwing> zfk, here's what i got from a regtest setup i just tried: https://0bin.net/paste/rVI8kjvVfMSEDWgl#QJhgi0Nmb-J7opR8UtqE12oFjDixLC0A4k9ejDAeUUF 07:21 < waxwing> i usually do something similar on mainnet when i run it occasionally (mainly i do it for testing, but it's still real .. i would tend towards much higher weights and probably a larger transaction count (and slighly higher counterparty counts, although not too much) per mixdepth, if i was more focused on my own coins having a better mixing effect. 07:22 < waxwing> damn "weights" should be "waits" :) 08:23 < waxwing> i created a high priority label and attached it to #381 and #419 for now. 08:23 < waxwing> (just trying to manage the large list here) 08:23 < waxwing> belcher, also pls do go ahead and merge anything trivial as you wish (saying so because i was earlier saying please don't, but #359 is in now) 08:24 < waxwing> i guess #416 probably counts 08:25 < waxwing> i'm leaving comments on a few where i think it's fine but just needs rebase (usually that'll be trivial) 09:00 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 264 seconds] 11:15 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket 11:24 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Ping timeout: 268 seconds] 11:25 < belcher> oh cool the wallet service PR is merged(!) 11:26 < belcher> will do waxwing 11:26 < belcher> also could people please review and/or test #387 11:34 < waxwing> belcher, yeah i know the tumbler one is a big/important one. today i was just browsing through trying to get the smaller simpler stuff out of the way. 11:34 < waxwing> like i think we can do #419 right now, do you agree? 11:34 < belcher> yes 11:35 < belcher> i opened all the PRs in tabs and that one was just open 11:40 < belcher> #416 could also be merged? its fairly straightforward and in a non-important part of the codebase 11:50 < belcher> ill merge #419 in a sec 11:55 -!- MaxSan [~four@195.206.105.227] has joined #joinmarket 12:00 -!- MaxSan [~four@195.206.105.227] has quit [Ping timeout: 268 seconds] 12:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 12:00 -!- MaxSan [~four@109.202.107.10] has joined #joinmarket 12:02 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket 12:03 < waxwing> belcher, Yes #416, why not. i've tended to just ignore that stuff (because i can, if you see what i mean). and that one's trivial anyway from what i see. 12:06 -!- MaxSan [~four@109.202.107.10] has quit [Quit: Leaving.] 12:17 < belcher> merged 416 and 419 12:18 < belcher> ill merge 421, its clearly trivial and its been reviewed and tested 12:19 < belcher> iv fixed the conflict in 417, travis is still running but once its done i think ill merge it too 12:22 < belcher> ill fix 418, it adds code `if not self.wallet:` but self.wallet doesnt exist anymore, since the code is just added there was never a conflict 12:49 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 13:47 -!- Brielle89Conn [~Brielle89@ns334669.ip-5-196-64.eu] has joined #joinmarket 14:14 < waxwing> i hadn't really looked at 418 but no worries i'll just test it out now and have a quick read. 14:15 < waxwing> 394 may or may not still be relevant (i'm hoping not), i'll have to go over it tomorrow. and 395 was quite confusing, but wherever we left it, the new refactoring shouldn't affect it either way. 14:22 < waxwing> yep 418 looks fine and tests correct too, thanks (i also double checked private key export is working correct too in Qt after change, and it is. i forgot to check that before.) 14:25 < waxwing> yeah, that's a good and important improvement. the Qt app is nearly something fairly good now. 14:26 < waxwing> but people should report if they see any sluggish responsiveness in it, i think that could happen because of the polling loop, but it should be minimal if at all. 14:31 -!- fishguts [~fishguts@121-200-12-43.79c80c.syd.nbn.aussiebb.net] has quit [Ping timeout: 264 seconds] 14:37 -!- fishguts [~fishguts@121-200-12-43.79c80c.syd.nbn.aussiebb.net] has joined #joinmarket 16:53 < zfk> waxwing, thank you 16:54 < zfk> belcher_, thank you as well for responding earlier/yesterday 17:08 -!- CgRelayBot [~CgRelayBo@p54866FA8.dip0.t-ipconnect.de] has joined #joinmarket 17:10 -!- AgoraRelay [~jmrelayfn@p54866FA8.dip0.t-ipconnect.de] has joined #joinmarket 17:10 -!- CgRelayBot_ [~CgRelayBo@p5DE4A553.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds] 17:10 -!- AgoraRelay_ [~jmrelayfn@p5DE4A553.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds] 18:17 -!- Brielle89Conn [~Brielle89@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 276 seconds] 19:30 -!- CgRelayBot [~CgRelayBo@p54866FA8.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 19:31 -!- AgoraRelay [~jmrelayfn@p54866FA8.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds] 19:31 -!- CgRelayBot [~CgRelayBo@p54866D78.dip0.t-ipconnect.de] has joined #joinmarket 19:33 -!- AgoraRelay [~jmrelayfn@p54866D78.dip0.t-ipconnect.de] has joined #joinmarket 23:03 -!- fishguts [~fishguts@121-200-12-43.79c80c.syd.nbn.aussiebb.net] has quit [Ping timeout: 264 seconds] 23:03 -!- fishguts [~fishguts@121-200-12-43.79c80c.syd.nbn.aussiebb.net] has joined #joinmarket 23:14 -!- fishguts [~fishguts@121-200-12-43.79c80c.syd.nbn.aussiebb.net] has quit [Ping timeout: 264 seconds] 23:14 -!- fishguts [~fishguts@121-200-12-43.79c80c.syd.nbn.aussiebb.net] has joined #joinmarket 23:20 -!- fishguts [~fishguts@121-200-12-43.79c80c.syd.nbn.aussiebb.net] has quit [Ping timeout: 264 seconds] 23:50 -!- fishguts [~fishguts@121-200-12-43.79c80c.syd.nbn.aussiebb.net] has joined #joinmarket