--- Day changed Mon Nov 18 2019 02:07 < CgRelayBot> [cgan/Guest90317] Hello 04:18 -!- openoms [~quassel@185.174.156.219] has joined #joinmarket 06:38 -!- belcher_ [~user@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 06:40 -!- belcher_ [~user@unaffiliated/belcher] has joined #joinmarket 08:44 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 265 seconds] 08:47 -!- openoms [~quassel@185.174.156.219] has quit [Ping timeout: 240 seconds] 08:48 -!- sturles [~sturles@ulrik.uio.no] has joined #joinmarket 08:48 -!- sturles [~sturles@ulrik.uio.no] has quit [Changing host] 08:48 -!- sturles [~sturles@unaffiliated/sturles] has joined #joinmarket 08:49 < waxwing> really not sure about #441 , see my comment https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/450#issuecomment-555104336 08:49 < waxwing> it's not so much 'that's broken' as 'god that's a whole can of worms i'm going to have to check in great detail' 10:42 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 10:51 < belcher> waxwing maybe its best we revert it? not because its bad as you say but because its a lot of work and its not really in line with the joinmarket mission 10:54 < belcher> perhaps a less-work solution that still solves the issue of UX can be to have Qt be able to use btc/sat/whatever which it immediately converts to sats, but all the CLI stuff to use only sats 11:00 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 245 seconds] 11:43 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 11:47 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 246 seconds] 12:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket 12:06 < waxwing> i think honestly it might be better not to do it .. except a rationalisation and definition of amount formats does make sense. At least on CLI we have a fairly simple ruleset: btc amounts are all in sats, and any non-sat value implies a fraction. 12:07 < waxwing> violated that a bit in the GUI and used BTC amounts in the dialog box. 12:07 < waxwing> 'i think honestly ..' means i think i agree it might be better to revert. but not sure. 12:07 < waxwing> belcher, ^ 12:08 < belcher> i think i agree with you 12:10 < waxwing> right so changes only on the Qt layer. what we could do is keep the amounts.py code in btc (although i haven't really reviewed it yet, but let's say that's fine), but for now only use it in Qt. 12:11 < waxwing> or .. i dunno really whatever works, but yeah, we agree I think. 12:27 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 12:37 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 12:39 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket 12:40 -!- simon_ [~simon@93-238-145-85.ftth.glasoperator.nl] has quit [Ping timeout: 240 seconds] 12:40 < kristapsk> waxwing, probably I should look into tumbler stuff, if #441 breaks something, probably could be changed to require "btc" suffix for BTC amounts, in any case ability to copy/paste BTC amounts for sendpayment.py is very useful for me 12:42 < kristapsk> actually I once depositet 10x more BTC to one site as I wanted, just because of failure in my brain with converting BTC to sats :) 12:43 < waxwing> yeah that's always been a problem for bitcoin software. that's why so many of them ended up making a fiat currency feature. 12:43 < kristapsk> anyway, I don't see any problems with #450, if something needs to be changed, it's in #441 code 12:43 -!- simon_ [~simon@93-238-145-85.ftth.glasoperator.nl] has joined #joinmarket 12:44 < waxwing> like i've said i'm not really in a position to know, i just freak out when i see a change to something sensitive like that, specifically because what we had before was kind of weird/fragile. rationalising it makes sense, but it's a job, and it has to account for our weird "non-integer is fractional amount in mixdepth" rule. 12:44 < waxwing> and tbh i don't want to do that job right now. 12:46 < kristapsk> well, it's my code, I could look at / test tumbler stuff in coming days (was traveling last few days, returned from London last night, still recovering :) ) 13:04 -!- simon_ [~simon@93-238-145-85.ftth.glasoperator.nl] has quit [Quit: simon_] 13:05 -!- simon_ [~simon@93-238-145-85.ftth.glasoperator.nl] has joined #joinmarket 13:38 -!- openoms [~quassel@185.174.156.219] has joined #joinmarket 14:16 -!- joinmarketuser2 [~joinmarke@198.52.36.4] has joined #joinmarket 14:19 -!- joinmarketuser1 [~joinmarke@198.52.36.4] has quit [Ping timeout: 245 seconds] 15:08 -!- joinmarketuser2 [~joinmarke@198.52.36.4] has quit [Remote host closed the connection] 15:08 -!- joinmarketuser2 [~joinmarke@198.52.36.4] has joined #joinmarket 15:10 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 265 seconds] 15:10 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #joinmarket 15:10 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 16:20 -!- openoms [~quassel@185.174.156.219] has quit [Ping timeout: 252 seconds] 17:32 -!- ghost43_ is now known as ghost43 17:38 -!- AgoraRelay_ [~jmrelayfn@p5DE4A781.dip0.t-ipconnect.de] has joined #joinmarket 17:39 -!- CgRelayBot_ [~CgRelayBo@p5DE4A781.dip0.t-ipconnect.de] has joined #joinmarket 17:39 -!- CgRelayBot [~CgRelayBo@p5DE4A8D5.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 17:40 -!- AgoraRelay [~jmrelayfn@p5DE4A8D5.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds] 20:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 20:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket 21:31 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has quit [Ping timeout: 260 seconds] 21:49 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has joined #joinmarket 21:51 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 22:06 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 245 seconds] 23:53 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Ping timeout: 265 seconds]