--- Day changed Fri Nov 22 2019 01:05 -!- joinmarketuser [~joinmarke@198.52.36.4] has joined #joinmarket 01:06 -!- joinmarketuser1 [~joinmarke@198.52.36.4] has quit [Ping timeout: 246 seconds] 01:34 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket 01:46 < waxwing> GAit, just listening to your podcast, interesting thoughts, i did explicitly remove non-single key address types from scope (so Green is 'not included'), but re your comment about what value it might have there, i think the answer is, it invalidates the common input ownership heuristic 01:47 < waxwing> however, realistically this is not useful: because unfortunately snicker as described can't fit any standard payment pattern. three outputs. 01:47 < waxwing> so i dunno but i think we're kinda restricted (until taproot) to standard single key address types. i think. 02:57 -!- Giszmo [~leo@122-58-98-6-adsl.sparkbb.co.nz] has quit [Remote host closed the connection] 03:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 03:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #joinmarket 04:50 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Quit: Leaving] 06:04 < waxwing> belcher, i'm thinking that maybe #387 and #391 are the only two we should add and "bed down" before creating a new release. thoughts? 06:04 < waxwing> same question to others ofc 06:04 < waxwing> i feel like we have already added a ton of stuff recently and want to limit the scope. i'm also keen to propagate what we have added, into a release. 06:14 < waxwing> kristapsk, ping 06:31 < waxwing> kristapsk, see #438 06:39 < belcher> sounds fine with me waxwing 06:41 < waxwing> belcher, ok is #387 testable now? does it work for you? 06:42 < belcher> oh yes 06:42 < belcher> i think the only PR which was merged since i tested it was the exit codes PR 06:43 < belcher> sorry i probably shouldve commented as well as pushing a commit, it was testable the day or two after you messaged 06:47 < waxwing> i'm still hoping we can do #391 but like i mentioned the other day i didn't actually understand what travis was complaining about 06:47 < waxwing> takinbo ^ 06:51 < belcher> i wouldnt mind #444 but i accept the point about not adding too much especially when theres this shortage of reviewing 06:51 < belcher> i wonder if we can reduce the need of reviewing somehow, like making use of release candidates where evreything is tested at once instead of one-by-one for each PR 07:02 < waxwing> i think the biggest win would be automated E2E tests of top level functions (what the scripts do, what the GUI does). unfortunately we don't have that. 09:05 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 09:31 < kristapsk> waxwing, I would suggest also adding #448 in next release, as it's pretty simple and adds some protection against accidental address reuse in qt 09:32 < kristapsk> + and as #441 is merged, then #450 also would make sense (just makes more consistencies in log output) 09:32 < kristapsk> unless #441 is reverted, but I really don't see much point, answered you in comments in #450 (but maybe BTC/sat switching because of "." in string could be taken out, just force "btc" suffix) 09:34 < kristapsk> also about release process in general, maybe release branch could be created before release, so that it could be tested independently from master, and only bugfixes merged in, so that testing other features and merging could happen in parallel too 09:46 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds] 09:57 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 250 seconds] 11:54 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket 11:59 -!- avril [wha@unaffiliated/avril] has quit [Quit: later skater] 12:11 -!- avril [wha@cute.b.oy.hu] has joined #joinmarket 12:11 -!- avril [wha@cute.b.oy.hu] has quit [Changing host] 12:11 -!- avril [wha@unaffiliated/avril] has joined #joinmarket 13:32 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket 16:09 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 265 seconds] 16:19 -!- achow101 [~achow101@unaffiliated/achow101] has joined #joinmarket 16:22 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection] 17:41 -!- AgoraRelay [~jmrelayfn@p548665E1.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds] 17:42 -!- CgRelayBot [~CgRelayBo@p548665E1.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds] 17:54 -!- AgoraRelay [~jmrelayfn@p5DE4AA26.dip0.t-ipconnect.de] has joined #joinmarket 17:56 -!- CgRelayBot [~CgRelayBo@p5DE4AA26.dip0.t-ipconnect.de] has joined #joinmarket 18:53 -!- MaxSan [~four@103.254.153.99] has joined #joinmarket 19:01 -!- MaxSan [~four@103.254.153.99] has quit [Ping timeout: 276 seconds] 19:15 -!- MaxSan [~four@103.254.153.99] has joined #joinmarket 19:26 -!- reallll [~belcher@unaffiliated/belcher] has joined #joinmarket 19:29 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 19:42 -!- MaxSan [~four@103.254.153.99] has quit [Ping timeout: 276 seconds] 20:07 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Remote host closed the connection] 20:21 -!- MaxSan [~four@209.58.173.138] has joined #joinmarket 21:01 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket 22:22 -!- MaxSan [~four@209.58.173.138] has quit [Ping timeout: 252 seconds] 22:54 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 23:19 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 250 seconds] 23:51 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 23:58 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 245 seconds]