--- Day changed Sun Nov 24 2019 00:49 -!- MaxSan [~four@103.254.153.99] has joined #joinmarket 01:02 -!- MaxSan [~four@103.254.153.99] has quit [Ping timeout: 240 seconds] 01:17 -!- MaxSan [~four@103.254.153.99] has joined #joinmarket 01:26 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket 01:55 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #joinmarket 01:55 -!- minion_ [~chatzilla@206.189.130.245] has joined #joinmarket 01:56 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 02:17 -!- minion_ [~chatzilla@206.189.130.245] has quit [Remote host closed the connection] 02:18 -!- minion_ [~chatzilla@206.189.130.245] has joined #joinmarket 02:30 -!- minion_ [~chatzilla@206.189.130.245] has quit [Ping timeout: 240 seconds] 02:40 -!- MaxSan [~four@103.254.153.99] has quit [Ping timeout: 240 seconds] 02:45 -!- MaxSan [~four@103.254.153.99] has joined #joinmarket 04:12 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 250 seconds] 04:16 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 04:23 -!- MaxSan [~four@103.254.153.99] has quit [Ping timeout: 276 seconds] 04:37 -!- MaxSan [~four@103.254.153.99] has joined #joinmarket 05:10 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Quit: Leaving] 05:12 -!- minion_ [~chatzilla@114.253.249.182] has joined #joinmarket 05:16 -!- minion_ [~chatzilla@114.253.249.182] has quit [Ping timeout: 240 seconds] 06:27 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 250 seconds] 06:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 06:35 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket 06:51 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket 09:27 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 09:50 < waxwing> belcher, i haven't even looked at #445 . what's the situation? needs fixing now? 09:53 < belcher> hold on ill try to remember 09:53 < belcher> theres an annoying facet that in many places the code catches all Exceptions and doesnt print the stack trace or any other debug information, but thats something to fix for another day 09:54 < belcher> id guess the bug is still there 09:54 < waxwing> right 09:54 < belcher> although seed phrase extensions work fine on CLI so perhaps its not that urgent 09:54 < belcher> nobody noticed until now right 09:54 < waxwing> i've now marked 3 PRs as 'on hold' meaning they're specifically held up by something, and most relevant today: won't be in the release. 09:55 < waxwing> this is why i didn't want to add it tbh ... i can't find time to test it. sorry. 09:55 < waxwing> i know it's a good thing, really, don't misunderstand me. 09:55 < belcher> are we talking about the same issue? 445 is "Error when generating wallet with extension" 09:56 < waxwing> oh. well i was talking about the extension in general terms. 09:56 < waxwing> so i think so yeah. but basically you're saying it doesn't work in Qt when you enter it. 09:56 < belcher> yep 09:57 < waxwing> that's the best kind of bug, the one that refuses to let you actually do the thing :) 09:57 < belcher> which PR are you talking about testing? since 445 is an issue not a PR 09:57 < waxwing> my 17:55 message was distinct from my 17:54 message, was talking about testing mnemonic extensions. 09:57 < waxwing> which i uh basically have never done. maybe just a few times on CLI. 09:58 < belcher> got it 09:58 < waxwing> my 17:54 message was about me trying to herd the cats^H PRs before getting ready for release. 09:59 < CgRelayBot> [cgan/RedAcor] zxx221 You can ask anything about market in here 10:00 < belcher> dw about never trying it, its natural in open source that people generally work on stuff which interests them 10:00 < waxwing> ah. thanks RedAcor 10:00 < CgRelayBot> [cgan/belcher_] hello 10:00 < CgRelayBot> [cgan/RedAcor] You're welcome. 10:01 < CgRelayBot> [cgan/RedAcor] zxx221 wonders how it can use market. 10:01 < waxwing> belcher, well no. when things get added they need to be tested, a lot. the main issue is really the lack of end to end testing of top level functions. 10:01 < waxwing> zxx221 go to https://github.com/Joinmarket-Org/joinmarket-clientserver and read the instructions on that page, it will link to other documents as needed. 10:01 < CgRelayBot> [cgan/RedAcor] Hai belcher_ :) 10:04 < belcher> i think im getting my worldview on open source from an essay called The Cathedral and the Bazaar 10:04 < waxwing> so here's my suggestion (hoping we can make the release during the next week): merge #454 #453 and mark all others on hold. #453 is fairly minor but it does result in a failure for users loading a wallet file on a new instance. I could be persuaded to drop it, but it is simple. 10:05 < waxwing> or not 'mark on hold' if that's confusing, just don't merge. 10:05 < belcher> sounds good to me 10:05 < belcher> ill aim to review and test #453 asap 10:13 < waxwing> thanks, that'd be appreciated. it's pretty minor so shouldn't be trouble. 10:14 < waxwing> oh but that brings back to #445. so we need to fix that eh. i guess i'll start taking a look at that this evening. 10:14 < waxwing> because that's in the same class, i.e. an actual direct bug (and probably a simple one) 10:21 < belcher> #453 is very straightforward 10:21 < belcher> to read/review 10:22 < belcher> and a quick look at wallet_service.py shows that restart_callback behaves in that way that makes sense 10:23 < waxwing> yeah the annoyance with #453 is what i mentiond in the extra comment, i.e. the recovery case. i'm not sure we *ever* handled that properly in Qt. 10:24 < waxwing> i mean let's face it, we barely handle it in CLI! 10:24 < waxwing> it almost feels like that should be addressed at the base layer first. then the Qt could follow. at the moment a sequence of rescans may be needed in the worst case. 10:24 < waxwing> so can of worms, i thought,just don't get into it here, make sure a basic usage doesn't encounter the error. 10:26 < belcher> its definitely a tricky situation, one which EPS suffers from too 10:27 < belcher> the #444 PR could help in avoiding needing to do /multiple/ rescans 11:10 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Ping timeout: 276 seconds] 11:11 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket 11:25 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 250 seconds] 11:59 < waxwing> good point thanks. 11:59 < waxwing> will also need to quickly retest payjoin before release. it may need a minor edit or two after the refactoring. 11:59 < waxwing> another thing is any improvements in docs, if anyone has anything in the docs/ files linked from the readme that might need an edit or update, please do that, thanks. 12:15 -!- ghost43_ is now known as ghost43 12:16 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 12:29 < waxwing> since the #445 fix was just one line i pushed it. i don't think it's controversial since it now behaves as CLI (see '') 12:42 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has quit [Ping timeout: 240 seconds] 12:44 -!- takamatsu [~takamatsu@unaffiliated/takamatsu] has joined #joinmarket 12:44 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Ping timeout: 250 seconds] 13:00 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 13:41 < belcher> waxwing testing #438 on regtest is not possible because Load Wallet in regtest has a different behaviour where it asks for the testnet seed 13:41 < belcher> im waiting for my node to catch up and after that ill be able to test it 13:42 < belcher> maybe a better design is to have Load Wallet do the same thing but regtest adds a new menu item called something like Load Wallet From Hex Seed 13:55 < waxwing> we need to redesign all the test stuff so the test paths are the same as mainnet 13:55 < waxwing> yes you have to cheat basically change 'regtest' to 'jegtest' or something in two places :) 13:55 < waxwing> otherwise yeah can't test on regtest these Qt wallet features 13:55 < waxwing> belcher, ^ 13:58 < waxwing> belcher, since it's so annoying i'll let you know all the awkward steps i used to test it on regtest: 13:59 < waxwing> wipe regtest first. then run ygrunner just to get the blockchain up. 13:59 < waxwing> then do a python wallet-tool generate to make a regtest wallet with a name. 14:00 < waxwing> then you need to edit two checks, let me find them 14:00 < belcher> ok 14:01 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/scripts/joinmarket-qt.py#L1515 https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/blockchaininterface.py#L241 14:01 < waxwing> change both these checks so they don't cancel the behaviour in regtest. 14:02 < waxwing> oh but wait. *BEFORE* making those edits, shut down ygrunner, wipe the regtest (that's important!) and then restart ygrunner. 14:02 < waxwing> you have to do that to make it so the addresses aren't imported. but you also have to not have those edits or it won't start up. 14:03 < waxwing> then once it's up, make those edits. then start joinmarket-qt and try to load the created wallet file. 14:03 < waxwing> that should reproduce the error (without #453 of course) 14:03 < waxwing> oh i forgot after `wallet-tool generate` do a `wallet-tool display` to actually do the first run sync. 14:05 < waxwing> wait lol no that isn't needed is it :) 14:05 < waxwing> after you wipe it it doesn't matter what you did before 14:12 < belcher> i reproduced the bug 14:20 < belcher> good call with the edits, that was much faster than waiting for the mainnet node to catch up the last few days of blocks 14:21 < waxwing> yeah doing this on mainnet is annoying, because you have to mess with your wallet setup somehow 14:27 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has quit [Remote host closed the connection] 14:27 -!- johnonchain [~johnoncha@2001:41d0:fc63:9c00:2931:aec:9468:a5e7] has joined #joinmarket 14:27 < belcher> reviewed and tested 14:28 < belcher> commented on the PR about changing the commit message slightly 14:28 < waxwing> thanks 14:46 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket 14:46 -!- kristapsk_ is now known as kristapsk 15:31 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 2.6] 15:48 -!- MaxSan [~four@103.254.153.99] has quit [Quit: Leaving.] 16:50 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection] 17:39 -!- CgRelayBot [~CgRelayBo@p54866BC1.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds] 17:40 -!- AgoraRelay [~jmrelayfn@p54866BC1.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds] 17:51 -!- AgoraRelay [~jmrelayfn@p5DE4A117.dip0.t-ipconnect.de] has joined #joinmarket 17:52 -!- CgRelayBot [~CgRelayBo@p5DE4A117.dip0.t-ipconnect.de] has joined #joinmarket 19:02 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 276 seconds] 19:12 -!- achow101 [~achow101@unaffiliated/achow101] has joined #joinmarket 19:26 -!- reallll [~belcher@unaffiliated/belcher] has joined #joinmarket 19:29 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 19:31 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket 21:51 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket 21:52 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 260 seconds] 23:13 -!- decryp70 [~dcryp7@98.156.137.20] has joined #joinmarket 23:20 -!- decryp70 [~dcryp7@98.156.137.20] has quit [Read error: Connection reset by peer] 23:46 -!- reallll is now known as belcher