--- Day changed Mon Dec 02 2019
00:07 -!- reallll is now known as belcher     
02:56 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Ping timeout: 246 seconds]     
03:32 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket     
03:42 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection]     
03:48 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket     
03:49 -!- Netsplit *.net <-> *.split quits: nsh
03:55 -!- Netsplit over, joins: nsh
04:16 -!- MaxSan [~four@193.148.16.211] has quit [Ping timeout: 268 seconds]     
04:40 -!- MaxSan [~four@193.148.16.211] has joined #joinmarket     
05:29 < sturles> I just did a git pull and new setup og Joinmarket, and now yg-privacyenhanced.py have begun throwing this error: https://0bin.net/paste/pu+uSu7OatyuOsjm#T4ALHcMEAytARNn07TRtm0rGyKyXGkj6wYt76K7DRxt
05:30 < sturles> KeyError: 'txid' after listing transactions.
05:31 < belcher> some transactions returned from listtransactions dont have a txid? weird
05:31 < belcher> i guess that could be fixed by changing the line to:
05:31 < belcher> [x['txid'] for x in self.bci.list_transactions(100) if "txid" in x]
05:32 < belcher> i wonder how it ended up that your wallet has transactions with no txid
05:33 < sturles> It is account movement transactions.
05:34 < sturles> Moves from one account to another.
05:34 < belcher> ooh     
05:35 < sturles> Example: https://0bin.net/paste/fONRUvJTi-zNSLLn#Loy3WKImehz9LX8ly7FZ86UHi85HPKoYwlcnUJDpYRH
05:37 < belcher> well i can code and open a PR which i think fixes it, could you try running the PR after i open it
05:37 < sturles> Of course
05:40 < belcher> here we go https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/464
05:41 < belcher> i havent actually tried running the code :p, its a fairly trivial fix but lets see what the automated tests say
05:56 < belcher> the automated test passed, phew
05:57 < sturles> https://0bin.net/paste/0RGMXwlrVbt2LTRG#GYJbAnHOlWuaTmbICf4sve+eefmP17FWvlFQdE+7fPJ
06:01 < belcher> ty     
06:04 < sturles> Fixed using the same trick as in the second part of your pull request on line 195.
06:05 < belcher> i just pushed an update fixing it
06:08 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Ping timeout: 250 seconds]     
06:11 < sturles> The fix works.  Thanks!
06:12 < belcher> cool
06:13 < waxwing> sturles, belcher thanks
06:14 < waxwing> i guess it illustrates a couple of things, first how hard it is to test every possible scenario before release, and also i think a more useful observation; when we take in data structures from outside programs, have some kind of *generic* sanity check of structure so we don't forget stuff like this
06:14 < waxwing> forget or make the mistake of thinking "that can't happen", when it's easy to just check
06:15 < waxwing> it'd make sense perhaps to have a CoreRPCListTransactionsResponse structure (that is, either class or just dict, in python), and similar. would add quite a fair chunk of code though so it's arguable.
06:18 < belcher> could also have a rule that dont access json fields unless you first check they exist
06:20 < waxwing> i'll take a quick look and do a test or two and then we can merge it after a tACK. at first sight it looks fine.
06:24 < waxwing> good job picking up the awkward repetition at line 334 :)
06:32 < belcher> i searched for list_transactions everywhere it appeared
06:34 < waxwing> right :)
06:34 < waxwing> merged anyway, it works fine on mainnet and testnet, but as noted in comment, obviously it would not be trivial to actually test against this bug
06:34 < waxwing> perhaps sturles can report?
06:35 < waxwing> oh he already said, sorry lol
06:35 < sturles> :-)     
06:35 < waxwing> how old is old btw? not sure the answer to that question matters, just curious
06:36 < waxwing> i don't actually know what 'account movement transactions' are. or whatever it was called.
06:36 < sturles> 0.18 with deprecatedrpc=accounts
06:36 < waxwing> i see. but i suppose it is like, moving money between accounts in the same wallet?
06:36 < sturles> Yep.
07:14 -!- SourDoughB [965000000@2405:8100:8000:5ca1::176:3880] has joined #joinmarket     
07:25 < SourDoughB> Hi all. New JM user here running the yieldgenerator. I successfully funded addresses in the mixdepth 0 and had one coinjoin happening. Now in mixdepth 0 I have one funded deposit address + one “change out”  internal address, and both of those addresses have been combined into a new offer by the yieldgenerator. But there is also one internal
07:25 < SourDoughB> “cj-out” address in mixdepth 1 now, which doesn’t get included in the yieldgenerator offer. It has lots of confirmations and is above my mixing minimum settings. Is there any action I need to take to get it included (already tried restarting the yg) or does it get excluded for some reason?
07:27 < waxwing> SourDoughB, if you have 1btc in mixdepth 0 and 2btc in mixdepth 1, then the yg will announce an offer of e.g. 1.85 btc (randomised, but based on the '2' number, i.e. the largest amount in any one mixdepth)
07:27 < waxwing> it'll never make a coinjoin combining coins from different mixdepths (=accounts) because that could undo the privacy gain created by doing the coinjoin.
07:30 < SourDoughB> Ah, makes sense, thx :) So the yg can only make one offer at a time, and this offer is based on the largest amount I have in a mixdepth? So for my mixdepth 1 balance to get included in a coinjoin, it will need to get larger than my mixdepth 0 balance (through future coinjoins in mixdepth 0)?
07:38 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket     
07:38 < waxwing> in my scenario, you could still end up mixing with the coins in mixdepth 0 (that has a lower amount); it depends on the size that the other party requests. if it's less than 1btc, your yg may choose to use the smaller one. but it doesn't advertise in public anything other than a maximum and minimum.
07:40 < SourDoughB> Ahh, so the balance in my mixdepth1 is actually available for mixing, it just is not explicitly advertised publicly (it is included in the min-max range), right?
07:41 -!- SourDoughB [965000000@2405:8100:8000:5ca1::176:3880] has quit [Remote host closed the connection]     
07:44 < waxwing> right
09:43 -!- SourDoughB4 [965000000@2405:8100:8000:5ca1::157:82c9] has joined #joinmarket     
09:45 < SourDoughB4> Hi Waxwing, I got disconnected and couldn't reconnect for a while... I probably missed a reply after my last question. Would you mind to kindly copypaste it, please (if there was any reply)? :)
09:47 < waxwing> SourDoughB4, the only reply was 'right' :)
09:47 < SourDoughB4> ah lol, thanks :D
09:50 -!- SourDoughB4 [965000000@2405:8100:8000:5ca1::157:82c9] has quit [Remote host closed the connection]     
11:07 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 250 seconds]     
11:24 -!- SourDoughB [027ec820@2.126.200.32] has joined #joinmarket     
11:54 -!- |avril [wha@cute.b.oy.hu] has joined #joinmarket     
11:54 -!- stoner19_ [~stoner19@vmi221374.contaboserver.net] has joined #joinmarket     
11:54 -!- stoner19_ [~stoner19@vmi221374.contaboserver.net] has quit [Changing host]     
11:54 -!- stoner19_ [~stoner19@unaffiliated/stoner19] has joined #joinmarket     
12:01 -!- waxwing_ [~waxwing@193.29.57.116] has joined #joinmarket     
12:02 -!- Netsplit *.net <-> *.split quits: stoner19, avril, waxwing
12:07 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket     
13:06 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket     
13:07 -!- Zenton [~user@unaffiliated/vicenteh] has joined #joinmarket     
13:40 -!- waxwing_ is now known as waxwing     
13:40 -!- waxwing [~waxwing@193.29.57.116] has quit [Changing host]     
13:40 -!- waxwing [~waxwing@unaffiliated/waxwing] has joined #joinmarket     
15:07 -!- SourDoughB [027ec820@2.126.200.32] has quit [Remote host closed the connection]     
15:27 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Ping timeout: 250 seconds]     
15:40 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Ping timeout: 246 seconds]     
15:43 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket     
15:43 -!- stoner19_ is now known as stoner19     
15:51 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has joined #joinmarket     
17:20 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 252 seconds]     
17:29 -!- AgoraRelay [~jmrelayfn@p5DE4A293.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]     
17:30 -!- CgRelayBot [~CgRelayBo@p5DE4A293.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]     
17:42 -!- CgRelayBot [~CgRelayBo@p5DE4A8B5.dip0.t-ipconnect.de] has joined #joinmarket     
17:43 -!- AgoraRelay [~jmrelayfn@p5DE4A8B5.dip0.t-ipconnect.de] has joined #joinmarket     
18:07 -!- achow101 [~achow101@unaffiliated/achow101] has joined #joinmarket     
18:59 -!- dopplerg- [~dop@45.9.238.27] has quit [Ping timeout: 240 seconds]     
19:18 -!- dopplergange [~dop@31.169.121.17] has joined #joinmarket     
19:26 -!- reallll [~belcher@unaffiliated/belcher] has joined #joinmarket     
19:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]     
19:47 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 276 seconds]     
19:51 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #joinmarket     
19:51 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection]     
21:44 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket     
23:35 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Ping timeout: 250 seconds]     
23:44 -!- reallll is now known as belcher