--- Day changed Sun Dec 22 2019 00:54 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket 01:45 < belcher> zfk yes 01:46 < belcher> k3tan no, the 0.3btc it will be offered. the bot will announce 0.7btc but if a coinjoin offer comes in for say 0.15btc then the bot might use the 0.3btc mixdepth 01:50 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has quit [Ping timeout: 240 seconds] 01:57 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has joined #joinmarket 02:02 < AgoraRelay> [agora-irc/AlexCato1] k3tan, it always offers that maximum amount (or very close to it wtih yg-privacyenhanced) it can provide for a coinjoin. Since funds from different mix depths must never be combined in the same transaction (otherwise it could be linked), the maximum it can provide in your scenario after step 3 is 0.7 btc at that point in time 02:03 < AgoraRelay> [agora-irc/AlexCato1] but if another coinjoin takes place of, say, 0.6 btc after this, it would move those 0.6 btc from mixdepth 0 to 1 as well, having 0.9 btc available in mixdepth 1 after that. Then the amount offered would be 0.9 from then on 02:04 < AgoraRelay> [agora-irc/AlexCato1] zfk: yes, you can. But it's bad for privacy, only the taker/person who does the tumbling would do that in the overwhelming amonut of cases 02:13 < k3tan> thank you belcher and AgoraRelay for your clarification, appreciate your help. does that mean the joinmarket orderbook is probably higher than what is 'officially' stated? 02:13 < belcher> yes, the published offers are only a lower bound 02:13 < k3tan> thanks 02:14 < belcher> bech32 addresses arent that bad for privacy in tumbler, even though in the final coinjoin the destination is revealed because of all the previous coinjoins the source is unknown, so the link between source and destination should be hidden 02:15 < AgoraRelay> [agora-irc/AlexCato1] true, it's not 100% bad. But also depends: if you funded your JM wallet from a bech32 as well, then you're pretty much screwed 02:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 02:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 02:59 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has quit [Ping timeout: 240 seconds] 03:01 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has joined #joinmarket 03:52 < waxwing> AlexCato i don't think that even that is true, in the scenario where lots of people fund JM from bech32. 03:53 < waxwing> you're clearly worse off though 04:29 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has quit [Remote host closed the connection] 07:02 < takinbo> working on #391, i was able to resolve some of the issues with successfully building and running in travis 07:03 < takinbo> i did come across two issues though, the first affecting the tests in python 2; i have a fix for that and was wondering if I should make it part of my PR or submit a fresh PR for that. 07:04 < takinbo> they had to do with the jmclient blockchaininterface and the commontest.py module in jmclient 07:04 < takinbo> thoughts on merging the patch with my PR or creating a new PR for that? 07:05 < takinbo> also, has anyone ran the tests on bitcoin-core 0.19.0.1? test_tx_creation.py and test_wallet.py are failing for me, will create an issue for that. 07:06 < waxwing> i guess it depends if you think it's trivial and/or uncontroversial takinbo . but for me, either way is OK unless it's a really huge change. 07:06 < waxwing> oh i haven't tried that yet. thanks yes pls Issue that. 07:06 < takinbo> it's a rather small change; could send a patch for you to review independently if that's okay 07:08 < waxwing> takinbo, sure 07:08 < takinbo> https://ncry.pt/p/OjPn#TxFCMgJIEcUc4yAqjvQ0J5xqvMJvfOyIpkEWAPkKY0c 07:10 < takinbo> basically i needed to override the `import_addresses_if_needed` and `is_address_labeled` methods for the ElectrumWalletInterface as python2 wouldn't accept using abstract methods. 07:11 < belcher> maybe we could take away @Override to stop that? 07:12 < takinbo> belcher: that might work, i'll make that change and run the tests again 07:13 < takinbo> as for BitcoinCoreNoHistoryInterface, I needed to copy the definition for `grab_coins` and `tick_forward_chain` as it throws an exception: `TypeError: unbound method grab_coins() must be called with RegtestBitcoinCoreInterface instance as first argument (got BitcoinCoreNoHistoryInterface instance instead)` 07:14 < takinbo> i understand why it was done that way but python2 seems not to allow that, any suggestions on a better way to resolve it? 07:16 < belcher> those functions maybe dont belong in any BlockchainInterface, can they be made functions not in any class 07:16 < belcher> im just thinking, not sure if the above is a good idea yet 07:17 < belcher> they're only ever used in the automated tests, and automated tests only use regtest... but then BitcoinCoreNoHistoryInterface also came along which is tested too 07:19 < belcher> takinbo also, it might work to use super() instead 07:20 < belcher> wait no, super() doesnt work since RegtestBitcoinCoreInterface isnt a superclass of NoHistory 07:20 < takinbo> yeah 07:21 < takinbo> maybe monkey patch the method at run time so there's no need to define the method in the class? 07:21 < belcher> worth a try 07:21 < takinbo> okay 07:21 < belcher> those functions are only ever used in one test iirc 07:21 < takinbo> right 07:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 07:42 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 08:44 < takinbo> so i ended up refactoring the `grab_coins` and `tick_forward_chain` methods into a mixin that is used by both `BitcoinCoreNoHistoryInterface` and `RegtestBitcoinCoreInterface`. 08:56 < belcher> sounds good --- Log opened Sun Dec 22 09:34:29 2019 09:34 -!- gnusha [~gnusha@unaffiliated/kanzure/bot/gnusha] has joined #joinmarket 09:34 -!- Topic for #joinmarket: Welcome to JoinMarket: Increase Fungibility and Subsidise Your Fees | https://github.com/Joinmarket-Org/joinmarket-clientserver | @joinmarket r/joinmarket | Live View: https://joinmarket.me/ob | Latest release 0.6.1 | Also on ssl 6dvj6v5imhny3anf.onion:6697 09:34 -!- Topic set by waxwing [~waxwing@unaffiliated/waxwing] [Tue Dec 10 04:45:59 2019] 09:34 [Users #joinmarket] 09:34 [@ChanServ ] [ BlueMatt ] [ ghost43 ] [ luke-jr ] [ puddinpop ] [ technonerd] 09:34 [ achow101 ] [ CgRelayBot] [ gnusha ] [ M1 ] [ qubenix ] [ treyzania ] 09:34 [ adlai ] [ core ] [ harding ] [ midnight ] [ schmidty ] [ viasil ] 09:34 [ AgoraRelay] [ d3spwn ] [ johnhmay ] [ mr_burdell ] [ Sentineo ] [ vrana ] 09:34 [ Anduck ] [ dave_uy ] [ justinmoon_] [ nanotube ] [ slimcognito] [ waxwing ] 09:34 [ avril ] [ dopplerg- ] [ k3tan ] [ nkuttler ] [ so ] [ willcl_ark] 09:34 [ azizLIGHT ] [ emzy ] [ kanzure ] [ nothingmuch] [ sosthene ] [ windsok ] 09:34 [ belcher ] [ felix34 ] [ kristapsk ] [ nsh ] [ stoner19 ] [ Xeha ] 09:34 [ belcher_ ] [ fluffypony] [ Lightsword ] [ openoms ] [ sturles ] [ Zenton ] 09:34 [ berndj ] [ GAit ] [ lnostdal ] [ pigeons ] [ takinbo ] [ zfk ] 09:34 -!- Irssi: #joinmarket: Total of 60 nicks [1 ops, 0 halfops, 0 voices, 59 normal] 09:34 -!- Channel #joinmarket created Wed Dec 24 06:26:02 2014 09:34 -!- Irssi: Join to #joinmarket was synced in 1 secs 09:35 < kanzure> belcher: irc logs http://gnusha.org/joinmarket/ 09:35 < belcher> ty kanzure 09:36 -!- mode/#joinmarket [+o belcher] by ChanServ 09:36 -!- belcher changed the topic of #joinmarket to: Welcome to JoinMarket: Increase Fungibility and Subsidise Your Fees | https://github.com/Joinmarket-Org/joinmarket-clientserver | @joinmarket r/joinmarket | Logs: http://gnusha.org/joinmarket/ | Live View: https://joinmarket.me/ob | Latest release 0.6.1 | Also on ssl 6dvj6v5imhny3anf.onion:6697 09:37 -!- mode/#joinmarket [-o belcher] by belcher 09:39 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has quit [Ping timeout: 240 seconds] 09:40 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has joined #joinmarket 09:41 < technonerd> when moving a wallet to a new core instance --recoversync is all that is needed? 09:42 < belcher> what exactly do you mean by wallet? seed phrase / joinmarket's wallet.jmdat file / core's wallet.dat file / both 09:42 < belcher> if you can, the easiest thing to do is to transfer both core's wallet.dat and joinmarket's wallet.jmdat 09:42 < belcher> then you dont need --recoversync or any special flags 09:43 < belcher> technonerd ^ --- Log closed Sun Dec 22 09:44:03 2019 --- Log opened Sun Dec 22 09:44:03 2019 09:50 < kristapsk> hmmm, wanted to test #477, is there a standard way to specify custom path for bitcoind executable for tests? 09:53 < belcher> --btcroot=/your/path/to/bitcoin-0.18/bin according to my notes 09:54 < belcher> as a command line argument to pytest 10:01 < technonerd> ok that worked 10:14 < waxwing> kristapsk, belcher yep that's it, if you want to do ./test/run_tests.sh you have to edit the shell script to add that extra option to the pytest command 10:14 < waxwing> at least that's what i did 10:15 < waxwing> and thanks for looking at that, i haven't got round to it 10:16 < kristapsk> ok, will try 10:16 < waxwing> or just use pytest directly, that's what i usually do. run it from the joinmarket-clientserver/ root dir 10:17 < waxwing> pretty sure it's in TESTING.md ? i did update it a bit recently. 10:18 < waxwing> oh, actually you were the last to update it :) 10:20 < kristapsk> I have a plan to update TESTING.md with stuff from old wiki and other stuff someday 10:20 < waxwing> belcher, so in the update TODO.md thread, are you basically saying that fidelity bonds could address other stuff than just issue 693, i.e. other possible sybil attacks? 10:21 < waxwing> at first i thought you were saying 693 is not a sybil attack and couldn't see what you meant, but if that ^ then yeah, makes sense. 10:22 < belcher> the way i see it, ... yes 10:22 < belcher> 693 helps make sybil attacks cheaper 10:22 < belcher> someone might use 693 because they want to earn more coinjoin fees, not because they want to sybil attack and spy on people 10:23 < belcher> but this is all semantics i guess... though i personally found the fidelity bonds idea more exciting for solving sybil attacks rather than 693, even though it solves both 10:23 < waxwing> ok so there's a distinction: in my head a sybil attack is anything that uses the fact that identities are cheap to create; it doesn't specify the *goal* of the attack. 10:23 < waxwing> it sounds like you see sybil attacks as specifically only spying attacks? but i don't think that's right. 10:23 < belcher> ooh yes you're right 10:24 < belcher> hmm 10:24 < waxwing> right so how i see it is: on taker side we have an anti-sybil mechanism; on maker side we don't really and so we have issue693 describing that and it is a sybil attack problem specifically (mostly? entirely?) 10:25 < belcher> the way i saw it 693 is about when someone can run multiple ygen bots using the /same/ wallet, so then its literally the same coins being offered 10:31 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has quit [Remote host closed the connection] 10:36 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has joined #joinmarket 11:57 < waxwing> belcher, yes i don't think there's any disagreement about what it is, concretely. but it is a sybil attack, right? 11:58 < belcher> yeah 12:01 < waxwing> ok; do you think this line should be changed? seems like it's still correct even if 693 is only a subset of what fidelity bonds would address? 12:01 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/474/files#diff-e02f7b5eb279990ed19ab57010bb36f6R51 12:09 < belcher> waxwing: i dont think it needs to be changed 13:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 14:10 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket 14:36 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection] 15:13 -!- slivera [slivera@gateway/vpn/privateinternetaccess/slivera] has joined #joinmarket 15:44 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 16:00 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket 16:03 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 260 seconds] 16:26 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 17:17 -!- CgRelayBot [~CgRelayBo@p5DE4AA5E.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds] 17:18 -!- AgoraRelay [~jmrelayfn@p5DE4AA5E.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds] 17:29 -!- CgRelayBot [~CgRelayBo@p5DE4AA1A.dip0.t-ipconnect.de] has joined #joinmarket 17:32 -!- AgoraRelay [~jmrelayfn@p5DE4AA1A.dip0.t-ipconnect.de] has joined #joinmarket 18:16 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 260 seconds] 18:20 -!- achow101 [~achow101@unaffiliated/achow101] has joined #joinmarket 18:50 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 265 seconds] 19:03 -!- achow101 [~achow101@unaffiliated/achow101] has joined #joinmarket 20:26 -!- viasil [~viasil@95.174.67.204] has quit [Ping timeout: 260 seconds] 20:27 -!- viasil [~viasil@95.174.67.204] has joined #joinmarket 21:24 -!- viasil [~viasil@95.174.67.204] has quit [Ping timeout: 260 seconds] 21:25 -!- viasil [~viasil@95.174.67.204] has joined #joinmarket 21:54 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has quit [Quit: WeeChat 2.6] --- Log closed Mon Dec 23 00:00:47 2019