--- Log opened Sat May 09 00:00:16 2020
01:44 -!- azizLIGHT [~azizLIGHT@unaffiliated/azizlight] has quit [Ping timeout: 240 seconds]
02:07 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket
02:30 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer]
02:50 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has quit [Remote host closed the connection]
02:53 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has joined #joinmarket
04:39 < waxwing> belcher, i'm curious, i've always considered that comment sections that are `#` prefixed should be `# comment` not `#comment`, it looks like you don't?
04:45 < belcher> waxwing i never really thought about tbh
04:48 < waxwing> nbd
05:24 < kristapsk> PEP 8 says it should be "# comment" (with single space)
05:24 < belcher> didnt know that, ty
05:35 < belcher> waxwing iv written some notes in the commit messages of fidelity bond wallets which might help a bit with understanding why i wrote the code that way
05:42 < belcher> although even then those messages could be further elaborated, i think later ill add some of my replies in the PR thread into those messages
05:42 < belcher> they can be really useful down the line when using git blame and later modifying that code
06:03 < kristapsk> anyone plans to do some more testing / review on #567 or have any concerns or I can just merge it?
06:07 < belcher> kristapsk it looks good to me, id say merge it
06:15 < kristapsk> I think I will try to get back on #530 now, there are refactorization in single send dialog code, which would be useful for any changes to it, including payjoin support in GUI
06:37 -!- fiatjaf [~fiatjaf@2804:7f2:2a84:199d:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 256 seconds]
06:38 < belcher> i think #466 could be merged as well?
06:42 < waxwing> ok i agree
06:42 < belcher> ill do that
06:45 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
06:57 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #joinmarket
07:41 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Quit: Leaving]
07:41 < belcher> i just noticed we're at commit 1000 in joinmarket-clientserver
07:49 < waxwing> cool :) kinda cheated by using merges but still
08:20 -!- rdymac [uid31665@gateway/web/irccloud.com/x-ywpcrjvtkpcqzrzp] has joined #joinmarket
08:23 -!- fiatjaf [~fiatjaf@2804:7f2:2a81:6c39:ea40:f2ff:fe85:d2dc] has joined #joinmarket
08:23 < waxwing> belcher, this is a very generic comment but: this idea of making a re-interpretation "priv is actually pub here" seems quite dangerous.
08:24 < waxwing> i'm not saying it can't be done right but caution would tend to dictate that it shouldn't be done, because there is the chance of a fuckup that could have a lot worse effect than a usual fuckup.
08:50 < kristapsk> waxwing, #466 was waiting for your reply on my comment :)
08:53 < waxwing> kristapsk, yeah. you asked if i insist, i didn't. anyway lost the thread a long time ago, but i re-read the patch today and it looks fine, as-is.
10:11 < belcher> waxwing you're right
10:11 < belcher> i wonder if its worth renaming all the functions and variables
10:12 < belcher> _get_script_from_priv() -> _get_script_from_key()
10:12 < belcher> then key could be either pub or priv
11:07 < waxwing> belcher yeah maybe ... it does seem like a lot of hassle though, i admit.
11:08 < belcher> renaming loads of stuff isnt that bad actually, grep really helps
11:08 < belcher> im wondering if there are any downsides
11:08 < belcher> if people can still confuse "key" with something... probably not
11:34 -!- MaxSan [~four@46.183.220.203] has left #joinmarket []
13:29 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has quit [Quit: ZNC]
13:30 -!- Lightsword [~Lightswor@2604:a880:1:20::1d3:9001] has joined #joinmarket
13:52 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Ping timeout: 272 seconds]
13:52 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket
14:19 -!- belcher [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer]
14:20 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket
14:57 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
15:35 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Remote host closed the connection]
15:35 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
17:24 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
17:37 -!- HackRelay [~jmrelayha@p5DE4AFD2.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
17:37 -!- DSRelBot [~DSRelBot@p5DE4AFD2.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
17:44 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket
17:50 -!- HackRelay [~jmrelayha@p54866A4A.dip0.t-ipconnect.de] has joined #joinmarket
17:54 -!- DSRelBot [~DSRelBot@p54866A4A.dip0.t-ipconnect.de] has joined #joinmarket
22:16 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has quit [Ping timeout: 240 seconds]
22:18 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has joined #joinmarket
23:41 -!- Pasha [~Cory@071-013-023-252.res.spectrum.com] has joined #joinmarket
23:57 -!- Pasha [~Cory@071-013-023-252.res.spectrum.com] has quit []
--- Log closed Sun May 10 00:00:16 2020