--- Log opened Sun May 10 00:00:16 2020
00:14 -!- Pasha [~Cory@071-013-023-252.res.spectrum.com] has joined #joinmarket
03:05 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket
03:28 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer]
03:29 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
03:32 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer]
04:59 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has quit [Remote host closed the connection]
05:00 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has joined #joinmarket
05:12 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has quit [Ping timeout: 240 seconds]
05:14 -!- sosthene [~sosthene@gateway/tor-sasl/sosthene] has joined #joinmarket
07:45 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
07:45 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket
08:07 -!- bece [4182174b@65-130-23-75.slkc.qwest.net] has joined #joinmarket
08:14 < waxwing> belcher, think i've mostly finished the initial read-through review. i'll now do testing, first test all the most important basic functions without the new wallet types and then after a little testing of those wallet types.
08:15 < belcher> ok
08:23 < belcher> i will make a slight edit because of a comment you had about sync_burner_outputs() but it shouldnt change much
08:23 < belcher> i think
08:28 -!- MaxSan [~four@185.156.175.171] has joined #joinmarket
08:29 < belcher> btw it seems the certificate of joinmarket.me is expired
08:29 < belcher> oh it expired today
08:33 < waxwing> oh? damn i usually catch it in time.
08:33 < waxwing> will get on it.
08:36 < waxwing> belcher, can you check it's working now? should be
08:36 < belcher> yes it is
08:36 < belcher> 8th august 2020 is new expirey
08:37 < waxwing> heads up on test errors if you didn't see it. i'm getting on with generic functionality tests meanwhile
08:37 < belcher> i saw, starting up my tests now
09:03 < belcher> waxwing fixed the failing tests, still working on fixing the limited-to-6-burn-scripts problem
09:24 -!- M1 [~Michail@michail.com] has quit [Remote host closed the connection]
09:25 -!- M1 [~Michail@michail.com] has joined #joinmarket
09:55 -!- M1 [~Michail@michail.com] has quit [Ping timeout: 256 seconds]
09:55 -!- M1 [~Michail@michail.com] has joined #joinmarket
09:58 -!- bece [4182174b@65-130-23-75.slkc.qwest.net] has quit [Remote host closed the connection]
10:31 -!- jackinthefox [~user@c-66-229-163-226.hsd1.fl.comcast.net] has joined #joinmarket
10:35 -!- jackinthefox [~user@c-66-229-163-226.hsd1.fl.comcast.net] has quit [Client Quit]
10:37 -!- jackinthefox [~user@c-66-229-163-226.hsd1.fl.comcast.net] has joined #joinmarket
10:38 < jackinthefox> hey guys stupid question. how do i figure out my counterparty id
10:50 -!- jackinthefox [~user@c-66-229-163-226.hsd1.fl.comcast.net] has quit [Read error: Connection reset by peer]
10:50 -!- jackinthefox [~user@c-66-229-163-226.hsd1.fl.comcast.net] has joined #joinmarket
10:55 -!- jackinthefox [~user@c-66-229-163-226.hsd1.fl.comcast.net] has quit [Client Quit]
11:00 < belcher> made another comment waxwing, the limited-to-6-burn-scripts actually isnt a problem, it just looks a bit odd because burn outputs are a bit odd (you can only sync them by scanning in recoversync mode)
11:08 -!- jackinthefox [~user@45.152.182.133] has joined #joinmarket
11:51 -!- jackinthefox [~user@45.152.182.133] has quit [Quit: Leaving]
13:32 < waxwing> belcher, i'm still getting the first 2 of the 4 errors after updating to latest on #544
13:33 < waxwing> i'm on 4990015
13:52 -!- belcher [~belcher@unaffiliated/belcher] has quit [Remote host closed the connection]
14:04 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket
14:09 < waxwing> belcher, independent Q/point. to understand the burner thing, basically you're storing everything in the wallet file, including the raw tx itself. so after an initial recoversync with a gap limit as high as needed, in future the burn outputs are displayed directly from the JM wallet contents.
14:09 < waxwing> is that right?
14:09 < belcher> yep
14:10 < waxwing> thanks
14:10 < belcher> unfortunately i only fixed 2 of those errors, derp, didnt realize there were 4
14:10 < belcher> i read your comment too quickly, fix incoming hopefully
14:34 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
14:38 < belcher> pushed the fix waxwing 
14:38 < belcher> hold on, in your comment you talk about 3 errors but here on irc you said 4
14:39 < belcher> well i fixed all the errors in test_tx_creation.py and test_wallet.py, and it looks like only those failed
14:39 < waxwing> belcher, no 4 is right
14:39 < waxwing> i'll try it and report back
14:40 < waxwing> the first one was in the serialization test in jmbitcoin though?
14:40 < waxwing> jmbitcoin/test/test_btc_formatting.py:57: AssertionError
14:40 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/544#issuecomment-626345596
14:41 < waxwing> yep that one's still failing it seems
14:41 < belcher> right
14:42 < waxwing> if you run the tests as per testing.md these things should show up right?
14:42 < waxwing> i mean using pytest (although i think you can also use the run_tests.sh wrapper but i don't )
14:43 < belcher> i think i never got some of them to work so i just ran the files one by one
14:43 < belcher> then again i gave up running them all months ago, maybe they'll work again now
14:43 < waxwing> yes we should definitely fix that
14:43 < waxwing> problems on travis are one thing, but you need to be able to do it locally at least
14:44 < waxwing> i do remember the HDD related stuff. but we should find a way round it i guess.
14:44 < waxwing> or maybe, yeah, it's already fixed.
15:06 < belcher> so i just got this error https://0bin.net/paste/CtmEG1PSw4SImVyI#KoafqnLdL5XyUKIUB7yjj5-9RI9XlOb7ZDWAEsnOHox
15:06 < belcher> actual error rather than test failing
15:07 < belcher> im going to push my fix anyway, because it works
15:07 < belcher> but if that error makes any sense to you let me know, it seems to fail when calling `bitcoin-cli stop`
15:09 < belcher> fix for test_btc_formatting.py is pushed
15:10 < waxwing> i don't use `python3 -m pytest` i use just `pytest` fwiw
15:11 < belcher> i know, pytest and pytest3 dont work for me
15:11 < belcher> weirdly, pytest3 used to work a few weeks ago and then one day just stopped
15:11 < belcher> im pretty sure i didnt update or install any packages either *shrug*
15:12 < belcher> i ran the whole test suite as in testing.md it will be interesting to see how that goes
15:12 < waxwing> hmm i wonder if there's something going on here. could even affect travis.
15:12 < waxwing> i noticed i have different versions of basically everything:
15:12 < waxwing> platform linux -- Python 3.6.7, pytest-5.2.2, py-1.8.0, pluggy-0.13.0
15:20 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Quit: Leaving]
15:34 -!- Wylatend [~Logiciant@82.102.24.131] has joined #joinmarket
16:05 -!- Matterlend [~Logiciant@82.102.24.131] has joined #joinmarket
16:08 -!- Wylatend [~Logiciant@82.102.24.131] has quit [Ping timeout: 256 seconds]
17:37 -!- HackRelay [~jmrelayha@p54866A4A.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
17:37 -!- DSRelBot [~DSRelBot@p54866A4A.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
17:50 -!- HackRelay [~jmrelayha@p5DE4A390.dip0.t-ipconnect.de] has joined #joinmarket
17:54 -!- DSRelBot [~DSRelBot@p5DE4A390.dip0.t-ipconnect.de] has joined #joinmarket
18:08 -!- MaxSan [~four@185.156.175.171] has quit [Ping timeout: 246 seconds]
21:25 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Remote host closed the connection]
21:26 -!- achow101 [~achow101@unaffiliated/achow101] has joined #joinmarket
21:42 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Remote host closed the connection]
21:43 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
22:33 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Ping timeout: 256 seconds]
22:35 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket
22:39 -!- viasil [~nobody@134.19.189.124] has quit [Ping timeout: 246 seconds]
22:44 -!- viasil [~nobody@134.19.189.124] has joined #joinmarket
23:18 -!- EvanitoC [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
23:20 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Ping timeout: 260 seconds]
--- Log closed Mon May 11 00:00:17 2020