--- Log opened Thu Jun 11 00:00:47 2020
00:02 -!- windsok [~windsok@unaffiliated/windsok] has quit [Ping timeout: 256 seconds]
00:05 -!- windsok [~windsok@rarepepe.cash] has joined #joinmarket
00:05 -!- windsok [~windsok@rarepepe.cash] has quit [Changing host]
00:05 -!- windsok [~windsok@unaffiliated/windsok] has joined #joinmarket
00:22 -!- slivera [~slivera@103.231.88.10] has joined #joinmarket
00:51 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket
01:20 -!- Kareem28Purdy [~Kareem28P@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds]
01:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
01:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket
01:42 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Quit: Leaving]
01:43 -!- windsok [~windsok@unaffiliated/windsok] has quit [Ping timeout: 272 seconds]
01:44 -!- windsok [~windsok@rarepepe.cash] has joined #joinmarket
01:44 -!- windsok [~windsok@rarepepe.cash] has quit [Changing host]
01:44 -!- windsok [~windsok@unaffiliated/windsok] has joined #joinmarket
02:03 -!- rdymac [uid31665@gateway/web/irccloud.com/x-gruboaogajtczksp] has joined #joinmarket
02:14 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer]
02:25 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket
03:06 -!- Rhianna64Luettge [~Rhianna64@static.57.1.216.95.clients.your-server.de] has joined #joinmarket
04:06 -!- rdymac [uid31665@gateway/web/irccloud.com/x-gruboaogajtczksp] has quit [Quit: Connection closed for inactivity]
04:32 -!- Rhianna64Luettge [~Rhianna64@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 264 seconds]
04:58 -!- belcher [~belcher@unaffiliated/belcher] has joined #joinmarket
05:32 -!- schmidty [sid297174@gateway/web/irccloud.com/x-nngxwkzqbkdnzwpw] has quit [Read error: Connection reset by peer]
05:33 -!- schmidty [sid297174@gateway/web/irccloud.com/x-jmabqekawstlkbtw] has joined #joinmarket
06:01 < belcher> i will review #536 now (python-bitcointx backend for jmbitcoin)
06:49 -!- slivera [~slivera@103.231.88.10] has quit [Remote host closed the connection]
07:57 -!- fiatjaf1 [~fiatjaf@2804:7f2:2a84:fb44:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 260 seconds]
07:57 -!- fiatjaf1 [~fiatjaf@179.187.182.70.dynamic.adsl.gvt.net.br] has joined #joinmarket
08:22 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 272 seconds]
08:29 < waxwing> belcher, thanks
08:30 < waxwing> so i think it's time to freeze master after #585 is merged for building the 0.6.3 in say a week or so
08:33 < belcher> will #536 be included?
08:34 < waxwing> no, if you remember the idea was 0.6.3 would be the last py3.5 supporting release
08:34 < waxwing> and 0.7.0 is going to be the new stuff
08:35 < waxwing> there's some discussion in that thread, let me dig it out for you
08:37 < belcher> ah, yes i remember now
08:37 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/560#issuecomment-626155919
08:37 < waxwing> it's in the wrong thread but yeah
08:38 < waxwing> the payjoin bip is mired in endless discussions but that doesn't really affect anything here. the python-bitcointx version update has been tagged so i expect dmitry to release it fairly soon, so that won't be a hold up either.
08:47 < waxwing> was reading that stuff about taint by nopara on the mailing list and a thought occurred to me, if 1 in 1 out gets marked as self-transfer by chainalysis, does that mean anyone can attach their cluster to anyone they feel like by sending them some money? :)
08:47 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #joinmarket
08:48 < waxwing> i mean if it's dust i guess the software might treat it as irrelevant but maybe it's worth sending some "white" address $100 or whatever, especially if your coins are "unclean" and you really don't like them :)
08:49 < belcher> waxwing regarding 1-to-1, yes it seems that would be an easy heuristic to break
08:50 < belcher> a surprisingly high number of donations coming to this project are actually 1-to-1 txes
08:51 < belcher> maybe not so surprising, it might make sense because the actual value of a donation can be anything and people presumably choose to spend the whole coin to save miner fees
08:57 < harding> If onchain transactions ever get frequently used to pay recurring bills, that could be an interesting technique to promote.  E.g., when I pay my recurring bills in fiat, I usually round up to the nearest $10 or $100, which gets credited towards my next month's bill.  It'd be interesting if you could tell your wallet that a similar situation applied and it could try to generate changeless transactions with up to a ~25% overpayment.
09:01 < waxwing> lightning channel opens (or top ups with on-off chain swaps) can/will also have the advantage of not caring much about denomination.
09:01 < waxwing> i guess more top ups than opens, but in principle.
09:02 < waxwing> (to be fair about what i said above: i have no reason to believe chainalysis firms are flagging 1-1 transfers as co-owned, and i'd guess they aren't)
09:50 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Quit: Leaving]
09:55 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
10:06 -!- Floofie [~phl00fie@2601:18f:881:5e80:9d28:dd31:ca62:c0d3] has joined #joinmarket
10:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
10:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #joinmarket
10:44 -!- Floofie [~phl00fie@2601:18f:881:5e80:9d28:dd31:ca62:c0d3] has quit [Quit: Leaving.]
11:59 -!- rdymac [uid31665@gateway/web/irccloud.com/x-kfsbtdfadmizetdu] has joined #joinmarket
12:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
12:09 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #joinmarket
13:06 -!- MaxSan [~four@185.156.175.171] has quit [Ping timeout: 246 seconds]
13:45 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Remote host closed the connection]
14:36 < waxwing> belcher, about your summary comments, where you're listing what the PR includes, it's possible (likely) that you didn't see this message because github hides chunks of conversations when they get very long: https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/536#issuecomment-623349586
14:37 < belcher> oh yeah i saw that
14:37 < belcher> my summary was notes to myself, which i then decided to just put as a comment
14:38 < waxwing> ok np. thanks. no issue with the name changes, just looking at that weird regtest thing. i've forgotten what it was about, now.
14:39 < belcher> i bet i know why the tests wont fail, which is that p2sh testnet and p2sh regtest is the same vbyte
14:40 < waxwing> yeah but i guess it was to do with bcrt hrp
14:40 < waxwing> which i've always found weird
14:41 < waxwing> umm there i go again, i think that stands for 'human readable prefix' but i blame bip173 :)
14:41 < belcher> i thought "human readable part" :p
14:41 < waxwing> :)
14:41 < belcher> prefix is probably more likely
14:41 < belcher> thats the great thing about acronyms :p
15:58 < waxwing> belcher, ok so i understand what the issue is with that regtest address thing, but what *should* happen in case of bitcoin core no history interface, for regtest?
15:58 < waxwing> i remember it was complicated
15:59 < belcher> not sure what you mean, what should happen is that the test passes
15:59 < waxwing> right now the test just does create_wallet_for_sync without specifying wallet_cls , so it just uses default SegwitLegacyWallet so ofc no issue arises
15:59 < waxwing> the issue is at the intersection of (a)no history sync and (b) regtest and (c) bech32
15:59 < belcher> the test uses regtest
15:59 < belcher> yes
15:59 < waxwing> only when all 3 apply is there a problem
15:59 < belcher> yep, and the test doesnt use bech32 so it doesnt fail
16:00 < belcher> so maybe nothing needs to be done?
16:00 < waxwing> well maybe .. should we not perhaps have no-history get tested against SegwitWallet too?
16:01 < waxwing> can't see it as crucial, but .. it's kinda weird that overall this doesn't work simply.
16:01 < belcher> yep thats an option, have the test use bech32 as well
16:02 < waxwing> what i was trying to ask is how the logic work when you fixed this up originally
16:02 < belcher> and then the TODO in the PR has to be fixed
16:02 < waxwing> you remember you had to slightly change the logic of how RegtestBitcoinCoreInterface worked
16:02 < waxwing> oh yeah it became a mixin
16:02 < belcher> when i wrote it i dont think it ever tested bech32 addresses
16:02 < waxwing> whatever it is, i should be able to apply the same logic in that check in configure.py to decide which select-chain-params to use
16:02 -!- slivera [~slivera@103.231.88.26] has joined #joinmarket
16:07 < waxwing> ok, is it just that when you made that change, it became a thing to use `network=regtest` in the config? i have a feeling i have just ignored that in all my test setups.
16:08 < belcher> i dont remember
16:08 < belcher> i remember there being some weirdness around that, because testnet and regtest are the same in some cases
16:08 < belcher> reading the PR now
16:09 < waxwing> yeah it's pretty damn confusing. i'll just have the setup of that test fix network to 'regtest', then i can add SegwitWallet as a second case in the test.
16:09 < waxwing> the one place i think having `network=regtest` might screw up the tests is the irc channel name fixes itself on `-test` if get_network()=='testnet'
16:10 < waxwing> not sure want to get into the can of worms. all of this came out of the fact that regtest was originally completely transparently testnet and then was not.
16:11 < belcher> according to the PR regtest network existed before
16:11 < belcher>         netmap = {'main': 'mainnet', 'test': 'testnet', 'regtest': 'regtest'}
16:11 < belcher> is a line that existed before
16:11 < waxwing> i see, i don't remember a usage. all the tests are on a config with network='testnet'.
16:11 < belcher> oh wait i misunderstood, the keys of that dict come from getblockchaininfo, not from the config file
16:11 < waxwing> oh, right, makes sense.
16:12 < belcher> relevant conversation: https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/444/files#r356111514
16:13 < belcher> so according to that the only possible options for network are mainnet and testnet
16:13 -!- viasil_ [~nobody@37.120.141.36] has quit [Ping timeout: 264 seconds]
16:19 < waxwing> i think things actually changed in #536 ... the usage of 'network' in the BitcoinCoreInterface constructor seems to be only a sanity check; network (or get_network()) is used in config to set other stuff up (addresses, irc channels), but no longer to set vbyte
16:19 -!- viasil_ [~nobody@37.120.141.36] has joined #joinmarket
16:20 < waxwing> so with 'regtest', the sanity check would pass, it would allow correct select_chain_params() call (which is what replaced the manual vbyte etc. settings).
16:20 < waxwing> just the irc channel thing is left to be corrected.
16:22 < waxwing> oh i'm wrong, those functions are still there. but looking at references, they're not used any more (except in a test).
16:24 < waxwing> (i mean these functions: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/e9367fd755bfbb94c5bb1b73a07a2550536b942c/jmclient/jmclient/configure.py#L370-L375 )
16:24 < belcher> ah
16:24 < waxwing> yeah i just forgot to delete them
16:26 < waxwing> oh i also need to remove the VBYTE methods in cryptoengine. they are no longer used, it's the same thing.
16:27 < waxwing> ugh, no that's false, wif_to_privkey
17:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
17:58 -!- fiatjaf1 [~fiatjaf@179.187.182.70.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 256 seconds]
17:58 -!- HackRelay [~jmrelayha@p54866e6d.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
17:59 -!- DSRelBot [~DSRelBot@p54866e6d.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
18:10 -!- HackRelay [~jmrelayha@p54866d49.dip0.t-ipconnect.de] has joined #joinmarket
18:10 -!- DSRelBot [~DSRelBot@p54866d49.dip0.t-ipconnect.de] has joined #joinmarket
18:31 -!- fiatjaf1 [~fiatjaf@2804:7f2:2a84:fb44:ea40:f2ff:fe85:d2dc] has joined #joinmarket
21:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
21:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket
23:56 -!- rdymac [uid31665@gateway/web/irccloud.com/x-kfsbtdfadmizetdu] has quit [Quit: Connection closed for inactivity]
--- Log closed Fri Jun 12 00:00:47 2020