--- Log opened Thu Jun 25 00:00:00 2020
00:38 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 272 seconds]
00:47 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #joinmarket
00:57 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 244 seconds]
01:06 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket
01:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
01:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #joinmarket
01:48 -!- nixbitcoin [~nixbitcoi@gateway/tor-sasl/nixbitcoin] has joined #joinmarket
01:56 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #joinmarket
02:28 -!- adlai [~adlai@unaffiliated/adlai] has joined #joinmarket
03:02 < waxwing> is anyone else not getting github emails on PRs/issues etc?
03:02 < waxwing> i wonder if it was connected to the UI change?
03:03  * adlai tried to unwatch all issues and PRs that did not directly concern himself; perhaps github changed their defaults to a similar policy?
03:03 -!- Dario2Spinka [~Dario2Spi@static.57.1.216.95.clients.your-server.de] has joined #joinmarket
03:04 < waxwing> yeah but I think one option is to get notified on all conv threads in a particular repo, at least i'm sure i had that for JMCS
03:05 < waxwing> but i'm not 100% sure what's going on, i might also have lost pings on PR threads on other repos, i'll have to check. could be me/my mail provider.
03:06 < darosior> waxwing: fwiw all good for me (other repos than JM though)
03:09 -!- Dario2Spinka [~Dario2Spi@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds]
03:30 -!- EvanitoC [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer]
03:51 -!- reallll [~belcher@unaffiliated/belcher] has joined #joinmarket
03:55 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 258 seconds]
06:50 -!- slivera [~slivera@103.231.88.10] has quit [Remote host closed the connection]
06:56 < DSRelBot> [DS/AlexCato_] and the network name was fixed indeed, from my connection right now:
06:56 < DSRelBot> [DS/AlexCato_] NETWORK=darkscience
06:56 -!- reallll is now known as belcher
06:56 < DSRelBot> [DS/AlexCato_] so the problem with nick sig verification failures should be gone now
06:59 < belcher> excellent news(!)
07:01 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
07:33 < waxwing> yeah thanks for that alex. i'll check it out shortly myself.
07:51 < waxwing> oh hang on, just before i try it, i guess we will still get them until every bot restarts. since that value is set on startup. hmm not sure though, if reconnection due to server down i guess it gets reset then.
07:53 -!- jules23 [4486dbb5@pool-68-134-219-181.bltmmd.fios.verizon.net] has joined #joinmarket
07:56 < jules23> hi! im having trouble running the test suite on the branch pblwrap (pr 536) wondering if it's changed from running the test suite on master
07:58 < jules23> usually the template below works:
07:58 < jules23> pytest --btcconf=/path/to/bitcoin.conf --btcroot=/path/to/bitcoin/bin/ --btcpwd=whatever --nirc=2 --ignore test/test_full_coinjoin.py -p no:warnings
07:58 < waxwing> yup. should still work like that.
07:59 < waxwing> unless i forgot something. what error do you get?
08:00 < jules23> o actually just remembered is bitcoin 0.20 compatible with the test suite?
08:00 < waxwing> oh come to think of it there are a couple of things that could go wrong. python>=3.6 is one, but even more likely is absence of a libsecp256k1.so available.
08:00 < waxwing> oh that's a third one :) i saw an error recently that suggested to me that no, it isn't, but didn't have time to investigate further.
08:00 < waxwing> something to do with regtest bech32 addresses maybe? (when coins are generated)
08:01 < jules23> yes that's exactly what failed
08:01 < waxwing> we need to fix that if so.
08:01 < jules23> generatetoaddress 
08:01 < waxwing> maybe you could figure that one out by looking at what changed in 0.20
08:01 < jules23> ok! i'll see what i can do
08:02 < jules23> also you need to run pip install python-bitcointx before right? with jmvenv activated
08:02 < jules23> ?
08:03 < waxwing> Well .. it should be in setup.py if you ran the installation in that pr branch.
08:03 < jules23> okok i did a checkout and then just ran the command above
08:03 < waxwing> but yeah otherwise do that, but there is a problem/sticking point perhaps, which is that we are waiting on tagging of 1.1.0
08:04 < jules23> didn't go from scratch
08:04 < waxwing> or whatever the version is. i've been in discussion with dmitry on this. i think he will tag it soon.
08:04 < waxwing> let me dig up the correct syntax to install the latest.
08:05 < waxwing> pip install git+git://github.com/Simplexum/python-bitcointx.git@648ad8f45ff853bf9923c6498bfa0648b3d7bcbd
08:05 < waxwing> (in the virtualenv of course)
08:05 < waxwing> replace commit with whatever is master now
08:05 < waxwing> sorry this is way more involved than i remembered.
08:06 < jules23> not a problem i'll let you know if this fixes the crash
08:06 < waxwing> i don't think so; i was testing something else (not that pr) a couple days ago and had the same thing with 0.20
08:06 < jules23> ok
08:06 < jules23> bitcoin-cli returned error code 5
08:07 < jules23> wondering if it refers to this?
08:07 < jules23> RPC_INVALID_ADDRESS_OR_KEY      = -5,  //! Invalid address or key
08:07 < jules23> from here
08:07 < jules23> https://github.com/bitcoin/bitcoin/blob/62f2d769e45043c1f262ed45babb70fe237ad2bb/src/rpc/protocol.h#L30
08:07 < waxwing> yeah somehow it's ending up getting a bech32 addr for generateaddress but it's invalid or something? sorry i could look into it but i want to get the release done.
08:07 < waxwing> if it's a pain don't worry i can come back to it later.
08:08 < jules23> not a problem im asking to see how i can help with testing
08:08 < jules23> should i just switch back to 0.19?
08:09 < waxwing> i think probably yes.
08:09 < jules23> ok
08:09 < waxwing> the other thing might be confusing. either helps, just do whatever you can.
08:10 < jules23> ok
08:39 < belcher> does every yieldgen bot need to restart? or only some kinds (for example, only clearnet connections)
08:47 < waxwing> i think as per comment above, beccause the server restarted, they reset their hostid
08:47 < waxwing> so it's ok already
08:48 < waxwing> i mean, i think
08:49 < belcher> but the already-running bots will be using the old network name until they're restarted
08:49 < waxwing> i'm saying i think the irc server will resend the message on restart
08:49 < belcher> so do all yieldgen operators need to restart?
08:50 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmdaemon/jmdaemon/irc.py#L394
08:50 < waxwing> i think not
08:51 < waxwing> 'irc server will resend the message on restart' = (perhaps easy to misunderstand) restart *of irc server*
08:56 < belcher> ahh
08:56 < belcher> oh yes because if the server was restarted then all tcp connections were dropped, and the yieldgen bots with automatically reconnect and be sent the new network name
08:59 < DSRelBot> [DS/AlexCato_] can confirm everyone bot on onion did reconnect
09:05 -!- mactonight [~eatpoo22@185.195.237.203] has joined #joinmarket
09:09 < jules23> waxwing hi forget the bitcoin 0.20 error i mentioned above on pblwrap
09:09 < jules23> the error im actually getting is this one
09:09 < jules23> https://pastebin.com/QASuzL6n
09:09 < jules23> sorry for the confusion
09:09 < jules23> im quite confident im attempting to run the test suite as usual
10:01 -!- asoltys [~root@s207-81-214-2.bc.hsia.telus.net] has quit [Quit: Lost terminal]
11:18 -!- jules23 [4486dbb5@pool-68-134-219-181.bltmmd.fios.verizon.net] has quit [Remote host closed the connection]
11:30 -!- jules23 [4486dbb5@pool-68-134-219-181.bltmmd.fios.verizon.net] has joined #joinmarket
12:19 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
13:09 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
13:22 < jules23> hey everyone so we are currently wrestling with the error shown below when trying to run the pblwrap test suite on mac os
13:22 < jules23> https://pastebin.com/QASuzL6n
13:22 < jules23> i am not getting this error on master, seems to me this is specific to the branch
13:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 244 seconds]
13:51 < jules23> also see this crash report, as launching the test suite causes python to crash
13:51 < jules23> https://pastebin.com/G30pnfvR
13:52 < jules23> i think the following is interesting:
13:52 < jules23> Application Specific Information:abort() calledInvalid dylib load. Clients should not load the unversioned libssl dylib as it does not have a stable ABI.
14:03 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Ping timeout: 240 seconds]
14:22 < waxwing> for anyone who didn't know "pblwrap" is the #536 branch
14:22 < waxwing> also i believe from the pastebin jules23 is working on macos?
14:23 < jules23> yes!
14:23 < waxwing> i'm not sure but i think kristapsk has run it before (as well as me of course)
14:57 < waxwing> (sorry if that wasn't clear: i mean we both have run the test suite, on that branch, with linux)
14:58 -!- fiatjaf [~fiatjaf@2804:7f2:2a82:8ad2:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 272 seconds]
14:58 -!- fiatjaf [~fiatjaf@2804:7f2:2a82:8ad2:ea40:f2ff:fe85:d2dc] has joined #joinmarket
15:35 < jules23> problem solved !
15:35 < jules23> i ran these two commands:
15:35 < jules23> ln -s /usr/local/Cellar/openssl@1.1/1.1.1g/lib/libssl.1.1.dylib /usr/local/lib/libssl.dylib 
15:35 < jules23> ln -s /usr/local/Cellar/openssl@1.1/1.1.1g/lib/libcrypto.1.1.dylib /usr/local/lib/libcrypto.dylib
15:35 < jules23> usr/local/Cellar seems to be where homebrew puts things
15:58 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
16:15 < jules23> ran the test suite, i failed 26 of them and the whole thing took five minutes
16:16 < jules23> all 26 failures gave me this error
16:16 < jules23> https://pastebin.com/kjWr1rkv
16:21 < jules23> actually 25 is the above and 1 is the one below
16:21 < jules23> https://pastebin.com/UF0VHuR8
16:22 < jules23> passed 264
17:37 < waxwing> jules23, i believe that error is specific to the most recent commit. i will get around to fixing the bug in the test code shortly (which you've probably already figured out), but if you want to you can run tests on the previous commit.
17:38 < waxwing> the most interesting/useful thing there is to run through all the different main functions (command line scripts and Qt). this can be done using regtest with the ygrunner script as explained briefly in TESTING.md
17:38 < jules23> hey! i actually figured out a fix to the 264 that failed
17:38 < waxwing> thanks for checkign this, also thanks for testing on Mac, it is very useful. as i've said several times in our recent conversations, please be patient in that i cannot quite cover all the points you're raising immediately.
17:38 < jules23> im running the test suite as we speak
17:38 < waxwing> try it on the previous commit, it should work.
17:38 < jules23> sorry if im pestering too much
17:39 < waxwing> it's just a minor bug in a bit of test code that was altered/added in the last commit.
17:39 < waxwing> not at all.
17:39 < waxwing> trying to explain why i am not answering/dealing with each point you raise.
17:39 < jules23> that's ok totally understand
17:39 < jules23> i'll go test the previous commit 
17:40 < waxwing> since the bug is specific to testing code, it's fine to use the most recent commit for testing CLI functions and Qt functions. i mean whenever you choose to do that.
17:40 < waxwing> but well ok maybe not, since that bug probably affects ygrunner too. one thing at a time i guess :)
17:41 < waxwing> (note i haven't addressed the openssl thing yet, that looked interesting, but mac specific, so we definitely have to check it out)
17:41 < jules23> ok! just want to make sure you have seen how i solved the python crashing that's an important one i believe
17:41 < waxwing> yeah that's what i just mentioned.
17:41 < jules23> yep!
17:46 -!- HackRelay [~jmrelayha@p5de4a167.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
17:47 -!- DSRelBot [~DSRelBot@p5de4a167.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
17:58 -!- DSRelBot [~DSRelBot@p5de4a0dc.dip0.t-ipconnect.de] has joined #joinmarket
18:00 -!- HackRelay [~jmrelayha@p5de4a0dc.dip0.t-ipconnect.de] has joined #joinmarket
18:07 -!- grubles [~blockhash@unaffiliated/grubles] has quit [Quit: WeeChat 2.7.1]
18:30 -!- mactonight [~eatpoo22@185.195.237.203] has quit [Ping timeout: 246 seconds]
19:15 -!- slivera [~slivera@103.231.88.10] has joined #joinmarket
20:00 -!- jules23 [4486dbb5@pool-68-134-219-181.bltmmd.fios.verizon.net] has quit [Remote host closed the connection]
21:27 -!- coconutanna [~coconutan@gateway/tor-sasl/coconutanna] has quit [Remote host closed the connection]
21:31 -!- coconutanna [~coconutan@gateway/tor-sasl/coconutanna] has joined #joinmarket
21:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
21:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #joinmarket
23:57 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #joinmarket
--- Log closed Fri Jun 26 00:00:01 2020