--- Log opened Fri Jun 26 00:00:01 2020
00:38 -!- slivera [~slivera@103.231.88.10] has quit [Remote host closed the connection]
01:25 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has quit [Remote host closed the connection]
01:25 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has joined #joinmarket
01:39 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket
02:17 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has quit [Ping timeout: 240 seconds]
02:33 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Read error: Connection reset by peer]
03:05 -!- Estella76Lynch [~Estella76@static.57.1.216.95.clients.your-server.de] has joined #joinmarket
03:07 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Quit: Leaving]
03:12 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has joined #joinmarket
03:23 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has joined #joinmarket
03:25 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has quit [Ping timeout: 240 seconds]
03:50 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has joined #joinmarket
03:51 -!- reallll [~belcher@unaffiliated/belcher] has joined #joinmarket
03:55 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
03:58 -!- reallll is now known as belcher
04:25 < waxwing> i published the new release (actually last night): https://github.com/JoinMarket-Org/joinmarket-clientserver/releases/tag/v0.6.3
04:26 < waxwing> attached a binary again (as i did a number times ages ago), just linux 64 bit, testing it again on debian now, i guess it will mostly work but has to be treated as experimental. for all the complicated and boring reasons explained previously, i don't yet have a good way to build binary releases with more generality/reliability.
04:32 < belcher> nice!
04:58 < waxwing> https://x0f.org/web/statuses/104409319736148439 i'll update irc topics and reddit, belcher iirc there's one you need to do
04:58 -!- mode/#joinmarket [+o waxwing] by ChanServ
04:58 < belcher> ill do that
04:58 -!- waxwing changed the topic of #joinmarket to: Welcome to JoinMarket: Increase Fungibility and Subsidise Your Fees | https://github.com/Joinmarket-Org/joinmarket-clientserver | @joinmarket r/joinmarket | Logs: http://gnusha.org/joinmarket/ | Live View: https://joinmarket.me/ob | Latest release 0.6.3 | Also on ssl cfyfz6afpgfeirst.onion:6667
04:59 -!- mode/#joinmarket [-o waxwing] by ChanServ
05:01 < waxwing> yeah binary still works ok on debian 10, as before still get a bunch of font config errors on console. thing is with static build binary is 145MB but still doesn't seem enough to fully encapsulate.
05:01 < waxwing> hmm i guess by far the most of that 145MB is the Qt though.
06:23 < kristapsk> tried binary on my Gentoo laptop, there' fontconfig errors on start, not fatal, but when I try to do Wallet > Load it crashes with fatal error
06:23 -!- Estella76Lynch [~Estella76@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
06:23 < kristapsk> Gtk:ERROR:../../../../gtk/gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Failed to load /usr/share/icons/Adwaita/16x16/status/image-missing.png: Unrecognized image file format (gdk-pixbuf-error-quark, 3)
06:25 < kristapsk> and Wallet > Recover is not working with v0.6.3 (not related with binary), will fill an issue on github :(
06:28 < kristapsk> belcher, it's likely broken after merging fidelity bond code
06:29 < kristapsk> https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/610
06:29 < belcher> doh
06:29 < belcher> at least its easy to fix
06:30 < belcher> you just add the required argument and make it None
06:30 < belcher> i can do that, sec (in about an hour)
06:32 < kristapsk> yes, likely should be easy to fix, but it sucks we again find some bug right after publishing release :(
06:34 < belcher> :(
06:35 < waxwing> kristapsk, doesn't surprise me at all about gentoo (not that i know literally anything at all about gentoo, but i have no idea how to make a fully static binary that will work across all distros)
06:36 < waxwing> i have tested that process across a couple of ubuntu and debian setups, i can't realistically do more than that.
06:38 < waxwing> jules is not here but (a) i'd like him to run python-bitcointx tests on mac to find out if the same error repeats, since the error (and his fix) was specific to openssl libraries
06:39 < waxwing> also i'd like to ask dmitry petukhov about it, since i know he makes the openssl dependency for the keys library optionally not used, so it would be nice if the dependency were optional
06:39 < waxwing> and ofc the other aspect is whatever weird thing macos is doing with ssl to crash python there
06:40 < waxwing> "calledInvalid dylib load. Clients should not load the unversioned libssl dylib as it does not have a stable ABI." (see backtrace)
06:41 < waxwing> for now i will fix the latest commit in #536, minor bug that broke tests. but mainly there i am going to be waiting on bip78 clarification and tag for python-bitcointx before it becomes mergeable.
06:41 < waxwing> about this Wallet Recover bug not much to be said. all the Qt functions need to be tested but someone needs to do the work to automate that, it is not trivial.
06:42 < waxwing> in the absence of that, if you make a substantial change you have to test it against any Qt functions that might be impacted. it's particularly critical that you know how to make regtest tests easy, because any other type are far too time consuming.
06:43 -!- asymptotically [~asymptoti@gateway/tor-sasl/asymptotically] has quit [Ping timeout: 240 seconds]
07:17 -!- viasil [~nobody@37.120.141.36] has quit [Ping timeout: 258 seconds]
07:22 -!- viasil [~nobody@37.120.141.36] has joined #joinmarket
07:56 -!- MaxSan [~four@185.156.175.171] has joined #joinmarket
08:48 < waxwing> i think there is an error in Wallet->Generate too. investigating.
08:49 < waxwing> seems specific to mnemonic extension case
08:58 < waxwing> think this error was before fidelity stuff, not sure when actually, still investigating
08:59 < waxwing> what's going on here? https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/wallet_utils.py#L645
09:03 -!- fiatjaf [~fiatjaf@2804:7f2:2a82:8ad2:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 260 seconds]
09:05 -!- fiatjaf [~fiatjaf@2804:7f2:2984:8276:ea40:f2ff:fe85:d2dc] has joined #joinmarket
09:06 < belcher> waxwing if `display_seed_callback` is None then it wont call the function on the right hand side of the `and`
09:06 < belcher> its confusing i agree
09:06 < waxwing> i haven't checked thoroughly, but i strongly suspect that that bug is a result of this commit: https://github.com/JoinMarket-Org/joinmarket-clientserver/commit/6f90e3042483c4a447c024083791216e78bb2f64
09:06 < waxwing> belcher, oh i see, thanks
09:06 < belcher> `if display_seed_callback: display_seed_callback(whatever)` is equivalent and better
09:06 < belcher> iv seen that kind of style in php code sometimes
09:07 < waxwing> so to explain my thinking: we have 'show seed' which calls self.displayWords(), and this calls wallet.get_mnemonic_words, and for that call, it's necessary to have the .decode(), but for the wallet->generate we call displayWords() after creating the wallet, and in that case, we must not have the .decode()
09:07 < waxwing> and that's what i believe causes the error message. ping kristapsk ^
09:10 < waxwing> yes, confirmed: if i take a wallet i generated with a mnemonic extension, but got an error (str has no 'decode' method) during the generation, i can load it fine, and when i do 'show seed' it correctly shows the mnemonic extension
09:10 < waxwing> wait hang on don't we .. not want to do that? isn't that the point?
09:11 < waxwing> anyway i'll make another PR to fix this error. i have noticed this pattern before: a fix is put in for some suboptimal behaviour, but it's not realised that there is a cross-dependency where some other functionality is affected.
09:12 < waxwing> a good tip is to always do 'show usages' of a function (or some kind of 'find usages' however your editor/IDE works), so  when you change something you fully investigate what else could be affected.
09:12 < waxwing> of course i should spot that in review, but usually i am guilty of thinking something just 'looks trivial'.
09:12 < kristapsk> ehh, probably need to make some checklist of this kind of stuff to always remember to re-test with GUI changes
09:13 < waxwing> in this case it should have been seen that a change to 'self.displayWords()` does not *only* affect the "Show Seed"
09:13 < waxwing> or JMMainWindow.displayWords, sorry
09:30 < waxwing> ok afk for a bit, but, for the record: i am not sure i understood it yet so some part of the above may be wrong :)
09:57 -!- stoner19 [~stoner19@unaffiliated/stoner19] has quit [Ping timeout: 265 seconds]
10:05 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
10:22 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Ping timeout: 264 seconds]
10:22 -!- k3tan [~pi@unaffiliated/k3tan] has joined #joinmarket
10:50 -!- stoner19 [~stoner19@2a02:c207:2022:1374::1] has joined #joinmarket
10:50 -!- stoner19 [~stoner19@2a02:c207:2022:1374::1] has quit [Changing host]
10:50 -!- stoner19 [~stoner19@unaffiliated/stoner19] has joined #joinmarket
11:43 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has quit [Ping timeout: 240 seconds]
11:54 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
12:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
12:05 -!- vrana [~mvranic@gateway/tor-sasl/vrana] has joined #joinmarket
12:05 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
12:28 -!- MaxSan [~four@185.156.175.171] has quit [Ping timeout: 240 seconds]
12:50 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
14:44 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
14:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
15:17 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
17:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
17:26 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
17:27 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #joinmarket
17:45 -!- DSRelBot [~DSRelBot@p5de4a0dc.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
17:45 -!- EvanitoC [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
17:47 -!- HackRelay [~jmrelayha@p5de4a0dc.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
17:47 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Ping timeout: 246 seconds]
17:55 -!- HackRelay [~jmrelayha@p54866559.dip0.t-ipconnect.de] has joined #joinmarket
17:58 -!- DSRelBot [~DSRelBot@p54866559.dip0.t-ipconnect.de] has joined #joinmarket
19:06 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Remote host closed the connection]
19:18 -!- slivera [~slivera@103.231.88.30] has joined #joinmarket
19:29 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket
21:02 -!- Evanito [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has joined #joinmarket
21:05 -!- EvanitoC [~Evanito@cpe-76-87-174-228.socal.res.rr.com] has quit [Ping timeout: 260 seconds]
--- Log closed Sat Jun 27 00:00:02 2020