--- Log opened Fri Jan 29 00:00:29 2021
00:30 -!- smoothlife [~smoothlif@2a02:a210:2525:5b80:1785:1bd:55de:a509] has joined #joinmarket
00:54 -!- mememe [3227cb59@50.39.203.89] has joined #joinmarket
01:15 -!- mememe [3227cb59@50.39.203.89] has quit [Quit: Connection closed]
02:05 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 240 seconds]
02:07 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #joinmarket
02:47 -!- undeath [~undeath@hashcat/team/undeath] has joined #joinmarket
03:18 -!- Reanna37Stokes [~Reanna37S@static.57.1.216.95.clients.your-server.de] has joined #joinmarket
03:40 -!- rdymac_ is now known as rdymac
04:32 -!- waxwing_ is now known as waxwing
04:32 -!- waxwing [~waxwing@193.29.57.116] has quit [Changing host]
04:32 -!- waxwing [~waxwing@unaffiliated/waxwing] has joined #joinmarket
04:43 -!- viasil_ [~nobody@95.174.67.172] has quit [Ping timeout: 264 seconds]
04:59 -!- viasil [~nobody@95.174.67.172] has joined #joinmarket
05:00 -!- Netsplit *.net <-> *.split quits: midnight, tiker[m], Evanito[m]
05:01 -!- Netsplit over, joins: midnight, Evanito[m], tiker[m]
05:01 -!- Netsplit *.net <-> *.split quits: HackRelay, DSRelBot, Xeha, fiatjaf2
05:01 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Max SendQ exceeded]
05:01 -!- Netsplit over, joins: fiatjaf2, HackRelay, DSRelBot, Xeha
05:03 -!- Netsplit *.net <-> *.split quits: keithhub[m], undeath
05:03 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #joinmarket
05:03 -!- M1 [~Michail@michail.com] has quit [Ping timeout: 246 seconds]
05:03 -!- johnhmay [sid110431@gateway/web/irccloud.com/x-wwciwutvvyvxnhkc] has quit [Ping timeout: 246 seconds]
05:03 -!- Netsplit over, joins: undeath, keithhub[m]
05:04 -!- keithhub[m] [keithhubma@gateway/shell/matrix.org/x-xtsfvlxrwszqnjcg] has quit [Ping timeout: 258 seconds]
05:04 -!- Evanito[m] [evanitomat@gateway/shell/matrix.org/x-punsanlrpfjylxnn] has quit [Ping timeout: 244 seconds]
05:04 -!- tiker[m] [tikerfunky@gateway/shell/matrix.org/x-tiqnjacbwiywwgks] has quit [Ping timeout: 244 seconds]
05:05 -!- johnhmay [sid110431@gateway/web/irccloud.com/x-koqqehhrhqdtbavh] has joined #joinmarket
05:05 -!- M1 [~Michail@michail.com] has joined #joinmarket
05:44 -!- belcher_ is now known as belcher
06:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #joinmarket
06:16 -!- keithhub[m] [keithhubma@gateway/shell/matrix.org/x-fjrwchpxwbfittuw] has joined #joinmarket
06:42 -!- pigeons [~pigeons@androzani.sysevolve.com] has joined #joinmarket
06:42 -!- pigeons is now known as Guest30520
06:57 -!- Guest30520 is now known as pigeons
06:59 -!- Evanito[m] [evanitomat@gateway/shell/matrix.org/x-lxszbavhtfbzivhz] has joined #joinmarket
06:59 -!- tiker[m] [tikerfunky@gateway/shell/matrix.org/x-jbxewiedvudjgudk] has joined #joinmarket
07:56 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Ping timeout: 260 seconds]
09:08 -!- jungly [~jungly@host-87-18-27-108.retail.telecomitalia.it] has quit [Read error: Connection reset by peer]
09:12 -!- jungly [~jungly@host-87-18-27-108.retail.telecomitalia.it] has joined #joinmarket
09:14 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #joinmarket
09:23 < waxwing> so i am of the opinion we should build a release soon it's been a while.
09:24 < waxwing> #793 i've just opened is very minor and only related to tests.
09:24 < waxwing> #787 is minor but a bugfix that should be added. i don't mind if no one else tests it, although it'd be nice.
09:24 < waxwing> #756 is the big open "add functionality" PR that would be nice to finish off before a new release.
09:25 < waxwing> we did a fair bit of work on it (in particular i spent a while messing around with test vectors that weren't easy to set up). and it could form the basis of something users really want.
09:25 < waxwing> ie. useful PSBT support (outside of snicker, useful arguably, but not yet)
09:26 < waxwing> but the only concern is whether we can actually finish it off. right now i'm waiting to see if kristapsk has time to address the last few points mentioned. if not, maybe i can push it further myself.
09:27 < undeath> are you sure you pushed the correct code in #787?
09:27 < undeath> there are only comments
09:30 < waxwing> undeath, oh lol thanks, good spot
09:30 < waxwing> this is why we need reviewers
09:35 < undeath> but anyway, why use a generator at all when you need to create a set anyway?
09:35 < waxwing> undeath, i'm taking the contents of an existing generator
09:35 < waxwing> my first attempt, calling set(used_addresses_gen) just consumed it, borking it for later use.
09:35 < waxwing> if you think there's a better way than tee() I'm all ears.
09:35 < undeath> why not change used_addresses_gen to a set?
09:36 < waxwing> i'll have to check but i believe it's the output of _yield_addresses?
09:36 < undeath> it's defined just in the line above
09:36 < undeath> using an in-line generator
09:36 < waxwing> _yield_transactions yeah
09:37 < waxwing> i see. i was trying not to change anything else but perhaps you're right.
09:39 < waxwing> yes that seems to be fine. the call to get_used_indices is the only other place it's used, and i think it being a set will be fine.
09:41 < undeath> yes, that should work fine. no need for a tee() hackery
10:04 -!- smoothlife [~smoothlif@2a02:a210:2525:5b80:1785:1bd:55de:a509] has quit [Quit: WeeChat 3.0]
10:08 < belcher> i havent read the code but what about used_addresses_gen = list(used_addresses_gen)
10:09 < belcher> i.e. make it into a list which can be read from multiple times
10:15 < undeath> same is true for a set ;)
10:15 < undeath> and it's later put into a set anyway
10:34 < waxwing> belcher, my original patch was basically that; but set() instead of list(). the problem is that that consumed the contents of the generator, meaning the following use of the variable didn't get the data.
10:35 < belcher> i meant you add a line above which converts it from an iterator to a list, then later you can use the variable `used_addresses_gen` many times without using it up
10:35 < belcher> or set as undeath said
10:35 < waxwing> yes it's done now
10:35 < belcher> cool
12:08 -!- Saloframes [~Saloframe@71-218-241-243.hlrn.qwest.net] has joined #joinmarket
12:10 -!- Saloframes_ [~Saloframe@174-29-249-97.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
12:18 -!- Saloframes [~Saloframe@71-218-241-243.hlrn.qwest.net] has quit [Quit: Leaving]
12:28 -!- jungly [~jungly@host-87-18-27-108.retail.telecomitalia.it] has quit [Ping timeout: 258 seconds]
13:09 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #joinmarket
13:12 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds]
13:26 -!- belcher_ is now known as belcher
13:49 -!- jungly [~jungly@host-87-18-27-108.retail.telecomitalia.it] has joined #joinmarket
14:06 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Remote host closed the connection]
14:07 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #joinmarket
14:51 -!- jigawatt [~mcfly@2605:2700:1:100e:dc::f01d] has joined #joinmarket
15:28 -!- jungly [~jungly@host-87-18-27-108.retail.telecomitalia.it] has quit [Ping timeout: 256 seconds]
15:49 < HackRelay> [hackint-irc/kristapsk] waxwing, I will look at this stuff during weekend
16:00 -!- rdymac [uid31665@gateway/web/irccloud.com/x-rtrvbrteldnwftvj] has quit [Quit: Connection closed for inactivity]
16:26 -!- undeath [~undeath@hashcat/team/undeath] has quit [Quit: WeeChat 3.0]
16:33 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #joinmarket
16:34 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds]
16:38 -!- belcher_ is now known as belcher
17:16 -!- rdymac [uid31665@gateway/web/irccloud.com/x-nwqrhoaiovkjywdm] has joined #joinmarket
17:39 -!- HackRelay [~jmrelayha@p5de4a999.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
17:39 -!- DSRelBot [~DSRelBot@p5de4a999.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
17:49 -!- HackRelay [~jmrelayha@p3ee38b66.dip0.t-ipconnect.de] has joined #joinmarket
17:50 -!- DSRelBot [~DSRelBot@p3ee38b66.dip0.t-ipconnect.de] has joined #joinmarket
20:00 -!- rdymac [uid31665@gateway/web/irccloud.com/x-nwqrhoaiovkjywdm] has quit [Quit: Connection closed for inactivity]
20:03 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has quit [Remote host closed the connection]
20:03 -!- technonerd [~techno@gateway/tor-sasl/technonerd] has joined #joinmarket
--- Log closed Sat Jan 30 00:00:30 2021