--- Log opened Mon Jun 07 00:00:31 2021
01:13 -!- nsh [~lol@5.135.157.17] has quit [Ping timeout: 244 seconds]
01:17 -!- belcher_ is now known as belcher
01:20 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 272 seconds]
01:21 -!- koolazer [~koo@user/koolazer] has joined #joinmarket
01:40 -!- k3tan [~pi@user/k3tan] has quit [Remote host closed the connection]
01:40 -!- k3tan [~pi@user/k3tan] has joined #joinmarket
02:12 -!- waxwing [~waxwing@user/waxwing] has quit [Quit: ZNC 1.7.4+deb0+bionic0 - https://znc.in]
02:12 -!- waxwing [~waxwing@193.29.57.116] has joined #joinmarket
03:30 -!- undeath [~undeath@user/undeath] has joined #joinmarket
04:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
04:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #joinmarket
05:00 -!- waxwing [~waxwing@193.29.57.116] has quit [Changing host]
05:00 -!- waxwing [~waxwing@user/waxwing] has joined #joinmarket
05:39 -!- tiker[m] [~tikerfunk@2001:470:69fc:105::103a] has joined #joinmarket
05:41 -!- undeath [~undeath@user/undeath] has quit [Quit: WeeChat 3.1]
06:28 -!- xyy [~xyy@2001:470:69fc:105::f2d] has quit [Quit: node-irc says goodbye]
06:28 -!- Evanito[m] [~evanito@2001:470:69fc:105::1ec] has quit [Quit: node-irc says goodbye]
06:28 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has quit [Quit: node-irc says goodbye]
06:28 -!- tiker[m] [~tikerfunk@2001:470:69fc:105::103a] has quit [Quit: node-irc says goodbye]
07:28 < belcher> getting the error "{"errorCode": "original-psbt-rejected", "message": "Bad request: we cannot achieve minfeerate requested."}" when trying to do a payjoin with myself, a non-payjoin tx happens instead, full details https://0bin.net/paste/pgkVrjMV#8BMymNhOreXtgoOu945thuODdw6vsNXtEwMSkYQIsHj
07:29 < belcher> anything i could do to make a payjoin happen? (e.g. add more regtest coins to the wallets)
08:13 -!- Evanito[m] [~evanito@2001:470:69fc:105::1ec] has joined #joinmarket
08:14 < waxwing> belcher, was afk, sec, will take a look
08:14 -!- xyy [~xyy@2001:470:69fc:105::f2d] has joined #joinmarket
08:14 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has joined #joinmarket
08:14 -!- tiker[m] [~tikerfunk@2001:470:69fc:105::103a] has joined #joinmarket
08:16 < waxwing> belcher, oh also, let me know the commit so i can try to reproduce. in the past i don't remember needing to play any tricks to get it to work on regtest, different to what you did there, but i'm sure we can work it out.
08:19 < waxwing> interesting that the max additional fee contribution worked out to 120. that's low i think. but anyway let me do one sample on regtest right now.
08:46 < waxwing> hmm, so when i tried it (and it worked), i got this: 2021-06-07 16:44:09,719 [DEBUG]  Initial nonpayjoin transaction feerate is: 9.943262411347519
08:46 < waxwing> 2021-06-07 16:44:09,719 [DEBUG]  From which we calculated a max additional fee contribution of: 811
08:47 < waxwing> and i'm guessing that's because i have `tx_fees = 3`, but .. not sure what the correct answer is here.
08:47 < waxwing> and ofc i had the `max_additional_fee_contribution` at its default value, which is "default"
08:48 < waxwing> which results in this: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/payjoin.py#L473
09:34 < belcher> the commit was bc54b5b
09:34 < belcher> my joinmarket.cfg https://0bin.net/paste/6h5ddrjP#i-lSRkv/VO24ZIjX+09eluQwA4sTKaK5zvNM2h6LcwI
09:39 < waxwing> belcher, ah, k gotcha.
09:40 < waxwing> but i guess you were testing a fix for the payjoin thing on top of that commit?
09:40 < belcher> yeah
09:40 < waxwing> can you try it with tx_fees = 3 ?
09:40 < belcher> no i was trying to reproduce the bug you found, without a fix yet
09:40 < waxwing> oh i see, makes sense
09:41 < belcher> trying now..
09:42 < belcher> ah that works
09:42 < belcher> or rather, it crashes with the same bug you found
09:43 < waxwing> ok good to know. i'll take a moment to think about the situation where we're close to the sat/byte floor later.
09:43 < belcher> why didnt tx_fees = 1500 work? 1.5 sat/vb seems like a normal fee on regtest
09:43 < belcher> ah ok
09:44 < waxwing> yeah i'm not sure if i ever tried it with small numbers. sounds at least likely there's a bug, or possibly just me not having thought about exactly what happens there.
09:44 < waxwing> afaik we're doing what bip78 asks, but there are tiny choices that have to be made that are not specified at the proto level, so, not sure.
09:53 < waxwing> i suppose what's not immediately obvious: payjoin's default operation, even according to the spec, is to *allow* the receiver to add the extra input and let/ask the sender to reduce their change. but how much of a reduction that is is controlled by 'max_additional_fee_contribution'.
09:53 < waxwing> so the question is how does the user decide what to accept for that max_additional_fee_contribution.
09:53 < waxwing> s/user/sender
09:53 < waxwing> belcher, ^
09:57 < belcher> i see
11:03 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has quit [Ping timeout: 244 seconds]
11:03 -!- Evanito[m] [~evanito@2001:470:69fc:105::1ec] has quit [Ping timeout: 244 seconds]
11:03 -!- xyy [~xyy@2001:470:69fc:105::f2d] has quit [Ping timeout: 244 seconds]
11:03 -!- tiker[m] [~tikerfunk@2001:470:69fc:105::103a] has quit [Ping timeout: 272 seconds]
12:05 < waxwing> belcher, fwiw it looks like there's a bug where additionalfeeoutputindex is not being recognized. still investigating between doing other thigns, will keep you updated
12:09 < waxwing> oof figured it out. `if afoi: ..` ... but afoi is the output index, it can be 1 or 0 :facepalm:
12:10 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/jmclient/jmclient/payjoin.py#L820
12:10 < waxwing> will PR it shortly
12:11 < waxwing> the effect of that error on earlier payjoin runs: about 1/2 of the time, it will insist on not reducing the change output (and that will be fine unless feerate is very low). so it's not terrible; it's just wrong.
12:58 -!- Evanito[m] [~evanito@2001:470:69fc:105::1ec] has joined #joinmarket
13:00 -!- xyy [~xyy@2001:470:69fc:105::f2d] has joined #joinmarket
13:00 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has joined #joinmarket
13:00 -!- tiker[m] [~tikerfunk@2001:470:69fc:105::103a] has joined #joinmarket
13:16 < belcher> wow i just noticed new.reddit.com/r/bitcoin has "subreddit ads" and those link to joinmarket amongst other projects (like btcpayserver)
13:16 < belcher> makes me feel a bit bad about neglecting the r/joinmarket subreddit a bit
14:36 < waxwing> oh, right
15:05 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Quit: No Ping reply in 180 seconds.]
15:07 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #joinmarket
15:57 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Ping timeout: 252 seconds]
15:58 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #joinmarket
16:04 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Ping timeout: 252 seconds]
16:21 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #joinmarket
16:26 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Remote host closed the connection]
17:18 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #joinmarket
19:43 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Remote host closed the connection]
19:44 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #joinmarket
20:58 -!- DeanGuss [~dean@nonplayercharacter.me] has joined #joinmarket
21:02 -!- technonerd [~techno@user/technonerd] has quit [Remote host closed the connection]
21:03 -!- technonerd [~techno@user/technonerd] has joined #joinmarket
21:18 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Ping timeout: 252 seconds]
21:18 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #joinmarket
21:21 -!- technonerd [~techno@user/technonerd] has quit [Ping timeout: 252 seconds]
21:22 -!- technonerd [~techno@user/technonerd] has joined #joinmarket
21:36 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 264 seconds]
21:49 -!- belcher [~belcher@user/belcher] has joined #joinmarket
--- Log closed Tue Jun 08 00:00:32 2021