--- Log opened Mon Jul 05 00:00:57 2021
00:10 < waxwing> openoms[m], "just modified defaults". you sure? which settings? as i said above, 20% variation is *always* applied, unless i forgot something.
00:14 < openoms[m]> waxwing you are right, I confused it with the YG settings. One can't set the miner fee variation in the .cfg.
00:14 < openoms[m]> Although if you set 1000 would it have like a 50% chance to end up with 1sat/byte? (in case the variation is negative)
00:18 < waxwing> openoms[m], hmm good question, i don't think so but i'll check
00:19 < waxwing> openoms[m], oh yeah of course, i'm dumb ... we recently added 'mempoolminfee' rpc result
00:19 < waxwing> so that we force it not to go below that. so that'll be the reason.
00:21 < waxwing> oh but, we also randomize it upwards, so it's rather strange that it can come out at exactly 1K
00:21 < waxwing> https://github.com/JoinMarket-Org/joinmarket-clientserver/commit/7a9519252828a91dbbf26145b8b27145b865a258
00:22 < waxwing> in particular https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/7a9519252828a91dbbf26145b8b27145b865a258/jmclient/jmclient/blockchaininterface.py#L432-L433
00:55 -!- reallll is now known as belcher
00:57 < JoinMarketRelay> [hackint/p`NW^FkQ^DB`\uKd] thanks for checking the case, I'm curios too :)
01:01 < JoinMarketRelay> [hackint/p`NW^FkQ^DB`\uKd] as I said earlier, you would need to set it to above 1000, 1001 satoshis tx_fees: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/7a9519252828a91dbbf26145b8b27145b865a258/jmclient/jmclient/blockchaininterface.py#L62-L66 else it is understood as "in X blocks"
01:03 < JoinMarketRelay> [hackint/p`NW^FkQ^DB`\uKd] equivalent to "estimatesmartfee 1000" in bitcoind rpc? {"feerate": 0.00001000,"blocks": 784} so in the end it seems to get 1000 satoshis anyway. because fee estimated for 1000 blocks is the same as mempoolminfee. but it should still be randomized above it?!
01:05 < waxwing> yeah we randomize whether "manually set" (i.e. not estimatesmartfee), or not. ping kristapsk
01:06 < waxwing> ok it could be like this: use tx_fees = 999 and estimatesmartfee returns 1000. Now, 1000 is *not* less than `mempoolminfee_in_sat` so the randomization step doesn't kick in.
01:07 < waxwing> i mean, it's not technically wrong, our code is designed to prevent falling below the minimum, not disallow the minimum. but still.
01:12 < JoinMarketRelay> [hackint/kristapsk] coinmerge, there is nothing malicious about using low fees, taker can use whatever fee he likes, there is proposal to allow makers to specify minimum fee, but nobody has worked on that yet, https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/721
01:22 < JoinMarketRelay> [hackint/JoinMarketChannelBridgeRelayBot] [freenode/coinmerge] yes, I found the #721 beforehand. ty anyways. thats it. but send link above of 721 in case you cannot see logs. still fear of taker with lowestfee end up all coins in unconfirmed state. nothing to do about it then as maker until issue is solved.
02:04 -!- technonerd [~techno@user/technonerd] has quit [Remote host closed the connection]
02:04 -!- technonerd [~techno@user/technonerd] has joined #joinmarket
02:19 -!- jungly [~jungly@host-87-20-188-221.retail.telecomitalia.it] has joined #joinmarket
04:27 -!- undeath [~undeath@user/undeath] has joined #joinmarket
04:34 < waxwing> just dropping another note, not sure if I'll get round to it: we should be sure to test the "add FB to existing wallet using recover" rather than only testing newly generated, since a lot of people are likely to choose that option.
04:34 < waxwing> re: #872 of course, which btw i've now noted, i think is ready for merge.
05:18 < JoinMarketRelay> [hackint/JoinMarketChannelBridgeRelayBot] [OFTC/coinjoin] is there a easy way to calculate what Fidelity Bond value you will receive, in the end? like a --dry-run on the locking? To see how much is required a reasonable amount to be locked. Since every locked satoshi can no longer coinjoin while locked.
05:24 < waxwing> good point to raise, since the formula isn't that simple, we could add a method/flag for that. it can be done after the PR though.
05:25 < JoinMarketRelay> [hackint/JoinMarketChannelBridgeRelayBot] [OFTC/coinjoin] great it's nice2have
05:26 < waxwing> of course it does depend on the interest rate though
05:26 < waxwing> the calculation is done here in case it helps: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/71046d6717669e6a78b5aa6aeb5c4cc96589fcf1/jmclient/jmclient/wallet.py#L2393-L2408
05:27 < waxwing> we could have it calculate based on the yg's interest rate setting in their config, or just the default
05:29 < waxwing> on that topic, why is there a _DEFAULT_INTEREST_RATE fallback in `get_interest_rate()`, wouldn't it make more sense to use the same as other config settings, i.e. use the default from configure.py if it's not set by user.
05:38 -!- Lightsword [~Lightswor@user/lightsword] has quit [Quit: ZNC]
05:41 -!- kanzure [~kanzure@user/kanzure] has joined #joinmarket
05:54 < undeath> waxwing: _DEFAULT_INTEREST_RATE is the default set in configure.py and get_interest_rate() is also defined in configure.py
05:57 -!- jungly [~jungly@host-87-20-188-221.retail.telecomitalia.it] has quit [Ping timeout: 246 seconds]
06:02 -!- jungly [~jungly@a-rm31-56.tin.it] has joined #joinmarket
06:07 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Quit: ZNC 1.8.0 - https://znc.in]
07:09 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
07:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #joinmarket
08:28 -!- undeath [~undeath@user/undeath] has quit [Ping timeout: 246 seconds]
08:35 -!- undeath [~undeath@user/undeath] has joined #joinmarket
08:42 -!- davterra [~davterra@178.128.106.205] has quit [Quit: Leaving]
11:28 -!- jungly [~jungly@a-rm31-56.tin.it] has quit [Ping timeout: 252 seconds]
11:35 -!- Netsplit *.net <-> *.split quits: michaelfolkson, JoinMarketRelay, shiza, Michail1
11:40 -!- Netsplit over, joins: JoinMarketRelay, michaelfolkson, shiza, Michail1
12:59 < belcher> im still working on squishing the fidelity bonds PRs so that the commits are all nice
13:05 -!- mode/#joinmarket [+v JoinMarketRelay] by ChanServ
13:40 -!- Lightsword [~Lightswor@user/lightsword] has joined #joinmarket
13:43 < belcher> waxwing i just saw your comment on the PR, im already 3/4 of the way through squishing it in groups..
13:44 < belcher> i think it will be worth it months later when we want to read and understand old code
14:29 -!- Lightsword [~Lightswor@user/lightsword] has quit [Quit: ZNC]
14:29 -!- Lightsword [~Lightswor@user/lightsword] has joined #joinmarket
14:37 < waxwing> belcher, yeah, understood on the motivation. hopefully we can just diff it and it'll be all good.
15:03 -!- deafboy [quasselcor@cicolina.org] has quit [Remote host closed the connection]
15:05 -!- deafboy [quasselcor@cicolina.org] has joined #joinmarket
16:36 -!- Lightsword [~Lightswor@user/lightsword] has quit [Quit: ZNC]
17:25 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 268 seconds]
17:38 -!- belcher [~belcher@user/belcher] has joined #joinmarket
19:12 -!- technonerd [~techno@user/technonerd] has quit [Ping timeout: 244 seconds]
19:18 -!- technonerd [~techno@user/technonerd] has joined #joinmarket
21:06 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #joinmarket
21:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 244 seconds]
21:14 -!- davterra [~davterra@178.128.106.205] has joined #joinmarket
21:22 -!- Lightsword [~Lightswor@user/lightsword] has joined #joinmarket
22:11 -!- davterra [~davterra@178.128.106.205] has quit [Ping timeout: 252 seconds]
22:35 -!- davterra [~davterra@178.128.106.205] has joined #joinmarket
--- Log closed Tue Jul 06 00:00:59 2021