--- Log opened Tue Jul 06 00:00:59 2021
00:42 <+JoinMarketRelay> [hackint/JoinMarketChannelBridgeRelayBot] 1 sat/vB mining fees, enjoy!
00:42 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has quit [Ping timeout: 246 seconds]
02:34 < belcher> i have pushed the squished commits to the announce fidelity bonds PR
02:34 < belcher> automated tests are running but they all were successful on my own machine
02:35 < belcher> using diff to compare should work, i think there shouldnt be any edits
02:36 < belcher> oh wait looks like theres some flake8 failures
02:44 < belcher> ok here we go, pushed again, flake8 checks should succeed now
03:16 < waxwing> belcher, thanks. i'll see if i can easily diff file by file, if there's no meaningful difference then a few sanity checks should be fine.
03:16 < waxwing> did anything difficult crop up?
03:17 < belcher> in squishing? not really it just took a bit of time to move bits of code around that ended up in the wrong commit
03:17 < belcher> hmm more failures
03:18 < belcher> oh wait no, i just didnt refresh the page
03:19 < undeath> the diff betwen 3c20d1774f8ce90b8fd6edfff27ea70008f2949e and 71046d6717669e6a78b5aa6aeb5c4cc96589fcf1 is quite long
03:21 < belcher> how do you calculate/view it?
03:22 < undeath> diff -r joinmarket-clientserver-3c20d1774f8ce90b8fd6edfff27ea70008f2949e joinmarket-clientserver-71046d6717669e6a78b5aa6aeb5c4cc96589fcf1 
03:23 < undeath> i got those dirs by downloading + extracting https://github.com/JoinMarket-Org/joinmarket-clientserver/archive/3c20d1774f8ce90b8fd6edfff27ea70008f2949e.tar.gz and the other one
03:23 < belcher> ah
03:24 < belcher> i just tried `git diff 71046d6717669e6a78b5aa6aeb5c4cc96589fcf1 3c20d1774f8ce90b8fd6edfff27ea70008f2949e` which also gives a long diff but it contains irrelevant edits that are nothing to do with the PR
03:24 < belcher> so that cant be the right command
03:25 < belcher> i wonder if its because i rebased on master
03:26 < belcher> there's this: -**LATEST VERSION of JoinMarket-Qt is GUI version 20**. You can check the version via `About` in the menu.
03:26 < belcher> +**LATEST VERSION of JoinMarket-Qt is GUI version 21**. You can check the version via `About` in the menu.
03:26 < belcher> git blame tells me that edit is from 17th june
03:26 < belcher> so the rebase on master was the change looks like, damn
03:26 < belcher> i wonder if theres a way to rebase 71046d6 onto master too
03:26 < waxwing> yeah it's kind of massive if i just look at taker.py. def rebase on master would be a part of it.
03:27 < waxwing> well yeah sure but all the testing has to be redone. i wasn't aware we were too far diverged from master here. but maybe we were.
03:28 < waxwing> the diff i'm seeing somehow doesn't look right even taking that into account... maybe i'm not reading it well.
03:28 < belcher> i only see things that are unrelated to fidelity bonds, for example +    def _verify_ioauth_data(self, ioauth_data):
03:29 < belcher> here is one line i remember adding `+        self.fidelity_bond = None` in test_client_protocol.py which was needed to fix a failing test
03:29 < waxwing> oh yeah that big refactor of verify_ioauth_data that was recent.
03:30 < waxwing> that explains that one.
03:30 < belcher> a new file is `b/docs/release-notes/release-notes-0.8.3.md` which makes sense since there was a new joinmarket release since the fidelity bonds PR was opened
03:30 < waxwing> so is there any chance someone else will do extensive testing of all wallet tool methods, tumbler in gui and command line, and some other stuff?
03:31 < waxwing> alternatively to me spending hours on that, perhaps belcher is it possible to redo it without rebasing on master, and then rebasing after?
03:31 < waxwing> or maybe it isnt.
03:31 < belcher> ill do those tests, at least most of them
03:32 < belcher> i dont know how to undo a rebase... i think i actually did a rebase master first and then squish so its even  harder
03:32 < waxwing> ok
03:32 < waxwing> i think you're right, although i haven't thought about the details
03:33 < belcher> its quite helpful that you wrote which tests you did manually, so i can just read them and repeat
03:34 < waxwing> a useful one i did at the end is: switch between branch and v0.8.3 on git, with makers being one and and taker on other, then swap
03:34 < belcher> good idea
03:35 < waxwing> i'll leave it up to you to decide when to merge then.
03:36 < belcher> ok
03:36 < waxwing> undeath, from yesterday, re: interest rate, yes, but it seems weird to me that it's different from all the other settings that are defined as default in the default text and managed by the config parsing.
03:36 < waxwing> i mean clearly it's fine.
03:37 < waxwing> yeah it's just inserted there so hardly can be considered worse.
03:39 < waxwing> (hmm but it's like .. if it's part of config it can be accessed as all other parts of config, if it isn't we need this separate access method - why is it treated different? Sorry for waffling)
03:40 < belcher> you're right it is different from the status quo, i forgot all about the trick of first loading the default and then loading the file from disk
03:42 < belcher> also someone was asking about a calculator for fidelity bond values, i was thinking that could be best done by some js code in the orderbook web page
03:43 < belcher> most of the complications with the formula are only relevant when the timelock expires
03:43 < waxwing> yeah. wouldn't hurt to put a method on command line also i suppose. but on ob-watcher fits pretty well.
03:44 < belcher> if you're intended to create a timelocked address and fund it right now, then the formula for value is relatively simple: (bitcoins*(exp(interest_rate*length_of_locktime) - 1))^2
03:44 < belcher> or with symbols instead of words: (B*(exp(r*T) - 1))^2
03:45 < belcher> the exp()-1 calculates the time-value-of-money, multiplied by how many bitcoins are actually in the address, and then everything squared
03:46 < belcher> one facet of the market is that even if you calculate that your bond will be worth say 10% or 20% of the total advertised fidelity bonds, someone else could come along tomorrow and create a more valuable bond... and your bitcoins are still stuck for your whole locktime... because the market environment is so easily changed the value of calculating things in advance maybe isnt so useful, you may as well put as many bitcoins as you can in the bond come 
03:46 < belcher> what may
04:09 < undeath> belcher: does this look right? https://gist.github.com/undeath/afefa05f69e71579814668fc5765e52d
04:09 < undeath> that's what I get when I rebase 71… before the diff
04:09 < belcher> aha
04:10 < belcher> yes it does
04:10 < undeath> great
04:10 < belcher> i edited fidelity-bonds.md and that one line in test_client_protocol.py
04:10 < belcher> and theres one or two added or removed line breaks
04:10 < undeath> and a doc change in wallet_utils.py
04:12 < belcher> yes
04:12 < belcher> thats the warning printed when `gettimelockedaddress` is called
04:12 < undeath> perfect, then nothing got lost
04:13 <+JoinMarketRelay> [hackint/jliyEDFK\YR`sHyu] yes i see, a value calculator could probably create false expectations for the user, in that the value can look quite different in a short time compared to the market value and would therefore have little meaningfulness.
04:16 < waxwing> i see, so you rebased 71.. and then compared that with 3c2 and got that undeath ?
04:16 < waxwing> yeah if so that looks absolutely fine
04:16 < undeath> exactly
04:16 < waxwing> but the rebase is still a thing, so we should def do a few sanity checks here and there, but, still.
04:35 < belcher> ill do some tests anyway
04:54 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has joined #joinmarket
05:04 -!- jungly [~jungly@host-79-49-186-28.retail.telecomitalia.it] has joined #joinmarket
05:08 -!- ghost43_ is now known as ghost43
05:45 -!- pastly [~pastly@gateway/tor-sasl/pastly] has quit [Quit: pastly]
06:00 -!- technonerd [~techno@user/technonerd] has quit [Remote host closed the connection]
06:01 -!- technonerd [~techno@user/technonerd] has joined #joinmarket
06:56 -!- undeath [~undeath@user/undeath] has quit [Ping timeout: 252 seconds]
06:58 -!- undeath [~undeath@user/undeath] has joined #joinmarket
07:46 -!- davterra [~davterra@178.128.106.205] has quit [Remote host closed the connection]
08:20 < belcher> done my tests
08:22 < belcher> waxwing undeath kristapsk tell me if you have any more desire to review the PR, if not ill merge
08:22 < undeath> i'm reviewing rn
08:22 < belcher> ok
08:26 <+JoinMarketRelay> [hackint/kristapsk] belcher, I will try to do some testing
08:26 < belcher> ok
10:41 -!- Nicj [~Nicj@185-10-223-126.ip4.fiberby.net] has joined #joinmarket
10:44 -!- Nicj [~Nicj@185-10-223-126.ip4.fiberby.net] has quit [Client Quit]
12:57 -!- jungly [~jungly@host-79-49-186-28.retail.telecomitalia.it] has quit [Ping timeout: 252 seconds]
14:03 -!- jungly [~jungly@host-79-49-186-28.retail.telecomitalia.it] has joined #joinmarket
14:05 -!- undeath [~undeath@user/undeath] has quit [Quit: WeeChat 3.1]
14:19 -!- davterra [~davterra@178.128.106.205] has joined #joinmarket
14:24 -!- jungly [~jungly@host-79-49-186-28.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds]
17:21 -!- belcher_ [~belcher@user/belcher] has joined #joinmarket
17:25 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 246 seconds]
--- Log closed Wed Jul 07 00:01:00 2021