--- Day changed Wed Jun 21 2017 00:29 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fxkmziqrrvqcuxpl] has joined #lightning-dev 01:04 -!- bedeho [~bedeho@91.186.71.3] has joined #lightning-dev 01:04 -!- bedeho [~bedeho@91.186.71.3] has quit [Remote host closed the connection] 02:35 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 02:44 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 276 seconds] 02:48 -!- bedeho [~bedeho@91.186.71.3] has joined #lightning-dev 03:13 -!- nemgun [~nemgun@105.101.144.71] has joined #lightning-dev 03:18 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #lightning-dev 03:39 -!- bedeho [~bedeho@91.186.71.3] has quit [Remote host closed the connection] 03:41 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 03:49 -!- bedeho [~bedeho@91.186.71.3] has joined #lightning-dev 04:05 < cdecker> Hey Corne, how are you doing? Sorry for not seeing this before 04:06 * cdecker turns on channel notifications 04:06 < cdecker> :-) 04:14 -!- bedeho [~bedeho@91.186.71.3] has quit [Remote host closed the connection] 04:18 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 276 seconds] 04:19 -!- bedeho [~bedeho@91.186.71.3] has joined #lightning-dev 04:20 -!- [b__b] [~b__b]@ec2-54-85-45-223.compute-1.amazonaws.com] has quit [Ping timeout: 260 seconds] 04:25 -!- ThomasV [~ThomasV@p2003006CCD429D01E40FB50234DE3FEB.dip0.t-ipconnect.de] has joined #lightning-dev 04:26 -!- ThomasV [~ThomasV@p2003006CCD429D01E40FB50234DE3FEB.dip0.t-ipconnect.de] has quit [Changing host] 04:26 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 04:29 -!- [b__b] [~b__b]@ec2-54-85-45-223.compute-1.amazonaws.com] has joined #lightning-dev 04:39 -!- roasbeef_ is now known as roasbeef 04:45 -!- bedeho [~bedeho@91.186.71.3] has quit [Remote host closed the connection] 04:50 -!- bedeho [~bedeho@91.186.71.3] has joined #lightning-dev 04:54 -!- shesek [~shesek@unaffiliated/shesek] has joined #lightning-dev 05:02 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 05:10 -!- bedeho [~bedeho@91.186.71.3] has quit [Remote host closed the connection] 05:11 -!- bedeho [~bedeho@91.186.71.3] has joined #lightning-dev 05:13 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 255 seconds] 05:42 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #lightning-dev 05:44 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 06:04 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #lightning-dev 06:06 -!- bedeho [~bedeho@91.186.71.3] has quit [Remote host closed the connection] 06:08 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 06:17 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #lightning-dev 06:26 -!- bedeho [~bedeho@91.186.71.3] has joined #lightning-dev 06:28 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 276 seconds] 06:30 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 06:34 -!- bedeho [~bedeho@91.186.71.3] has quit [Remote host closed the connection] 06:44 -!- starkness [~starkness@cpe-69-200-236-97.nyc.res.rr.com] has joined #lightning-dev 06:54 -!- bedeho [~bedeho@91.186.71.3] has joined #lightning-dev 06:55 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #lightning-dev 07:02 -!- bedeho [~bedeho@91.186.71.3] has quit [Remote host closed the connection] 07:10 -!- bedeho [~bedeho@91.186.71.3] has joined #lightning-dev 07:11 -!- bedeho [~bedeho@91.186.71.3] has quit [Read error: Connection reset by peer] 07:29 -!- deusexbeer [~deusexbee@079-170-136-225-dynamic-pool-adsl.wbt.ru] has joined #lightning-dev 08:10 -!- bedeho [~bedeho@90.149.204.91] has joined #lightning-dev 08:14 -!- bedeho [~bedeho@90.149.204.91] has quit [Ping timeout: 240 seconds] 08:16 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has joined #lightning-dev 08:24 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 08:28 -!- JackH [~laptop@46.231.18.66] has quit [Ping timeout: 255 seconds] 08:40 -!- JackH [~laptop@217.149.140.177] has joined #lightning-dev 08:50 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #lightning-dev 08:55 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has quit [Remote host closed the connection] 08:57 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has joined #lightning-dev 09:29 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 258 seconds] 09:32 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 09:45 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 276 seconds] 09:53 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 10:05 -!- deusexbeer [~deusexbee@079-170-136-225-dynamic-pool-adsl.wbt.ru] has quit [Quit: Konversation terminated!] 10:11 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has quit [Remote host closed the connection] 10:12 -!- AmikoPay_CJP [~AmikoPay_@a83-163-77-195.adsl.xs4all.nl] has joined #lightning-dev 10:12 < AmikoPay_CJP> Any C-Lightning developer available? 10:13 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has joined #lightning-dev 10:20 -!- JackH [~laptop@217.149.140.177] has quit [Ping timeout: 240 seconds] 10:28 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 240 seconds] 10:49 -!- starkness [~starkness@cpe-69-200-236-97.nyc.res.rr.com] has quit [Quit: starkness] 11:07 < cdecker> Hi AmikoPay_CJP :-) 11:07 < AmikoPay_CJP> hi! 11:07 < cdecker> How are you doing? 11:07 < AmikoPay_CJP> I was trying to compile C-Lightning, and ran into some issues. 11:08 < cdecker> What platform? 11:08 < AmikoPay_CJP> Debian Jessie (= Linux) 11:09 < cdecker> What's the output of make? 11:09 < AmikoPay_CJP> One issue is relatively simple: sometimes a variable is declared in a for loop, and the compiler doesn't accept this. 11:09 < AmikoPay_CJP> For instance: "for(int i=0; i<..; i++)" 11:09 < cdecker> Oh, you have a stricter compiler than I do then ^^ 11:10 < cdecker> Are you using gcc or clang? 11:10 < AmikoPay_CJP> I use the Makefile that comes from the Git repository. I use gcc 4.9.2. 11:11 < cdecker> Ok, I'm using gcc 5.4, let me see if I can reproduce the error on jessie 11:12 < AmikoPay_CJP> Of course I can fix this, but I'd like to know what the policy is. Should we fix the code (get all declarations out of for loops) or fix the options in the Makefile? 11:13 < cdecker> I think pulling declarations to the top is the policy (I was just too lazy sometimes for the for loops) 11:14 < AmikoPay_CJP> OK thx. FYI I get this error in lightningd/sphinx.c and test/test_sphinx.c. 11:15 < AmikoPay_CJP> Oh, and I see I'm currently 23 commits behind: I'm on f1f9af480827730689ea9cd4e2c971837d1aaae8 11:15 < cdecker> Pretty sure I did this wrong a few times 11:16 < cdecker> That shouldn't be a problem, we don't change the compilation stuff too often 11:16 < AmikoPay_CJP> OK, next issue: I got a compilation error on lightning.pb-c.c 11:17 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has quit [Remote host closed the connection] 11:18 < AmikoPay_CJP> It seems this is automatically-generated code (there even is a rule for it in the Makefile), but it also comes with the repository. 11:18 < cdecker> Yep, we are distributing it in the hopes that people don't need to install protoc (the protobuf generator) 11:19 < cdecker> It'll be removed in future versions since we no longer use protobufs anywhere 11:19 < AmikoPay_CJP> The version from the repository seems to expect a certain macro, probably to be provided by the protobuf header file, but that macro isn't found on my system. 11:20 < cdecker> Ok, what happens if you remove and regenerate the file? 11:20 < cdecker> (you will need the protobuf-compiler package to get `protoc` 11:21 < AmikoPay_CJP> Debian Jessie might have an older protoc than recommended by your docs, but I'll try anyway. 11:21 < AmikoPay_CJP> $ rm lightning.pb-c.* 11:21 < AmikoPay_CJP> $ make lightning.pb-c.c 11:22 < AmikoPay_CJP> fatal: ambiguous argument 'lightning.pb-c.c': unknown revision or path not in the working tree. 11:22 < AmikoPay_CJP> Use '--' to separate paths from revisions, like this: 11:22 < AmikoPay_CJP> 'git [...] -- [...]' 11:22 < cdecker> Whops? 11:22 < AmikoPay_CJP> protoc-c lightning.proto --c_out=. 11:22 < AmikoPay_CJP> $ make lightning.pb-c.o 11:22 < AmikoPay_CJP> cc -Werror -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -g -fstack-protector -I ccan -I libwally-core/src/secp256k1/include/ -I libwally-core/include/ -I libsodium/src/libsodium/include/ -I . -DSHACHAIN_BITS=48 -c -o lightning.pb-c.o lightning.pb-c.c 11:23 < AmikoPay_CJP> (no error there) 11:23 < cdecker> Ok, I also don't get an error 11:24 < AmikoPay_CJP> But you said this actually isn't used elsewhere in the code? So as long as it compiles, it should be good, right? 11:25 < cdecker> Right, we have two versions: daemon/lightningd (legacy) and lightningd/lightningd (new) 11:25 < cdecker> The legacy version still uses protobuf, the new one doesn't 11:25 < cdecker> We'll be removing the legacy daemon soon(-ish) 11:25 < cdecker> And clean out these old dependencies as well 11:26 < cdecker> If you get things to compile you can verify things with `make full-check` 11:26 < cdecker> If that passes you're set ^^ 11:26 < AmikoPay_CJP> I ran into another issue: 11:26 < cdecker> Glad to see that you're back by the way ^^ 11:27 < AmikoPay_CJP> Oh yeah, thanks. There were several reasons for my relatively long absence. 11:28 < AmikoPay_CJP> 1. Do all the things I delayed because of the Scaling Bitcoin Milan, e.g. do some painting in my house. 11:30 < AmikoPay_CJP> 2. After Scaling Bitcoin Milan I realized Amiko Pay needed a major re-working; doing either that or joining one of the other implementations was a major mental hurdle to take. 11:30 < AmikoPay_CJP> 3. Several distraction projects. 11:30 -!- starkness [~starkness@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #lightning-dev 11:30 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 11:30 < AmikoPay_CJP> Anyway, the next error I ran into: 11:31 < AmikoPay_CJP> $ make 11:31 < AmikoPay_CJP> [skip lots of compilation steps] 11:31 < AmikoPay_CJP> cc test/test_protocol.o bitcoin/base58.o bitcoin/block.o bitcoin/locktime.o bitcoin/pubkey.o bitcoin/pullpush.o bitcoin/script.o bitcoin/shadouble.o bitcoin/signature.o bitcoin/tx.o bitcoin/varint.o bitcoin/libbase58.o wire/wire_sync.o wire/wire_io.o wire/fromwire.o wire/peer_wire.o wire/towire.o wire/gen_peer_wire.o ccan-asort.o ccan-autodata.o ccan-breakpoint.o ccan-crypto-hmac.o ccan-crypto-hkdf.o ccan-crypto-ripemd160.o 11:31 < AmikoPay_CJP> ccan-crypto-sha256.o ccan-crypto-siphash24.o ccan-err.o ccan-fdpass.o ccan-htable.o ccan-ilog.o ccan-io-io.o ccan-intmap.o ccan-io-poll.o ccan-io-fdpass.o ccan-isaac.o ccan-isaac64.o ccan-list.o ccan-mem.o ccan-noerr.o ccan-opt-helpers.o ccan-opt-parse.o ccan-opt-usage.o ccan-opt.o ccan-pipecmd.o ccan-read_write_all.o ccan-str-hex.o ccan-str.o ccan-take.o ccan-tal-grab_file.o ccan-tal-path.o ccan-tal-str.o ccan-tal.o 11:31 < AmikoPay_CJP> ccan-time.o ccan-timer.o lightningd/sphinx.o utils.o version.o libwallycore.a libsecp256k1.a libsodium.a -lprotobuf-c -lgmp -lsqlite3 -o test/test_protocol 11:31 < AmikoPay_CJP> cc -Werror -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -g -fstack-protector -I ccan -I libwally-core/src/secp256k1/include/ -I libwally-core/include/ -I libsodium/src/libsodium/include/ -I . -DSHACHAIN_BITS=48 -I. -c -o test/test_sphinx.o test/test_sphinx.c 11:31 < AmikoPay_CJP> cc test/test_sphinx.o bitcoin/base58.o bitcoin/block.o bitcoin/locktime.o bitcoin/pubkey.o bitcoin/pullpush.o bitcoin/script.o bitcoin/shadouble.o bitcoin/signature.o bitcoin/tx.o bitcoin/varint.o bitcoin/libbase58.o wire/wire_sync.o wire/wire_io.o wire/fromwire.o wire/peer_wire.o wire/towire.o wire/gen_peer_wire.o ccan-asort.o ccan-autodata.o ccan-breakpoint.o ccan-crypto-hmac.o ccan-crypto-hkdf.o ccan-crypto-ripemd160.o 11:31 < AmikoPay_CJP> ccan-crypto-sha256.o ccan-crypto-siphash24.o ccan-err.o ccan-fdpass.o ccan-htable.o ccan-ilog.o ccan-io-io.o ccan-intmap.o ccan-io-poll.o ccan-io-fdpass.o ccan-isaac.o ccan-isaac64.o ccan-list.o ccan-mem.o ccan-noerr.o ccan-opt-helpers.o ccan-opt-parse.o ccan-opt-usage.o ccan-opt.o ccan-pipecmd.o ccan-read_write_all.o ccan-str-hex.o ccan-str.o ccan-take.o ccan-tal-grab_file.o ccan-tal-path.o ccan-tal-str.o ccan-tal.o 11:31 < AmikoPay_CJP> ccan-time.o ccan-timer.o lightningd/sphinx.o utils.o version.o libwallycore.a libsecp256k1.a libsodium.a -lprotobuf-c -lgmp -lsqlite3 -o test/test_sphinx 11:31 < AmikoPay_CJP> (echo 'enum PktCase {'; grep '^ PKT__' lightning.pb-c.h; echo '};') | ccan/ccan/cdump/tools/cdump-enumstr - | sed 's/enum PktCase/Pkt__PktCase/' > daemon/gen_pkt_names.h 11:31 < AmikoPay_CJP> cc -Werror -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -g -fstack-protector -I ccan -I libwally-core/src/secp256k1/include/ -I libwally-core/include/ -I libsodium/src/libsodium/include/ -I . -DSHACHAIN_BITS=48 -USHACHAIN_BITS -c -o daemon/lightningd.o daemon/lightningd.c 11:32 < AmikoPay_CJP> In file included from daemon/state.h:5:0, 11:32 < AmikoPay_CJP> from daemon/peer.h:16, 11:32 < AmikoPay_CJP> from daemon/db.h:4, 11:32 < AmikoPay_CJP> from daemon/lightningd.c:3: 11:32 < cdecker> Pastebin? 11:32 < AmikoPay_CJP> ./daemon/state_types.h:65:13: error: 'PKT__PKT_OPEN' undeclared here (not in a function) 11:32 < AmikoPay_CJP> PKT_OPEN = PKT__PKT_OPEN, 11:32 < cdecker> Yeah, I'm also currently running against that problem 11:32 < AmikoPay_CJP> [etc., similar errors] 11:33 < cdecker> That is also part of the protobuf, apparently we reach into the generated files where we shouldn't 11:33 < cdecker> Maybe it's easiest to disable the legacy daemon altogether 11:33 < AmikoPay_CJP> how? 11:34 < cdecker> I.e., remove the rule for daemon/lightningd and the path that goes from the default target 11:34 -!- starkness [~starkness@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Client Quit] 11:35 < AmikoPay_CJP> This line? 11:35 < AmikoPay_CJP> default: $(PROGRAMS) doc-all daemon-all 11:35 < cdecker> Uh oh, that's going to be a bit more painful 11:35 < cdecker> I'll have to try to get that working on my own first 11:36 < AmikoPay_CJP> I thought I could just cd into the lightningd directory and make there, but it's not that simple either. 11:37 < cdecker> Yeah, it'll call the root makefile :-) 11:38 < cdecker> `make lightningd/lightningd` should work, but it currently pulls in some of the legacy stuff which is just plain stupid 11:38 < cdecker> I'll prune those includes and see if I can compile 11:38 < cdecker> But now I need to finish cooking 11:38 -!- starkness [~starkness@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #lightning-dev 11:38 < AmikoPay_CJP> :-) 11:38 < cdecker> I'll try afterwards (or tomorrow morning) 11:38 < cdecker> Thanks for bringing these up btw, I hadn't tried on jessie yet 11:38 < AmikoPay_CJP> ok 11:39 < AmikoPay_CJP> you're welcome, and thanks for the support. 11:42 < cdecker> No problem, any time (now that I have channel notifications I should also see messages in time ^^) 12:09 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has joined #lightning-dev 12:37 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 13:19 -!- AmikoPay_CJP [~AmikoPay_@a83-163-77-195.adsl.xs4all.nl] has quit [Quit: Leaving] 13:20 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 258 seconds] 14:20 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 14:57 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has quit [Remote host closed the connection] 15:03 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has joined #lightning-dev 15:16 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has quit [Remote host closed the connection] 15:42 -!- nemgun [~nemgun@105.101.144.71] has quit [Read error: Connection reset by peer] 15:43 -!- starkness [~starkness@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Quit: starkness] 15:43 -!- nemgun [~nemgun@105.101.158.11] has joined #lightning-dev 15:59 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has joined #lightning-dev 16:04 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has quit [Ping timeout: 240 seconds] 16:58 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:08 -!- maaku [~mark@173.234.25.100] has quit [Quit: Lost terminal] 17:18 -!- maaku [~mark@173.234.25.100] has joined #lightning-dev 18:02 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fxkmziqrrvqcuxpl] has quit [Quit: Connection closed for inactivity] 18:29 -!- starkness [~starkness@cpe-69-200-236-97.nyc.res.rr.com] has joined #lightning-dev 19:28 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #lightning-dev 19:34 -!- sirius_101 [4aed891c@gateway/web/freenode/ip.74.237.137.28] has joined #lightning-dev 19:44 < sirius_101> setting up litcoin testnet node w/lnd. Cannot establish connection to ltc test faucet --- https://pastebin.com/iwhiDyZP 20:26 -!- nemgun [~nemgun@105.101.158.11] has quit [Quit: Leaving] 20:31 -!- starkness [~starkness@cpe-69-200-236-97.nyc.res.rr.com] has quit [Quit: starkness] 21:02 -!- sirius_101 [4aed891c@gateway/web/freenode/ip.74.237.137.28] has left #lightning-dev [] 21:25 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has joined #lightning-dev 22:53 -!- CubicEarth [~cubiceart@50-1-104-188.dsl.dynamic.fusionbroadband.com] has joined #lightning-dev 23:12 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has quit [Remote host closed the connection] 23:21 -!- bedeho [~bedeho@91.90-149-204.nextgentel.com] has joined #lightning-dev 23:22 -!- CubicEarth [~cubiceart@50-1-104-188.dsl.dynamic.fusionbroadband.com] has quit [] 23:32 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 23:47 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vtgbmkbyomnovnoi] has joined #lightning-dev 23:49 -!- JackH [~laptop@46.231.18.66] has joined #lightning-dev