--- Log opened Mon May 24 00:00:04 2021 00:13 -!- Xaldafax [~Xaldafax@cpe-198-72-160-101.socal.res.rr.com] has quit [Ping timeout: 246 seconds] 00:17 -!- orccoin [~Rheanna@101.89.207.55] has quit [Remote host closed the connection] 00:19 -!- orccoin [~Rheanna@101.89.207.55] has joined #lightning-dev 00:32 -!- OJD [~OJDz@ool-182e587b.dyn.optonline.net] has joined #lightning-dev 00:32 -!- orccoin [~Rheanna@101.89.207.55] has quit [Remote host closed the connection] 00:34 -!- orccoin [~Rheanna@101.91.193.123] has joined #lightning-dev 00:55 -!- OJD [~OJDz@ool-182e587b.dyn.optonline.net] has quit [Quit: Leaving] 00:59 -!- riclas [riclas@77.7.37.188.rev.vodafone.pt] has joined #lightning-dev 01:08 -!- orccoin [~Rheanna@101.91.193.123] has quit [Remote host closed the connection] 01:10 -!- orccoin [~Rheanna@101.91.193.123] has joined #lightning-dev 01:13 -!- ThomasV__ [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 01:57 -!- orccoin [~Rheanna@101.91.193.123] has quit [Remote host closed the connection] 01:59 -!- orccoin [~Rheanna@101.91.193.123] has joined #lightning-dev 02:47 -!- orccoin [~Rheanna@101.91.193.123] has quit [Remote host closed the connection] 02:49 -!- orccoin [~Rheanna@101.91.238.197] has joined #lightning-dev 02:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 03:11 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 240 seconds] 03:17 -!- queip [~queip@unaffiliated/rezurus] has joined #lightning-dev 04:27 -!- orccoin [~Rheanna@101.91.238.197] has quit [Remote host closed the connection] 04:28 -!- orccoin [~Rheanna@101.89.154.192] has joined #lightning-dev 04:42 -!- orccoin [~Rheanna@101.89.154.192] has quit [Remote host closed the connection] 04:44 -!- orccoin [~Rheanna@101.91.209.187] has joined #lightning-dev 04:48 -!- ThomasV__ [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 240 seconds] 04:54 -!- belcher_ is now known as belcher 05:17 -!- orccoin [~Rheanna@101.91.209.187] has quit [Remote host closed the connection] 05:19 -!- orccoin [~Rheanna@101.91.209.187] has joined #lightning-dev 05:32 -!- orccoin [~Rheanna@101.91.209.187] has quit [Remote host closed the connection] 05:34 -!- orccoin [~Rheanna@101.89.207.55] has joined #lightning-dev 06:07 -!- berndj [~berndj@ns1.linksynergy.co.za] has left #lightning-dev ["Leaving"] 06:07 -!- orccoin [~Rheanna@101.89.207.55] has quit [Remote host closed the connection] 06:09 -!- orccoin [~Rheanna@101.89.207.55] has joined #lightning-dev 06:21 -!- orccoin [~Rheanna@101.89.207.55] has quit [Remote host closed the connection] 06:23 -!- orccoin [~Rheanna@101.91.192.124] has joined #lightning-dev 06:26 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 06:48 -!- Zana [~lord@c-66-229-1-22.hsd1.fl.comcast.net] has joined #lightning-dev 06:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #lightning-dev 06:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 06:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #lightning-dev 07:11 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 260 seconds] 07:12 -!- orccoin [~Rheanna@101.91.192.124] has quit [Remote host closed the connection] 07:14 -!- orccoin [~Rheanna@119.96.171.22] has joined #lightning-dev 07:17 -!- Xaldafax [~Xaldafax@cpe-198-72-160-101.socal.res.rr.com] has joined #lightning-dev 07:47 -!- orccoin [~Rheanna@119.96.171.22] has quit [Remote host closed the connection] 07:49 -!- orccoin [~Rheanna@119.96.171.22] has joined #lightning-dev 07:52 -!- contrapumpkin is now known as copumpkin 07:54 -!- ryanthegentry [883195f5@136.49.149.245] has joined #lightning-dev 08:02 -!- orccoin [~Rheanna@119.96.171.22] has quit [Remote host closed the connection] 08:03 -!- orccoin [~Rheanna@119.96.171.22] has joined #lightning-dev 08:08 -!- orccoin [~Rheanna@119.96.171.22] has quit [Remote host closed the connection] 08:09 -!- orccoin [~Rheanna@119.96.171.22] has joined #lightning-dev 08:11 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has joined #lightning-dev 08:24 -!- orccoin [~Rheanna@119.96.171.22] has quit [Quit: Leaving.] 08:27 -!- ThomasV [~ThomasV@unaffiliated/thomasv] has quit [Ping timeout: 260 seconds] 08:39 -!- orccoin [~Rheanna@119.96.171.22] has joined #lightning-dev 08:52 -!- orccoin [~Rheanna@119.96.171.22] has quit [Remote host closed the connection] 08:53 -!- orccoin [~Rheanna@218.78.77.129] has joined #lightning-dev 09:05 -!- molz_ [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer] 09:06 -!- mol [~mol@unaffiliated/molly] has joined #lightning-dev 09:07 -!- mol_ [~mol@unaffiliated/molly] has joined #lightning-dev 09:11 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 09:37 -!- ryanthegentry [883195f5@136.49.149.245] has quit [Quit: Connection closed] 10:31 -!- orccoin [~Rheanna@218.78.77.129] has quit [Remote host closed the connection] 10:33 -!- orccoin [~Rheanna@101.91.180.110] has joined #lightning-dev 10:51 -!- ryanthegentry [883195f5@136.49.149.245] has joined #lightning-dev 11:07 -!- orccoin [~Rheanna@101.91.180.110] has quit [Remote host closed the connection] 11:10 -!- orccoin [~Rheanna@101.91.180.110] has joined #lightning-dev 11:14 -!- deusexbeer [~deusexbee@093-092-176-212-dynamic-pool-adsl.wbt.ru] has quit [Ping timeout: 265 seconds] 11:16 -!- deusexbeer [~deusexbee@093-092-179-195-dynamic-pool-adsl.wbt.ru] has joined #lightning-dev 11:20 -!- molz_ [~mol@unaffiliated/molly] has joined #lightning-dev 11:24 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 11:42 -!- emcy_ [~emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 11:42 -!- emcy_ [~emcy@unaffiliated/emcy] has joined #lightning-dev 11:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 11:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #lightning-dev 12:04 -!- lndev-bot [~docker-me@243.86.254.84.ftth.as8758.net] has joined #lightning-dev 12:11 -!- orccoin [~Rheanna@101.91.180.110] has quit [Remote host closed the connection] 12:13 -!- orccoin [~Rheanna@101.91.218.28] has joined #lightning-dev 12:38 -!- joost_ [~joostjgr@2a02-a450-1546-1-bb6a-febc-1dd9-74f0.fixed6.kpn.net] has joined #lightning-dev 12:41 -!- joost__ [~joostjgr@2a02-a450-1546-1-bb6a-febc-1dd9-74f0.fixed6.kpn.net] has joined #lightning-dev 12:41 -!- joost_ [~joostjgr@2a02-a450-1546-1-bb6a-febc-1dd9-74f0.fixed6.kpn.net] has quit [Client Quit] 12:41 -!- joost__ [~joostjgr@2a02-a450-1546-1-bb6a-febc-1dd9-74f0.fixed6.kpn.net] has left #lightning-dev [] 12:42 -!- joost_ [~joostjgr@2a02-a450-1546-1-bb6a-febc-1dd9-74f0.fixed6.kpn.net] has joined #lightning-dev 12:47 -!- orccoin [~Rheanna@101.91.218.28] has quit [Remote host closed the connection] 12:48 -!- orccoin [~Rheanna@101.91.218.28] has joined #lightning-dev 12:55 < niftynei> hello hello 12:56 < niftynei> for all the early birds who want to get a look at today's agenda https://github.com/lightningnetwork/lightning-rfc/issues/874 12:57 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #lightning-dev 12:59 < BlueMatt> here today or libera? 12:59 < BlueMatt> seems like everything's moving 13:01 -!- ariard__ [~ariard@167.99.46.220] has joined #lightning-dev 13:01 -!- ariard__ [~ariard@167.99.46.220] has left #lightning-dev [] 13:01 < niftynei> probably best to use a deprecation plan? 13:02 -!- orccoin [~Rheanna@101.91.218.28] has quit [Remote host closed the connection] 13:02 < niftynei> e.g. email to list announcing move 13:02 < BlueMatt> :shrug: thats what channel topics are for 13:02 < BlueMatt> also we could do the usual of just kicking everyone from here lol 13:02 < rusty> There are still many more people here than in the libera.chat channel though. I had intended to at least warn ppl that if this goes away, we'll be there... 13:03 < BlueMatt> but i think we should at least get a logger set up on libera 13:03 -!- orccoin [~Rheanna@101.91.180.110] has joined #lightning-dev 13:03 < rusty> BlueMatt: indeed. Until then we remain here, where the meetbot is :) 13:04 < BlueMatt> heh, fair 13:04 < BlueMatt> who does the logging here anyway? 13:04 < ariard> let's do it here for this week and libera next time? 13:04 < BlueMatt> kanzure: or someone? 13:05 < BlueMatt> anyway, meeting time? 13:05 < rusty> BlueMatt: aj does the logging. 13:05 < BlueMatt> ah.....aj jjjjjjjjjjjjjjjjjjjjjjjjjjjjjj 13:05 < rusty> Who's chairing this week? 13:06 <+roasbeef> is the libera thing even happening? never found a easily readable summary about what's even going on 13:06 <+roasbeef> everything is also still on freenode afaict 13:07 < rusty> roasbeef: grab your nick now, in case Freenode stops working though :) 13:07 <+roasbeef> do we have any reason to believe it 13:07 <+roasbeef> 'll actually stop working? 13:07 < BlueMatt> roasbeef: yea, I think its more of a "freenode has been sketchy af for years, and we should have moved then, but now is a good excuse" thing 13:07 * jkczyz waves 13:07 < BlueMatt> and, yes, freenode ownership is absolutely maximally sketch 13:08 < BlueMatt> but I assume it'll keep running 13:08 <+roasbeef> BlueMatt: what's diff from now vs when the same thign happened like 2 yrs ago? idk I skimmed stuff and it just seems liek personal beef, why should we all be displaced because of that? 13:08 < BlueMatt> (and highly filled with anti-bitcoiners) 13:08 < rusty> roasbeef: well, given all their tech staff seems to have left, I suspect they're one failure away from total fail. 13:08 < jkczyz> i've been getting a ton of spam on freenode since the switch 13:08 < BlueMatt> roasbeef: apparently something about them actually trying to impose control vs previously they'd just owned it, but personally I've wanted to move since the acquisition 2 years ago :p 13:09 <+roasbeef> rusty: iirc some of them had like resignation notices "leak" but they weren't actually leaving? from my pov I still don't really understand the story 13:09 <+roasbeef> ¯\_(ツ)_/¯ 13:09 < BlueMatt> I mean either way, freenode is sketch af. the libera thing seems also kinda sketch, but I've never been against oftc either lol 13:09 -!- ariard_ [~ariard@167.99.46.220] has quit [Quit: Lost terminal] 13:11 < devrandom> IRC UX is a pain... how about matrix? 13:11 < rusty> OK, let's get this bikeshed started! 13:11 < rusty> #startmeeting 13:11 < lndev-bot> rusty: Error: A meeting name is required, e.g., '#startmeeting Marketing Committee' 13:12 < rusty> #startmeeting https://github.com/lightningnetwork/lightning-rfc/issues/874 13:12 < lndev-bot> Meeting started Mon May 24 20:12:12 2021 UTC and is due to finish in 60 minutes. The chair is rusty. Information about MeetBot at http://wiki.debian.org/MeetBot. 13:12 < lndev-bot> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 13:12 < lndev-bot> The meeting name has been set to 'https___github_com_lightningnetwork_lightning_rfc_issues_874' 13:12 < rusty> #topic https://github.com/lightningnetwork/lightning-rfc/pull/872 13:13 < rusty> Ouch, roasbeef I hadn't seen this before. 13:14 <+roasbeef> rusty: yeh something we ran into a while ago, but didn't know what was up, then the launch of our new node analysis thingy ended up triggering it w/ the ACINQ node, and we dug in exchanging error info till we found it 13:14 * rusty wonders what c-lightning does, but fortunately with those test vectors I know I'm going to find out today. 13:14 <+roasbeef> mpp kinda causes it to occur more often since the payhash is always re-used 13:14 <+roasbeef> and if you split in half, then the amts may be the same more often 13:14 <+roasbeef> rusty: I checked and iirc CL does msat 13:15 <+roasbeef> assuming this is where the sorting happens: https://github.com/ElementsProject/lightning/blob/ade10e7fc4dacbb9d635b05152c7dc38c0896ce7/common/permute_tx.c#L138 13:15 < rusty> roasbeef: yeah, that would be the "obvious" approach. And wrong ofc. 13:15 <+roasbeef> err does sat* 13:15 < BlueMatt> I believe we do sat 13:16 < rusty> I mean. Of course we do it correctly! Yeah! Go us! (Meh, only because we post-sort the tx after construction, so bullet dodged) 13:16 <+roasbeef> yeh small fix which is nice, hard to know how many force closes over the past few years have happened because of this 13:16 <+roasbeef> acinq has a fix up on their end 13:17 < rusty> BlueMatt: I thought there was a proposal to spell out and not just refer to BIP 69. Maybe it got lost in the backlog? 13:17 <+roasbeef> which has been merged 13:17 < BlueMatt> rusty: I dunno, I've complained about that a few times, but I think I've always just been loud and annoying and never done the work to fix it 13:17 < midnight> fwiw, I have a reliable report of the new owner who has now direct control over the infrastructure, breaking into an email account and a slack server. Additionally, pointers in /topic which state the channel as moved to libera, Lee is directly using as justification for channel takeover. New staff who have demonstrated fairly extreme hostility (even for our sensibilities) are now invading/joining 13:18 < midnight> channels, and Freenode infrastructure and services are being replaced. Why are they being replaced? Who knows. 13:18 < rusty> OK, I do not know how to ack #872 hard enough. Would like to test the vectors though: assuming they pass, everyone happy with applying? 13:19 < BlueMatt> if we're fixing it for the 3rd time now I'd kinda prefer we finally actually drop the BIP 69 reference and be self-contained, but, yea, looks good. 13:19 <+roasbeef> rusty: added some test vectors from pierre to include the msat rounding 13:19 < midnight> Apologies, I didn't see the meeting start. 13:19 < rusty> roasbeef: yeah, I just wanna incorporate them in the c-lightning vector tests. Should only take me 10 minutes. 13:20 < BlueMatt> thanks for context either way, midnight 13:20 < midnight> \o 13:20 < rusty> #action BlueMatt to create PR to excise BIP-69 references in favor of explicit ordering requirements. 13:21 < rusty> OK, so seems like we have consensus? Any objections to applying #872? 13:22 < kanzure> BlueMatt: i do logging 13:22 < kanzure> at least the one in the /topic 13:22 < BlueMatt> kanzure: plz2log libera 13:22 < kanzure> just let me know where to point it to 13:23 < BlueMatt> rusty: let me just suggest a different text for roasbeef on 872. we all know how long trivial prs lie around.... 13:23 < kanzure> will the channel be moving entirely or should i be logging both places? 13:24 < kanzure> and if so, what is the new channel name? 13:24 < rusty> BlueMatt: not if we pre-approve the open-coding now? I'd rather agree to merge 872 (pending final test vector check), then pre-approve an open-coded BIP-69 replace assuming two of us sign off. 13:24 <+roasbeef> BlueMatt: which would be to essentially include the BIP 69 text? 13:24 < BlueMatt> roasbeef: honestly, bip 69 is, itself, underspecified 13:24 < BlueMatt> rusty: eh, whatever. 13:24 < ariard> kanzure: i believe it's still lightning-dev 13:24 <+roasbeef> in this context, only becauase we added this tie-breaker, where else is it underspecified? 13:25 < rusty> roasbeef: I believe the shorter-wins tiebreak is also unspecified in BIP-69. 13:25 <+roasbeef> gotcha, if so ofc it can be updated to make it more fully specified 13:26 < rusty> i.e. "ab" < "abc". Which is common convention, but still needs to be spelled out. 13:26 < rusty> It's pretty trivial tho, so I think it comes under "spelling rule", esp if we've agreed here to it? 13:26 < BlueMatt> anyway, either https://github.com/lightningnetwork/lightning-rfc/pull/872/files#r638250523 or I'll open a new pr with that text. 13:26 < BlueMatt> either way ack the total with that. 13:27 < rusty> BlueMatt: Ack that change. We can clean it up into an ordered list as a spelling fix if we want. 13:27 < BlueMatt> right, or that. 13:27 <+roasbeef> rusty: yeh I meant update BIP 69 itself for that length case 13:28 < rusty> roasbeef: yeah, but BIP-69 is DOA afaict? 13:28 < BlueMatt> roasbeef: bip 69 should basically be used absolutely never anyway. so why bother updating it? :) 13:28 <+roasbeef> is it? 13:28 < BlueMatt> yes, I think that's a pretty universally-held view that bip 69 is fundamentally a bad idea. 13:28 <+roasbeef> BlueMatt: pretty useful in practice imo, just because you don't use it doesn't mean it isn't useful... 13:28 < BlueMatt> well, outside of lightning where you need a consistent sort order, of course 13:29 < BlueMatt> roasbeef: dunno, you're literally the first person I've spoken to who is sensible on these things who has thought it was a reasonable thing in almost any context outside of lightning. 13:29 < devrandom> the order could be pseudo-random instead? 13:29 <+roasbeef> we use it in pool as an eaxmple, useful to have a cannonical ordering in any multi-party transaction context 13:30 < BlueMatt> devrandom: yes, there is basically no reason to ever prefer sorted over random unless you're doing something like lightning 13:30 < BlueMatt> anyway, this is quite a tangent 13:31 < rusty> roasbeef: better is an order by shared secret-prefix SHA, though until taproot it's a bit pointless to try to hide IMHO? 13:31 <+roasbeef> idk make your own sorting BIP then if you don't like it, BIPs just say how things can be done, if ppl find them useful (like in thsi context), they'll use it 13:31 < BlueMatt> (and if we ever had commitment transactions that weren't obviously-lightning I'd strongly suggest we permute the order by a shared secret) 13:31 <+roasbeef> seems this entire time, no one has cared enough to make another one 13:31 < BlueMatt> roasbeef: why write a bip for the thing that all wallets that are halfway decent already do :) 13:31 <+roasbeef> BlueMatt: something something standards 13:31 < rusty> BlueMatt: snap! In fact, dual funding gives you this control over ordering. 13:32 < BlueMatt> rusty: huh! good opportunity to do sorting with a shared-secret permutation? 13:32 < BlueMatt> rusty: I'd strongly suggest we do that to avoid standing out (though i assume it doesnt matter until taproot?) 13:33 < rusty> BlueMatt: on co-construction, you explicitly give an ordering. So you can do whatever you want in this case. 13:33 < niftynei> iiuc the DLC project uses the same protocol for ordering as the dual-funding proposal 13:33 < BlueMatt> ah! hmmm, i guess sensible implementations will randomize. guess it'd be cool to just force it to be random based on some shared random values (like pubkeys that dont ever hit the chain) 13:33 -!- ryanthegentry [883195f5@136.49.149.245] has quit [Quit: Connection closed] 13:33 < BlueMatt> avoids one more parameter on the wire, which is also always good 13:33 -!- ryanthegentry [883195f5@136.49.149.245] has joined #lightning-dev 13:34 < ariard> yes we have custom inputs'serial_id in dlcs 13:34 < rusty> BlueMatt: Naah, you may want explicit ordering for weird SIGHASH_SINGLE tricks etc. 13:34 < BlueMatt> ohhh, hum. yuck but ok 13:35 < rusty> Anyway, meanwhile I'm happy with Matt's text. Simply spelling out the requirement is nice. 13:35 * BlueMatt has always found it confusing to have to click through to bip 69, and was confused the first time he read it and had to look up implementation details for what to do if lengths differ 13:37 -!- orccoin [~Rheanna@101.91.180.110] has quit [Remote host closed the connection] 13:38 < rusty> OK, so I think we're in bikeshed territory? Let's hash it out on issue, and apply it with or without Matt's reword. I'd rather not block it on tangential rewording. 13:38 <+roasbeef> it's mergeable as is imo 13:39 < rusty> #action rusty Merge #872 (after validating test vectors). 13:39 -!- orccoin [~Rheanna@101.91.180.110] has joined #lightning-dev 13:39 < rusty> I will split Matt's change into a separate PR myself, how's that? Then we can argue there :) 13:39 < rusty> #topic https://github.com/lightningnetwork/lightning-rfc/pull/672 13:40 < BlueMatt> this seems to have enough acks already? 13:40 < BlueMatt> more than enough 13:40 < rusty> BlueMatt: Indeed. And we have Eclair and c-lightning tested interop on this (it's pretty trivial). Note that c-lightning has not implemented bech32m yet, so there's no normal way for users to supply an actual v1 address. 13:41 < rusty> Any objections to applying this? 13:41 < BlueMatt> do it 13:41 <+roasbeef> heh yeh thought this was merged a while ago 13:41 <+roasbeef> do eet 13:41 < rusty> #action rusty to merge #672 13:42 < rusty> #topic https://github.com/lightningnetwork/lightning-rfc/issues/873 13:42 < BlueMatt> yes, would be nice, someone's gotta do the work :/ 13:43 < rusty> Someone remind me of the purpose of this? Is it more a "why not, it's free?" 13:43 < BlueMatt> yea, basically, though marginally increases the cost of dos'ing a channel so you have to actually put up non-dust values 13:44 <+roasbeef> basically that someone can add dust and make your channel less useful 13:44 -!- lnd-bot [~lnd-bot@165.227.7.29] has joined #lightning-dev 13:44 < lnd-bot> [lightning-rfc] TheBlueMatt opened pull request #876: Concretize Output Ordering to be less confusing (master...2021-05-no-bip69) https://github.com/lightningnetwork/lightning-rfc/pull/876 13:44 -!- lnd-bot [~lnd-bot@165.227.7.29] has left #lightning-dev [] 13:45 < rusty> Well, since dust levels don't have to be the same on both sides, this proposal is insufficient? 13:45 < BlueMatt> tbh i didnt read the proposed text lol 13:45 < rusty> I think it has to be "if either side considers it non-dust, we count it"? 13:45 < BlueMatt> yea, probably what you said rusty 13:46 <+roasbeef> rusty: well the dust is already asymmetric, so I imagine this would be as well? 13:46 <+roasbeef> at a high level is proposes not counting dust htlcs to the max htlc limit 13:47 <+roasbeef> which would then be clamped only by the max dust settings 13:47 <+roasbeef> tho maybe just two limits a better? 13:48 < BlueMatt> but if you have one side that adds a billion dust outputs but they aren't dust for the other side, then the other side cant broadcast a transaction cause it has a billion outputs? 13:48 < rusty> Well, I guess if you propose 1M dust htlcs which are not dust for yourself, that's on you? 13:48 < BlueMatt> cause the dust limit of the broadcaster applies to all the htlcs not just the broadcaster's htlcs 13:48 < BlueMatt> wouldnt you be able to prevent someone from broadcasting their commitment tx? 13:48 < rusty> BlueMatt: the proposal says you can't add an htlc if it would go over the max for the *other* side. 13:48 <+roasbeef> BlueMatt: each side says what their dust limit is tho 13:49 < joost_> hi all. won't this open up a new vector where an attacker can send indeed a billion htlcs along the same (26 hop) route into the network? it won't weigh down on the commit txes, but it does on processing 13:49 < rusty> BlueMatt: so I think you can only shoot yourself. 13:49 < joost_> (1 msat htlcs) 13:49 <+roasbeef> joost_: yeh so there needs to be another count clamp on dust htlcs themselves 13:49 < BlueMatt> joost_: I dont see why that needs a separate limit? you already have fees and its no different than any other htlc 13:50 <+roasbeef> I think the ML post has more context here also 13:50 < rusty> BlueMatt: if you set fees to zero you get this problem though, I guess. 13:50 <+roasbeef> I g2g in 10 13:50 < BlueMatt> rusty: I mean you get that problem if you send a bajillion 1sat htlcs too.... 13:51 < BlueMatt> rusty: ok, I think I agree that as worded you can only shoot yourself. I'd propose mentioning that you can shoot yourself in the spec. 13:52 <+roasbeef> BlueMatt: another limit since those would all be dust, you need to clamp dust and non dust in total count of each 13:52 -!- orccoin [~Rheanna@101.91.180.110] has quit [Remote host closed the connection] 13:52 < BlueMatt> roasbeef: why 13:52 < BlueMatt> roasbeef: what is wrong with having a ton of dust outputs? 13:52 <+roasbeef> that PR says don't count dust towards the max htlc number anymore 13:52 < rusty> Thinking more, I'm not sure what the actual CPU limitation BigNum dust HTLCs would be. I suspect we may have some O(N^2) somewhere in our tx construction code maybe? 13:52 <+roasbeef> what stops a commitment from being fully dusted if that isn't there BlueMatt ? 13:53 < BlueMatt> rusty: it doesnt feed into tx construction, though? 13:53 < BlueMatt> rusty: you dont have to send signatures for a dust htlc, too! 13:53 < rusty> BlueMatt: we discard them though, and turn them into fees. 13:53 < BlueMatt> roasbeef: you already have a limit on the total in-flight? 13:53 < rusty> BlueMatt: I think that's O(N). 13:53 <+roasbeef> BlueMatt: that PR says you don't count dust towards total in flight anymore 13:54 < BlueMatt> roasbeef: htlc count, I assumed we'd still count them towards value-in-flight 13:54 < rusty> BlueMatt: yeah, but a 1 BTC channel can easily have > 10M dust htlcs. 13:54 < BlueMatt> rusty: right, would need to read code carefully, but i was assuming signature creation/checking would basically dwarf you in any case 13:54 < BlueMatt> ie even one signature could dwarf 1M simple ifs in a for loop....depending on how the code is 13:54 -!- orccoin [~Rheanna@101.89.207.55] has joined #lightning-dev 13:54 < rusty> BlueMatt: I'd like to benchmark, just to be sure. We never bothered optimizations for < 1000 htlcs as we have now. 13:55 < BlueMatt> yes, agreed 13:55 < rusty> OK, so next step is to turn it into actual patch with caveats mentioned here? 13:55 < BlueMatt> +1 13:55 <+roasbeef> i'll ping eugene about that 13:56 <+roasbeef> (crypt-iq) 13:56 < rusty> #action rusty to assign feature bit for #873 13:56 < niftynei> seems like setting a "max fees from dust" limit might be a better way to approach this than a cap on the num of 'dust htlcs' 13:56 < BlueMatt> let me paste this on the issue 13:56 < BlueMatt> niftynei: sgtm 13:57 < rusty> OK, I say we end the meeting early, rather than trying to squeeze something in 4 minutes? 13:57 < BlueMatt> niftynei: its already hard to pick appropriate dust limits trying to munge a "max fees from dust" limit out of it. having an explicit "max fees from dust" seems strictly better than today in any case. 13:57 < BlueMatt> rusty: ack 13:58 < rusty> #endmeting 13:58 < rusty> #endmeeting 13:58 < lndev-bot> Meeting ended Mon May 24 20:58:06 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 13:58 < lndev-bot> Minutes: https://lightningd.github.io/meetings/https___github_com_lightningnetwork_lightning_rfc_issues_874/2021/https___github_com_lightningnetwork_lightning_rfc_issues_874.2021-05-24-20.12.html 13:58 < lndev-bot> Minutes (text): https://lightningd.github.io/meetings/https___github_com_lightningnetwork_lightning_rfc_issues_874/2021/https___github_com_lightningnetwork_lightning_rfc_issues_874.2021-05-24-20.12.txt 13:58 < lndev-bot> Log: https://lightningd.github.io/meetings/https___github_com_lightningnetwork_lightning_rfc_issues_874/2021/https___github_com_lightningnetwork_lightning_rfc_issues_874.2021-05-24-20.12.log.html 13:58 * rusty needs more coffee... OK, thanks everyone! 13:58 < niftynei> thanks for chairing rusty! 14:00 < rusty> Hmm, none of those links from the bot work :( 14:03 < harding> rusty: the links from last week also don't work, so it could be a general misconfiguration / something broken. 14:07 -!- joost_ [~joostjgr@2a02-a450-1546-1-bb6a-febc-1dd9-74f0.fixed6.kpn.net] has quit [Quit: Leaving] 14:15 -!- lnd-bot [~lnd-bot@165.227.7.29] has joined #lightning-dev 14:15 < lnd-bot> [lightning-rfc] rustyrussell merged pull request #872: BOLT-03: make sats portion of HTLC CLTV tie-breaker more explicit (master...explicit-cltv-tiebreaker) https://github.com/lightningnetwork/lightning-rfc/pull/872 14:15 -!- lnd-bot [~lnd-bot@165.227.7.29] has left #lightning-dev [] 14:15 -!- lnd-bot [~lnd-bot@165.227.7.29] has joined #lightning-dev 14:15 < lnd-bot> [lightning-rfc] rustyrussell pushed 2 commits to master: https://github.com/lightningnetwork/lightning-rfc/compare/a9db80e49d17...46d798e1046b 14:15 < lnd-bot> lightning-rfc/master e336241 Olaoluwa Osuntokun: BOLT-03: make sats portion of HTLC CLTV tie-breaker more explicit 14:15 < lnd-bot> lightning-rfc/master 46d798e Olaoluwa Osuntokun: BOLT-03: update test vectors w/ updated HTLC tie-breaker case 14:15 -!- lnd-bot [~lnd-bot@165.227.7.29] has left #lightning-dev [] 14:16 -!- lnd-bot [~lnd-bot@165.227.7.29] has joined #lightning-dev 14:16 < lnd-bot> [lightning-rfc] rustyrussell merged pull request #672: BOLT 2: `option_shutdown_anysegwit` (Feature 26/27) (master...opt_shutdown_moreversions) https://github.com/lightningnetwork/lightning-rfc/pull/672 14:16 -!- lnd-bot [~lnd-bot@165.227.7.29] has left #lightning-dev [] 14:16 -!- lnd-bot [~lnd-bot@165.227.7.29] has joined #lightning-dev 14:16 < lnd-bot> [lightning-rfc] rustyrussell pushed 1 commit to master: https://github.com/lightningnetwork/lightning-rfc/compare/46d798e1046b...3508e4e85d26 14:16 < lnd-bot> lightning-rfc/master 3508e4e Rusty Russell: BOLT 2: `option_shutdown_anysegwit` 14:16 -!- lnd-bot [~lnd-bot@165.227.7.29] has left #lightning-dev [] 14:25 -!- ryanthegentry [883195f5@136.49.149.245] has quit [Quit: Connection closed] 14:27 -!- orccoin [~Rheanna@101.89.207.55] has quit [Remote host closed the connection] 14:27 -!- orccoin [~Rheanna@101.89.207.55] has joined #lightning-dev 14:37 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 265 seconds] 15:17 -!- orccoin [~Rheanna@101.89.207.55] has quit [Remote host closed the connection] 15:18 -!- orccoin [~Rheanna@218.78.43.189] has joined #lightning-dev 15:32 -!- orccoin [~Rheanna@218.78.43.189] has quit [Remote host closed the connection] 15:34 -!- orccoin [~Rheanna@101.91.180.110] has joined #lightning-dev 16:07 -!- orccoin [~Rheanna@101.91.180.110] has quit [Remote host closed the connection] 16:10 -!- orccoin [~Rheanna@101.91.180.110] has joined #lightning-dev 16:21 -!- knocte [knocte@booster.qnetp.net] has quit [Ping timeout: 240 seconds] 16:21 -!- orccoin [~Rheanna@101.91.180.110] has quit [Remote host closed the connection] 16:24 -!- orccoin [~Rheanna@119.96.171.22] has joined #lightning-dev 16:25 -!- knocte [knocte@booster.qnetp.net] has joined #lightning-dev 16:44 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 16:44 -!- shesek [~shesek@164.90.217.137] has joined #lightning-dev 16:44 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 16:44 -!- shesek [~shesek@unaffiliated/shesek] has joined #lightning-dev 17:11 -!- orccoin [~Rheanna@119.96.171.22] has quit [Remote host closed the connection] 17:14 -!- orccoin [~Rheanna@101.91.193.123] has joined #lightning-dev 17:15 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #lightning-dev 17:28 -!- mol_ [~mol@unaffiliated/molly] has joined #lightning-dev 17:31 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 17:47 -!- orccoin [~Rheanna@101.91.193.123] has quit [Remote host closed the connection] 17:50 -!- orccoin [~Rheanna@101.91.193.123] has joined #lightning-dev 18:01 -!- orccoin [~Rheanna@101.91.193.123] has quit [Remote host closed the connection] 18:03 -!- orccoin [~Rheanna@101.89.197.243] has joined #lightning-dev 18:05 -!- Netsplit *.net <-> *.split quits: luke-jr, mol_, shesek, orccoin, rusty, deusexbeer, riclas, knocte, Zana 18:07 -!- kiltzman [~k1ltzman@5.206.224.243] has quit [Ping timeout: 240 seconds] 18:15 -!- mol [~mol@unaffiliated/molly] has joined #lightning-dev 18:15 -!- kiltzman [~k1ltzman@5.206.224.243] has joined #lightning-dev 18:15 -!- Netsplit over, joins: luke-jr, rusty, shesek, deusexbeer, orccoin, knocte, Zana 18:15 -!- mol [~mol@unaffiliated/molly] has quit [Max SendQ exceeded] 18:15 -!- kiltzman [~k1ltzman@5.206.224.243] has quit [Max SendQ exceeded] 18:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Max SendQ exceeded] 18:15 -!- kiltzman [~k1ltzman@5.206.224.243] has joined #lightning-dev 18:16 -!- mol [~mol@unaffiliated/molly] has joined #lightning-dev 18:18 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #lightning-dev 18:24 -!- riclas [riclas@77.7.37.188.rev.vodafone.pt] has joined #lightning-dev 18:37 -!- orccoin [~Rheanna@101.89.197.243] has quit [Remote host closed the connection] 18:38 -!- orccoin [~Rheanna@101.89.197.243] has joined #lightning-dev 18:52 -!- orccoin [~Rheanna@101.89.197.243] has quit [Remote host closed the connection] 18:54 -!- orccoin [~Rheanna@101.91.232.94] has joined #lightning-dev 19:00 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #lightning-dev 19:23 -!- rojiro [~rojiro@gateway/tor-sasl/rojiro] has joined #lightning-dev 19:24 < rojiro> How much can a node operator make? Let say you run a pretty well connected node with let's say 1 btc of channel balances? 19:27 -!- orccoin [~Rheanna@101.91.232.94] has quit [Remote host closed the connection] 19:28 -!- orccoin [~Rheanna@101.91.232.94] has joined #lightning-dev 19:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 20:32 -!- orccoin [~Rheanna@101.91.232.94] has quit [Remote host closed the connection] 20:34 -!- orccoin [~Rheanna@101.91.197.175] has joined #lightning-dev 20:35 -!- Zana [~lord@c-66-229-1-22.hsd1.fl.comcast.net] has quit [Ping timeout: 252 seconds] 20:40 -!- orccoin [~Rheanna@101.91.197.175] has quit [Remote host closed the connection] 20:41 -!- orccoin [~Rheanna@101.91.197.175] has joined #lightning-dev 20:58 -!- awesome_doge1 [~Thunderbi@118-167-115-103.dynamic-ip.hinet.net] has joined #lightning-dev 21:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #lightning-dev 21:07 -!- orccoin [~Rheanna@101.91.197.175] has quit [Remote host closed the connection] 21:09 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #lightning-dev 21:09 -!- orccoin [~Rheanna@101.91.197.175] has joined #lightning-dev 21:12 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 21:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 21:57 -!- orccoin [~Rheanna@101.91.197.175] has quit [Remote host closed the connection] 21:59 -!- orccoin [~Rheanna@218.78.88.163] has joined #lightning-dev 22:21 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 22:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #lightning-dev 22:29 -!- Xaldafax [~Xaldafax@cpe-198-72-160-101.socal.res.rr.com] has quit [Quit: Bye...] 22:30 -!- arij [uid225068@gateway/web/irccloud.com/x-kzdscjqncznwtotd] has joined #lightning-dev 22:34 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 268 seconds] 22:47 -!- orccoin [~Rheanna@218.78.88.163] has quit [Remote host closed the connection] 22:49 -!- orccoin [~Rheanna@101.91.238.197] has joined #lightning-dev 22:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #lightning-dev 23:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds] 23:09 -!- Netsplit *.net <-> *.split quits: orccoin 23:16 -!- orccoin [~Rheanna@218.78.27.29] has joined #lightning-dev 23:37 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #lightning-dev 23:37 -!- orccoin [~Rheanna@218.78.27.29] has quit [Remote host closed the connection] 23:39 -!- orccoin [~Rheanna@218.78.27.29] has joined #lightning-dev --- Log closed Tue May 25 00:00:05 2021