--- Day changed Thu Oct 19 2017 00:22 -!- [a]akselrod [~aakselrod@gateway/vpn/privateinternetaccess/aakselrod] has quit [Ping timeout: 252 seconds] 00:23 -!- [a]akselrod [~aakselrod@2601:281:c702:8621:44b2:5f4a:72ab:28b8] has joined #lnd 00:50 -!- chjj [~chjj@unaffiliated/chjj] has joined #lnd 01:25 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 248 seconds] 01:27 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #lnd 01:32 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 01:33 -!- Emcy [~MC@unaffiliated/emcy] has joined #lnd 01:34 -!- sycofly [~sycofly@121.99.240.44] has joined #lnd 01:38 -!- Emcy_ [~MC@unaffiliated/emcy] has joined #lnd 01:41 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 01:41 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #lnd 01:42 -!- Emcy [~MC@unaffiliated/emcy] has quit [Ping timeout: 260 seconds] 01:51 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-fozbjbmbflhahbds] has quit [Quit: Connection closed for inactivity] 02:06 -!- gaf_ [~fag@12.smos-linux.org] has quit [Quit: SMOS - http://smos-linux.org] 02:33 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has joined #lnd 02:46 -!- Emcy_ [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 02:48 -!- Emcy [~MC@unaffiliated/emcy] has joined #lnd 03:00 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 03:01 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 03:27 -!- sycofly [~sycofly@121.99.240.44] has quit [Quit: This computer has gone to sleep] 03:30 -!- JackH [~laptop@91.189.61.70] has joined #lnd 04:18 -!- moctos [~moctos@cpe-107-9-138-59.neo.res.rr.com] has quit [Ping timeout: 248 seconds] 04:19 -!- esotericnonsense [~esotericn@gateway/vpn/privateinternetaccess/esotericnonsense] has quit [Ping timeout: 252 seconds] 04:26 -!- JackH [~laptop@91.189.61.70] has quit [Ping timeout: 255 seconds] 04:39 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has quit [Ping timeout: 255 seconds] 04:42 -!- eugene_ [6c1ad26e@gateway/web/freenode/ip.108.26.210.110] has joined #lnd 04:51 -!- eugene_ [6c1ad26e@gateway/web/freenode/ip.108.26.210.110] has quit [Ping timeout: 260 seconds] 04:51 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has joined #lnd 05:22 -!- deusexbeer [~deusexbee@093-092-177-156-dynamic-pool-adsl.wbt.ru] has quit [Ping timeout: 260 seconds] 05:23 -!- deusexbeer [~deusexbee@079-170-137-143-dynamic-pool-adsl.wbt.ru] has joined #lnd 05:30 -!- eugene_ [6c1ad26e@gateway/web/freenode/ip.108.26.210.110] has joined #lnd 05:33 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [] 05:46 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #lnd 05:52 -!- mrwhythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 05:54 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 06:07 -!- eugene_ [6c1ad26e@gateway/web/freenode/ip.108.26.210.110] has quit [Ping timeout: 260 seconds] 06:14 -!- dabura667 [~dabura667@KD111103034253.ppp-bb.dion.ne.jp] has joined #lnd 06:28 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has quit [Ping timeout: 252 seconds] 06:33 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has joined #lnd 07:03 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #lnd 07:35 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-gpsjbfsqolqirsrh] has quit [Quit: Connection closed for inactivity] 07:45 -!- pvs_ [d13a8e9e@gateway/web/freenode/ip.209.58.142.158] has joined #lnd 07:47 -!- pvs_ is now known as pradeep 07:47 -!- pradeep is now known as ayn 07:47 -!- ayn [d13a8e9e@gateway/web/freenode/ip.209.58.142.158] has left #lnd [] 07:49 -!- fluidjax [~fluidjax@host81-153-234-3.range81-153.btcentralplus.com] has quit [Quit: Leaving...] 07:55 -!- pradeep [d13a8e9e@gateway/web/freenode/ip.209.58.142.158] has joined #lnd 07:55 -!- pradeep [d13a8e9e@gateway/web/freenode/ip.209.58.142.158] has left #lnd [] 08:19 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has quit [Read error: No route to host] 08:19 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has joined #lnd 08:23 -!- Emcy [~MC@unaffiliated/emcy] has joined #lnd 08:37 -!- Emcy [~MC@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 08:56 -!- Emcy [~MC@unaffiliated/emcy] has joined #lnd 08:58 -!- alanc44 [~alanc@109.255.196.64] has quit [Ping timeout: 248 seconds] 09:01 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has quit [Read error: Connection reset by peer] 09:02 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has joined #lnd 09:02 -!- alanc44 [~alanc@109.255.196.64] has joined #lnd 09:07 -!- Emcy [~MC@unaffiliated/emcy] has quit [Ping timeout: 258 seconds] 09:10 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has quit [Read error: Connection reset by peer] 09:12 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has joined #lnd 09:16 -!- eck [~eck@fsf/member/eck] has quit [Quit: we out here] 09:17 -!- eck [~eck@fsf/member/eck] has joined #lnd 09:28 -!- Emcy [~MC@unaffiliated/emcy] has joined #lnd 09:42 -!- alanc44 [~alanc@109.255.196.64] has quit [Ping timeout: 246 seconds] 09:42 -!- alanc44 [~alanc@109.255.196.64] has joined #lnd 10:15 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 248 seconds] 10:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 248 seconds] 10:44 -!- afdudley [afdudleyma@gateway/shell/matrix.org/x-kgysuqlyeymwteta] has quit [Ping timeout: 252 seconds] 10:47 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #lnd 10:51 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #lnd 11:02 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has joined #lnd 11:33 -!- esotericnonsense [~esotericn@gateway/vpn/privateinternetaccess/esotericnonsense] has joined #lnd 11:49 -!- StopAndDecrypt__ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #lnd 11:50 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 252 seconds] 11:51 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Remote host closed the connection] 11:53 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 11:54 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-yazhwszykkunjrqj] has joined #lnd 12:00 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 248 seconds] 12:06 -!- mrwhythat [~whythat@gateway/tor-sasl/whythat] has quit [Remote host closed the connection] 12:07 -!- mrwhythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 12:08 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 12:16 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vqrwdpodkxbsokoj] has joined #lnd 12:34 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has quit [Read error: Connection reset by peer] 12:34 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has joined #lnd 13:36 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has quit [Quit: .] 14:15 -!- alanc44 [~alanc@109.255.196.64] has quit [Ping timeout: 240 seconds] 14:22 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has quit [Ping timeout: 255 seconds] 14:24 -!- mnkk___ [~mnk4@95.90.233.42] has joined #lnd 14:47 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #lnd 14:52 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has joined #lnd 14:57 -!- PaulCapestany [~PaulCapes@ip68-100-207-53.dc.dc.cox.net] has quit [Quit: .] 14:58 -!- afdudley [afdudleyma@gateway/shell/matrix.org/x-pzchruhisgroesam] has joined #lnd 15:11 -!- mnkk___ [~mnk4@95.90.233.42] has quit [] 15:14 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-tettgwlccdfffvhs] has quit [Quit: Connection closed for inactivity] 15:29 -github-lnd:#lnd- [lnd] cfromknecht opened pull request #384: WIP: Utxo Nursery, adds outgoing 2nd-layer HTLC persistence (master...utxn-incubate-2nd-layer-htlcs) https://git.io/vddLa 15:56 -!- abpa [~abpa@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 16:33 -!- dabura667 [~dabura667@KD111103034253.ppp-bb.dion.ne.jp] has quit [Remote host closed the connection] 17:18 -!- quitobro_ [~quitobro@pool-108-41-0-186.nycmny.fios.verizon.net] has joined #lnd 17:18 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Ping timeout: 246 seconds] 17:18 -!- quitobro_ is now known as quitobro 17:38 -github-lnd:#lnd- [lnd] Roasbeef pushed 6 new commits to master: https://git.io/vddCb 17:38 -github-lnd:#lnd- lnd/master fb32c3f Jim Posen: lnwallet: Create type to estimate transaction weights.... 17:38 -github-lnd:#lnd- lnd/master ced530f Jim Posen: lnwallet: Use TxWeightEstimator for funding transaction. 17:38 -github-lnd:#lnd- lnd/master 10a336d Jim Posen: lnwallet: Use TxWeightEstimator in breacharbiter. 17:52 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vqrwdpodkxbsokoj] has quit [Quit: Connection closed for inactivity] 18:12 -!- sdfgsdfg [~sdfgsdfg@unaffiliated/sdfgsdfg] has joined #lnd 18:32 -!- mnkk___ [~mnk4@95.90.233.42] has joined #lnd 18:41 <@roasbeef> 2017-10-19 18:41:02.158 [INF] CRTR: Pruning channel graph using block 00000000db7c434822533ac82953f740673898024424ce0bb640cbf857f543cc (height=1210624) 18:41 <@roasbeef> 2017-10-19 18:41:02.159 [INF] CRTR: Block 00000000db7c434822533ac82953f740673898024424ce0bb640cbf857f543cc (height=1210624) closed 0 channels 18:41 <@roasbeef> 2017-10-19 18:41:02.159 [INF] NTFN: New block: height=1210624, sha=00000000db7c434822533ac82953f740673898024424ce0bb640cbf857f543cc 18:41 <@roasbeef> 2017-10-19 18:41:02.159 [INF] UTXN: New block: height=1210624, sweeping 1 mature outputs 18:41 <@roasbeef> 2017-10-19 18:41:02.160 [INF] UTXN: Sweeping 1 time-locked outputs with sweep tx (txid=6f56a68e9a94315a18c6c86cde862e63497aee58a8a52c363f95f2cbcb5f40c1): (*wire.MsgTx)(0xc4208cc600)({ 18:42 < [a]akselrod> \m/ 18:42 -!- [a]akselrod is now known as aakselrod 18:48 -!- quitobro_ [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #lnd 18:49 <@roasbeef> dat block tho: https://www.smartbit.com.au/block/000000000000000000c4416a21362e41ee374bdecccd453e68cc127940b1197f 18:49 -!- quitobro [~quitobro@pool-108-41-0-186.nycmny.fios.verizon.net] has quit [Ping timeout: 248 seconds] 18:49 -!- quitobro_ is now known as quitobro 18:56 < lndbot> :O 18:58 < aakselrod> 1.4MB, 8.17sat/B 18:58 < aakselrod> no segwit adoption though 19:05 <@roasbeef> suuper low sat/byte 19:06 <@roasbeef> a bit suspect, seems like they grabbed from the "bottom" of the mempool? 19:06 <@roasbeef> btw aakselrod, in the wallet encryption PR, it seems like that validateMacaroon check should fail, no? 19:06 <@roasbeef> as in the "create" case, the macaroons don't even exist yet 19:10 <@roasbeef> ah just realized it also chagnes the default passphrase 19:13 * aakselrod looks 19:13 < aakselrod> i think i mentioned to him that unlock shouldn't use a macaroon at all 19:13 < aakselrod> nor create 19:17 -github-lnd:#lnd- [lnd] Roasbeef pushed 8 new commits to master: https://git.io/vddRW 19:17 -github-lnd:#lnd- lnd/master e6cc46d Johan T. Halseth: lnwallet: export btcwallet.NetworkDir 19:17 -github-lnd:#lnd- lnd/master 1f34bd8 Johan T. Halseth: lnrpc: add WalletUnlocker service.... 19:17 -github-lnd:#lnd- lnd/master b7ba269 Johan T. Halseth: walletunlocker: add package walletunlocker... 19:17 <@roasbeef> mhmm, will do a quick follow up commit on that 19:18 <@roasbeef> and also fallback to the default phrase 19:18 < aakselrod> i see where he has the fallback to the default phrase 19:18 <@roasbeef> ah yeh as once the macaroon rootkeys and nonces are encrypted, then wouldn't be able to otherwise 19:18 <@roasbeef> yeh there's two pharses: public and private 19:18 < aakselrod> https://twitter.com/edgette22/status/921103567771131904 19:18 <@roasbeef> lolololol 19:19 < aakselrod> er 19:19 < aakselrod> wrong paste :P 19:19 < aakselrod> https://github.com/lightningnetwork/lnd/pull/367/files#diff-ec4b517f146700b3546a7af2224b6191R180 19:19 < aakselrod> but yeah that tweet is hilarious :P 19:19 < aakselrod> and yeah, can't decrypt macaroon DB without pw, so can't verify macaroons for unlock or create :P 19:20 <@roasbeef> yeh gonnna do a quick path 19:20 <@roasbeef> also fixes a deadlock issue in chanMsgStream >_< 19:21 < aakselrod> yeah 19:24 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #lnd 19:51 -github-neutrino:#lnd- [neutrino] aakselrod opened pull request #24: [WIP] Windows rollback fix (master...windows-rollback-fix) https://git.io/vddE3 19:57 <@roasbeef> ^ noice 19:57 -github-lnd:#lnd- [lnd] Roasbeef pushed 4 new commits to master: https://git.io/vddEV 19:57 -github-lnd:#lnd- lnd/master 4cf4fd3 Olaoluwa Osuntokun: peer: in chanMsgStream release lock for condition var after msg q pop... 19:57 -github-lnd:#lnd- lnd/master 8de0a4c Olaoluwa Osuntokun: peer: when logging message summaries use the correct preposition 19:57 -github-lnd:#lnd- lnd/master 08940b4 Olaoluwa Osuntokun: walletunlocker: don't utilize the macaroon authentication service... 19:57 < aakselrod> :> 19:58 <@roasbeef> build tags ftw :) 19:58 <@roasbeef> have you tested this on a VM or on a live instance? 19:58 < aakselrod> not on a windows box yet lol 19:58 < aakselrod> thus WIP :) 19:58 <@roasbeef> hehe gotcha 19:58 < aakselrod> i've tested on linux to make sure the correct build flags are used 19:59 <@roasbeef> could cut a version of the app for our windows testers and just have them keep it running to see if it can properly eat re-orgs 19:59 < aakselrod> yeah i'd be ok with that 19:59 <@roasbeef> the whole "can't truncate while open" is an odd restriction, curious as to the underlying mechanism that prevents it 19:59 < aakselrod> yeah... me too 20:00 < aakselrod> i'm really curious because the original code is using a file handle to truncate 20:00 < aakselrod> so it *should* truncate even though it's open, like on linux and mac 20:00 < aakselrod> but windows is a different beast i guess 20:00 -github-lnd:#lnd- [lnd] Roasbeef pushed 2 new commits to master: https://git.io/vddE1 20:00 -github-lnd:#lnd- lnd/master be7cb08 Jim Posen: chainntnfs: Rename file with typo in filename. 20:00 -github-lnd:#lnd- lnd/master e9c1684 Jim Posen: chainntnfs: Remove some unnecessary channels in interface_test. 20:00 <@roasbeef> yeh idk how to windows anymore 20:01 < aakselrod> me neither :( 20:01 < aakselrod> i've avoided it for years 20:03 -github-lnd:#lnd- [lnd] Roasbeef pushed 1 new commit to master: https://git.io/vddE7 20:03 -github-lnd:#lnd- lnd/master cc221b1 mlerner: Fix spelling in docker docs 20:04 <@roasbeef> you get a merge! 20:04 -github-lnd:#lnd- [lnd] Roasbeef pushed 1 new commit to master: https://git.io/vddE5 20:04 -github-lnd:#lnd- lnd/master aa63958 nsa: wallet: channel test fee fix for added HTLC... 20:04 < aakselrod> and you get a merge! 20:04 <@roasbeef> and you get a merge! 20:04 <@roasbeef> kek 20:04 <@roasbeef> thx nsa :^) 20:10 -github-lnd:#lnd- [lnd] Roasbeef closed pull request #151: networktest: add wait for lnd to be started without errors (master...bypassed_goexit_stuck) https://git.io/vDpQf 20:10 <@roasbeef> aakselrod: can you rebase #232? thx 20:11 < aakselrod> sure, sec 20:15 < aakselrod> rerunning tests 20:15 <@roasbeef> fsho 20:15 <@roasbeef> doing a bit of all cleaning ;) 20:15 <@roasbeef> fall8 20:15 < aakselrod> yeh :D 20:17 <@roasbeef> hmm, would also be nice if on test failure, the test framework generated a goroutine dump from /debug/pprof/goroutine 20:18 <@roasbeef> or like _right_ before it kills all the lnd's, so we'd have a wrapping around *testing.T to accomplish this 20:18 < aakselrod> rebased 20:18 <@roasbeef> tight, peeping 20:18 < aakselrod> let's see if it passes tests on travis :P 20:19 < aakselrod> let me see if i actually addressed your comments, too 20:19 < aakselrod> lol 20:20 -github-lnd:#lnd- [lnd] Roasbeef pushed 1 new commit to master: https://git.io/vdduK 20:20 -github-lnd:#lnd- lnd/master 5661748 Dustin Dettmer: test: fix typo 20:21 < aakselrod> looks like yes 20:23 < aakselrod> one check failed 20:23 < aakselrod> looks like a different flake though 20:24 <@roasbeef> if you click the "after script" you can peep the logs 20:25 < aakselrod> --- FAIL: TestLightningNetworkDaemon/node_announcement (8.45s) 20:25 < aakselrod> lnd_test.go:66: Failed: (node announcement): exited with error: 20:25 < aakselrod> *errors.errorString expected IP addresses not in channel graph: map[192.168.1.1:8333:true [2001:db8:85a3:8d3:1319:8a2e:370:7348]:8337:true] 20:25 < aakselrod> that's a something else :P 20:26 < aakselrod> hrm, and another fail 20:26 < aakselrod> --- FAIL: TestLightningNetworkDaemon/max_pending_channel (20.60s) 20:26 < aakselrod> lnd_test.go:65: Failed: (max pending channel): exited with error: 20:26 < aakselrod> *errors.errorString channel not seen on network before timeout: channel not opened before timeout 20:27 < aakselrod> ooh i have restart job permissions! 20:27 < aakselrod> did that happen when i got write permissions to the repo? 20:30 <@roasbeef> have a fix for that first one 20:30 < aakselrod> --- FAIL: TestLightningNetworkDaemon/graph_topology_notifications (18.76s) 20:30 < aakselrod> lnd_test.go:66: Failed: (graph topology notifications): exited with error: 20:30 < aakselrod> *errors.errorString timeout waiting for graph notification 0 20:30 < aakselrod> :( 20:31 <@roasbeef> that one is what makes me need the goroutine dump, looking at the logs for the " graph notification 0" one, you see Bob sync graph state, but then the messages never actually get sent over 20:31 < aakselrod> i've seen that one a few times... yeah, goroutine dump would be great 20:36 -!- aakselrod [~aakselrod@2601:281:c702:8621:44b2:5f4a:72ab:28b8] has quit [Ping timeout: 255 seconds] 20:36 -!- [a]akselrod [~aakselrod@gateway/vpn/privateinternetaccess/aakselrod] has joined #lnd 20:36 -!- [a]akselrod is now known as aakselrod 20:36 < aakselrod> ugh 20:39 < aakselrod> got that graph_topology_notifications flake again, restarted again... imma keep running it until i either see all green or a flake in the test i just added 20:44 < aakselrod> yay it passed integration tests 20:44 < aakselrod> plz2notdieonneutrinotestskthx 20:44 <@roasbeef> heh 20:47 < aakselrod> weird, log stopped updating 20:47 < aakselrod> and rewound to the integration tests 20:48 <@roasbeef> yehh travis can be weird at times 20:53 < aakselrod> imma stop and restart, it's past 14 minutes for that build 20:57 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Remote host closed the connection] 20:58 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 21:00 <@roasbeef> aight giving it a final sweep 21:01 < aakselrod> how'd coverage decrease if all i did was add a test? O_o 21:02 < aakselrod> anyway, it's all green now 21:05 <@roasbeef> yeh the code covg is odd, not caterted to go programs 21:06 <@roasbeef> once I added more comments, and the covg went _down_ lol 21:06 < aakselrod> lol... good concept, silly execution :( 21:13 <@roasbeef> one minor comment, stray debug code looks like 21:14 < aakselrod> yep, fixed and pushed 21:14 < aakselrod> missed that somehow 21:18 -github-lnd:#lnd- [lnd] Roasbeef pushed 1 new commit to master: https://git.io/vdd23 21:18 -github-lnd:#lnd- lnd/master 126c73a Olaoluwa Osuntokun: test: increase timeout for testNodeAnnouncement 21:22 < aakselrod> all green again, first try this time! 21:23 < aakselrod> and somehow coverage increased this time 21:24 <@roasbeef> noice 21:24 <@roasbeef> reviewing it agian, it could be a bit more precise as in re-org _away_ a block that confirmed an output for the wallet, but I think this is a good start to build off of 21:25 < aakselrod> when i wrote this, we were having that reorg issue in btcwallet that was corrected by keeping hashes of all the blocks 21:26 < aakselrod> so the balance changed because it'd reorg all the way to genesis and get stuck 21:26 <@roasbeef> ahh yeh I recall now 21:26 -github-lnd:#lnd- [lnd] Roasbeef pushed 1 new commit to master: https://git.io/vdd2g 21:26 -github-lnd:#lnd- lnd/master 0994852 Alex: lnwallet: add reorg test 21:26 < aakselrod> \m/ 21:27 < aakselrod> but yeah, we can definitely enhance it 21:28 < aakselrod> aight. i'm out for tonight, gonna try and finish up the rest of these bug fixes tomorrow. 21:29 <@roasbeef> fsho, peace 21:31 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Quit: quitobro] 21:33 < aakselrod> g'nite :) 22:05 -!- alanc44 [~alanc@109.255.196.64] has joined #lnd 22:23 -github-lnd:#lnd- [lnd] Roasbeef closed pull request #349: lnwallet: Commitment refactor (master...commitment-refactor) https://git.io/vdIAQ 22:58 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-iqpofkcwxnnapzvo] has joined #lnd