--- Day changed Wed Oct 25 2017 00:05 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has joined #lnd 00:21 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has quit [] 01:17 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has joined #lnd 01:33 -!- sycofly [~sycofly@121.99.240.44] has joined #lnd 01:56 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-vgkmpwaopnkopjny] has quit [Quit: Connection closed for inactivity] 02:24 -!- sycofly [~sycofly@121.99.240.44] has quit [Quit: This computer has gone to sleep] 04:12 -!- quitobro [~quitobro@pool-108-41-0-186.nycmny.fios.verizon.net] has joined #lnd 04:17 -!- quitobro [~quitobro@pool-108-41-0-186.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds] 04:18 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has joined #lnd 05:21 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 05:40 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 248 seconds] 05:46 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #lnd 06:35 -!- aakselrod [~aakselrod@gateway/vpn/privateinternetaccess/aakselrod] has quit [Ping timeout: 248 seconds] 06:48 -!- aakselrod [~aakselrod@2601:281:c702:8621:7985:f750:3996:bede] has joined #lnd 07:32 -!- sdfgsdfg [~sdfgsdfg@unaffiliated/sdfgsdfg] has quit [Ping timeout: 255 seconds] 08:27 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has quit [] 08:34 -!- deusexbeer [~deusexbee@093-092-183-194-dynamic-pool-adsl.wbt.ru] has quit [Ping timeout: 240 seconds] 08:35 -!- deusexbeer [~deusexbee@080-250-075-054-dynamic-pool-adsl.wbt.ru] has joined #lnd 08:40 -!- deusexbeer [~deusexbee@080-250-075-054-dynamic-pool-adsl.wbt.ru] has quit [Ping timeout: 260 seconds] 08:40 -!- deusexbeer [~deusexbee@095-129-175-248-dynamic-pool-adsl.wbt.ru] has joined #lnd 08:54 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-mrndwvsklucuhpxw] has quit [Quit: Connection closed for inactivity] 09:01 -!- castl2342 [ubuntu@gateway/vpn/mullvad/x-cellicmagxenwgod] has quit [Ping timeout: 248 seconds] 09:14 -!- MaxSan [~user@91.214.169.69] has joined #lnd 09:14 -!- castl2342 [~ubuntu@199.66.90.113] has joined #lnd 09:14 < MaxSan> roasbeef: hey you about? 09:23 -!- alreadylate [~textual@37-247-1-221.customers.ownit.se] has quit [] 09:23 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 248 seconds] 09:25 -!- quitobro [~quitobro@gateway/vpn/privateinternetaccess/quitobro] has quit [Quit: quitobro] 09:28 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 09:33 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-ltzxintwmasdlmaa] has joined #lnd 10:25 -!- MaxSan [~user@91.214.169.69] has quit [Ping timeout: 248 seconds] 11:13 <@roasbeef> jimpo: haven't looked at that one modify mapping in the switch PR yet, but at first glance (w/o reading the code lol), not sure that it'll work in the non-ideal setting 11:13 <@roasbeef> the htlc id's of links are sync'd at all 11:14 <@roasbeef> you don't know what the id of the htlc you added to the outgoing link is (unless you make HandleSwitchPacket synchronous and also returnt hat id) 11:14 < jimpo> The dest HTLC ID is blank for forwarded adds 11:14 < jimpo> it really only comes into play after the outgoing HTLC is sent and *then* is added to the circuit map 11:15 < jimpo> But higher level, yeah, I'm not 100% sure that it's the right approach, but to the best of my knowledge it should work and is probably better than matching on payment hash 11:16 < jimpo> What do you mean by "the non-ideal setting"? 11:16 <@roasbeef> well the payment hash methods currently _works_ 11:17 <@roasbeef> well I mean i'd imagined you thought of some scenario that it worked to convice yourself that it would work in the general case 11:17 <@roasbeef> i'm seeing how you can match the backwards add/settle to that forwarded htlc, as it won't ref the same htlc id 11:17 < jimpo> My thought process was a little more rigorous than that, haha 11:17 <@roasbeef> and also there can be multiple active circuits to a particualr dest 11:18 <@roasbeef> lolol yeh just an example :p 11:18 < jimpo> and I actually don't think the payment hash method works perfectly if there are multiple HTLCs with the same hash 11:18 < jimpo> I put an example of some faulty code in the PR desc 11:19 <@roasbeef> iirc it maps to a alice which also have value, which is how we'd differntiate them 11:25 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has joined #lnd 11:43 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-ltzxintwmasdlmaa] has quit [Quit: Connection closed for inactivity] 12:42 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has joined #lnd 12:48 <@roasbeef> should be updating the seed and peerBootstrapper later today to address some of the DNS woes we've been having, switching to TCP resolution as a fallback _should_ address the issue 13:12 -github-lnd:#lnd- [lnd] Roasbeef closed pull request #383: lnwallet: Simplify updateLog struct by removing redundant pointers. (master...channel-chain) https://git.io/vd7TS 13:17 -github-lnd:#lnd- [lnd] Roasbeef closed pull request #366: fundingmanager test: poll or database state instead of using timeouts. (master...funding-tests-db-read) https://git.io/vdl8f 13:21 -github-lnd:#lnd- [lnd] Roasbeef pushed 1 new commit to master: https://git.io/vFvb5 13:21 -github-lnd:#lnd- lnd/master a13ad0a Jim Posen: multi: Fix various typos. 13:46 -!- jimpo [~jimpo@ec2-52-42-179-84.us-west-2.compute.amazonaws.com] has quit [Ping timeout: 252 seconds] 13:46 -!- jimpo [~jimpo@ec2-52-42-179-84.us-west-2.compute.amazonaws.com] has joined #lnd 14:01 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ifdohirtusuqvnnt] has joined #lnd 14:19 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has quit [] 14:19 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has joined #lnd 14:47 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-buzvrvqvkwoqawjc] has joined #lnd 14:51 -!- aakselrod [~aakselrod@2601:281:c702:8621:7985:f750:3996:bede] has quit [Quit: Leaving] 14:51 -!- aakselrod [~aakselrod@gateway/vpn/privateinternetaccess/aakselrod] has joined #lnd 15:00 -!- aakselrod [~aakselrod@gateway/vpn/privateinternetaccess/aakselrod] has quit [Ping timeout: 260 seconds] 15:00 -!- alreadylate [~textual@c-250e71d5.153-1-64736c10.cust.bredbandsbolaget.se] has quit [] 15:03 -!- aakselrod [~aakselrod@gateway/vpn/privateinternetaccess/aakselrod] has joined #lnd 15:03 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 248 seconds] 15:06 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 15:12 -github-neutrino:#lnd- [neutrino] aakselrod closed pull request #27: Refactor locking in `headerfs`, fix rescan race condition during reorg (master...refactor-locking) https://git.io/vdhKQ 15:13 < jimpo> roasbeef: There are a bunch of places in lnd_test where the async SendPayment RPC call is may in a synchronous way (eg. https://github.com/lightningnetwork/lnd/blob/master/lnd_test.go#L1028) 15:13 < jimpo> Any reason not to use SendPaymentSync? 15:13 < jimpo> The benefit is that you can put a timeout on the context, whereas right now Recv() will block indefinitely (which I got burned by) 15:13 <@roasbeef> typically later in the tests the stream is re-used to send another payment 15:14 <@roasbeef> but really there should be a timeout there, as otehrwise the test can just hang if an issue is introduced somewhere int he switch 15:14 <@roasbeef> yeh 15:14 <@roasbeef> i _think_ there might be another method on the stream we can use as well 15:14 < jimpo> So it's OK if I change the ones calling it in a blocking manner to use SendPaymentSynC? 15:14 < jimpo> nah, no sync method on the stream 15:15 -!- spinza [~spin@196.212.164.26] has quit [Quit: Coyote finally caught up with me...] 15:26 -!- spinza [~spin@196.212.164.26] has joined #lnd 15:37 -!- mnkk___ [~mnk4@ip5f5ae92a.dynamic.kabel-deutschland.de] has quit [] 16:47 -!- sdfgsdfg [~sdfgsdfg@unaffiliated/sdfgsdfg] has joined #lnd 16:51 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 248 seconds] 16:54 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 16:57 <@roasbeef> jimpo: yeh I'd give it a shot, might find some incompatabilities 17:01 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Read error: Connection reset by peer] 17:22 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #lnd 17:40 < jimpo> So the only incompatibility I see between the sync & async interfaces is that the async one returns certain errors in the PaymentError field of the response whereas the sync one returns as an error 17:41 < jimpo> eg https://github.com/lightningnetwork/lnd/blob/master/rpcserver.go#L1606 vs https://github.com/lightningnetwork/lnd/blob/master/rpcserver.go#L1744 17:41 < jimpo> Should we change the Sync interface to match the behavior of the async? 17:43 <@roasbeef> yep taht's the expected behvior 17:43 <@roasbeef> sync isn't really used much, only reson it's there is for the rest intefrace 17:43 <@roasbeef> but there's also gRPC web 17:43 <@roasbeef> now 17:45 < jimpo> What is the expected behavior? as is or returning in the PaymentError field? 17:46 <@roasbeef> payment error 18:00 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #lnd 18:01 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-ifdohirtusuqvnnt] has quit [Quit: Connection closed for inactivity] 18:05 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Read error: Connection reset by peer] 18:13 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 248 seconds] 18:17 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 18:19 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #lnd 19:24 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Remote host closed the connection] 19:26 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 19:51 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 248 seconds] 19:52 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 19:57 -!- chjj [~chjj@unaffiliated/chjj] has joined #lnd 20:08 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 248 seconds] 20:12 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 20:21 -github-neutrino:#lnd- [neutrino] Roasbeef pushed 4 new commits to master: https://git.io/vFfVr 20:21 -github-neutrino:#lnd- neutrino/master 34aa7aa Alex: headerfs: gofmt -s store_test.go 20:21 -github-neutrino:#lnd- neutrino/master 4a8946d Alex: multi: export serverPeer as ServerPeer 20:21 -github-neutrino:#lnd- neutrino/master 6c58f26 Alex: build: update to latest btcd with rpctest fixes 20:26 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 248 seconds] 20:30 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 20:40 -github-neutrino:#lnd- [neutrino] aakselrod closed pull request #23: query: race condition and performance fixes (master...cfilter-type-check) https://git.io/vdDhx 21:05 -github-neutrino:#lnd- [neutrino] aakselrod pushed 1 new commit to master: https://git.io/vFfrD 21:05 -github-neutrino:#lnd- neutrino/master 33b9ac7 Alex: Update README.md with godoc, travis, coveralls badges 21:05 < aakselrod> almost like it's a real project now :P 21:47 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 248 seconds] 21:47 -!- sdfgsdfg [~sdfgsdfg@unaffiliated/sdfgsdfg] has quit [Read error: Connection reset by peer] 21:59 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 22:03 -!- sdfgsdfg [~sdfgsdfg@unaffiliated/sdfgsdfg] has joined #lnd 22:19 -!- whythat [~whythat@gateway/tor-sasl/whythat] has quit [Ping timeout: 248 seconds] 22:23 -!- whythat [~whythat@gateway/tor-sasl/whythat] has joined #lnd 22:26 -!- sdfgsdfg [~sdfgsdfg@unaffiliated/sdfgsdfg] has quit [Quit: sdfgsdfg] 22:41 -!- sdfgsdfg [~sdfgsdfg@unaffiliated/sdfgsdfg] has joined #lnd 23:23 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-kmslojrsexfbeeoe] has joined #lnd