--- Log opened Wed Oct 28 00:00:59 2020 03:21 < raj_> dr_orlovsky: I will be available in IRC from now on. We can initiate the discussion on Noise handshake here. 03:26 < dr_orlovsky> Hi! Yes, we finally decided to try to move our dev communications from Telegram to here 05:36 < dr_orlovsky> raj_: regarding the handshake, I will be able to describe the task after the call today. I will be also giving important details on how LNP Node is organized during the call which will help to explain the task 05:36 < raj_> Noted. 10:13 < raj_> Great session. I was looking through lnp-node parallelly, and it seems very clean and concise. Based on the slides it seems most of the skeleton is ready and major work to be done is in the application layers. Feel free to describe the next requirement to be implemented, and I will get onto it. 10:14 < dr_orlovsky> Thank you! I will have short rest and will prepare the description. It's late in your locations, so you can check it by tomorrow morning 17:24 < dr_orlovsky> raj_: I wrote the task description here: https://github.com/LNP-BP/rust-lnpbp/issues/134 . Please let me know if any further explanations are needed 19:00 -!- coreyphillips [coreyphill@gateway/web/irccloud.com/x-cchzmkdoeuqwrkdp] has quit [Read error: Connection reset by peer] 19:01 -!- coreyphillips [coreyphill@gateway/web/irccloud.com/x-yvxrbufnljohksni] has joined #lnp-bp 22:20 < raj_> dr_orlovsky: I have gone through the task description and the associated references. The task is basically to implement business logic to handle peer handshake. As discussed earlier we wont use the AED from rust-lightning, will have our own external dependency for it, and using it we need to create the handshake logic which also coforms to the required API. 22:20 < raj_> For the reference mentioned here https://github.com/rust-bitcoin/rust-lightning/pull/691, if you look in the src/ln/peers/handshake/state.rs this basically implements all the state transitions from 3 ACT step as per BOLT8. Which seems to extensively cover all the edge cases and includes test vectors. Is it possible we can use this part of rust-lightning directly without implenting the same logic ourselves? Because this will 22:20 < raj_> quite comfortably conform to BOLT8 and wont have issue like AED implementation. 22:20 < raj_> I would personally go for the following: 22:20 < raj_> 1. Use AED from external dependency. 22:20 < raj_> 2. Use Handshake from rust-lightning 22:20 < raj_> 3. Make the API comply with our requirements. 22:21 < raj_> Also, do we need this functionality in lnpbp or lnp-node? 22:32 < raj_> the above PR to rust-lightning also includes HKDF which we might use directly. 22:42 < raj_> Partly answering myself: The state transitions from rust-lightning cannot be directly used as a dependency as it uses its own AED. So what we can do is use the code and refactor it to have our own AED. But this part of the code is still an open PR, so not much confidence can be imparted. Open to suggestions here. --- Log closed Thu Oct 29 00:00:01 2020