--- Log opened Thu Oct 29 00:00:01 2020 02:37 -!- zoe_ [uid464843@gateway/web/irccloud.com/x-nfnmgregmxfognyv] has joined #lnp-bp 02:38 < dr_orlovsky> raj_: Yes, we can't use rust-lightning because it's an open PR which can any time change (and was doing muyltiple times) and there for already 9 months, constantly mutating. Also, we can't have unpublished dependencies in published crates. So this simply will not work. The best thing we can do is to copy & refactor parts of the code (referencing the original authors) 02:38 < dr_orlovsky> We need this in rust-lnpbp 02:41 < raj_> dr_orlovsky: understood. So I am going to use similar kind of structures and logic that the PR used for handshaking, refactor it to use our AED construction, directly copy paste the HKDF, and use the test vectors to ensure its working ok. Sounds good? 02:52 * zoe_ hi! I need to map rgb::i9n::Error to an error type in rgb-sdk, but I don't know how to name it. from the code I can see this error covers Service, Reply, Base64, Bitcoin, Encoding and UnexpectedResponse errors. 03:03 < dr_orlovsky> raj_: You may use different logic and structure, if required. The only requirements is to fit into the same API like `NoEncryption` has, so we would not need to change other parts of the system 03:03 < dr_orlovsky> zoe_: this can be "Integration" I think 03:04 < dr_orlovsky> (i9n ia actually stands for "integration") 03:10 * zoe_ ok great, thanks! 08:54 < raj_> I am trying to use some helper function for u64 to LE conversion, and its available in rust-bitcoin, but unfortunately that module is private. See here https://github.com/LNP-BP/rust-bitcoin/blob/dc06d451c01ef7b22509f0eb4db1f817e4e83daa/src/util/mod.rs#L35 08:55 < raj_> Is it possible to change it into public? I can open a PR. Or should i just copy the code and make our own utils? 09:39 < dr_orlovsky> you do not need them, we have rust functions called `from_le_bytes` and `to_be_bytes` that are avaliable for each of the numeric types 09:40 < dr_orlovsky> https://doc.rust-lang.org/std/primitive.u32.html#method.from_le_bytes 09:40 < dr_orlovsky> and on other types as well 09:40 < dr_orlovsky> the same applies for be 09:49 < raj_> Oh neat.. Thanks.. 10:18 < raj_> Just a random question, doesn't rust-lightning use any form of BOLT8 communication right now? 11:39 < dr_orlovsky> it does for sure 11:40 < dr_orlovsky> that's why they use Noise protocol and have that handshake. That PR is just does a lot of refactoring, because before it it was not implemented as a state machine and was not a separable module at all 12:06 -!- zoe_ [uid464843@gateway/web/irccloud.com/x-nfnmgregmxfognyv] has quit [Quit: Connection closed for inactivity] --- Log closed Fri Oct 30 00:00:04 2020