--- Log opened Wed Nov 18 00:00:20 2020
14:26 -!- dieeasy [uid472335@gateway/web/irccloud.com/x-mwtjidpqfpfivpqm] has quit [Ping timeout: 260 seconds]
14:26 -!- dieeasy [uid472335@gateway/web/irccloud.com/x-ecmmkwzlpgxdjtmb] has joined #lnp-bp
20:34 < raj_> Hi all, I have made some initial comment regarding encoding in the lightning node here https://github.com/LNP-BP/rust-lnpbp/issues/136. My understanding so far is lightning encoding have to be different from other encoding that we use in lnpbp core library, namely `strict_encode`. One naive way to do this would be specifically define tlv encoding of the specific tlv data we might need (BOLT1 defines some) and do away with
20:34 < raj_> it. Is there more better way of doing this? Because otherwise I am inclining towards using the same encoding logic in rust-lightning, because it feels like inventing the same wheel. Thoughts and suggestions appreciated.
21:11 < raj_> Follow up question. Is there a reason we have no dependecy on rust-lightning so far in both lnpbp-core and lnp-node? I am talking about helper functions and things like BigSize and TLVs. Even if we have our own architecture we can still use some of their toolings. Otherwise it seems unnecessary redundant works and maintanace burden.
21:31 < raj_> My amature feeling so far while trying to write my own TLV is theres a lot of detail that needs to be carefully coded. And this might apply to many other things within an LN node as well. To get a full LN node with adequate security a lot of details are to be addressed. To me it seems much easier to grab what has already been done by other people in public. I am not sure if there are more nunaced reason for not doing this.
21:31 < raj_> For this particlular case I am feeling its safer to use rust-lightning TLV macros than to write my own. Or just copy paste code if we dont want added dependency.
23:47 < dr-orlovsky> Sorry guys, being out for a few days: had a lot of meetings in a raw. Reviewing GitHub and answering here ASAP
--- Log closed Thu Nov 19 00:00:21 2020