--- Log opened Wed Dec 02 00:00:33 2020
00:45 -!- step_ [uid472302@gateway/web/irccloud.com/x-qwezwzwbgiruolji] has joined #lnp-bp
01:10 -!- dieeasy [uid472335@gateway/web/irccloud.com/x-wvqwtzkeguifsndu] has joined #lnp-bp
02:34 < step_> Also I noticed that in lnp-node asset identifier is again in hex format. Is there a plan to uniform everything with bech32 encoding or is there a reeson to have mixed encoding there as well?
03:29 -!- marenkar [~marenkar@51.154.28.156] has joined #lnp-bp
03:40 -!- olga__ [uid458260@gateway/web/irccloud.com/x-etryfyhssvuejdum] has joined #lnp-bp
04:32 < dr-orlovsky> I think it is related to RGB node, i.e. the same issue (since LNP Node uses RGB Node methods). Yes, everything should be Bech32
05:02 < step_> thanks
05:13 -!- zoe_ [uid464843@gateway/web/irccloud.com/x-curoisrquwcnbsie] has joined #lnp-bp
05:16 < dieeasy> I'm trying to have `cargo workspaces` correctly update the version of crates and dependencies in Cargo.toml for rust-lnpbp (which has a _derive and a _services sub-crates)
05:16 < dieeasy> as commented in PR #143 https://github.com/LNP-BP/rust-lnpbp/pull/143#issuecomment-736663973 I have it basically working and crate versions get correctly updated, but it's still unclear to me what triggers also the update of inter-dependencies... I can force the update of inter-dependency versions adding the `--exact` flag (although that rewrites dependencies using `=` so it might not be what we want), while if I don't
05:16 < dieeasy> add it versions don't update
05:16 < dieeasy> it's probably me not knowing enough about rust/crates/workspaces or expect something to happen when it shouldn't, if anybody has any clue or pointer I'd appreciate getting that additional hint ;)
05:19  * dieeasy dr-orlovsky: would it be ok to have inter-dependencies fixed with `=` ? if so, this would not be an issue and I might proceed using `--exact`, what's your opinion?
06:33 < dr-orlovsky> I think it's ok to fix inter-dependencies with `=`. And unfortunatelly no experience in working with cargo workspaces :(
06:39 < dr-orlovsky> dieeasy: why did we need to pin seockt2 version to socket2 = { version = "=0.3.15" }  in adroid target?
06:39 < dr-orlovsky> now it breaks dependency tree :(
06:50 < dr-orlovsky> this think broke everything: miow v0.3.6
06:50 < dieeasy> > why did we need to pin seockt2 version
06:50 < dieeasy> I had to fix those as part of https://github.com/LNP-BP/rust-lnpbp/pull/149, since the project was not building anymore (after a rebase on `master`, which included a cargo update)
06:50 < dieeasy> in the end, I had to diff `Cargo.lock` with the previous working version and isolate the dependencies that broke the build
06:50 < dieeasy> no problem in removing those fixed versions (you might unlock some other issues, though)
06:51 < dr-orlovsky> they have yanked all previous versions and introduced breaking changes with new one: https://crates.io/crates/miow/versions
06:51 < dr-orlovsky> > no problem in removing those fixed versions (you might unlock some other issues, though)
06:51 < dr-orlovsky> well, I assume it will break android build
06:53 < dr-orlovsky> yeah, it does: https://github.com/LNP-BP/rust-lnpbp/pull/156/checks?check_run_id=1486887575 :(
06:54  * dieeasy IIRC this was the issue I was facing: https://github.com/LNP-BP/rust-lnpbp/pull/149/checks?check_run_id=1425115067
06:55 < dr-orlovsky> it is, and it's a very wierd one
11:46 -!- zoe_ [uid464843@gateway/web/irccloud.com/x-curoisrquwcnbsie] has quit [Quit: Connection closed for inactivity]
12:46 -!- step_ [uid472302@gateway/web/irccloud.com/x-qwezwzwbgiruolji] has quit [Quit: Connection closed for inactivity]
17:14 < dr-orlovsky> LNP/BP Core Lib and RGB Node 0.2 RC1 are out: thoroughly tested with consignment creation, validation, acceptance. Everything works with real testnet data
17:15 -!- dieeasy [uid472335@gateway/web/irccloud.com/x-wvqwtzkeguifsndu] has quit [Quit: Connection closed for inactivity]
17:25 -!- olga__ [uid458260@gateway/web/irccloud.com/x-etryfyhssvuejdum] has quit [Quit: Connection closed for inactivity]
21:10 -!- marenkar [~marenkar@51.154.28.156] has quit [Ping timeout: 272 seconds]
21:18 -!- marenkar [~marenkar@51.154.28.156] has joined #lnp-bp
21:25 -!- marenkar [~marenkar@51.154.28.156] has quit [Ping timeout: 256 seconds]
--- Log closed Thu Dec 03 00:00:34 2020