--- Day changed Mon Jun 29 2020
07:17 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds]     
07:38 -!- tralfaz [~tralfaz@68.235.43.93] has joined ##miniscript     
07:39 -!- tralfaz is now known as davterra     
07:43 -!- davterra [~tralfaz@68.235.43.93] has left ##miniscript []     
08:35 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined ##miniscript     
11:58 < sanket1729> andytoshi: 97 fixed
11:58 < sanket1729> up for review again
12:53 < andytoshi> dope
13:49 < andytoshi> ok, reviewed except for the compiler..
13:49 < andytoshi> so far just the `pub` thing
13:52 < andytoshi> heh, it just clicked for me that this strategy gives us a working pre-segwit compiler
13:52 < andytoshi> that's really cool
13:53 < andytoshi> and like, if you try to create a legacy descriptor and compile a miniscript into it, the type inference engine will make sure the correct compiler is used
13:53 < andytoshi> the rust type inference engine*
13:57 < sanket1729> andytoshi, well you suggested that strategy for compiler construction :P . 
13:57 < andytoshi> i know, and i remember describing this even :P
13:58 < andytoshi> but i don't think i realized that (a) we currently didn't have a legacy compiler; (b) we didn't want to put any effort into making one
13:58 < andytoshi> ...but we managed to get one without putting any effort in :P
14:03 < sanket1729> Changed the comment and `pub` PhantomData to `pub(crate)` PhantomData
14:03 < sanket1729> We still need it inside crate for testing purposes. 
14:13 < andytoshi> looks great, just waiting on travis
14:15 < sanket1729> There is 105 which should be easy to review 5 line diff
14:17 < andytoshi> kk     
14:18 < andytoshi> yeah lgtm
14:19 < andytoshi> lol now you have to rebase 96
14:19 < andytoshi> 97     
14:19 < sanket1729> really, that should have not created conflict.
14:20 < sanket1729> it did :(
14:20 < andytoshi> yeah i didn't expect it either
14:27 < sanket1729> rebased. CI taking 20 mins per build which is kindof annoying. 
14:35 < andytoshi> merged 97 :)
14:35 < andytoshi> sanket1729: what more do you think we need to do a new release?
14:37 < sanket1729> andytoshi: I can looking at some of the decoding bug issues. #63 and #77. 
14:37 < andytoshi> ok great
14:38 < sanket1729> I am unable to reproduce 77. and looks like some external contributor started looking at 63
14:39 < sanket1729> But has marked it as Draft
14:40 < andytoshi> cool 77 closed
14:40 < andytoshi> is 73 fixed by the PR we just merged?
14:41 < andytoshi> pretty sure yes
14:42 < andytoshi> i'm taking a look at the fix for 63 .. it might be ok to just merge
15:10 < sanket1729> I don't remember any of the decoding logic, does the fix look good to you?
15:15 < sanket1729> I think after that, we are good for release
15:32 < andytoshi> cool. on a high level it looks good
15:32 < andytoshi>  but i need to dig in more
16:09 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds]     
16:31 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined ##miniscript     
19:14 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-56-253.adslplus.ch] has quit [Quit: Textual IRC Client: www.textualapp.com]