--- Day changed Thu Nov 05 2020
03:06 -!- shesek [~shesek@164.90.217.137] has joined ##miniscript     
03:06 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]     
03:06 -!- shesek [~shesek@unaffiliated/shesek] has joined ##miniscript     
07:25 < andytoshi> why isn't deny(missing_docs) on rust-miniscript?
07:43 < sanket1729> We never had it
07:43 < sanket1729> I can add it
07:44 < sanket1729> or do you have some standard stuff from other rust-repos that you want in?
07:48 < sanket1729> or do you have some standard stuff from other rust-repos that you want in?
08:04 < sanket1729> andytoshi: Did we decide on the `secp` context for ToPublicKey API. 
08:08 < andytoshi> sanket1729: i think we should do it
08:08 < andytoshi> as for standard stuff .. yeah, i think we should copy all the lints from rust-bitcoin
08:10 < sanket1729> I will update the draft PR. 
08:11 < sanket1729> As a side comment, what is best way to explain the parameter ToPkCtx in all function doccomments. 
08:11 < sanket1729> Since many functions will have the same parameter and it is not obvious what the value should be
08:12 < sanket1729> I pasted the same explanation to in all the APIs
08:15 < andytoshi> hmm     
09:48 -!- roconnor [~roconnor@host-192.252-162-14.dyn.295.ca] has quit [Ping timeout: 258 seconds]     
09:54 -!- roconnor [~roconnor@host-192.252-162-14.dyn.295.ca] has joined ##miniscript     
11:42 -!- aj [aj@cerulean.erisian.com.au] has quit [Quit: leaving]     
11:43 -!- aj [aj@cerulean.erisian.com.au] has joined ##miniscript     
12:10 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined ##miniscript     
12:15 < darosior> Andrew, Sanket: saw the notifications about #150, will respond tomorrow
12:35 < sanket1729> cool
12:44 < sanket1729> andytoshi: Just saw all the messages about #150 now. Idk what messed my client yesterday. 
12:59 < sanket1729> w.r.t taking references to ToPkCtx in should we take the context as reference or not, I think we should probably take it as reference because the context will likely be shared across multiple functions?
13:02 < sanket1729> otherwise, we might require ToPkCtx to implement Clone. 
13:06 < sanket1729> or rather Copy
18:35 -!- sanket1729_ [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined ##miniscript     
18:35 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Ping timeout: 256 seconds]     
18:35 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Ping timeout: 256 seconds]     
18:37 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined ##miniscript