--- Day changed Sun Nov 22 2020 00:48 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds] 00:55 -!- jonatack [~jon@88.124.242.136] has joined ##miniscript 04:40 -!- roconnor [~roconnor@host-104-157-230-3.dyn.295.ca] has quit [Ping timeout: 240 seconds] 05:04 -!- roconnor [~roconnor@host-45-58-200-239.dyn.295.ca] has joined ##miniscript 06:34 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 08:58 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined ##miniscript 11:19 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 240 seconds] 11:20 -!- jonatack [~jon@134.19.179.179] has joined ##miniscript 12:23 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 15:26 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined ##miniscript 16:19 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 16:32 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined ##miniscript 16:35 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 16:36 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined ##miniscript 18:11 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 18:12 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined ##miniscript 18:38 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 19:06 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined ##miniscript 20:20 < sanket1729_> reviewing again 20:27 < sanket1729_> andytoshi: Why do you prefer testing the error string instead of the error variant? 20:34 < andytoshi> sanket1729_: because you can't check equality of the error variants 20:34 < sanket1729_> You can match them right? 20:34 < andytoshi> and because it lets you see what the error strings are ... lots of them were pretty bad :P 20:35 < andytoshi> sanket1729_: yeah, if you want to spend 4 LOC doing an equality check 20:35 < sanket1729_> I think I had something for rust-simplicity. 20:35 < sanket1729_> let me look up 20:35 < andytoshi> yeah, there's something in most of the crates i maintain 20:35 < andytoshi> but just converting to string is so much easier 20:35 < sanket1729_> https://github.com/apoelstra/rust-simplicity/blob/e2328d370f89ac0c088f53b90571fd410e63416d/src/macros.rs 20:36 < andytoshi> and it gets your stringified versions into your tests for free 20:36 < sanket1729_> true 20:36 < andytoshi> i'd rather avoid using macros everywhere in new code, even tests, if i can avoid it 20:37 < sanket1729_> In general and for future PRs, I should prefer matching error strings over error variants? 20:40 < andytoshi> hmmm 20:41 < andytoshi> i guess so. that feels like a strong statement 20:41 < andytoshi> i think, try it and see if it seems like the right thing to be doing 20:41 < andytoshi> but i think this is what i'm going to do in the future, yeah 20:44 < sanket1729_> and for the fuzztarget, how can I get secp signature from vec because the crypto operations are not implemented for fuzztarget in rust-secp