--- Log opened Mon Nov 30 00:00:31 2020
01:40 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
05:53 < andytoshi> sanket1729_: i argued with sipa for days and days about pkh :) and tried to remove it from miniscript until you showed up and showed it could give massive efficiency improvements
05:53 < andytoshi> but now i think he's right on all counts
05:54 < andytoshi> that you shouldn't participate without a descriptor (or equivalent information) except in weird niche cases where you shouldn't expect the type system to help you
05:54 < andytoshi> and that at signing time, missing a pkh preimage isn't really different than not having a normal hash preimage or not having a signing key ... i.e. the satisfier already understands how to fail
05:56 < andytoshi> sanket1729_: curiously, waay back when we were first designing miniscript (before we had the notion of a policy language and when we were really gunning for script->miniscript roundtrippabiilty as the main feature)
05:56 < andytoshi> ...we were happy that we had a "binary encoding" in the form of Script that all software already supported
05:57 < andytoshi> ...so there was no need for any modifications to existing protocols
05:57 < andytoshi> and very conveniently, it turns out that even though we've moved to a "miniscript is just a component of descriptors" view, this is still true of PSBT
06:03 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
06:27 < sanket1729_> andytoshi: So should we not expose lifting of miniscripts altogether and only allows users to use it via the descriptors. 
06:27 < andytoshi> though i do think we should define a canonical binary encoding in terms of PSBT with a dummy tx. it would be cool if the process for Updating were (a) replace the dummy tx with teh real one; (b) combinepsbt
07:09 < sanket1729_> andytoshi: Can you look at 199 and 200. Should be fairly easy to review. I think we should publish a patch release.
07:12 < andytoshi> kk
07:13 < andytoshi> btw did you make any progress updating rust-secp-zkp or do you want me to do that?
07:13 < andytoshi> probably the whole library basically needs to be redone :P
07:15 < sanket1729_> I autogenerated bindings for all the APIs in .h files of secp-zkp in the sys crate but did not create any high level APIs for those and I have not tested it. 
07:16 < andytoshi> oh dope, can you push that commit somewhere
07:16 < andytoshi> all the .h files?
07:16 < sanket1729_> yeah :P, why not have all?
07:16 < andytoshi> awesome :D
07:16 < andytoshi> that's amazing, if you push a commit somewhere i can fix it up so it compiles and start work on a high-level AP
07:17 < sanket1729_> let me clean up a bit. will push the commit in ~1 hour
07:17 < andytoshi> sounds good
07:18 < andytoshi> ok one nit on 199
07:19 < sanket1729_> fixing
07:20 < andytoshi> oh derp, i should have caught the panic in `satisfy`
07:24 < sanket1729_> added a commit removing all instances of impl error::Error with default implementation
07:24 < andytoshi> awesome 
07:24 < andytoshi> this is similar to the issue in rust-secp where i was casting &-pointers to *-pointers....it's something i learned in the rust 1.0 era and only recently discovered is no longer the right thing :P
07:27 < andytoshi> good catch using parse_insane in the psbt finalizer
07:27 < andytoshi> i am still tempted to write a parse_really_insane which will accept non-canonical scripts whose satisfactions are still miniscript-shaped :P e.g. if you throw a bunch of NOPs into a script
07:28 < andytoshi> and maybe it could accept the liquid script too..
07:28 < andytoshi> ok utack 200. lemme just run ci locally
08:19 < andytoshi> sanket1729_: merged 199 and 200. published patch release
08:26 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined ##miniscript
08:35 < sanket1729_> awesome
08:37 < andytoshi> sanket1729_: i think in the next week you and i will need to prioritize some non-miniscript things
08:38 < andytoshi> or well
08:38 < andytoshi> prioritize elements miniscript :P
08:38 < andytoshi> so is there other stuff we should get done on rust-miniscript before then?
08:38 < andytoshi> i am still trying to get rust-bitcoin updated and we'll do another rust-miniscript release after that
08:38 < andytoshi> and then we can upgrade the functionary and other blockstream shit to use it, which'll be fun
08:39 < sanket1729_> I don't think there is any feature that we want in rust-miniscript. 
08:39 < sanket1729_> I am working on a fork of elements-miniscript.
08:39 < andytoshi> dope
08:40 < sanket1729_> it's heavily WIP right now.
08:40 < andytoshi> no worries
08:40 < andytoshi> i will have a branch of elements later today which has taproot in it. also heavily WIP
13:49 -!- shesek [~shesek@164.90.217.137] has joined ##miniscript
13:49 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
13:49 -!- shesek [~shesek@unaffiliated/shesek] has joined ##miniscript
17:39 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
17:39 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined ##miniscript
20:27 -!- llfourn [~user@42.62.218.49] has joined ##miniscript
21:12 -!- jonatack [~jon@82.102.27.171] has quit [Ping timeout: 240 seconds]
21:15 -!- jonatack [~jon@88.124.242.136] has joined ##miniscript
23:08 -!- llfourn [~user@42.62.218.49] has quit [Remote host closed the connection]
--- Log closed Tue Dec 01 00:00:32 2020